from:"Ahmed Eldawy \(Code Review\)"

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

2018-03-26 Thread Ahmed Eldawy (Code Review)

Ahmed Eldawy has posted comments on this change.

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
..


Patch Set 19:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2056/18/asterixdb/asterix-geo/pom.xml
File asterixdb/asterix-geo/pom.xml:

PS18, Line 131:   org.apache.asterix This wasn't to be removed, you should use ${project.version} here, not hard
Sorry. I mixed it up with the others. I already changed it as you suggested.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ahmed Eldawy 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

2018-03-23 Thread Ahmed Eldawy (Code Review)

Hello Jenkins, Ian Maxon,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2056

to look at the new patch set (#19).

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
..

[ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type and functions

- A new geometry data type that represents standard OGC objects
- A new set of spatial functions that operate on geometry objects including
  spatial analysis, spatial predicates, and spatial aggregate functions
- Parse both Well-Known Text (WKT) and GeoJSON standard formats
- All geometry functions are implemented through the open source library
  Esri Geometry API

Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
---
M asterixdb/asterix-app/pom.xml
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/GeoJSONQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/analysis.12.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.17.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.4.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.6.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.9.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/analysis.10.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.13.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.14.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/primitive.7.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/analysis.16.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.11.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.8.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/primitive.15.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/datatype.3.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.12.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.17.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.4.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.5.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.6.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.9.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.10.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.13.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.14.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.7.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.15.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.16.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M asterixdb/asterix-external-data/pom.xml
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/AbstractDataParser.java
M 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ADMDataParserTest.java
A asterixdb/asterix-geo/pom.xml
A 
asterixdb/asterix-geo/src/main/java/org/apache/asterix/geo/aggregates/STUnionAggregateDescriptor.java
A 
asterixdb/asterix-geo/src/main/java/org/apache/asterix/geo/aggregates/STUnionAggregateFunction.java
A

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

2018-03-23 Thread Ahmed Eldawy (Code Review)

Ahmed Eldawy has posted comments on this change.

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
..


Patch Set 18:

(10 comments)

I removed most of the redundant dependencies. However, two of them seem to be 
necessary so I couldn't remove them. See my replies on your individual 
comments. I can push the changes but I prefer to wait and see if there is 
something we need to do about the remaining two dependencies.

https://asterix-gerrit.ics.uci.edu/#/c/2056/18/asterixdb/asterix-geo/pom.xml
File asterixdb/asterix-geo/pom.xml:

PS18, Line 96:   0.3.4-SNAPSHOT
> remove, this is inherited
Done


PS18, Line 101:   3.7
> remove, this is inherited
Done


PS18, Line 106:   0.3.4-SNAPSHOT
> remove, this is inherited
Done


PS18, Line 111:   0.3.4-SNAPSHOT
> remove, this is inherited
Done


PS18, Line 116:   0.3.4-SNAPSHOT
> remove, this is inherited
Done


PS18, Line 121:   0.3.4-SNAPSHOT
> remove, this is inherited
Done


PS18, Line 126:   0.3.4-SNAPSHOT
> remove, this is inherited
Done


PS18, Line 131:   0.9.4-SNAPSHOT
> ${project.version}
The build failed after removing this dependency with the error below. I 
replaced it with ${project.version} and it worked fine.
 Build error when removed 
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]   
[ERROR]   The project org.apache.asterix:asterix-geo:0.9.4-SNAPSHOT 
(/home/eldawy/workspace/asterixdb-pull/asterixdb/asterix-geo/pom.xml) has 1 
error
[ERROR] 'dependencies.dependency.version' for 
org.apache.asterix:asterix-common:jar is missing. @ 
org.apache.asterix:asterix-geo:[unknown-version], 
/home/eldawy/workspace/asterixdb-pull/asterixdb/asterix-geo/pom.xml, line 121, 
column 17
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException



PS18, Line 136:   0.3.4-SNAPSHOT
> remove, this is inherited
Done


https://asterix-gerrit.ics.uci.edu/#/c/2056/18/asterixdb/pom.xml
File asterixdb/pom.xml:

PS18, Line 1200: 1.9
> remove, this is inherited
I didn't modify this dependency myself. However, I tried to remove the version 
and the compilation failed with the following error.

[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]   
[ERROR]   The project org.apache.asterix:asterix-transactions:0.9.4-SNAPSHOT 
(/home/eldawy/workspace/asterixdb-pull/asterixdb/asterix-transactions/pom.xml) 
has 1 error
[ERROR] 'dependencies.dependency.version' for 
commons-codec:commons-codec:jar is missing. @ 
org.apache.asterix:asterix-transactions:[unknown-version], 
/home/eldawy/workspace/asterixdb-pull/asterixdb/asterix-transactions/pom.xml, 
line 162, column 17


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

2018-03-22 Thread Ahmed Eldawy (Code Review)

Hello Anon. E. Moose #1000171, Jenkins, Ian Maxon,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2056

to look at the new patch set (#18).

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
..

[ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type and functions

- A new geometry data type that represents standard OGC objects
- A new set of spatial functions that operate on geometry objects including
  spatial analysis, spatial predicates, and spatial aggregate functions
- Parse both Well-Known Text (WKT) and GeoJSON standard formats
- All geometry functions are implemented through the open source library
  Esri Geometry API

Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
---
M asterixdb/asterix-app/pom.xml
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/GeoJSONQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/analysis.12.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.17.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.4.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.6.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.9.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/analysis.10.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.13.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.14.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/primitive.7.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/analysis.16.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.11.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.8.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/primitive.15.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/datatype.3.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.12.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.17.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.4.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.5.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.6.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.9.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.10.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.13.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.14.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.7.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.15.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.16.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M asterixdb/asterix-external-data/pom.xml
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/AbstractDataParser.java
M 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ADMDataParserTest.java
A asterixdb/asterix-geo/pom.xml
A 
asterixdb/asterix-geo/src/main/java/org/apache/asterix/geo/aggregates/STUnionAggregateDescriptor.java
A 
asterixdb/asterix-geo/src/main/java/org/apache/asterix/geo/aggregates/STUnionAggregateFunction.java
A

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

2018-03-19 Thread Ahmed Eldawy (Code Review)

Ahmed Eldawy has posted comments on this change.

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
..


Patch Set 17:

It is already added to both asterix-server and asterix-app and these are the 
ones with tests. Specifically, the failing test is in asterix-server module. Do 
you have suggestions or where else I can add the dependency?

The exception is raised by FunctionManager which could not find the function 
'st-make-point'. This function is defined in the new asterix-geo module and is 
added to the built-in functions in asterix-om:BuiltinFunctions.java. I followed 
your design with the fuzzy join where you declared the functions in 
asterix-om:BuiltinFunctions without adding asterix-fuzzy as a dependency while 
defining them in asterix-fuzzy module. Am I missing something?

 > >
 > > https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3795/
 > > : UNSTABLE
 > >
 > You'll need to add the asterix-geo module as a test dependency to
 > any modules which have tests that depend on the geo functions. 
 > You'll also need to mark it as a usedDependency in the dependency
 > plugin configuration for the module.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ahmed Eldawy 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

2018-03-16 Thread Ahmed Eldawy (Code Review)

Hello Anon. E. Moose #1000171, Jenkins, Ian Maxon,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2056

to look at the new patch set (#17).

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
..

[ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type and functions

- A new geometry data type that represents standard OGC objects
- A new set of spatial functions that operate on geometry objects including
  spatial analysis, spatial predicates, and spatial aggregate functions
- Parse both Well-Known Text (WKT) and GeoJSON standard formats
- All geometry functions are implemented through the open source library
  Esri Geometry API

Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
---
M asterixdb/asterix-app/pom.xml
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/GeoJSONQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/analysis.12.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.17.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.4.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.6.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.9.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/analysis.10.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.13.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.14.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/primitive.7.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/analysis.16.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.11.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.8.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/primitive.15.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/datatype.3.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.12.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.17.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.4.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.5.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.6.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.9.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.10.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.13.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.14.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.7.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.15.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.16.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M asterixdb/asterix-external-data/pom.xml
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/AbstractDataParser.java
M 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ADMDataParserTest.java
A asterixdb/asterix-geo/pom.xml
A 
asterixdb/asterix-geo/src/main/java/org/apache/asterix/geo/aggregates/STUnionAggregateDescriptor.java
A 
asterixdb/asterix-geo/src/main/java/org/apache/asterix/geo/aggregates/STUnionAggregateFunction.java
A

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

2018-03-16 Thread Ahmed Eldawy (Code Review)

Hello Anon. E. Moose #1000171, Jenkins, Ian Maxon,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2056

to look at the new patch set (#16).

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
..

[ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type and functions

- A new geometry data type that represents standard OGC objects
- A new set of spatial functions that operate on geometry objects including
  spatial analysis, spatial predicates, and spatial aggregate functions
- Parse both Well-Known Text (WKT) and GeoJSON standard formats
- All geometry functions are implemented through the open source library
  Esri Geometry API

Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
---
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/GeoJSONQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/analysis.12.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.17.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.4.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.6.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.9.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/analysis.10.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.13.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.14.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/primitive.7.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/analysis.16.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.11.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.8.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/primitive.15.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/datatype.3.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.12.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.17.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.4.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.5.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.6.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.9.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.10.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.13.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.14.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.7.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.15.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.16.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M asterixdb/asterix-external-data/pom.xml
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/AbstractDataParser.java
M 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ADMDataParserTest.java
A asterixdb/asterix-geo/pom.xml
A 
asterixdb/asterix-geo/src/main/java/org/apache/asterix/geo/aggregates/STUnionAggregateDescriptor.java
A 
asterixdb/asterix-geo/src/main/java/org/apache/asterix/geo/aggregates/STUnionAggregateFunction.java
A

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

2018-03-12 Thread Ahmed Eldawy (Code Review)

Hello Anon. E. Moose #1000171, Jenkins, Ian Maxon,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2056

to look at the new patch set (#14).

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
..

[ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type and functions

- A new geometry data type that represents standard OGC objects
- A new set of spatial functions that operate on geometry objects including
  spatial analysis, spatial predicates, and spatial aggregate functions
- Parse both Well-Known Text (WKT) and GeoJSON standard formats
- All geometry functions are implemented through the open source library
  Esri Geometry API

Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
---
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/GeoJSONQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/analysis.12.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.17.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.4.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.6.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.9.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/analysis.10.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.13.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.14.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/primitive.7.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/analysis.16.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.11.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.8.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/primitive.15.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/datatype.3.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.12.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.17.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.4.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.5.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.6.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.9.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.10.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.13.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.14.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.7.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.15.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.16.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/BuiltinTypeMap.java
M asterixdb/asterix-om/pom.xml
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AObjectPrinterFactory.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AGeometryPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AObjectPrinterFactory.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AGeometrySerializerDeserializer.java
M

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

2018-03-09 Thread Ahmed Eldawy (Code Review)

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2056

to look at the new patch set (#13).

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
..

[ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type and functions

- A new geometry data type that represents standard OGC objects
- A new set of spatial functions that operate on geometry objects including
  spatial analysis, spatial predicates, and spatial aggregate functions
- Parse both Well-Known Text (WKT) and GeoJSON standard formats
- All geometry functions are implemented through the open source library
  Esri Geometry API

Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
---
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/GeoJSONQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/analysis.12.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.17.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.4.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.6.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.9.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/analysis.10.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.13.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.14.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/primitive.7.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/analysis.16.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.11.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.8.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/primitive.15.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/datatype.3.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.12.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.17.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.4.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.5.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.6.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.9.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.10.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.13.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.14.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.7.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.15.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.16.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/BuiltinTypeMap.java
M asterixdb/asterix-om/pom.xml
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AObjectPrinterFactory.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AGeometryPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AObjectPrinterFactory.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AGeometrySerializerDeserializer.java
M

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

2018-02-14 Thread Ahmed Eldawy (Code Review)

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2056

to look at the new patch set (#12).

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
..

[ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type and functions

- A new geometry data type that represents standard OGC objects
- A new set of spatial functions that operate on geometry objects including
  spatial analysis, spatial predicates, and spatial aggregate functions
- Parse both Well-Known Text (WKT) and GeoJSON standard formats
- All geometry functions are implemented through the open source library
  Esri Geometry API

Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
---
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/GeoJSONQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/analysis.12.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.17.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.4.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.6.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.9.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/analysis.10.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.13.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.14.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/primitive.7.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/analysis.16.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.11.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.8.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/primitive.15.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/datatype.3.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.12.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.17.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.4.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.5.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.6.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.9.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.10.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.13.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.14.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.7.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.15.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.16.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/BuiltinTypeMap.java
M asterixdb/asterix-om/pom.xml
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AObjectPrinterFactory.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AGeometryPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AObjectPrinterFactory.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AGeometrySerializerDeserializer.java
M

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

2018-02-13 Thread Ahmed Eldawy (Code Review)

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2347

to look at the new patch set (#3).

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
..

[ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type and functions

- A new geometry data type that represents standard OGC objects
- A new set of spatial functions that operate on geometry objects including
  spatial analysis, spatial predicates, and spatial aggregate functions
- Parse both Well-Known Text (WKT) and GeoJSON standard formats
- All geometry functions are implemented through the open source library
  Esri Geometry API

Change-Id: I1e08aeef2eb78c624f3956b2d1a66ef8ddd06951
---
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/GeoJSONQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/analysis.12.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.17.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.4.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.6.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.9.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/analysis.10.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.13.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.14.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/primitive.7.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/analysis.16.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.11.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.8.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/primitive.15.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/datatype.3.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.12.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.17.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.4.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.5.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.6.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.9.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.10.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.13.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.14.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.7.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.15.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.16.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/BuiltinTypeMap.java
M asterixdb/asterix-om/pom.xml
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AObjectPrinterFactory.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AGeometryPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AObjectPrinterFactory.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AGeometrySerializerDeserializer.java
M

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

2018-02-13 Thread Ahmed Eldawy (Code Review)

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2056

to look at the new patch set (#10).

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
..

[ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type and functions

- A new geometry data type that represents standard OGC objects
- A new set of spatial functions that operate on geometry objects including
  spatial analysis, spatial predicates, and spatial aggregate functions
- Parse both Well-Known Text (WKT) and GeoJSON standard formats
- All geometry functions are implemented through the open source library
  Esri Geometry API

Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
---
M asterixdb/asterix-active/pom.xml
M asterixdb/asterix-algebra/pom.xml
R 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/ExtensionStatement.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AbstractLangTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/CompiledStatements.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M asterixdb/asterix-app/pom.xml
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
D 
asterixdb/asterix-app/src/test/java/org/apache/asterix/aql/translator/QueryTranslatorTest.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/graph/pregel-q01/pregel-q01.1.ddl.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/graph/pregel-q01/pregel-q01.2.update.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/graph/pregel-q01/pregel-q01.3.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/graph/pregel-q02/pregel-q02.1.ddl.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/graph/pregel-q02/pregel-q02.2.update.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/graph/pregel-q02/pregel-q02.3.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/graph/pregel-q03/pregel-q03.1.ddl.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/graph/pregel-q03/pregel-q03.2.update.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/graph/pregel-q03/pregel-q03.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/GeoJSONQueries.xml
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/analysis.12.query.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.2.update.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.3.query.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.17.query.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.4.query.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.5.query.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.6.query.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.9.query.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/analysis.10.query.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.13.query.sqlpp
R 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.14.query.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/primitive.7.query.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/analysis.16.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.11.update.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.8.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/primitive.15.query.sqlpp
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/graph/pregel-q01/pregel-q01.1.ddl.sqlpp
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/graph/pregel-q01/pregel-q01.2.update.sqlpp
D

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

2018-02-07 Thread Ahmed Eldawy (Code Review)

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2056

to look at the new patch set (#9).

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
..

[ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type and functions

- A new geometry data type that represents standard OGC objects
- A new set of spatial functions that operate on geometry objects including
  spatial analysis, spatial predicates, and spatial aggregate functions
- Parse both Well-Known Text (WKT) and GeoJSON standard formats
- All geometry functions are implemented through the open source library
  Esri Geometry API

Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
---
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/GeoJSONQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/analysis.12.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.17.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.4.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.6.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.9.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/analysis.10.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.13.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.14.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/primitive.7.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/analysis.16.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.11.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.8.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/primitive.15.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/datatype.3.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.12.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.17.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.4.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.5.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.6.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.9.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.10.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.13.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.14.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.7.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.15.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.16.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/BuiltinTypeMap.java
M asterixdb/asterix-om/pom.xml
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AObjectPrinterFactory.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AGeometryPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AObjectPrinterFactory.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AGeometrySerializerDeserializer.java
M

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

2018-02-02 Thread Ahmed Eldawy (Code Review)

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2056

to look at the new patch set (#8).

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
..

[ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type and functions

- A new geometry data type that represents standard OGC objects
- A new set of spatial functions that operate on geometry objects including
  spatial analysis, spatial predicates, and spatial aggregate functions
- Parse both Well-Known Text (WKT) and GeoJSON standard formats
- All geometry functions are implemented through the open source library
  Esri Geometry API

Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
---
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/GeoJSONQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/analysis.12.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.17.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.4.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.6.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.9.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/analysis.10.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.13.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.14.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/primitive.7.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/analysis.16.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.11.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.8.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/primitive.15.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/datatype.3.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.12.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.17.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.4.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.5.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.6.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.9.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.10.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.13.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.14.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.7.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.15.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.16.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/BuiltinTypeMap.java
M asterixdb/asterix-om/pom.xml
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AObjectPrinterFactory.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AGeometryPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AObjectPrinterFactory.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AGeometrySerializerDeserializer.java
M

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

2018-02-02 Thread Ahmed Eldawy (Code Review)

Ahmed Eldawy has posted comments on this change.

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
..


Patch Set 7:

(3 comments)

I didn't test its memory consumption but my understanding is that it will 
create as many Java objects as the number of records in the input. I understand 
how bad it is but this is the price of using the existing Esri library. It is 
not really optimized for streaming data from a binary stream where it reuses 
the same object over and over. I don't see anyway around it without changing 
the Esri library itself. However, we can probably have our own implementation 
for the easy functions (e.g., XMin and XMax) which does not create any objects 
and processes it from the binary stream. But we will still rely on Esri for the 
complex functions (e.g., Union and Intersect for multipolygon.

 > (4 comments)
 > 
 > Has this been benchmarked for memory consumption? I see a lot of
 > places that look like to me, they will consume memory in proportion
 > to the data perhaps...

https://asterix-gerrit.ics.uci.edu/#/c/2056/6/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AGeometrySerializerDeserializer.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AGeometrySerializerDeserializer.java:

PS6, Line 49: OGCGeometry geometry = 
OGCGeometry.createFromOGCStructure(
: OperatorImportFromWkb.local().executeOGC(0, 
buffer, null), SpatialReference.create(4326));
: return new AGeometry(geometry);
> They should both be static final variables then, the numbers.
Done


https://asterix-gerrit.ics.uci.edu/#/c/2056/6/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/STUnionAggregateFunction.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/STUnionAggregateFunction.java:

PS6, Line 66: 
: @
> That should definitely be a static final variable then.
Done


Line 104: }
> Maybe use this UnsupportedItemTypeException?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ahmed Eldawy 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

2018-02-02 Thread Ahmed Eldawy (Code Review)

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2056

to look at the new patch set (#7).

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
..

[ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type and functions

- A new geometry data type that represents standard OGC objects
- A new set of spatial functions that operate on geometry objects including
  spatial analysis, spatial predicates, and spatial aggregate functions
- Parse both Well-Known Text (WKT) and GeoJSON standard formats
- All geometry functions are implemented through the open source library
  Esri Geometry API

Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
---
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/GeoJSONQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/analysis.12.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.17.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.4.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.6.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.9.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/analysis.10.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.13.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.14.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/primitive.7.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/analysis.16.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.11.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.8.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/primitive.15.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/datatype.3.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.12.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.17.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.4.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.5.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.6.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.9.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.10.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.13.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.14.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.7.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.15.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.16.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/BuiltinTypeMap.java
M asterixdb/asterix-om/pom.xml
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AObjectPrinterFactory.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AGeometryPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AObjectPrinterFactory.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AGeometrySerializerDeserializer.java
M

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

2018-02-02 Thread Ahmed Eldawy (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2347

to look at the new patch set (#2).

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
..

[ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type and functions

- A new geometry data type that represents standard OGC objects
- A new set of spatial functions that operate on geometry objects including
  spatial analysis, spatial predicates, and spatial aggregate functions
- Parse both Well-Known Text (WKT) and GeoJSON standard formats
- All geometry functions are implemented through the open source library
  Esri Geometry API

Change-Id: I1e08aeef2eb78c624f3956b2d1a66ef8ddd06951
---
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/GeoJSONQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/analysis.12.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.17.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.4.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.6.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.9.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/analysis.10.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.13.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.14.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/primitive.7.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/analysis.16.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.11.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.8.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/primitive.15.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/datatype.3.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.12.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.17.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.4.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.5.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.6.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.9.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.10.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.13.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.14.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.7.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.15.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.16.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/BuiltinTypeMap.java
M asterixdb/asterix-om/pom.xml
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AObjectPrinterFactory.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AGeometryPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AObjectPrinterFactory.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AGeometrySerializerDeserializer.java
M

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

2018-02-02 Thread Ahmed Eldawy (Code Review)

Ahmed Eldawy has posted comments on this change.

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
..


Patch Set 6:

(36 comments)

I handled the comments raised in that pull request. I pushed the updated code 
but it got assigned a new ID. I don't know why this happened as I'm not very 
familiar with gerrit yet. You can find the updated code here 
https://asterix-gerrit.ics.uci.edu/#/c/2347/

https://asterix-gerrit.ics.uci.edu/#/c/2056/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.4.query.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.4.query.sqlpp:

Line 21: SELECT VALUE {"Type": geometry_type(geo.myGeometry), "Area": 
st_area(geo.myGeometry), "Coordinate dimension": st_coord_dim(geo.myGeometry), 
"Dimension":st_dimension(geo.myGeometry), 
"NPoints":st_n_points(geo.myGeometry), 
"XMax":st_x_max(geo.myGeometry),"XMin":st_x_min(geo.myGeometry), 
"YMax":st_y_max(geo.myGeometry), "YMin":st_y_min(geo.myGeometry), "Binary": 
st_as_binary(geo.myGeometry), 
"GeoJSON":st_as_geojson(geo.myGeometry),"WKT":st_as_text(geo.myGeometry)}  FROM 
Geometries geo;
> Let's trim the long lines into several lines for easier reading/editing.
Done


https://asterix-gerrit.ics.uci.edu/#/c/2056/6/asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/datatype.3.adm
File 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/datatype.3.adm:

Line 2: { "Geometries": { "id": 135, "myGeometry": 
{"type":"LineString","coordinates":[[1,2],[4,5],[7,8]],"crs":{"type":"name","properties":{"name":"EPSG:4326"}}}
 } }
> Maybe order the result by type or id?
Done! Sorted by ID


https://asterix-gerrit.ics.uci.edu/#/c/2056/6/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AGeometrySerializerDeserializer.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AGeometrySerializerDeserializer.java:

PS6, Line 49: OGCGeometry geometry = OGCGeometry
: 
.createFromOGCStructure(OperatorImportFromWkb.local().executeOGC(0, buffer, 
null),
: SpatialReference.create(4326))
> What are the 0, null, and 4326 here for? Can we get them defined as static 
The parameter 0 uses the default import flags in JTS.
null is a progress tracker which allows canceling or tracking the running time 
of a lengthy operation. Currently, it is not used but it can be added in the 
future if we need to terminate or kill a job.
4326 is the ID of the WGS84 coordinate reference system, a.k.a. latitude and 
longitude. http://spatialreference.org/ref/epsg/wgs-84/


https://asterix-gerrit.ics.uci.edu/#/c/2056/6/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AGeometry.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AGeometry.java:

Line 73: throw new RuntimeException(e);
> +1, should throw something else preferably...
We're bound here to the signature of JSONSerializable#toJSON which does not 
declare any exceptions to be thrown. We cannot throw any of the Hyracks 
exceptions because they all extend HyracksException which is a type of 
IOException. We can only throw one of the RuntimeExceptions which do not need 
to be declared explicitly.
Is it OK to declare my own exception and make it a subtype of RuntimeException?
As an example, the class 
org.apache.hyracks.algebricks.common.exceptions.NotImplementedException was 
declared in this way.


https://asterix-gerrit.ics.uci.edu/#/c/2056/6/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java:

Line 724: //Geo
> space
Should I add a space? I found no space in the heading of other sections.


https://asterix-gerrit.ics.uci.edu/#/c/2056/6/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/utils/NonTaggedFormatUtil.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/utils/NonTaggedFormatUtil.java:

PS6, Line 200: AInt32SerializerDeserializer
> Wait, what? Why AInt32?
For efficiency, we stored the size of the geometry attribute in the first 
32-bits. I added a comment to explain this.


https://asterix-gerrit.ics.uci.edu/#/c/2056/6/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/STUnionAggregateFunction.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/STUnionAggregateFunction.java:

PS6, Line 66: geometry = new OGCPoint(new Point(), 
SpatialReference.create(4326));
: }
> Again what is the 4326 about?
4326 is the ID of the WGS84 CRS which is the default one used by most 
applications (think: latitude and longitude).

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

2018-02-02 Thread Ahmed Eldawy (Code Review)

Ahmed Eldawy has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2347

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
..

[ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type and functions

- A new geometry data type that represents standard OGC objects
- A new set of spatial functions that operate on geometry objects including
  spatial analysis, spatial predicates, and spatial aggregate functions
- Parse both Well-Known Text (WKT) and GeoJSON standard formats
- All geometry functions are implemented through the open source library
  Esri Geometry API

Change-Id: I1e08aeef2eb78c624f3956b2d1a66ef8ddd06951
---
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/GeoJSONQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/analysis.12.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.17.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.4.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.6.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.9.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/analysis.10.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.13.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.14.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/primitive.7.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/analysis.16.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.11.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.8.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/primitive.15.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/datatype.3.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.12.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.17.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.4.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.5.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.6.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.9.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.10.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.13.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.14.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.7.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.15.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.16.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/BuiltinTypeMap.java
M asterixdb/asterix-om/pom.xml
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AObjectPrinterFactory.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AGeometryPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AObjectPrinterFactory.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AGeometrySerializerDeserializer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AObjectSerializerDeserializer.java
M

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

2017-10-11 Thread Ahmed Eldawy (Code Review)

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2056

to look at the new patch set (#6).

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
..

[ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type and functions

- A new geometry data type that represents standard OGC objects
- A new set of spatial functions that operate on geometry objects including
  spatial analysis, spatial predicates, and spatial aggregate functions
- Parse both Well-Known Text (WKT) and GeoJSON standard formats
- All geometry functions are implemented through the open source library
  Esri Geometry API

Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
---
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/GeoJSONQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/analysis.12.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.17.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.4.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.6.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.9.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/analysis.10.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.13.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/predicate.14.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/single-method/primitive.7.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/analysis.16.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.11.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/datatype_definition.8.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/two-geometries/primitive.15.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/datatype.3.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.12.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.17.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.4.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.5.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.6.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/result.9.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.10.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.13.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.14.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/single-method/result.7.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.15.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/two-geometries/result.16.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/BuiltinTypeMap.java
M asterixdb/asterix-om/pom.xml
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AObjectPrinterFactory.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AGeometryPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AObjectPrinterFactory.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AGeometrySerializerDeserializer.java
M

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

2017-10-11 Thread Ahmed Eldawy (Code Review)

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2056

to look at the new patch set (#5).

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
..

[ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type and functions

- A new geometry data type that represents standard OGC objects
- A new set of spatial functions that operate on geometry objects including
  spatial analysis, spatial predicates, and spatial aggregate functions
- Parse both Well-Known Text (WKT) and GeoJSON standard formats
- All geometry functions are implemented through the open source library
  Esri Geometry API

The following commits from your working branch will be included:

commit 45cc86f21ce214f6edc4fbc5885aaac2dfa1ec8f
Author: Ahmed Eldawy 
Date:   Wed Oct 4 16:43:35 2017 -0700

Reverted an import change that is not necessary

commit fa8066d6467839a8f6082c71e2a83048f5560252
Author: Ahmed Eldawy 
Date:   Wed Oct 4 16:29:23 2017 -0700

Reverted a minor unnecessary change

commit 73b05382fe34b334e7b334142a8ab59f3304925c
Author: Ahmed Eldawy 
Date:   Wed Oct 4 16:10:59 2017 -0700

Removed some redundant files

commit 344157c4780f156e34d5201ad8d71aee35aa9957
Merge: 9ea90ca ca8cd25
Author: Ahmed Eldawy 
Date:   Wed Oct 4 13:54:16 2017 -0700

Merged with the latest work from Riyafa/geometry

commit 9ea90caaeaf5953f43752a585b0255f34bfe8722
Author: Ahmed Eldawy 
Date:   Wed Oct 4 13:51:26 2017 -0700

Removed the source code of Esri Geometry API and rely on Maven

commit 2d7e6a9109c75f377d601dafde2ab9db13911365
Merge: 7204fcc b2e50b7
Author: Ahmed Eldawy 
Date:   Wed Oct 4 13:39:20 2017 -0700

Merged with the master and did minor refactors

commit 7204fcc3304be79df6e47c47215751a09b70a985
Author: Ahmed Eldawy 
Date:   Wed Oct 4 11:27:49 2017 -0700

Reverted a change that collapses imports since it is irrelevant to geometry 
functions

commit ca8cd2502bb0e9abfc6276dc5c286cf3a984c701
Author: riyafa 
Date:   Sun Sep 3 21:25:56 2017 +0530

Use the newly released esri api as a maven dependencyc

commit ef295946d8c19bcdd18a65b72efa5e43662a3b40
Author: riyafa 
Date:   Sat Aug 26 09:00:48 2017 +0530

Update pom files

commit 9e8c42e2b462a880f5a0210cee1df61f45a4d190
Author: riyafa 
Date:   Mon Aug 21 20:48:09 2017 +0530

Add test cases

commit 8467da56445787f218035e789490521690a7dd47
Author: riyafa 
Date:   Mon Aug 21 20:47:46 2017 +0530

Add test cases

commit d802d527520fb5a5727cb3755cd3d359e26e16b6
Author: riyafa 
Date:   Thu Aug 17 20:46:29 2017 +0530

add function st_polygonize

commit 454953b68b9b0fd2ed55714f7832857054af8a83
Author: riyafa 
Date:   Wed Aug 16 19:17:07 2017 +0530

Changes to get things working

commit ee29d8142a11132c38c5c4a54fffb2b295045952
Author: Till Westmann 
Date:   Fri Jul 28 16:49:31 2017 -0700

ASTERIXDB-1371 - Define new datatype 'geometry'

user model changes: Add new builtin type 'geometry'
storage format changes: Add parsing functionality and functions for
datatype 'geometry'
interface changes: no

details:
- temporarily adds a new module "esri-geometry-api" which is taken from
  
https://github.com/Esri/geometry-api-java/commit/b0bc20e9f3a8e6ea880dbfefebeb54d2552b97fe
  It should be removed and retrieved from a maven repository instead as
  soon as Esri releases a version of the API that does not depend on
  the JSON license

commit 10e2c9b8d18926d8152dca42e37512049abd9fca
Author: riyafa 
Date:   Fri Aug 25 14:31:08 2017 +0530

Ignore dependency change

commit f57004205bebb8dc3efd8102d5f8db2dfac94701
Author: riyafa 
Date:   Tue Aug 22 19:56:00 2017 +0530

ASTERIXDB-1371 - Define new datatype 'geometry'

user model changes: Add new builtin type 'geometry'
storage format changes: Add parsing  functionality and functions for 
datatype 'geometry'
interface changes: no

Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
---
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/GeoJSONQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/analysis.12.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.1.ddl.sqlpp
A

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Ahmed Eldawy (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2056

to look at the new patch set (#4).

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..

Standard geometry support in AsterixDB through Esri Geometry API.

The following commits from your working branch will be included:

commit 45cc86f21ce214f6edc4fbc5885aaac2dfa1ec8f
Author: Ahmed Eldawy 
Date:   Wed Oct 4 16:43:35 2017 -0700

Reverted an import change that is not necessary

commit fa8066d6467839a8f6082c71e2a83048f5560252
Author: Ahmed Eldawy 
Date:   Wed Oct 4 16:29:23 2017 -0700

Reverted a minor unnecessary change

commit 73b05382fe34b334e7b334142a8ab59f3304925c
Author: Ahmed Eldawy 
Date:   Wed Oct 4 16:10:59 2017 -0700

Removed some redundant files

commit 344157c4780f156e34d5201ad8d71aee35aa9957
Merge: 9ea90ca ca8cd25
Author: Ahmed Eldawy 
Date:   Wed Oct 4 13:54:16 2017 -0700

Merged with the latest work from Riyafa/geometry

commit 9ea90caaeaf5953f43752a585b0255f34bfe8722
Author: Ahmed Eldawy 
Date:   Wed Oct 4 13:51:26 2017 -0700

Removed the source code of Esri Geometry API and rely on Maven

commit 2d7e6a9109c75f377d601dafde2ab9db13911365
Merge: 7204fcc b2e50b7
Author: Ahmed Eldawy 
Date:   Wed Oct 4 13:39:20 2017 -0700

Merged with the master and did minor refactors

commit 7204fcc3304be79df6e47c47215751a09b70a985
Author: Ahmed Eldawy 
Date:   Wed Oct 4 11:27:49 2017 -0700

Reverted a change that collapses imports since it is irrelevant to geometry 
functions

commit ca8cd2502bb0e9abfc6276dc5c286cf3a984c701
Author: riyafa 
Date:   Sun Sep 3 21:25:56 2017 +0530

Use the newly released esri api as a maven dependencyc

commit ef295946d8c19bcdd18a65b72efa5e43662a3b40
Author: riyafa 
Date:   Sat Aug 26 09:00:48 2017 +0530

Update pom files

commit 9e8c42e2b462a880f5a0210cee1df61f45a4d190
Author: riyafa 
Date:   Mon Aug 21 20:48:09 2017 +0530

Add test cases

commit 8467da56445787f218035e789490521690a7dd47
Author: riyafa 
Date:   Mon Aug 21 20:47:46 2017 +0530

Add test cases

commit d802d527520fb5a5727cb3755cd3d359e26e16b6
Author: riyafa 
Date:   Thu Aug 17 20:46:29 2017 +0530

add function st_polygonize

commit 454953b68b9b0fd2ed55714f7832857054af8a83
Author: riyafa 
Date:   Wed Aug 16 19:17:07 2017 +0530

Changes to get things working

commit ee29d8142a11132c38c5c4a54fffb2b295045952
Author: Till Westmann 
Date:   Fri Jul 28 16:49:31 2017 -0700

ASTERIXDB-1371 - Define new datatype 'geometry'

user model changes: Add new builtin type 'geometry'
storage format changes: Add parsing functionality and functions for
datatype 'geometry'
interface changes: no

details:
- temporarily adds a new module "esri-geometry-api" which is taken from
  
https://github.com/Esri/geometry-api-java/commit/b0bc20e9f3a8e6ea880dbfefebeb54d2552b97fe
  It should be removed and retrieved from a maven repository instead as
  soon as Esri releases a version of the API that does not depend on
  the JSON license

commit 10e2c9b8d18926d8152dca42e37512049abd9fca
Author: riyafa 
Date:   Fri Aug 25 14:31:08 2017 +0530

Ignore dependency change

commit f57004205bebb8dc3efd8102d5f8db2dfac94701
Author: riyafa 
Date:   Tue Aug 22 19:56:00 2017 +0530

ASTERIXDB-1371 - Define new datatype 'geometry'

user model changes: Add new builtin type 'geometry'
storage format changes: Add parsing  functionality and functions for 
datatype 'geometry'
interface changes: no

Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
---
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/GeoJSONQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/analysis.12.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.17.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.4.query.sqlpp
A

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Ahmed Eldawy (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2056

to look at the new patch set (#2).

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..

Standard geometry support in AsterixDB through Esri Geometry API.

The following commits from your working branch will be included:

commit 45cc86f21ce214f6edc4fbc5885aaac2dfa1ec8f
Author: Ahmed Eldawy 
Date:   Wed Oct 4 16:43:35 2017 -0700

Reverted an import change that is not necessary

commit fa8066d6467839a8f6082c71e2a83048f5560252
Author: Ahmed Eldawy 
Date:   Wed Oct 4 16:29:23 2017 -0700

Reverted a minor unnecessary change

commit 73b05382fe34b334e7b334142a8ab59f3304925c
Author: Ahmed Eldawy 
Date:   Wed Oct 4 16:10:59 2017 -0700

Removed some redundant files

commit 344157c4780f156e34d5201ad8d71aee35aa9957
Merge: 9ea90ca ca8cd25
Author: Ahmed Eldawy 
Date:   Wed Oct 4 13:54:16 2017 -0700

Merged with the latest work from Riyafa/geometry

commit 9ea90caaeaf5953f43752a585b0255f34bfe8722
Author: Ahmed Eldawy 
Date:   Wed Oct 4 13:51:26 2017 -0700

Removed the source code of Esri Geometry API and rely on Maven

commit 2d7e6a9109c75f377d601dafde2ab9db13911365
Merge: 7204fcc b2e50b7
Author: Ahmed Eldawy 
Date:   Wed Oct 4 13:39:20 2017 -0700

Merged with the master and did minor refactors

commit 7204fcc3304be79df6e47c47215751a09b70a985
Author: Ahmed Eldawy 
Date:   Wed Oct 4 11:27:49 2017 -0700

Reverted a change that collapses imports since it is irrelevant to geometry 
functions

commit ca8cd2502bb0e9abfc6276dc5c286cf3a984c701
Author: riyafa 
Date:   Sun Sep 3 21:25:56 2017 +0530

Use the newly released esri api as a maven dependencyc

commit ef295946d8c19bcdd18a65b72efa5e43662a3b40
Author: riyafa 
Date:   Sat Aug 26 09:00:48 2017 +0530

Update pom files

commit 9e8c42e2b462a880f5a0210cee1df61f45a4d190
Author: riyafa 
Date:   Mon Aug 21 20:48:09 2017 +0530

Add test cases

commit 8467da56445787f218035e789490521690a7dd47
Author: riyafa 
Date:   Mon Aug 21 20:47:46 2017 +0530

Add test cases

commit d802d527520fb5a5727cb3755cd3d359e26e16b6
Author: riyafa 
Date:   Thu Aug 17 20:46:29 2017 +0530

add function st_polygonize

commit 454953b68b9b0fd2ed55714f7832857054af8a83
Author: riyafa 
Date:   Wed Aug 16 19:17:07 2017 +0530

Changes to get things working

commit ee29d8142a11132c38c5c4a54fffb2b295045952
Author: Till Westmann 
Date:   Fri Jul 28 16:49:31 2017 -0700

ASTERIXDB-1371 - Define new datatype 'geometry'

user model changes: Add new builtin type 'geometry'
storage format changes: Add parsing functionality and functions for
datatype 'geometry'
interface changes: no

details:
- temporarily adds a new module "esri-geometry-api" which is taken from
  
https://github.com/Esri/geometry-api-java/commit/b0bc20e9f3a8e6ea880dbfefebeb54d2552b97fe
  It should be removed and retrieved from a maven repository instead as
  soon as Esri releases a version of the API that does not depend on
  the JSON license

commit 10e2c9b8d18926d8152dca42e37512049abd9fca
Author: riyafa 
Date:   Fri Aug 25 14:31:08 2017 +0530

Ignore dependency change

commit f57004205bebb8dc3efd8102d5f8db2dfac94701
Author: riyafa 
Date:   Tue Aug 22 19:56:00 2017 +0530

ASTERIXDB-1371 - Define new datatype 'geometry'

user model changes: Add new builtin type 'geometry'
storage format changes: Add parsing  functionality and functions for 
datatype 'geometry'
interface changes: no

Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
---
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/GeoJSONQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/analysis.12.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.17.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.4.query.sqlpp
A

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-05 Thread Ahmed Eldawy (Code Review)

Ahmed Eldawy has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2056

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..

Standard geometry support in AsterixDB through Esri Geometry API.

The following commits from your working branch will be included:

commit 45cc86f21ce214f6edc4fbc5885aaac2dfa1ec8f
Author: Ahmed Eldawy 
Date:   Wed Oct 4 16:43:35 2017 -0700

Reverted an import change that is not necessary

commit fa8066d6467839a8f6082c71e2a83048f5560252
Author: Ahmed Eldawy 
Date:   Wed Oct 4 16:29:23 2017 -0700

Reverted a minor unnecessary change

commit 73b05382fe34b334e7b334142a8ab59f3304925c
Author: Ahmed Eldawy 
Date:   Wed Oct 4 16:10:59 2017 -0700

Removed some redundant files

commit 344157c4780f156e34d5201ad8d71aee35aa9957
Merge: 9ea90ca ca8cd25
Author: Ahmed Eldawy 
Date:   Wed Oct 4 13:54:16 2017 -0700

Merged with the latest work from Riyafa/geometry

commit 9ea90caaeaf5953f43752a585b0255f34bfe8722
Author: Ahmed Eldawy 
Date:   Wed Oct 4 13:51:26 2017 -0700

Removed the source code of Esri Geometry API and rely on Maven

commit 2d7e6a9109c75f377d601dafde2ab9db13911365
Merge: 7204fcc b2e50b7
Author: Ahmed Eldawy 
Date:   Wed Oct 4 13:39:20 2017 -0700

Merged with the master and did minor refactors

commit 7204fcc3304be79df6e47c47215751a09b70a985
Author: Ahmed Eldawy 
Date:   Wed Oct 4 11:27:49 2017 -0700

Reverted a change that collapses imports since it is irrelevant to geometry 
functions

commit ca8cd2502bb0e9abfc6276dc5c286cf3a984c701
Author: riyafa 
Date:   Sun Sep 3 21:25:56 2017 +0530

Use the newly released esri api as a maven dependencyc

commit ef295946d8c19bcdd18a65b72efa5e43662a3b40
Author: riyafa 
Date:   Sat Aug 26 09:00:48 2017 +0530

Update pom files

commit 9e8c42e2b462a880f5a0210cee1df61f45a4d190
Author: riyafa 
Date:   Mon Aug 21 20:48:09 2017 +0530

Add test cases

commit 8467da56445787f218035e789490521690a7dd47
Author: riyafa 
Date:   Mon Aug 21 20:47:46 2017 +0530

Add test cases

commit d802d527520fb5a5727cb3755cd3d359e26e16b6
Author: riyafa 
Date:   Thu Aug 17 20:46:29 2017 +0530

add function st_polygonize

commit 454953b68b9b0fd2ed55714f7832857054af8a83
Author: riyafa 
Date:   Wed Aug 16 19:17:07 2017 +0530

Changes to get things working

commit ee29d8142a11132c38c5c4a54fffb2b295045952
Author: Till Westmann 
Date:   Fri Jul 28 16:49:31 2017 -0700

ASTERIXDB-1371 - Define new datatype 'geometry'

user model changes: Add new builtin type 'geometry'
storage format changes: Add parsing functionality and functions for
datatype 'geometry'
interface changes: no

details:
- temporarily adds a new module "esri-geometry-api" which is taken from
  
https://github.com/Esri/geometry-api-java/commit/b0bc20e9f3a8e6ea880dbfefebeb54d2552b97fe
  It should be removed and retrieved from a maven repository instead as
  soon as Esri releases a version of the API that does not depend on
  the JSON license

commit 10e2c9b8d18926d8152dca42e37512049abd9fca
Author: riyafa 
Date:   Fri Aug 25 14:31:08 2017 +0530

Ignore dependency change

commit f57004205bebb8dc3efd8102d5f8db2dfac94701
Author: riyafa 
Date:   Tue Aug 22 19:56:00 2017 +0530

ASTERIXDB-1371 - Define new datatype 'geometry'

user model changes: Add new builtin type 'geometry'
storage format changes: Add parsing  functionality and functions for 
datatype 'geometry'
interface changes: no

Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
---
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/GeoJSONQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/analysis.12.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.17.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.4.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.5.query.sqlpp
A

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

24 matches

Site Navigation

Mail list logo

Footer information