Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.

[Chen Li (Code Review)]

Chen Li has posted comments on this change.

Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
..


Patch Set 8:

@wenhai: Similar to another "fuzzy issue", I talked to @taewoo about this 
patch.  I suggest you two schedule a skype time to go through the changes 
together to explain/approve those changes.  Also I think it's critical to make 
sure proper comments are added, and those comments are clear.  Try to avoid 
grammatical mistakes in the comments.  Thanks!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1119
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wenhai Li 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Applied the multiway fuzzyjoin based on the prefix-based joi...

[Chen Li (Code Review)]

Chen Li has posted comments on this change.

Change subject: Applied the multiway fuzzyjoin based on the prefix-based join 
and the selectFuzzyJoin testCases.
..


Patch Set 5:

(2 comments)

@Wenhai: In this patch, can you give a high-level description of the changes, 
including the symptom, bug source, and the fix?

https://asterix-gerrit.ics.uci.edu/#/c/1076/5/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java:

Line 252: fuzzy.add(new FuzzyJoinRule());
Rename "fuzzy" to "fuzzyRules"?


Line 253: // Embedding the prefix join instead of ~= cause the newly 
subplan derived from the AggregateOp->NTSOp
I am not quite following this comment.  Can you try to rephrase it to make it 
more clear?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Applied the multiway fuzzyjoin based on the prefix-based joi...

[Chen Li (Code Review)]

Chen Li has posted comments on this change.

Change subject: Applied the multiway fuzzyjoin based on the prefix-based join 
and the selectFuzzyJoin testCases.
..


Patch Set 4:

@Wenhai: I want to take a closer look at this patch.  To help me and other 
reviewers, I wonder:

- Can you add high-level comments in the patch to explain the main changes you 
are making or the main bugs you are fixing?

- For those major changes, can we add brief comments to explain them?

- This patch looks big.  Is it possible to divide it to multiple, smaller 
patches?

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.

[Chen Li (Code Review)]

Chen Li has posted comments on this change.

Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
..


Patch Set 7:

Wenhai: I am trying to review this patch.  To help me (or other reviewers), can 
you add a high-level description of the cause of the problem, and how you fix 
it?  In addition, for those major changes (mainly the java file), add a few 
comments to explain those changes.  That will help a lot!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1119
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Applied the multiway fuzzyjoin based on the prefix-based joi...

[Chen Li (Code Review)]

Chen Li has posted comments on this change.

Change subject: Applied the multiway fuzzyjoin based on the prefix-based join 
and the selectFuzzyJoin testCases.
..


Patch Set 4:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1076/4/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/AsterixExtractFunctionsFromJoinConditionRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/AsterixExtractFunctionsFromJoinConditionRule.java:

Line 63: private boolean assignSimilarityPK(AbstractLogicalOperator joinOp, 
AbstractFunctionCallExpression fexp,
A general comment: to make the code much more readable, it will be much better 
to use a running example to explain the logic using the example.  People are 
good at doing generalization from examples.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: Yes

Change in asterixdb[master]: ASTERIXDB-1569: the config file now supports unit, comma, an...

[Chen Li (Code Review)]

Chen Li has posted comments on this change.

Change subject: ASTERIXDB-1569: the config file now supports unit, comma, and 
decimal.
..


Patch Set 1:

Cool :-)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1064
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I763d1b06e93f75775c0294da0d609c2bf3e102c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1544: fix the issue with fuzzyjoin on an indexed n...

[Chen Li (Code Review)]

Chen Li has posted comments on this change.

Change subject: ASTERIXDB-1544: fix the issue with fuzzyjoin on an indexed 
nullable field
..


Patch Set 1:

Thanks, @Taewoo.  It seems to be an easy change to review for @Wenhai.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1021
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie82badb0b9c1c04a1135b1829c445b5ddfb8c754
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No