[
https://issues.apache.org/jira/browse/ASTERIXDB-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247839#comment-16247839
]
ASF subversion and git services commented on ASTERIXDB-1871:
Commit c90f1e38af3fc59a019a8b551eac43ea8ef3cdd5 in asterixdb's branch
refs/heads/master from [~mhubail]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=c90f1e3 ]
[ASTERIXDB-1871][ASTERIXDB-2095] Stop Consumer Thread on Deallocate
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Currently there is a chance that a MaterializingPipelinedPartition
is deallocated before the consuming thread starts (e.g. due to job
abort) and therefore the consuming thread will not be interrupted
leading to leaked threads and files. This change checks if partition
was deallocated before the consumer starts, then the consumer thread
cleans up any files then exits.
- Make TaskAttemptId non-final class to mock it.
- Add test case.
Change-Id: I18c9fb085c149f41a202fff83aa6ec3aaeba6a77
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2143
Sonar-Qube: Jenkins
Tested-by: Jenkins
Integration-Tests: Jenkins
Contrib: Jenkins
Reviewed-by: Till Westmann
> Sporadic open file leaks in CancellationTest
>
>
> Key: ASTERIXDB-1871
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1871
> Project: Apache AsterixDB
> Issue Type: Bug
> Components: HYR - Hyracks
>Reporter: Yingyi Bu
>Assignee: Murtadha Hubail
>
> {noformat}
> Tests run: 1541, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 610.935
> sec <<< FAILURE! - in
> org.apache.asterix.test.runtime.SqlppExecutionWithCancellationTest
> org.apache.asterix.test.runtime.SqlppExecutionWithCancellationTest Time
> elapsed: 6.846 sec <<< FAILURE!
> java.lang.AssertionError: There are 4 leaked run files.
> at
> org.apache.asterix.test.runtime.LangExecutionUtil.checkOpenRunFileLeaks(LangExecutionUtil.java:166)
> at
> org.apache.asterix.test.runtime.LangExecutionUtil.tearDown(LangExecutionUtil.java:78)
> at
> org.apache.asterix.test.runtime.SqlppExecutionWithCancellationTest.tearDown(SqlppExecutionWithCancellationTest.java:53)
> [4/3/17, 9:10:23 PM] : java23938 michaelblow 728u REG
> 1,4 0 112414077
> /private/var/folders/5x/qdtntlds0fgcgknzwf61khvhgn/T/asterix_nc1/iodevice1/MaterializerTaskState4181303815132287300.waf
> java23938 michaelblow 729u REG1,4 0
> 112414078
> /private/var/folders/5x/qdtntlds0fgcgknzwf61khvhgn/T/asterix_nc2/iodevice0/MaterializerTaskState559113667370394226.waf
> java23938 michaelblow 730u REG1,4 0
> 112414079
> /private/var/folders/5x/qdtntlds0fgcgknzwf61khvhgn/T/asterix_nc1/iodevice0/MaterializerTaskState8296323294352675529.waf
> java23938 michaelblow 731u REG1,4 0
> 112414080
> /private/var/folders/5x/qdtntlds0fgcgknzwf61khvhgn/T/asterix_nc2/iodevice1/MaterializerTaskState6759935260936501189.waf
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
