Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Murtadha Hubail has submitted this change and it was merged.
Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query
Compilation
..
[ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation
- user model changes: no
- storage format changes: no
- interface changes:
Introduce IRequestParameters to encapsulate request parameters
and use it in IStatementExecutor#compileAndExecute and
IExtensionStatement#handle.
Details:
- Introduce IRequestParameters and its default implementation.
- Add optional parameters supplier in QueryServiceServlet.
Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1867
Tested-by: Jenkins
Contrib: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Till Westmann
---
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/IExtensionStatement.java
A
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IRequestParameters.java
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCQueryServiceServlet.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
A
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/RequestParameters.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java
M asterixdb/asterix-external-data/pom.xml
M asterixdb/asterix-metadata/pom.xml
M
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java
15 files changed, 233 insertions(+), 83 deletions(-)
Approvals:
Till Westmann: Looks good to me, approved
Jenkins: Verified; ; Verified
Objections:
Jenkins: Violations found
diff --git
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/IExtensionStatement.java
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/IExtensionStatement.java
index b0f863b..48441a3 100644
---
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/IExtensionStatement.java
+++
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/IExtensionStatement.java
@@ -20,12 +20,10 @@
import org.apache.asterix.lang.common.base.Statement;
import org.apache.asterix.metadata.declared.MetadataProvider;
+import org.apache.asterix.translator.IRequestParameters;
import org.apache.asterix.translator.IStatementExecutor;
-import org.apache.asterix.translator.IStatementExecutor.ResultDelivery;
-import org.apache.asterix.translator.IStatementExecutor.Stats;
import org.apache.hyracks.algebricks.common.exceptions.AlgebricksException;
import org.apache.hyracks.api.client.IHyracksClientConnection;
-import org.apache.hyracks.api.dataset.IHyracksDataset;
import org.apache.hyracks.api.exceptions.HyracksDataException;
/**
@@ -42,14 +40,15 @@
* Called when the {@code IStatementExecutor} encounters an extension
statement.
* An implementation class should implement the actual processing of the
statement in this method.
*
- * @param queryTranslator
- * @param metadataProvider
- * @param statementExecutor
* @param hcc
- * @param resultSetIdCounter
- * @throws Exception
+ * @param statementExecutor
+ * @param requestParameters
+ * @param metadataProvider
+ * @param resultSetId
+ * @throws HyracksDataException
+ * @throws AlgebricksException
*/
-void handle(IStatementExecutor statementExecutor, MetadataProvider
metadataProvider,
-IHyracksClientConnection hcc, IHyracksDataset hdc, ResultDelivery
resultDelivery, Stats stats,
-int resultSetIdCounter) throws HyracksDataException,
AlgebricksException;
-}
+void handle(IHyracksClientConnection hcc, IStatementExecutor
statementExecutor,
+IRequestParameters requestParameters, MetadataProvider
metadataProvider, int resultSetId)
+throws HyracksDataException, AlgebricksException;
+}
\ No newline at end of file
diff --git
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IRequestParameters.java
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IRequestParameters.java
new file mode 100644
index 000..8d0f20b
--- /dev/null
+++
b/asterixdb/asterix-algebra/src/main/java/
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 6: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 6: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3978/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 6: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1779/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 6: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1779/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1826/ (10/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 6: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 6: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3978/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/907/ (9/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1641/ (4/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4970/ (3/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/912/ (6/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1585/ (7/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1247/ (2/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1867 to look at the new patch set (#6). Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation - user model changes: no - storage format changes: no - interface changes: Introduce IRequestParameters to encapsulate request parameters and use it in IStatementExecutor#compileAndExecute and IExtensionStatement#handle. Details: - Introduce IRequestParameters and its default implementation. - Add optional parameters supplier in QueryServiceServlet. Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/IExtensionStatement.java A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IRequestParameters.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCQueryServiceServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/RequestParameters.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java M asterixdb/asterix-external-data/pom.xml M asterixdb/asterix-metadata/pom.xml M hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java 15 files changed, 233 insertions(+), 83 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/67/1867/6 -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1525/ (8/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6463/ (1/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/913/ (5/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 5: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/1867/5/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IRequestContext.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IRequestContext.java: PS5, Line 27: IRequestContext rename to IRequestParameters? PS5, Line 32: getHyracksClientConnection move this to the IStatementExecutorContext PS5, Line 62: getStatementExecutorContext move this out of this interface https://asterix-gerrit.ics.uci.edu/#/c/1867/5/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/ctx/RequestContext.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/ctx/RequestContext.java: PS5, Line 19: ctx move to asterix.app.translator -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 5: Contrib+1 Analytics Compatibility Tests Successful Build 2582 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 5: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3972/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 5: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1773/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 5: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1773/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1817/ (10/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 5: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 5: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3972/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1515/ (8/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/903/ (5/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6454/ (9/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1238/ (3/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/898/ (1/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4963/ (2/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1632/ (6/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1576/ (7/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1867 to look at the new patch set (#5). Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation - user model changes: no - storage format changes: no - interface changes: Introduce IRequestContexts to encapsulate request parameters and use it in IStatementExecutor#compileAndExecute and IExtensionStatement#handle. Details: - Introduce IRequestContext and its default implementation. - Add optional parameters supplier in QueryServiceServlet. Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/IExtensionStatement.java A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IRequestContext.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/ctx/RequestContext.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCQueryServiceServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java M asterixdb/asterix-external-data/pom.xml M asterixdb/asterix-metadata/pom.xml M hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java 15 files changed, 259 insertions(+), 88 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/67/1867/5 -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/903/ (4/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 4: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3971/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 4: Contrib-1 BAD Compatibility Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1770/ : FAILURE -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 4: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1770/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/899/ (8/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 4: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4962/ (2/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3971/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/899/ (6/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1572/ (9/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1813/ (10/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1511/ (5/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/894/ (7/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6450/ (1/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1867 to look at the new patch set (#4). Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation - user model changes: no - storage format changes: no - interface changes: Introduce IRequestContexts to encapsulate request parameters and use it in IStatementExecutor#compileAndExecute and IExtensionStatement#handle. Details: - Introduce IRequestContext and its default implementation. - Add optional parameters supplier in QueryServiceServlet. Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/IExtensionStatement.java A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IRequestContext.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/ctx/RequestContext.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCQueryServiceServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java M hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java 13 files changed, 257 insertions(+), 88 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/67/1867/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1234/ (3/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1628/ (4/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1812/ (10/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3970/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 3: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/893/ (9/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1571/ (8/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1627/ (5/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/898/ (6/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/898/ (7/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4961/ (4/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1510/ (2/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1233/ (3/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1867 to look at the new patch set (#3). Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation - user model changes: no - storage format changes: no - interface changes: Introduce IRequestContexts to encapsulate request parameters and use it in IStatementExecutor#compileAndExecute and IExtensionStatement#handle. Details: - Introduce IRequestContext and its default implementation. - Add optional parameters supplier in QueryServiceServlet. Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/IExtensionStatement.java A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IRequestContext.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/ctx/RequestContext.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCQueryServiceServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java M hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java 13 files changed, 256 insertions(+), 88 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/67/1867/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compi...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6449/ (1/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
