Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 3:

(1 comment)

too late ...

https://asterix-gerrit.ics.uci.edu/#/c/1934/1//COMMIT_MSG
Commit Message:

PS1, Line 7: shutdwon
s/shutdwon/shutdown/


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 1:

Will address your comments Mike with configurable subsequent change...

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 3:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1934/3//COMMIT_MSG
Commit Message:

PS3, Line 7: shutdwon
oops, don't forget to check format of commit messages...


https://asterix-gerrit.ics.uci.edu/#/c/1934/2/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCShutdownHook.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCShutdownHook.java:

PS2, Line 31: 10 * 60 * 1000L
not loving this- seems extremely long, also needs to be configurable


PS2, Line 44: try {
: shutdownHookThread.join(SHUTDOWN_WAIT_TIME); // 
10 min
: if (shutdownHookThread.isAlive()) {
: try {
: LOGGER.info("Watchdog is angry. Killing 
shutdown hook");
: } finally {
: Runtime.getRuntime().halt(66); // NOSONAR 
last resort
: }
: }
: } catch (Throwable th) { // NOSONAR must catch them 
all
: Runtime.getRuntime().halt(77); // NOSONAR last 
resort
: }
: };
Can we simplify this by just having a local boolean to control whether or not 
we halt, in a finally?  i.e. 
try {
  ...
  shutdownHookThread.join(SHUTDOWN_WAIT_TIME);
  sadface = shutdownHookThread.isAlive();
  if (sadface) {

  }
} finally {
  if (sadface) {

  }
}


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[abdullah alamoudi (Code Review)]

abdullah alamoudi has submitted this change and it was merged.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


[ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

- user model changes: Shutdown doesn't hang anymore
- storage format changes: no
- interface changes: no

details:
- A watchdog is added to the shutdown hook to ensure it completes
  within a pre-specified time window. If the window passes before
  shutdown completes, the JVM is killed.

Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1934
Integration-Tests: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Reviewed-by: Murtadha Hubail 
---
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/lifecycle/LifeCycleComponentManager.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCShutdownHook.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
M 
hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java
4 files changed, 60 insertions(+), 24 deletions(-)

Approvals:
  Murtadha Hubail: Looks good to me, approved
  Jenkins: Verified; ; Verified

Objections:
  Jenkins: Violations found



diff --git 
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/lifecycle/LifeCycleComponentManager.java
 
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/lifecycle/LifeCycleComponentManager.java
index 4674f9a..76fa322 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/lifecycle/LifeCycleComponentManager.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/lifecycle/LifeCycleComponentManager.java
@@ -51,11 +51,10 @@
 
 @Override
 public void uncaughtException(Thread t, Throwable e) {
-LOGGER.log(Level.SEVERE, "Uncaught Exception from thread " + 
t.getName(), e);
 try {
-stopAll(true);
-} catch (IOException e1) {
-LOGGER.log(Level.SEVERE, "Exception in stopping instance", e1);
+LOGGER.log(Level.SEVERE, "Uncaught Exception from thread " + 
t.getName() + ". Calling shutdown hook", e);
+} finally {
+Runtime.getRuntime().exit(99);// NOSONAR: It is really required
 }
 }
 
@@ -73,13 +72,14 @@
 
 @Override
 public synchronized void stopAll(boolean dumpState) throws IOException {
-if (LOGGER.isLoggable(Level.INFO)) {
-LOGGER.info("Attempting to stop " + this);
-}
 if (stopped) {
 LOGGER.info("Lifecycle management was already stopped");
 return;
 }
+stopped = true;
+if (LOGGER.isLoggable(Level.INFO)) {
+LOGGER.info("Attempting to stop " + this);
+}
 if (stopInitiated) {
 LOGGER.info("Stop already in progress");
 return;
diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCShutdownHook.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCShutdownHook.java
index a8b9461..4d0c159 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCShutdownHook.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCShutdownHook.java
@@ -23,21 +23,51 @@
 
 /**
  * Shutdown hook that invokes {@link NodeControllerService#stop() stop} method.
+ * This shutdown hook must have a failsafe mechanism to halt the process in 
case the shutdown
+ * operation is hanging for any reason
  */
 public class NCShutdownHook extends Thread {
 private static final Logger LOGGER = 
Logger.getLogger(NCShutdownHook.class.getName());
+private static final long SHUTDOWN_WAIT_TIME = 10 * 60 * 1000L;
+private final Thread watchDog;
 private final NodeControllerService nodeControllerService;
+private volatile Thread shutdownHookThread;
+
 public NCShutdownHook(NodeControllerService nodeControllerService) {
+super("ShutdownHook-" + nodeControllerService.getId());
 this.nodeControllerService = nodeControllerService;
+watchDog = new Thread(watch(), "ShutdownHookWatchDog-" + 
nodeControllerService.getId());
+}
+
+private Runnable watch() {
+return () -> {
+try {
+shutdownHookThread.join(SHUTDOWN_WAIT_TIME); // 10 min
+if (shutdownHookThread.isAlive()) {
+try {
+

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Murtadha Hubail (Code Review)]

Murtadha Hubail has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 2: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1618/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1618/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1280/
 (10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/593/
 (11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/937/ 
(9/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1503/ (9/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3677/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/936/ 
(11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1278/
 (9/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/590/
 (10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3677/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1215/ (1/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/602/ 
(3/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[abdullah alamoudi (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1934

to look at the new patch set (#2).

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..

[ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

- user model changes: Shutdown doesn't hang anymore
- storage format changes: no
- interface changes: no

details:
- A watchdog is added to the shutdown hook to ensure it completes
  within a pre-specified time window. If the window passes before
  shutdown completes, the JVM is killed.

Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
---
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/lifecycle/LifeCycleComponentManager.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCShutdownHook.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
M 
hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java
4 files changed, 60 insertions(+), 24 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/34/1934/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/418/
 (6/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6159/ (4/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1333/ 
(2/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4678/ (5/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 1: Contrib-1

Analytics Compatibility Tests Failed Build 2433
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 1: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1616/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1616/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/586/
 (11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1274/
 (11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1492/ (11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1325/ 
(11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3668/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/928/ 
(11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1323/ 
(11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/926/ 
(10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/409/
 (9/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/580/
 (8/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1268/
 (7/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/589/ (5/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1490/ (6/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3668/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6150/ (1/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1206/ (3/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/593/ 
(4/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4669/ (2/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

[abdullah alamoudi (Code Review)]

abdullah alamoudi has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1934

Change subject: [ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs
..

[ASTERIXDB-2031][HYR] Kill NC when shutdwon hangs

- user model changes: Shutdown doesn't hang anymore
- storage format changes: no
- interface changes: no

details:
- A watchdog is added to the shutdown hook to ensure it completes
  within a pre-specified time window. If the window passes before
  shutdown completes, the JVM is killed.

Change-Id: I9de911f81d6b3723e7cc3674bd80d56df8203c0a
---
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/lifecycle/LifeCycleComponentManager.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCShutdownHook.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
M 
hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java
4 files changed, 60 insertions(+), 24 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/34/1934/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/lifecycle/LifeCycleComponentManager.java
 
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/lifecycle/LifeCycleComponentManager.java
index 4674f9a..76fa322 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/lifecycle/LifeCycleComponentManager.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/lifecycle/LifeCycleComponentManager.java
@@ -51,11 +51,10 @@
 
 @Override
 public void uncaughtException(Thread t, Throwable e) {
-LOGGER.log(Level.SEVERE, "Uncaught Exception from thread " + 
t.getName(), e);
 try {
-stopAll(true);
-} catch (IOException e1) {
-LOGGER.log(Level.SEVERE, "Exception in stopping instance", e1);
+LOGGER.log(Level.SEVERE, "Uncaught Exception from thread " + 
t.getName() + ". Calling shutdown hook", e);
+} finally {
+Runtime.getRuntime().exit(99);// NOSONAR: It is really required
 }
 }
 
@@ -73,13 +72,14 @@
 
 @Override
 public synchronized void stopAll(boolean dumpState) throws IOException {
-if (LOGGER.isLoggable(Level.INFO)) {
-LOGGER.info("Attempting to stop " + this);
-}
 if (stopped) {
 LOGGER.info("Lifecycle management was already stopped");
 return;
 }
+stopped = true;
+if (LOGGER.isLoggable(Level.INFO)) {
+LOGGER.info("Attempting to stop " + this);
+}
 if (stopInitiated) {
 LOGGER.info("Stop already in progress");
 return;
diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCShutdownHook.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCShutdownHook.java
index a8b9461..4d0c159 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCShutdownHook.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCShutdownHook.java
@@ -23,21 +23,51 @@
 
 /**
  * Shutdown hook that invokes {@link NodeControllerService#stop() stop} method.
+ * This shutdown hook must have a failsafe mechanism to halt the process in 
case the shutdown
+ * operation is hanging for any reason
  */
 public class NCShutdownHook extends Thread {
 private static final Logger LOGGER = 
Logger.getLogger(NCShutdownHook.class.getName());
+private static final long SHUTDOWN_WAIT_TIME = 10 * 60 * 1000L;
+private final Thread watchDog;
 private final NodeControllerService nodeControllerService;
+private volatile Thread shutdownHookThread;
+
 public NCShutdownHook(NodeControllerService nodeControllerService) {
+super("ShutdownHook-" + nodeControllerService.getId());
 this.nodeControllerService = nodeControllerService;
+watchDog = new Thread(watch(), "ShutdownHookWatchDog-" + 
nodeControllerService.getId());
+}
+
+private Runnable watch() {
+return () -> {
+try {
+shutdownHookThread.join(SHUTDOWN_WAIT_TIME); // 10 min
+if (shutdownHookThread.isAlive()) {
+try {
+LOGGER.info("Watchdog is angry. Killing shutdown 
hook");
+} finally {
+Runtime.getRuntime().halt(66); // NOSONAR last resort
+}
+}
+} catch (Throwable th) { // NOSONAR must