Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Yingyi Bu has submitted this change and it was merged. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by - user model changes: no - storage format changes: no - interface changes: no Details: - Fix EliminateSubplanWithInputCardinalityOneRule to handle recursive subplans; - Fix various places that assumes the nested plans inside a group-by operator cannot be empty; - Added regression tests. Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Reviewed-on: https://asterix-gerrit.ics.uci.edu/1946 Integration-Tests: Jenkins Tested-by: Jenkins Contrib: Jenkins Reviewed-by: Yingyi Bu --- A asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810-2.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810-2.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1308-1.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/PreclusteredGroupByPOperator.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/typing/AbstractTypeEnvironment.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/AbstractIntroduceGroupByCombinerRule.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/PushNestedOrderByUnderPreSortedGroupByRule.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/subplan/EliminateSubplanWithInputCardinalityOneRule.java 10 files changed, 277 insertions(+), 46 deletions(-) Approvals: Yingyi Bu: Looks good to me, approved Anon. E. Moose #1000171: Jenkins: Verified; ; Verified Objections: Jenkins: Violations found diff --git a/asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810-2.sqlpp b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810-2.sqlpp new file mode 100644 index 000..b6f6159 --- /dev/null +++ b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810-2.sqlpp @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +/* + * Description : This test case is to verify the fix for issue810 + * https://code.google.com/p/asterixdb/issues/detail?id=810 + * Expected Res : SUCCESS + * Date : 16th Nov. 2014 + */ + +DROP DATAVERSE tpch IF EXISTS; +CREATE dataverse tpch; + +USE tpch; + + +CREATE TYPE LineItemType AS CLOSED { + l_orderkey : integer, + l_partkey : integer, + l_suppkey : integer, + l_linenumber : integer, + l_quantity : double, + l_extendedprice : double, + l_discount : double, + l_tax : double, + l_returnflag : string, + l_linestatus : string, + l_shipdate : string, + l_commitdate : string, + l_receiptdate : string, + l_shipinstruct : string, + l_shipmode : string, + l_comment : string +} + +CREATE DATASET LineItem(LineItemType) PRIMARY KEY l_orderkey,l_linenumber; + + +SELECT l_returnflag AS l_returnflag, + l_linestatus AS l_linestatus, + coll_count(cheap) AS count_cheaps, + coll_count(expensive) AS count_expensives +FROM LineItem AS l +/* +hash */ +GROUP BY l.l_returnflag AS l_returnflag,l.l_linestatus AS l_linestatus +GROUP AS g +LET cheap = ( + SELECT ELEMENT g.l + FROM g + WHERE g.l.l_discount > 0.05 +), +expensive = ( + SELECT ELEMENT g.l + FROM g + WHERE g.l.l_discount <= 0.05 +) +ORDER BY l_returnflag,l_linestatus +; diff --git a/asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810.sqlpp b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810.sqlpp new file mode 100644 index 000..451f163 --- /dev/null +++ b/asterixdb/asterix-app/src/t
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Yingyi Bu has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 5: Code-Review+2 Fwd Dmitry's +2. -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 5: Contrib+1 Analytics Compatibility Tests Successful Build 2466 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 5: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1657/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 5: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1657/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/683/ (11/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 5: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3764/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 5: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3764/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 5: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1363/ (9/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/499/ (5/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1297/ (8/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6238/ (11/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/678/ (1/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4757/ (2/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/682/ (3/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1019/ (6/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1421/ (10/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/682/ (7/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Hello Jenkins, Dmitry Lychagin, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1946 to look at the new patch set (#5). Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by - user model changes: no - storage format changes: no - interface changes: no Details: - Fix EliminateSubplanWithInputCardinalityOneRule to handle recursive subplans; - Fix various places that assumes the nested plans inside a group-by operator cannot be empty; - Added regression tests. Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 --- A asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810-2.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810-2.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1308-1.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/PreclusteredGroupByPOperator.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/typing/AbstractTypeEnvironment.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/AbstractIntroduceGroupByCombinerRule.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/PushNestedOrderByUnderPreSortedGroupByRule.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/subplan/EliminateSubplanWithInputCardinalityOneRule.java 10 files changed, 277 insertions(+), 46 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/46/1946/5 -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1599/ (4/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3763/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 4: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4756/ (2/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1598/ (3/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1420/ (10/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/681/ (7/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6237/ (1/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/498/ (6/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1362/ (8/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/681/ (4/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1018/ (5/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/677/ (9/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Hello Jenkins, Dmitry Lychagin, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1946 to look at the new patch set (#4). Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by - user model changes: no - storage format changes: no - interface changes: no Details: - Fix EliminateSubplanWithInputCardinalityOneRule to handle recursive subplans; - Fix various places that assumes the nested plans inside a group-by operator cannot be empty; - Added regression tests. Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 --- A asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810-2.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810-3.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810-2.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810-3.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1308-1.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/PreclusteredGroupByPOperator.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/typing/AbstractTypeEnvironment.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/AbstractIntroduceGroupByCombinerRule.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/PushNestedOrderByUnderPreSortedGroupByRule.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/subplan/EliminateSubplanWithInputCardinalityOneRule.java 12 files changed, 387 insertions(+), 46 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/46/1946/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1296/ (11/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 3: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 3: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3756/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 3: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1653/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 3: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1653/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3756/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1415/ (11/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 3: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4751/ (10/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/493/ (4/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1357/ (3/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/672/ (7/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1593/ (9/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1291/ (8/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1013/ (2/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/676/ (5/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6232/ (6/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1946 to look at the new patch set (#3). Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 --- A asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810-2.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810-2.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1308-1.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/PreclusteredGroupByPOperator.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/typing/AbstractTypeEnvironment.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/AbstractIntroduceGroupByCombinerRule.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/PushNestedOrderByUnderPreSortedGroupByRule.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/subplan/EliminateSubplanWithInputCardinalityOneRule.java 10 files changed, 277 insertions(+), 46 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/46/1946/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/676/ (1/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1592/ (10/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 2: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/671/ (8/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/675/ (6/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1290/ (1/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1012/ (3/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1356/ (9/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1946 to look at the new patch set (#2). Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 --- A asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1308-1.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/PreclusteredGroupByPOperator.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/typing/AbstractTypeEnvironment.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/AbstractIntroduceGroupByCombinerRule.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/PushNestedOrderByUnderPreSortedGroupByRule.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/subplan/EliminateSubplanWithInputCardinalityOneRule.java 8 files changed, 167 insertions(+), 46 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/46/1946/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/675/ (4/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6231/ (7/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4750/ (2/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/492/ (5/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1946 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No