Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Dmitry Lychagin has submitted this change and it was merged.
Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with
multiple predicates
..
[ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Broadcast hint now works if join condition has multiple predicates.
Only one predicate needs to be annotated.
Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2024
Sonar-Qube: Jenkins
Tested-by: Jenkins
Contrib: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Xikui Wang
Reviewed-by: Till Westmann
---
M
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/optimizer/OptimizerTest.java
A
asterixdb/asterix-app/src/test/resources/optimizerts/queries/hints/broadcast_hint_1.sqlpp
A
asterixdb/asterix-app/src/test/resources/optimizerts/queries/hints/broadcast_hint_2.sqlpp
A
asterixdb/asterix-app/src/test/resources/optimizerts/queries/hints/broadcast_hint_3.sqlpp
A
asterixdb/asterix-app/src/test/resources/optimizerts/results/hints/broadcast_hint_1.plan
A
asterixdb/asterix-app/src/test/resources/optimizerts/results/hints/broadcast_hint_2.plan
A
asterixdb/asterix-app/src/test/resources/optimizerts/results/hints/broadcast_hint_3.plan
M
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java
8 files changed, 250 insertions(+), 26 deletions(-)
Approvals:
Till Westmann: Looks good to me, approved
Jenkins: Verified; No violations found; ; Verified
Xikui Wang: Looks good to me, but someone else must approve
Objections:
Anon. E. Moose #1000171:
diff --git
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/optimizer/OptimizerTest.java
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/optimizer/OptimizerTest.java
index 409bbdc..d1c3ce4 100644
---
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/optimizer/OptimizerTest.java
+++
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/optimizer/OptimizerTest.java
@@ -172,6 +172,8 @@
LOGGER.info("RUN TEST: \"" + queryFile.getPath() + "\"");
Reader query = new BufferedReader(new InputStreamReader(new
FileInputStream(queryFile), "UTF-8"));
+LOGGER.info("ACTUAL RESULT FILE: " + actualFile.getAbsolutePath());
+
// Forces the creation of actualFile.
actualFile.getParentFile().mkdirs();
diff --git
a/asterixdb/asterix-app/src/test/resources/optimizerts/queries/hints/broadcast_hint_1.sqlpp
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/hints/broadcast_hint_1.sqlpp
new file mode 100644
index 000..02ba35d
--- /dev/null
+++
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/hints/broadcast_hint_1.sqlpp
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/*
+* Description : Test broadcast join hint.
+*Hint on one conjunct
+* Expected Res : Success
+* Date : 09/22/2017
+*/
+
+drop dataverse test if exists;
+create dataverse test;
+
+use test;
+
+create type TT as closed {
+ c_key : integer,
+ c_1 : integer,
+ c_2 : integer,
+ c_3 : integer,
+ c_4 : integer
+};
+
+create dataset t1(TT) primary key c_key;
+
+create dataset t2(TT) primary key c_key;
+
+select t1.c_4 as c0, t2.c_4 as c1
+from t1 join t2
+on t1.c_1 = t2.c_1 and t1.c_2 /*+ bcast */ = t2.c_2 and t1.c_3 = t2.c_3
+;
\ No newline at end of file
diff --git
a/asterixdb/asterix-app/src/test/resources/optimizerts/queries/hints/broadcast_hint_2.sqlpp
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/hints/broadcast_hint_2.sqlpp
new file mode 100644
index 000..1feb21f
--- /dev/null
+++
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/hints/broadcast_hint_2.sqlpp
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Xikui Wang has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 2: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4010/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 2: Contrib-1 Analytics Compatibility Tests Failed Build 2604 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 2: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1797/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1797/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 2: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4010/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/938/ (1/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/944/ (2/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/943/ (7/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1674/ (5/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2024 to look at the new patch set (#2). Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates - user model changes: no - storage format changes: no - interface changes: no Details: - Broadcast hint now works if join condition has multiple predicates. Only one predicate needs to be annotated. Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 --- M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/optimizer/OptimizerTest.java A asterixdb/asterix-app/src/test/resources/optimizerts/queries/hints/broadcast_hint_1.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/queries/hints/broadcast_hint_2.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/queries/hints/broadcast_hint_3.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/results/hints/broadcast_hint_1.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/hints/broadcast_hint_2.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/hints/broadcast_hint_3.plan M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java 8 files changed, 250 insertions(+), 26 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/24/2024/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1556/ (10/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1856/ (6/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6494/ (9/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5000/ (4/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1618/ (8/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1278/ (3/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 1: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4009/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1673/ (4/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4999/ (2/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1855/ (1/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1277/ (3/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6493/ (10/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/942/ (5/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/937/ (9/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1617/ (6/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Dmitry Lychagin has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2024
Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with
multiple predicates
..
[ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Broadcast hint now works if join condition has multiple predicates.
Only one predicate needs to be annotated.
Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514
---
M
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/optimizer/OptimizerTest.java
A
asterixdb/asterix-app/src/test/resources/optimizerts/queries/hints/broadcast_hint_1.sqlpp
A
asterixdb/asterix-app/src/test/resources/optimizerts/queries/hints/broadcast_hint_2.sqlpp
A
asterixdb/asterix-app/src/test/resources/optimizerts/queries/hints/broadcast_hint_3.sqlpp
A
asterixdb/asterix-app/src/test/resources/optimizerts/results/hints/broadcast_hint_1.plan
A
asterixdb/asterix-app/src/test/resources/optimizerts/results/hints/broadcast_hint_2.plan
A
asterixdb/asterix-app/src/test/resources/optimizerts/results/hints/broadcast_hint_3.plan
M
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java
8 files changed, 250 insertions(+), 25 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/24/2024/1
diff --git
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/optimizer/OptimizerTest.java
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/optimizer/OptimizerTest.java
index 409bbdc..d1c3ce4 100644
---
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/optimizer/OptimizerTest.java
+++
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/optimizer/OptimizerTest.java
@@ -172,6 +172,8 @@
LOGGER.info("RUN TEST: \"" + queryFile.getPath() + "\"");
Reader query = new BufferedReader(new InputStreamReader(new
FileInputStream(queryFile), "UTF-8"));
+LOGGER.info("ACTUAL RESULT FILE: " + actualFile.getAbsolutePath());
+
// Forces the creation of actualFile.
actualFile.getParentFile().mkdirs();
diff --git
a/asterixdb/asterix-app/src/test/resources/optimizerts/queries/hints/broadcast_hint_1.sqlpp
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/hints/broadcast_hint_1.sqlpp
new file mode 100644
index 000..02ba35d
--- /dev/null
+++
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/hints/broadcast_hint_1.sqlpp
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/*
+* Description : Test broadcast join hint.
+*Hint on one conjunct
+* Expected Res : Success
+* Date : 09/22/2017
+*/
+
+drop dataverse test if exists;
+create dataverse test;
+
+use test;
+
+create type TT as closed {
+ c_key : integer,
+ c_1 : integer,
+ c_2 : integer,
+ c_3 : integer,
+ c_4 : integer
+};
+
+create dataset t1(TT) primary key c_key;
+
+create dataset t2(TT) primary key c_key;
+
+select t1.c_4 as c0, t2.c_4 as c1
+from t1 join t2
+on t1.c_1 = t2.c_1 and t1.c_2 /*+ bcast */ = t2.c_2 and t1.c_3 = t2.c_3
+;
\ No newline at end of file
diff --git
a/asterixdb/asterix-app/src/test/resources/optimizerts/queries/hints/broadcast_hint_2.sqlpp
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/hints/broadcast_hint_2.sqlpp
new file mode 100644
index 000..1feb21f
--- /dev/null
+++
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/hints/broadcast_hint_2.sqlpp
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applica
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1555/ (8/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2105][COMP] Support broadcast join hint with mult...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2105][COMP] Support broadcast join hint with multiple predicates .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/943/ (7/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1475c5e574be2632c92ae619f3a36c56c222514 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
