Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Ali Alsuliman has submitted this change and it was merged. (
https://asterix-gerrit.ics.uci.edu/3399 )
Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE
..
[ASTERIXDB-2289][COMP] Fix field access with CASE
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
This patch fixes field access in the presense CASE and JOIN.
This is a scenario where push-down-field-access rule throws an
exception if the field access has potentially two sources and
it could not push down the field access to left or right branch.
Don't throw an exception and just return false
(i.e. field access was not pushed) instead of throwing an exception.
Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3399
Contrib: Jenkins
Tested-by: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Dmitry Lychagin
---
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access-ASTERIXDB-2289/field_access-ASTERIXDB-2289.1.ddl.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access-ASTERIXDB-2289/field_access-ASTERIXDB-2289.2.update.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access-ASTERIXDB-2289/field_access-ASTERIXDB-2289.3.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access-ASTERIXDB-2289/field_access-ASTERIXDB-2289.4.ddl.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/results/misc/field_access-ASTERIXDB-2289/field_access-ASTERIXDB-2289.3.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/util/OperatorPropertiesUtil.java
8 files changed, 162 insertions(+), 24 deletions(-)
Approvals:
Jenkins: Verified; ; Verified
Dmitry Lychagin: Looks good to me, approved
Objections:
Jenkins: Violations found
Anon. E. Moose (1000171): Violations found
diff --git
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
index 421b00d..c82aa33 100644
---
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
+++
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
@@ -84,6 +84,9 @@
if (op.getOperatorTag() != LogicalOperatorTag.ASSIGN) {
return false;
}
+if (!OperatorPropertiesUtil.isMovable(op)) {
+return false;
+}
AssignOperator access = (AssignOperator) op;
ILogicalExpression expr = getFirstExpr(access);
String finalAnnot;
@@ -196,17 +199,17 @@
pushDownFieldAccessRec(opRef2, context, finalAnnot);
return true;
}
-List usedInAccess = new LinkedList<>();
+HashSet usedInAccess = new HashSet<>();
VariableUtilities.getUsedVariables(assignOp, usedInAccess);
-List produced2 = new LinkedList<>();
+HashSet produced2 = new HashSet<>();
if (inputOp.getOperatorTag() == LogicalOperatorTag.GROUP) {
VariableUtilities.getLiveVariables(inputOp, produced2);
} else {
VariableUtilities.getProducedVariables(inputOp, produced2);
}
boolean pushItDown = false;
-List inter = new ArrayList<>(usedInAccess);
+HashSet inter = new HashSet<>(usedInAccess);
if (inter.isEmpty()) { // ground value
return false;
}
@@ -234,8 +237,7 @@
LogicalVariable oldVar = assignOp.getVariables().get(0);
VariableReferenceExpression v2Ref = new
VariableReferenceExpression(v2);
v2Ref.setSourceLocation(g.getSourceLocation());
-g.getDecorList().add(new Pair>(oldVar,
-new MutableObject(v2Ref)));
+g.getDecorList().add(new Pair<>(oldVar, new
MutableObject<>(v2Ref)));
changed = true;
assignOp.getVariables().set(0, v2);
VariableUtilities.substituteVariables(assignOp, m.first,
m.second, context);
@@ -281,8 +283,7 @@
}
}
}
-throw new CompilationException(ErrorCode.COMPILATION_ERROR,
assignOp.getSourceLocation(),
-"Field access " +
assignOp.getExpressions().get(0).getValue() + " doesn't correspond to any
input");
+return false;
} else {
// check if the accessed field is one of the partitioning key
fields. If yes, we can equate the 2
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 4: Code-Review+2 (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3399/4/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java: https://asterix-gerrit.ics.uci.edu/#/c/3399/4/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java@202 PS4, Line 202: HashSet usedInAccess = new HashSet<>(); minor. use interface in variable declaration (Set usedInAccess = new HashSet<>()) here and below -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 16 May 2019 23:12:04 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 4: Analytics Compatibility Tests Failed https://cbjenkins.page.link/bKAE6bWRcxbcz62KA : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 16 May 2019 22:18:11 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 4: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8576/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 16 May 2019 20:27:33 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 4: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/hueHeyQVEeJHnMa96 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 16 May 2019 20:09:58 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8576/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 16 May 2019 19:14:28 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 4: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4427/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 16 May 2019 19:04:28 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1074/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 16 May 2019 18:53:38 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1165/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 16 May 2019 19:01:01 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5797/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 16 May 2019 18:49:59 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 4: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4427/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 16 May 2019 18:50:18 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6020/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 16 May 2019 18:57:37 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3809/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 16 May 2019 18:57:48 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6380/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 16 May 2019 18:56:31 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9756/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 16 May 2019 18:53:35 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5815/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 16 May 2019 18:42:52 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/579/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 16 May 2019 18:44:24 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6170/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 16 May 2019 18:51:26 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 4: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/CjENh7ULebmwUb5JA : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 16 May 2019 18:47:01 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/976/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 16 May 2019 18:44:10 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 4: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 16 May 2019 18:44:10 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5965/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 16 May 2019 18:44:25 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5777/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 16 May 2019 18:42:52 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/738/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 16 May 2019 18:42:52 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Hello Anon. E. Moose (1000171), Till Westmann, Jenkins, Michael Blow, Dmitry Lychagin, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3399 to look at the new patch set (#4). Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. [ASTERIXDB-2289][COMP] Fix field access with CASE - user model changes: no - storage format changes: no - interface changes: no Details: This patch fixes field access in the presense CASE and JOIN. This is a scenario where push-down-field-access rule throws an exception if the field access has potentially two sources and it could not push down the field access to left or right branch. Don't throw an exception and just return false (i.e. field access was not pushed) instead of throwing an exception. Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access-ASTERIXDB-2289/field_access-ASTERIXDB-2289.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access-ASTERIXDB-2289/field_access-ASTERIXDB-2289.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access-ASTERIXDB-2289/field_access-ASTERIXDB-2289.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access-ASTERIXDB-2289/field_access-ASTERIXDB-2289.4.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/field_access-ASTERIXDB-2289/field_access-ASTERIXDB-2289.3.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/util/OperatorPropertiesUtil.java 8 files changed, 162 insertions(+), 24 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/99/3399/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5714/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 16 May 2019 18:42:52 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11289/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 16 May 2019 18:42:52 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 3: Contrib+1 Analytics Compatibility Tests Successful https://cbjenkins.page.link/eXLj4ckr7xideTKy9 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 11:06:30 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 3: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8569/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 10:39:39 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 3: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4419/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:44:04 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5768/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:19:47 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5807/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:24:13 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6012/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:24:22 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4418/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:22:50 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1158/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:31:58 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6371/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:20:01 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 3: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/ao4iy6YVMBaznzdk8 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:27:49 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 3: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4419/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:27:28 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/968/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:24:31 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5958/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:24:37 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6162/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:24:28 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1066/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:24:30 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3801/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:24:34 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8569/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:25:36 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5789/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:24:19 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9748/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:24:26 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6372/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:24:24 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11281/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:24:13 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/730/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:24:13 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5769/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:24:13 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/571/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:24:12 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5706/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:24:12 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Hello Anon. E. Moose (1000171), Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3399 to look at the new patch set (#3). Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. [ASTERIXDB-2289][COMP] Fix field access with CASE - user model changes: no - storage format changes: no - interface changes: no Details: This patch fixes field access in the presense CASE and JOIN. This is a scenario where push-down-field-access rule throws an exception if the field access has potentially two sources and it could not push down the field access to left or right branch. The exception thinks that the field access has no source when in reality it has but there were two potential sources because of CASE. Don't throw an exception if the field access is a valid one and return false (i.e. field access was not push) instead of throwing an exception. Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access-ASTERIXDB-2289/field_access-ASTERIXDB-2289.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access-ASTERIXDB-2289/field_access-ASTERIXDB-2289.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access-ASTERIXDB-2289/field_access-ASTERIXDB-2289.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/field_access-ASTERIXDB-2289/field_access-ASTERIXDB-2289.3.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml 6 files changed, 143 insertions(+), 3 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/99/3399/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1157/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:24:08 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 2: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/nW4JgtzCz2htddfn9 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:23:31 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8568/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:21:03 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3800/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:19:54 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6011/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:19:55 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6161/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:19:57 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/967/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:19:51 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9747/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:19:59 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/729/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:19:46 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1065/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:20:02 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/570/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:19:46 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5957/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:19:46 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5806/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:19:47 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5705/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:19:47 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11280/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:19:47 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 ) Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5788/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 16 May 2019 09:19:46 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2289][COMP] Fix field access with CASE
Hello Anon. E. Moose (1000171), Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3399 to look at the new patch set (#2). Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE .. [ASTERIXDB-2289][COMP] Fix field access with CASE - user model changes: no - storage format changes: no - interface changes: no Details: This patch fixes field access in the presense CASE and JOIN. This is a scenario where push-down-field-access rule throws an exception if the field access has potentially two sources and it could not push down the field access to left or right branch. The exception thinks that the field access has no source when in reality it has but there were two potential sources because of CASE. Don't throw an exception if the field access is a valid one and return false (i.e. field access was not push) instead of throwing an exception. Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access-ASTERIXDB-2289/field_access-ASTERIXDB-2289.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access-ASTERIXDB-2289/field_access-ASTERIXDB-2289.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access-ASTERIXDB-2289/field_access-ASTERIXDB-2289.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/field_access-ASTERIXDB-2289/field_access-ASTERIXDB-2289.3.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml 6 files changed, 143 insertions(+), 3 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/99/3399/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins
