Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Dmitry Lychagin has submitted this change and it was merged. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. [ASTERIXDB-2294][FUN] Implement is_atomic() - user model changes: yes - storage format changes: no - interface changes: no Details: - Implement is_atomic() function with aliases isatomic(), isatom() - Add testcases and documentation Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Reviewed-on: https://asterix-gerrit.ics.uci.edu/2416 Sonar-Qube: Jenkins Integration-Tests: Jenkins Tested-by: Jenkins Contrib: Jenkins Reviewed-by: Till Westmann --- A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/isatomic/isatomic.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/types/isatomic/isatomic.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md M asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/CommonFunctionMapUtil.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/IsAtomicDescriptor.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionCollection.java 8 files changed, 142 insertions(+), 0 deletions(-) Approvals: Till Westmann: Looks good to me, approved Jenkins: Verified; No violations found; ; Verified Objections: Anon. E. Moose #1000171: Violations found diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/isatomic/isatomic.1.query.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/isatomic/isatomic.1.query.sqlpp new file mode 100644 index 000..4339904 --- /dev/null +++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/isatomic/isatomic.1.query.sqlpp @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +{ + "a": isatomic(true), + "b": isatomic(false), + "c": is_atomic(null), + "d": is_atomic(missing), + "e": isatom("d"), + "f": isatom(4.0), + "g": isatom(5), + "h": isatom(["1", 2]), + "i": isatom({"a":1}) +}; diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/results/types/isatomic/isatomic.1.adm b/asterixdb/asterix-app/src/test/resources/runtimets/results/types/isatomic/isatomic.1.adm new file mode 100644 index 000..b6cd2d0 --- /dev/null +++ b/asterixdb/asterix-app/src/test/resources/runtimets/results/types/isatomic/isatomic.1.adm @@ -0,0 +1 @@ +{ "a": true, "b": true, "c": null, "e": true, "f": true, "g": true, "h": false, "i": false } diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml index 3a2c24c..a869b22 100644 --- a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml +++ b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml @@ -8987,6 +8987,11 @@ + +isatomic + + + isboolean diff --git a/asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md b/asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md index a2b2555..fd6a262 100644 --- a/asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md +++ b/asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md @@ -53,6 +53,38 @@ The function has an alias `isarray`. +### is_atomic (isatomic, isatom) ### + * Syntax: + +is_atomic(expr) + + * Checks whether the given expression is evaluated to be a value of a [primitive](../datamodel.html#PrimitiveTypes) type. + * Arguments: +* `expr` : an expression (any type is allowed). + * Return Value: +* a `boolean` on whether the argument is a primitive type or not, +* a `missing` if the argument is a `missing` value, +* a `null` if the argument is a `null` value. + + * Example: + +{ + "a": is_atomic(true), + "b": is_atomic(false), + "c": isatomic(null), + "d": isatomic(missi
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 2: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2761/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2761/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2820/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 2: Analytics Compatibility Tests Failed https://goo.gl/eEGJUb : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2816/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5731/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3314/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3290/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3551/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 2: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/FVfJf9 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5731/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2812/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/WQpacU : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6770/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2416 to look at the new patch set (#2). Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. [ASTERIXDB-2294][FUN] Implement is_atomic() - user model changes: yes - storage format changes: no - interface changes: no Details: - Implement is_atomic() function with aliases isatomic(), isatom() - Add testcases and documentation Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 --- A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/isatomic/isatomic.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/types/isatomic/isatomic.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md M asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/CommonFunctionMapUtil.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/IsAtomicDescriptor.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionCollection.java 8 files changed, 142 insertions(+), 0 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/16/2416/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8277/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2804/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3037/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2731/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2778/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3351/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/827/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 1: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2416/1/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/isatomic/isatomic.1.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/isatomic/isatomic.1.query.sqlpp: PS1, Line 26: isatom4 missing parenthesis https://asterix-gerrit.ics.uci.edu/#/c/2416/1/asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md File asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md: PS1, Line 61: WS -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 1: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5724/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/ZT4uBT : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3307/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/MPi9kr : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5724/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3028/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3544/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2722/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6761/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2769/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Dmitry Lychagin has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/2416 Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. [ASTERIXDB-2294][FUN] Implement is_atomic() - user model changes: yes - storage format changes: no - interface changes: no Details: - Implement is_atomic() function with aliases isatomic(), isatom() - Add testcases and documentation Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 --- A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/isatomic/isatomic.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/types/isatomic/isatomic.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md M asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/CommonFunctionMapUtil.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/IsAtomicDescriptor.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionCollection.java 8 files changed, 142 insertions(+), 0 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/16/2416/1 diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/isatomic/isatomic.1.query.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/isatomic/isatomic.1.query.sqlpp new file mode 100644 index 000..d8b2389 --- /dev/null +++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/isatomic/isatomic.1.query.sqlpp @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +{ + "a": isatomic(true), + "b": isatomic(false), + "c": is_atomic(null), + "d": is_atomic(missing), + "e": isatom("d"), + "f": isatom4.0), + "g": isatom(5), + "h": isatom(["1", 2]), + "i": isatom({"a":1}) +}; diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/results/types/isatomic/isatomic.1.adm b/asterixdb/asterix-app/src/test/resources/runtimets/results/types/isatomic/isatomic.1.adm new file mode 100644 index 000..b6cd2d0 --- /dev/null +++ b/asterixdb/asterix-app/src/test/resources/runtimets/results/types/isatomic/isatomic.1.adm @@ -0,0 +1 @@ +{ "a": true, "b": true, "c": null, "e": true, "f": true, "g": true, "h": false, "i": false } diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml index 909b523..541cd1b 100644 --- a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml +++ b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml @@ -9013,6 +9013,11 @@ + +isatomic + + + isboolean diff --git a/asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md b/asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md index a2b2555..ba3a735 100644 --- a/asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md +++ b/asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md @@ -53,6 +53,38 @@ The function has an alias `isarray`. +### is_atomic (isatomic, isatom) ### + * Syntax: + +is_atomic(expr) + + * Checks whether the given expression is evaluated to be a value of a [primitive](../datamodel.html#PrimitiveTypes) type. + * Arguments: +* `expr` : an expression (any type is allowed). + * Return Value: +* a `boolean` on whether the argument is a primitive type or not, +* a `missing` if the argument is a `missing` value, +* a `null` if the argument is a `null` value. + + * Example: + +{ + "a": is_atomic(true), + "b": is_atomic(false), + "c": isatomic(null), + "d": isatomic(missing), + "e": isatomic("d"), + "f": isatom(4.0), + "g": isatom(5), + "h": isatom(["1", 2]), + "i": isatom({"a":1}) +}; + +* The expected result is: + +{ "a"
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3342/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2795/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3283/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2803/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/818/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8268/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No