Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Ali Alsuliman has submitted this change and it was merged. (
https://asterix-gerrit.ics.uci.edu/3391 )
Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
..
[ASTERIXDB-2564][RT] Too many objects created in min() and max()
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
During min() and max() aggregation, the functions keep track of
the aggregation type in order to handle heterogeneous lists.
It promotes the aggregation type if needed (e.g. encountered double).
Don't switch to new aggregation type and create a new comparator
when the new input value type is the same as the previously
aggregated values. That is because canPromote(agg_type, new_val_type)
will always return true for same types.
Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3391
Contrib: Jenkins
Sonar-Qube: Jenkins
Tested-by: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Dmitry Lychagin
---
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractMinMaxAggregateFunction.java
1 file changed, 43 insertions(+), 60 deletions(-)
Approvals:
Jenkins: Verified; No violations found; ; Verified
Anon. E. Moose (1000171):
Dmitry Lychagin: Looks good to me, approved
diff --git
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractMinMaxAggregateFunction.java
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractMinMaxAggregateFunction.java
index 86ae924..90f006d 100644
---
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractMinMaxAggregateFunction.java
+++
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractMinMaxAggregateFunction.java
@@ -30,7 +30,6 @@
import org.apache.hyracks.algebricks.runtime.base.IScalarEvaluatorFactory;
import org.apache.hyracks.api.context.IHyracksTaskContext;
import org.apache.hyracks.api.dataflow.value.IBinaryComparator;
-import org.apache.hyracks.api.dataflow.value.IBinaryComparatorFactory;
import org.apache.hyracks.api.exceptions.HyracksDataException;
import org.apache.hyracks.api.exceptions.SourceLocation;
import org.apache.hyracks.data.std.api.IPointable;
@@ -39,18 +38,16 @@
import org.apache.hyracks.dataflow.common.data.accessors.IFrameTupleReference;
public abstract class AbstractMinMaxAggregateFunction extends
AbstractAggregateFunction {
-private IPointable inputVal = new VoidPointable();
-private ArrayBackedValueStorage outputVal = new ArrayBackedValueStorage();
-private ArrayBackedValueStorage tempValForCasting = new
ArrayBackedValueStorage();
-
-protected ArrayBackedValueStorage resultStorage = new
ArrayBackedValueStorage();
-private IScalarEvaluator eval;
+protected final ArrayBackedValueStorage resultStorage = new
ArrayBackedValueStorage();
+private final IPointable inputVal = new VoidPointable();
+private final ArrayBackedValueStorage outputVal = new
ArrayBackedValueStorage();
+private final ArrayBackedValueStorage tempValForCasting = new
ArrayBackedValueStorage();
+private final IScalarEvaluator eval;
+private final boolean isMin;
protected ATypeTag aggType;
private IBinaryComparator cmp;
-private ITypeConvertComputer tpc;
-private final boolean isMin;
-public AbstractMinMaxAggregateFunction(IScalarEvaluatorFactory[] args,
IHyracksTaskContext context, boolean isMin,
+AbstractMinMaxAggregateFunction(IScalarEvaluatorFactory[] args,
IHyracksTaskContext context, boolean isMin,
SourceLocation sourceLoc) throws HyracksDataException {
super(sourceLoc);
eval = args[0].createScalarEvaluator(context);
@@ -82,9 +79,8 @@
// First value encountered. Set type, comparator, and initial
value.
aggType = typeTag;
// Set comparator.
-IBinaryComparatorFactory cmpFactory =
-
BinaryComparatorFactoryProvider.INSTANCE.getBinaryComparatorFactory(aggType,
isMin);
-cmp = cmpFactory.createBinaryComparator();
+cmp =
BinaryComparatorFactoryProvider.INSTANCE.getBinaryComparatorFactory(aggType,
isMin)
+.createBinaryComparator();
// Initialize min value.
outputVal.assign(inputVal);
} else if (typeTag != ATypeTag.SYSTEM_NULL &&
!ATypeHierarchy.isCompatible(typeTag, aggType)) {
@@ -94,56 +90,27 @@
throw new IncompatibleTypeException(sourceLoc, "min/max",
aggType.serialize(), typeTag.serialize());
}
} else {
-
// If a system_null is encountered locally, it would be an error;
otherwise if it is seen
// by a global aggregator, it is simple ignored.
if (typeTag == ATypeTag.SYSTEM_NULL) {
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Mon, 13 May 2019 17:00:48 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 2: Contrib+1 Analytics Compatibility Tests Successful https://cbjenkins.page.link/pSyPhiXSFS16QEvw8 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 12 May 2019 13:08:51 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8543/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 12 May 2019 12:58:52 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 2: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4399/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 12 May 2019 11:59:55 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1132/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 12 May 2019 11:47:23 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6346/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 12 May 2019 11:40:25 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1039/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 12 May 2019 11:40:28 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3775/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 12 May 2019 11:40:19 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5743/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 12 May 2019 11:40:39 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 2: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/52zS2zeaBLzPfBsj6 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 12 May 2019 11:44:39 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4399/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 12 May 2019 11:43:28 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8543/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 12 May 2019 11:41:16 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5779/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 12 May 2019 11:40:42 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/942/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 12 May 2019 11:40:33 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/545/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 12 May 2019 11:40:37 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11255/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 12 May 2019 11:40:35 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5932/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 12 May 2019 11:40:30 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/704/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 12 May 2019 11:40:27 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5763/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 12 May 2019 11:40:21 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Hello Anon. E. Moose (1000171), Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3391 to look at the new patch set (#2). Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. [ASTERIXDB-2564][RT] Too many objects created in min() and max() - user model changes: no - storage format changes: no - interface changes: no Details: During min() and max() aggregation, the functions keep track of the aggregation type in order to handle heterogeneous lists. It promotes the aggregation type if needed (e.g. encountered double). Don't switch to new aggregation type and create a new comparator when the new input value type is the same as the previously aggregated values. That is because canPromote(agg_type, new_val_type) will always return true for same types. Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b --- M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractMinMaxAggregateFunction.java 1 file changed, 43 insertions(+), 60 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/91/3391/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5986/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 12 May 2019 11:40:20 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6136/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 12 May 2019 11:40:23 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5679/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 12 May 2019 11:40:18 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9722/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 12 May 2019 11:40:18 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://cbjenkins.page.link/8xDDdXMQmdvX14PV8 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sat, 11 May 2019 22:55:13 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8541/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sat, 11 May 2019 22:42:45 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1130/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sat, 11 May 2019 21:27:43 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4398/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sat, 11 May 2019 21:44:38 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Ali Alsuliman has uploaded this change for review. (
https://asterix-gerrit.ics.uci.edu/3391
Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
..
[ASTERIXDB-2564][RT] Too many objects created in min() and max()
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
During min() and max() aggregation, the functions keep track of
the aggregation type in order to handle heterogeneous lists.
It promotes the aggregation type if needed (e.g. encountered double).
Don't switch to new aggregation type and create a new comparator
when the new input value type is the same as the previously
aggregated values. That is because canPromote(agg_type, new_val_type)
will always return true for same types.
Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b
---
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractMinMaxAggregateFunction.java
1 file changed, 40 insertions(+), 54 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/91/3391/1
diff --git
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractMinMaxAggregateFunction.java
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractMinMaxAggregateFunction.java
index 86ae924..616bb5a 100644
---
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractMinMaxAggregateFunction.java
+++
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractMinMaxAggregateFunction.java
@@ -30,7 +30,6 @@
import org.apache.hyracks.algebricks.runtime.base.IScalarEvaluatorFactory;
import org.apache.hyracks.api.context.IHyracksTaskContext;
import org.apache.hyracks.api.dataflow.value.IBinaryComparator;
-import org.apache.hyracks.api.dataflow.value.IBinaryComparatorFactory;
import org.apache.hyracks.api.exceptions.HyracksDataException;
import org.apache.hyracks.api.exceptions.SourceLocation;
import org.apache.hyracks.data.std.api.IPointable;
@@ -39,18 +38,16 @@
import org.apache.hyracks.dataflow.common.data.accessors.IFrameTupleReference;
public abstract class AbstractMinMaxAggregateFunction extends
AbstractAggregateFunction {
-private IPointable inputVal = new VoidPointable();
-private ArrayBackedValueStorage outputVal = new ArrayBackedValueStorage();
-private ArrayBackedValueStorage tempValForCasting = new
ArrayBackedValueStorage();
-
-protected ArrayBackedValueStorage resultStorage = new
ArrayBackedValueStorage();
-private IScalarEvaluator eval;
+protected final ArrayBackedValueStorage resultStorage = new
ArrayBackedValueStorage();
+private final IPointable inputVal = new VoidPointable();
+private final ArrayBackedValueStorage outputVal = new
ArrayBackedValueStorage();
+private final ArrayBackedValueStorage tempValForCasting = new
ArrayBackedValueStorage();
+private final IScalarEvaluator eval;
+private final boolean isMin;
protected ATypeTag aggType;
private IBinaryComparator cmp;
-private ITypeConvertComputer tpc;
-private final boolean isMin;
-public AbstractMinMaxAggregateFunction(IScalarEvaluatorFactory[] args,
IHyracksTaskContext context, boolean isMin,
+AbstractMinMaxAggregateFunction(IScalarEvaluatorFactory[] args,
IHyracksTaskContext context, boolean isMin,
SourceLocation sourceLoc) throws HyracksDataException {
super(sourceLoc);
eval = args[0].createScalarEvaluator(context);
@@ -82,9 +79,8 @@
// First value encountered. Set type, comparator, and initial
value.
aggType = typeTag;
// Set comparator.
-IBinaryComparatorFactory cmpFactory =
-
BinaryComparatorFactoryProvider.INSTANCE.getBinaryComparatorFactory(aggType,
isMin);
-cmp = cmpFactory.createBinaryComparator();
+cmp =
BinaryComparatorFactoryProvider.INSTANCE.getBinaryComparatorFactory(aggType,
isMin)
+.createBinaryComparator();
// Initialize min value.
outputVal.assign(inputVal);
} else if (typeTag != ATypeTag.SYSTEM_NULL &&
!ATypeHierarchy.isCompatible(typeTag, aggType)) {
@@ -94,56 +90,27 @@
throw new IncompatibleTypeException(sourceLoc, "min/max",
aggType.serialize(), typeTag.serialize());
}
} else {
-
// If a system_null is encountered locally, it would be an error;
otherwise if it is seen
// by a global aggregator, it is simple ignored.
if (typeTag == ATypeTag.SYSTEM_NULL) {
processSystemNull();
return;
}
-
+if (aggType == typeTag) {
+compareAndUpdate(cmp, inputVal, outputVal);
+return;
+}
if
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 1: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/54GDbaQpTVRhBv2d9 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sat, 11 May 2019 21:31:53 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5777/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sat, 11 May 2019 21:27:54 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4398/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sat, 11 May 2019 21:31:06 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5984/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sat, 11 May 2019 21:28:01 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3774/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sat, 11 May 2019 21:27:58 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11253/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sat, 11 May 2019 21:27:59 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8541/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sat, 11 May 2019 21:28:47 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5741/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sat, 11 May 2019 21:27:56 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/703/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sat, 11 May 2019 21:27:50 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9720/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sat, 11 May 2019 21:27:43 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5761/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sat, 11 May 2019 21:27:48 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5677/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sat, 11 May 2019 21:27:43 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6344/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sat, 11 May 2019 21:27:44 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1038/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sat, 11 May 2019 21:27:44 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/544/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sat, 11 May 2019 21:27:52 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6134/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sat, 11 May 2019 21:27:45 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5931/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sat, 11 May 2019 21:27:47 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2564][RT] Too many objects created in min() and max()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3391 ) Change subject: [ASTERIXDB-2564][RT] Too many objects created in min() and max() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/940/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3391 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bb9f0715985ae555de00bbf3173c80371d8968b Gerrit-Change-Number: 3391 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sat, 11 May 2019 21:27:46 + Gerrit-HasComments: No
