Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Hussain Towaileb has submitted this change and it was merged. (
https://asterix-gerrit.ics.uci.edu/3393 )
Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..
[ASTERIXDB-2569][TEST] Refactor type computer tests
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Converted type computer tests to be parameterized.
- Moved the tests to appropriate packages to use the
log4j logger.
- Type computer instances check is based on the field
type instead of field name.
Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3393
Contrib: Jenkins
Sonar-Qube: Jenkins
Tested-by: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Dmitry Lychagin
---
M asterixdb/asterix-om/pom.xml
D
asterixdb/asterix-om/src/test/java/org/apache/asterix/om/typecomputer/ExceptionTest.java
D
asterixdb/asterix-om/src/test/java/org/apache/asterix/om/typecomputer/TypeComputerTest.java
A
asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java
A
asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/TypeComputerTest.java
R
asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/util/JSONDeserializerForTypesTest.java
6 files changed, 464 insertions(+), 301 deletions(-)
Approvals:
Jenkins: Verified; No violations found; ; Verified
Anon. E. Moose (1000171):
Dmitry Lychagin: Looks good to me, approved
diff --git a/asterixdb/asterix-om/pom.xml b/asterixdb/asterix-om/pom.xml
index b2beb41..f536be1 100644
--- a/asterixdb/asterix-om/pom.xml
+++ b/asterixdb/asterix-om/pom.xml
@@ -129,5 +129,10 @@
jaxb-api
test
+
+ org.apache.logging.log4j
+ log4j-api
+ test
+
diff --git
a/asterixdb/asterix-om/src/test/java/org/apache/asterix/om/typecomputer/ExceptionTest.java
b/asterixdb/asterix-om/src/test/java/org/apache/asterix/om/typecomputer/ExceptionTest.java
deleted file mode 100644
index 29cb9a7..000
---
a/asterixdb/asterix-om/src/test/java/org/apache/asterix/om/typecomputer/ExceptionTest.java
+++ /dev/null
@@ -1,133 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- *http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-package org.apache.asterix.om.typecomputer;
-
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.when;
-
-import java.lang.reflect.Field;
-import java.lang.reflect.Modifier;
-import java.util.ArrayList;
-import java.util.List;
-import java.util.Set;
-
-import org.apache.asterix.om.typecomputer.base.IResultTypeComputer;
-import org.apache.asterix.om.types.ATypeTag;
-import org.apache.asterix.om.types.BuiltinType;
-import org.apache.asterix.om.types.IAType;
-import org.apache.commons.lang3.mutable.Mutable;
-import org.apache.commons.lang3.mutable.MutableObject;
-import org.apache.hyracks.algebricks.common.exceptions.AlgebricksException;
-import org.apache.hyracks.algebricks.core.algebra.base.ILogicalExpression;
-import
org.apache.hyracks.algebricks.core.algebra.expressions.AbstractFunctionCallExpression;
-import
org.apache.hyracks.algebricks.core.algebra.expressions.IVariableTypeEnvironment;
-import org.apache.hyracks.algebricks.core.algebra.functions.FunctionIdentifier;
-import org.apache.hyracks.algebricks.core.algebra.metadata.IMetadataProvider;
-import org.junit.Assert;
-import org.junit.Test;
-import org.reflections.Reflections;
-import org.reflections.scanners.SubTypesScanner;
-
-public class ExceptionTest {
-
-@Test
-public void test() throws Exception {
-// Tests all usual type computers.
-Reflections reflections = new
Reflections("org.apache.asterix.om.typecomputer", new SubTypesScanner(false));
-Set> classes =
reflections.getSubTypesOf(IResultTypeComputer.class);
-int numTypeComputers = 0;
-for (Class c : classes) {
-if (Modifier.isAbstract(c.getModifiers())) {
-continue;
-}
-testTypeComputer(c);
-++numTypeComputers;
-}
-// Currently, there are 83 type computers.
-Assert.assertTrue(numTypeComputers >= 83);
-}
-
-private void
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 5: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 04:29:42 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 5: Contrib+1 Analytics Compatibility Tests Successful https://cbjenkins.page.link/WKbMfYo9wiKL67HR6 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 23:50:02 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 5: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8585/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 23:29:42 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 5: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4435/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 22:37:10 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 5: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/3393/4/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java File asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java: https://asterix-gerrit.ics.uci.edu/#/c/3393/4/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java@89 PS4, Line 89: // Prepare tests > remove this println() (or switch to use logger)? Done, removed. https://asterix-gerrit.ics.uci.edu/#/c/3393/4/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java@107 PS4, Line 107: > remove this println() (or switch to use logger)? Done, removed. https://asterix-gerrit.ics.uci.edu/#/c/3393/4/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/TypeComputerTest.java File asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/TypeComputerTest.java: https://asterix-gerrit.ics.uci.edu/#/c/3393/4/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/TypeComputerTest.java@94 PS4, Line 94: // Do any needed preparations once > remove this println() (or switch to use logger)? Done, removed. https://asterix-gerrit.ics.uci.edu/#/c/3393/4/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/TypeComputerTest.java@120 PS4, Line 120: > remove this println() (or switch to use logger)? Done, removed. -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 22:26:22 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5974/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 22:17:29 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/985/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 22:17:23 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 5: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/u7W2a2aiVSbCBonA7 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 22:21:31 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 5: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4435/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 22:20:31 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1083/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 22:17:18 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1174/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 22:17:25 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/747/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 22:17:31 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 5: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8585/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 22:18:49 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6179/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 22:17:27 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9765/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 22:17:21 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5806/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 22:17:34 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3818/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 22:17:17 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5723/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 22:17:09 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6029/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 22:17:12 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5787/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 22:17:11 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6389/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 22:17:14 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/588/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 22:17:10 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5824/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 22:17:10 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11298/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 22:17:11 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Hello Anon. E. Moose (1000171), Ali Alsuliman, Jenkins, Hussain Towaileb, Dmitry Lychagin, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3393 to look at the new patch set (#5). Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. [ASTERIXDB-2569][TEST] Refactor type computer tests - user model changes: no - storage format changes: no - interface changes: no Details: - Converted type computer tests to be parameterized. - Moved the tests to appropriate packages to use the log4j logger. - Type computer instances check is based on the field type instead of field name. Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 --- M asterixdb/asterix-om/pom.xml D asterixdb/asterix-om/src/test/java/org/apache/asterix/om/typecomputer/ExceptionTest.java D asterixdb/asterix-om/src/test/java/org/apache/asterix/om/typecomputer/TypeComputerTest.java A asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java A asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/TypeComputerTest.java R asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/util/JSONDeserializerForTypesTest.java 6 files changed, 464 insertions(+), 301 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/93/3393/5 -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Dmitry Lychagin has posted comments on this change. (
https://asterix-gerrit.ics.uci.edu/3393 )
Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..
Patch Set 4:
(4 comments)
https://asterix-gerrit.ics.uci.edu/#/c/3393/4/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java
File
asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java:
https://asterix-gerrit.ics.uci.edu/#/c/3393/4/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java@89
PS4, Line 89:
System.out.println("\n--");
remove this println() (or switch to use logger)?
https://asterix-gerrit.ics.uci.edu/#/c/3393/4/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java@107
PS4, Line 107:
System.out.println("--\n");
remove this println() (or switch to use logger)?
https://asterix-gerrit.ics.uci.edu/#/c/3393/4/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/TypeComputerTest.java
File
asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/TypeComputerTest.java:
https://asterix-gerrit.ics.uci.edu/#/c/3393/4/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/TypeComputerTest.java@94
PS4, Line 94:
System.out.println("\n--");
remove this println() (or switch to use logger)?
https://asterix-gerrit.ics.uci.edu/#/c/3393/4/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/TypeComputerTest.java@120
PS4, Line 120:
System.out.println("--\n");
remove this println() (or switch to use logger)?
--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb
Gerrit-Reviewer: Ali Alsuliman
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin
Gerrit-Reviewer: Hussain Towaileb
Gerrit-Reviewer: Hussain Towaileb
Gerrit-Reviewer: Jenkins
Gerrit-Comment-Date: Tue, 21 May 2019 20:57:43 +
Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 4: Contrib+1 Analytics Compatibility Tests Successful https://cbjenkins.page.link/WJE4c1HEuoACF76k9 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 19:58:54 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 4: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8584/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 19:42:54 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 4: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4434/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 18:50:09 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/984/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 18:30:18 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8584/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 18:31:34 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 4: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/GWb4XXWtf9HkhT7k8 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 18:34:33 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 4: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4434/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 18:33:38 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 4: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3393/3/asterixdb/asterix-om/pom.xml File asterixdb/asterix-om/pom.xml: https://asterix-gerrit.ics.uci.edu/#/c/3393/3/asterixdb/asterix-om/pom.xml@135 PS3, Line 135: test > add test . it's a test-only dependency, right? You're right, my bad, done. https://asterix-gerrit.ics.uci.edu/#/c/3393/3/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java File asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java: https://asterix-gerrit.ics.uci.edu/#/c/3393/3/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java@20 PS3, Line 20: package org.apache.asterix.test.om.typecomputer; > can you explain why these tests were moved to the "test" package? The usual The Log4j is using the log4j2-asterixdb-test.xml file for the test logging configuration, which looks for the reflection for "org.apache.asterix.test" to use the ConsoleTest appender, that's why I moved the tests to the "test" package. I noticed the same is being done for other tests, if you check the asterix-app module, the tests are under org.apache.asterix.test package as well. When I had it in the original package (before modifications), the logger wouldn't log anything, and it only started working after moving them. Please note that before we were using "System.out.print" for logging rather than Logger, that's why it wasn't an issue, but with the Logger, I had to move them. -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 18:33:14 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5786/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 18:30:30 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/587/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 18:30:24 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6178/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 18:30:17 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11297/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 18:30:33 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5973/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 18:30:29 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5805/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 18:30:23 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5823/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 18:30:32 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1082/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 18:30:19 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/746/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 18:30:26 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5722/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 18:30:14 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6028/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 18:30:16 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1173/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 18:30:16 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6388/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 18:30:16 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3817/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 18:30:14 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9764/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 18:30:15 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Hello Anon. E. Moose (1000171), Ali Alsuliman, Jenkins, Hussain Towaileb, Dmitry Lychagin, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3393 to look at the new patch set (#4). Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. [ASTERIXDB-2569][TEST] Refactor type computer tests - user model changes: no - storage format changes: no - interface changes: no Details: - Converted type computer tests to be parameterized. - Moved the tests to appropriate packages to use the log4j logger. - Type computer instances check is based on the field type instead of field name. Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 --- M asterixdb/asterix-om/pom.xml D asterixdb/asterix-om/src/test/java/org/apache/asterix/om/typecomputer/ExceptionTest.java D asterixdb/asterix-om/src/test/java/org/apache/asterix/om/typecomputer/TypeComputerTest.java A asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java A asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/TypeComputerTest.java R asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/util/JSONDeserializerForTypesTest.java 6 files changed, 472 insertions(+), 301 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/93/3393/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3393/3/asterixdb/asterix-om/pom.xml File asterixdb/asterix-om/pom.xml: https://asterix-gerrit.ics.uci.edu/#/c/3393/3/asterixdb/asterix-om/pom.xml@135 PS3, Line 135: add test . it's a test-only dependency, right? https://asterix-gerrit.ics.uci.edu/#/c/3393/3/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java File asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java: https://asterix-gerrit.ics.uci.edu/#/c/3393/3/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java@20 PS3, Line 20: package org.apache.asterix.test.om.typecomputer; can you explain why these tests were moved to the "test" package? The usual convention is to keep tests in the same package but in a different "test" source folder. your commit comment says that it had something to do with log4j. can you elaborate? -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 21 May 2019 17:35:00 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Contrib+1 Analytics Compatibility Tests Successful https://cbjenkins.page.link/Ynf3VP96dhGgfCUZ7 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 14:39:38 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8581/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 14:15:43 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1170/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:09:12 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4431/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:17:44 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5719/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:01:07 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/KhnSvMU2BKdYoWvc9 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:05:30 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4431/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:04:06 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8581/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:02:21 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9761/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:01:12 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6385/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:01:14 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11294/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:01:09 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6025/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:01:10 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1079/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:01:17 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5820/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:01:05 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/743/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:00:57 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5782/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:01:03 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5970/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:00:58 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/584/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:00:55 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5802/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:01:01 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6175/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:00:53 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/981/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:00:54 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3814/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:00:52 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Hello Anon. E. Moose (1000171), Jenkins, Hussain Towaileb, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3393 to look at the new patch set (#3). Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. [ASTERIXDB-2569][TEST] Refactor type computer tests - user model changes: no - storage format changes: no - interface changes: no Details: - Converted type computer tests to be parameterized. - Moved the tests to appropriate packages to use the log4j logger. - Type computer instances check is based on the field type instead of field name. Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 --- M asterixdb/asterix-om/pom.xml D asterixdb/asterix-om/src/test/java/org/apache/asterix/om/typecomputer/ExceptionTest.java D asterixdb/asterix-om/src/test/java/org/apache/asterix/om/typecomputer/TypeComputerTest.java A asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java A asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/TypeComputerTest.java R asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/util/JSONDeserializerForTypesTest.java 6 files changed, 471 insertions(+), 301 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/93/3393/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins
