Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/830/ 
(16/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 4
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Sat, 29 Jun 2019 01:42:39 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 4: Contrib-2

Analytics Compatibility Tests Failed
https://cbjenkins.page.link/czgqhX9RdfjrHYWX7 : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 4
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Sat, 29 Jun 2019 00:10:10 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 4:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/YbT4kA5ygMwW44u98 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 4
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 22:44:35 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8828/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 4
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 22:40:12 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/10017/ (2/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 4
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 22:37:49 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1419/
 (3/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 4
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 22:37:50 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6424/ 
(7/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 4
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 22:37:53 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 4:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5975/ 
(1/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 4
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 22:37:49 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Ali Alsuliman (Code Review)
Hello Anon. E. Moose (1000171), Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3470

to look at the new patch set (#4).

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..

[ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
Remove usages of ComparisonHelper and switch to logical or physical
comparators.

- updated RecordReplace test cases that used to throw an exception
when comparing complex types.
- cleaned up interval classes.
- fixed getStartOffset() in AIntervalPointable.
- removed ComparisonHelper

Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/ObjectsQueries.xml
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.4.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/objects/object_replace/object_replace.4.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/objects/object_replace/object_replace.5.adm
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AIntervalPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AIntervalPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/lossless/AIntervalPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AIntervalSerializerDeserializer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/AIntervalPointable.java
D 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/comparisons/ComparisonHelper.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordReplaceDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordReplaceEvaluator.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/AbstractIntervalLogicFuncDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/GetOverlappingIntervalDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/IntervalLogic.java
16 files changed, 202 insertions(+), 712 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/70/3470/4
--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 4
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1321/
 (5/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 4
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 22:37:51 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/6050/
 (16/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 3
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 17:09:45 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 3: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8824/ 
: FAILURE


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 3
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 16:14:27 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8824/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 3
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 16:06:45 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1416/
 (16/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 3
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 16:04:40 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1228/ (13/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 3
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 16:04:32 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/6033/ 
(10/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 3
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 16:04:26 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5972/ 
(15/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 3
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 16:04:35 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1318/
 (12/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 3
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 16:04:31 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6631/ (11/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 3
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 16:04:28 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/10014/ (3/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 3
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 16:04:17 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Ali Alsuliman (Code Review)
Hello Anon. E. Moose (1000171), Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3470

to look at the new patch set (#3).

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..

[ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
Remove usages of ComparisonHelper and switch to logical or physical
comparators.

- updated RecordReplace test cases that used to throw an exception
when comparing complex types.
- cleaned up interval classes.
- fixed getStartOffset() in AIntervalPointable.

Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/ObjectsQueries.xml
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.4.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/objects/object_replace/object_replace.4.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/objects/object_replace/object_replace.5.adm
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AIntervalPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AIntervalPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/lossless/AIntervalPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AIntervalSerializerDeserializer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/AIntervalPointable.java
D 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/comparisons/ComparisonHelper.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordReplaceDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordReplaceEvaluator.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/AbstractIntervalLogicFuncDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/GetOverlappingIntervalDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/IntervalLogic.java
16 files changed, 202 insertions(+), 712 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/70/3470/3
--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 3
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/4050/ 
(16/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 2
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 15:59:58 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1415/
 (15/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 2
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 15:58:39 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 2: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8823/ 
: FAILURE


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 2
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 15:58:36 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6270/ 
(14/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 2
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 15:57:40 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/6032/ 
(3/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 2
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 15:52:12 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/6048/
 (5/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 2
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 15:52:13 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11541/ (2/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 2
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 15:52:12 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-27 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 1: Contrib-2

Analytics Compatibility Tests Failed
https://cbjenkins.page.link/Eoo7MSPFFWoj8Vyj9 : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 1
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 05:45:23 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8815/ 
: SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 1
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 05:11:09 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-27 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/59WvctUd3dkygu9y8 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 1
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 03:55:53 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4631/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 1
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 03:55:05 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8815/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 1
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 03:54:01 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1218/ (6/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 1
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 03:51:42 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-27 Thread Ali Alsuliman (Code Review)
Ali Alsuliman has uploaded this change for review. ( 
https://asterix-gerrit.ics.uci.edu/3470


Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..

[ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
Remove usages of ComparisonHelper and switch to logical or physical
comparators.

- updated RecordReplace test cases that used to throw an exception
when comparing complex types.
- cleaned up interval classes.
- fixed getStartOffset() in AIntervalPointable.

Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/ObjectsQueries.xml
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.4.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/objects/object_replace/object_replace.4.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/objects/object_replace/object_replace.5.adm
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AIntervalPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AIntervalPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/lossless/AIntervalPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AIntervalSerializerDeserializer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/AIntervalPointable.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordReplaceDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordReplaceEvaluator.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/AbstractIntervalLogicFuncDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/GetOverlappingIntervalDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/IntervalLogic.java
15 files changed, 202 insertions(+), 231 deletions(-)



  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/70/3470/1

diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/ObjectsQueries.xml
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/ObjectsQueries.xml
index 150a37f..e37dee9c 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/ObjectsQueries.xml
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/ObjectsQueries.xml
@@ -147,8 +147,6 @@
   
 
   object_replace
-  function object-replace expects its 2nd input parameter 
to be of type primitive
-  function object-replace expects its 2nd input parameter 
to be of type primitive
   false
 
   
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.4.query.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.4.query.sqlpp
index 15c0bce..9e0b525 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.4.query.sqlpp
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.4.query.sqlpp
@@ -19,9 +19,9 @@

 /*
  * Description  : Testing object_replace under different queries.
- * Expected Res : Failure
+ * Expected Res : Success
  */

 use TinySocial;

-select value object_replace({"a":1}, {"b":2}, "z");
\ No newline at end of file
+select value object_replace({"a":1, "a2": {"b":2}, "a3": {"b2":2}, "a4": 
{"b":2}}, {"b":2}, "z");
\ No newline at end of file
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.5.query.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.5.query.sqlpp
index a46a727..63008dd 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.5.query.sqlpp
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.5.query.sqlpp
@@ -19,9 +19,9 @@

 /*
  * Description  : Testing object_replace under different queries.
- * Expected Res : Failure
+ * Expected Res : Success
  */

 use TinySocial;

-select value object_replace({"a":1}, 

Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/10004/ (4/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 1
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 03:51:40 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1406/
 (5/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 1
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 03:51:41 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/6040/
 (3/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 1
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 03:51:40 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6622/ (7/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 1
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 03:51:42 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1308/
 (8/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 1
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 03:51:44 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5962/ 
(1/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 1
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 03:51:40 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

2019-06-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3470 )

Change subject: [ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6261/ 
(2/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3470
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db
Gerrit-Change-Number: 3470
Gerrit-PatchSet: 1
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 28 Jun 2019 03:51:40 +
Gerrit-HasComments: No