Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Hussain Towaileb has submitted this change and it was merged. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. [ASTERIXDB-2584][FUN] Support rounding digit for round() - user model changes: yes - user can pass optional 2nd argument to round() function to specify the digit to round to. - storage format changes: no - interface changes: no Details: - Added new descriptor for 2-arguments version of round(). - Converted evaluator class to named class, now used by both round() descriptors. - Added test cases for 2-arguments version and invalid cases. Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Reviewed-on: https://asterix-gerrit.ics.uci.edu/3433 Contrib: Jenkins Tested-by: Jenkins Integration-Tests: Jenkins Reviewed-by: Hussain Towaileb Reviewed-by: Dmitry Lychagin --- A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round10_with_digit_double/round10_with_digit_double.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round11_invalid/round11_invalid.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round5_with_digit_int8/round5_with_digit_int8.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round6_with_digit_int16/round6_with_digit_int16.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round7_with_digit_int32/round7_with_digit_int32.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round8_with_digit_int64/round8_with_digit_int64.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round9_with_digit_float/round9_with_digit_float.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round10_with_digit_double/round10_with_digit_double.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round11_invalid/round11_invalid.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round5_with_digit_int8/round5_with_digit_int8.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round6_with_digit_int16/round6_with_digit_int16.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round7_with_digit_int32/round6_with_digit_int16.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round8_with_digit_int64/round8_with_digit_int64.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round9_with_digit_float/round9_with_digit_float.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java A asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NumericRoundFunctionTypeComputer.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundDescriptor.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundWithRoundDigitDescriptor.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionCollection.java 21 files changed, 650 insertions(+), 107 deletions(-) Approvals: Jenkins: Verified; ; Verified Hussain Towaileb: Looks good to me, but someone else must approve Anon. E. Moose (1000171): Dmitry Lychagin: Looks good to me, approved Objections: Jenkins: Violations found diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round10_with_digit_double/round10_with_digit_double.1.query.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round10_with_digit_double/round10_with_digit_double.1.query.sqlpp new file mode 100644 index 000..6feb726 --- /dev/null +++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round10_with_digit_double/round10_with_digit_double.1.query.sqlpp @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either expres
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 9: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/3433/9//COMMIT_MSG Commit Message: https://asterix-gerrit.ics.uci.edu/#/c/3433/9//COMMIT_MSG@10 PS9, Line 10: - user can pass optional 2nd argument to round() function > minor. fix indentation I put it on purpose to indicate that this belongs to the item above it. I will check if we have a standard for writing those to be consistent. :) https://asterix-gerrit.ics.uci.edu/#/c/3433/9/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NumericRoundFunctionTypeComputer.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NumericRoundFunctionTypeComputer.java: https://asterix-gerrit.ics.uci.edu/#/c/3433/9/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NumericRoundFunctionTypeComputer.java@83 PS9, Line 83: case ANY: > ANY could be FLOAT or DOUBLE at runtime, so we should also return nullable As discussed, since the type is "any", it will be already wrapped in a unknowable type from the AbstractTypeComputer. However, I will do a quick test to confirm that to be on the safe side. https://asterix-gerrit.ics.uci.edu/#/c/3433/9/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java: https://asterix-gerrit.ics.uci.edu/#/c/3433/9/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java@175 PS9, Line 175: double multiplier = Math.pow(10, Math.abs(roundingDigit)); > minor. Math.abs() is redundant here because roundingDigit >= 0 at this poin You're right, I'll do that in a follow up change. https://asterix-gerrit.ics.uci.edu/#/c/3433/9/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java@213 PS9, Line 213: double multiplier = Math.pow(10, Math.abs(roundingDigit)); > minor. You know that roundingDigit is < 0 at this point, so could just do - You're right, I'll do that in a follow up change. -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 21:46:18 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 9: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 21:35:24 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 9: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/3433/9//COMMIT_MSG Commit Message: https://asterix-gerrit.ics.uci.edu/#/c/3433/9//COMMIT_MSG@10 PS9, Line 10: - user can pass optional 2nd argument to round() function minor. fix indentation https://asterix-gerrit.ics.uci.edu/#/c/3433/9/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NumericRoundFunctionTypeComputer.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NumericRoundFunctionTypeComputer.java: https://asterix-gerrit.ics.uci.edu/#/c/3433/9/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NumericRoundFunctionTypeComputer.java@83 PS9, Line 83: case ANY: ANY could be FLOAT or DOUBLE at runtime, so we should also return nullable type for it (AUnionType.createNullableType()). We just need to move "case ANY" next to FLOAT/DOUBLE https://asterix-gerrit.ics.uci.edu/#/c/3433/9/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java: https://asterix-gerrit.ics.uci.edu/#/c/3433/9/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java@175 PS9, Line 175: double multiplier = Math.pow(10, Math.abs(roundingDigit)); minor. Math.abs() is redundant here because roundingDigit >= 0 at this point. https://asterix-gerrit.ics.uci.edu/#/c/3433/9/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java@213 PS9, Line 213: double multiplier = Math.pow(10, Math.abs(roundingDigit)); minor. You know that roundingDigit is < 0 at this point, so could just do -roundingDigit instead of Math.abs() -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 21:19:22 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 9: Contrib+1 Analytics Compatibility Tests Successful https://cbjenkins.page.link/tLo6wyWsfae7p9Xb6 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 20:41:19 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Hussain Towaileb has posted comments on this change. (
https://asterix-gerrit.ics.uci.edu/3433 )
Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..
Patch Set 7:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/3433/7/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java:
https://asterix-gerrit.ics.uci.edu/#/c/3433/7/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java@169
PS7, Line 169: switch (valueTypeTag) {
> I believe so, you're right, I'll do that.
Done
--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb
Gerrit-Reviewer: Ali Alsuliman
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin
Gerrit-Reviewer: Hussain Towaileb
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Till Westmann
Gerrit-Comment-Date: Wed, 12 Jun 2019 19:50:55 +
Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 9: Code-Review+1 (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3433/7/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java: https://asterix-gerrit.ics.uci.edu/#/c/3433/7/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java@160 PS7, Line 160: // Validity of arguments > Do we have this behavior (only accepting whole numbers) for casting floatin I added that check recently, so I can't tell for sure regarding the other functions, but I did use this implementation in all the functions I created (95% sure). Maybe other functions are doing the same check in a different way, but I'll have to check for that if you want. Just to give you an idea of why this appeared, N1QL's documentation states that arguments like position, count, ... etc are of type int64. However, when I did some tests, I noticed that if you give them a position of 4.3, they fail, but if you give it 4.0, it works fine. Based on some tests here and there in N1QL, it seems that they consider any X.0 a valid int64 and do the conversion, and hence, why I implemented that method just recently. https://asterix-gerrit.ics.uci.edu/#/c/3433/7/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java@169 PS7, Line 169: : ATypeHierarchy.ge > Would it make sense to fold this in (i.e. set roundingDigit to 0 and run th I believe so, you're right, I'll do that. -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 19:50:17 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 9: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8699/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 18:51:48 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1289/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 17:42:57 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 9: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8699/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 17:37:02 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/6085/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 17:32:16 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 9: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4535/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 17:18:37 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/701/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 17:15:07 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3930/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 17:11:38 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6143/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 17:11:08 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9879/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 17:11:05 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6504/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 17:10:33 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1195/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 17:04:49 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5944/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 17:03:35 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5922/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 17:04:37 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 9: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4535/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 17:04:12 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6293/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 17:03:46 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1100/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 17:01:09 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11413/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:59:34 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5903/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:59:39 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5840/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:59:22 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 9: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/6b2kMbMWyU3a79zUA : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:58:35 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/862/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:54:13 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Hello Anon. E. Moose (1000171), Till Westmann, Ali Alsuliman, Jenkins, Dmitry Lychagin, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3433 to look at the new patch set (#9). Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. [ASTERIXDB-2584][FUN] Support rounding digit for round() - user model changes: yes - user can pass optional 2nd argument to round() function to specify the digit to round to. - storage format changes: no - interface changes: no Details: - Added new descriptor for 2-arguments version of round(). - Converted evaluator class to named class, now used by both round() descriptors. - Added test cases for 2-arguments version and invalid cases. Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b --- A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round10_with_digit_double/round10_with_digit_double.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round11_invalid/round11_invalid.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round5_with_digit_int8/round5_with_digit_int8.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round6_with_digit_int16/round6_with_digit_int16.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round7_with_digit_int32/round7_with_digit_int32.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round8_with_digit_int64/round8_with_digit_int64.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round9_with_digit_float/round9_with_digit_float.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round10_with_digit_double/round10_with_digit_double.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round11_invalid/round11_invalid.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round5_with_digit_int8/round5_with_digit_int8.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round6_with_digit_int16/round6_with_digit_int16.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round7_with_digit_int32/round6_with_digit_int16.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round8_with_digit_int64/round8_with_digit_int64.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round9_with_digit_float/round9_with_digit_float.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java A asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NumericRoundFunctionTypeComputer.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundDescriptor.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundWithRoundDigitDescriptor.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionCollection.java 21 files changed, 650 insertions(+), 107 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/33/3433/9 -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 8: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4533/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:42:56 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 8: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/vfs5CNE7NGR6WwMh7 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:30:31 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 8: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4533/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:29:07 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5919/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:25:58 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/6082/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:25:55 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5941/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:26:02 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6290/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:25:53 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3927/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:26:05 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 8: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8696/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:27:18 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/859/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:25:56 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/698/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:26:00 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1192/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:25:49 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1286/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:25:44 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1097/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:25:51 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6501/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:25:46 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9876/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:25:42 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11410/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:25:43 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5900/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:25:41 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5837/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:25:40 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6140/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:25:40 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Hello Anon. E. Moose (1000171), Till Westmann, Ali Alsuliman, Jenkins, Dmitry Lychagin, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3433 to look at the new patch set (#8). Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. [ASTERIXDB-2584][FUN] Support rounding digit for round() - user model changes: yes - user can pass optional 2nd argument to round() function to specify the digit to round to. - storage format changes: no - interface changes: no Details: - Added new descriptor for 2-arguments version of round(). - Converted evaluator class to named class, now used by both round() descriptors. - Added test cases for 2-arguments version and invalid cases. Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b --- A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round10_with_digit_double/round10_with_digit_double.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round11_invalid/round11_invalid.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round5_with_digit_int8/round5_with_digit_int8.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round6_with_digit_int16/round6_with_digit_int16.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round7_with_digit_int32/round7_with_digit_int32.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round8_with_digit_int64/round8_with_digit_int64.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round9_with_digit_float/round9_with_digit_float.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round10_with_digit_double/round10_with_digit_double.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round11_invalid/round11_invalid.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round5_with_digit_int8/round5_with_digit_int8.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round6_with_digit_int16/round6_with_digit_int16.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round7_with_digit_int32/round6_with_digit_int16.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round8_with_digit_int64/round8_with_digit_int64.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round9_with_digit_float/round9_with_digit_float.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java A asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NumericRoundFunctionTypeComputer.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundDescriptor.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundWithRoundDigitDescriptor.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionCollection.java 21 files changed, 650 insertions(+), 107 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/33/3433/8 -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Till Westmann has posted comments on this change. (
https://asterix-gerrit.ics.uci.edu/3433 )
Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..
Patch Set 7:
(2 comments)
https://asterix-gerrit.ics.uci.edu/#/c/3433/7/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java:
https://asterix-gerrit.ics.uci.edu/#/c/3433/7/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java@160
PS7, Line 160: // Validity of arguments
Do we have this behavior (only accepting whole numbers) for casting floating
point to integer in other functions as well ?
https://asterix-gerrit.ics.uci.edu/#/c/3433/7/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java@169
PS7, Line 169: switch (valueTypeTag) {
Would it make sense to fold this in (i.e. set roundingDigit to 0 and run the
code in line 207)?
--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb
Gerrit-Reviewer: Ali Alsuliman
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin
Gerrit-Reviewer: Hussain Towaileb
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Till Westmann
Gerrit-Comment-Date: Tue, 11 Jun 2019 15:47:38 +
Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 7: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 12:55:14 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 7: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8692/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 12:53:46 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 7: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4529/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 12:01:25 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 7: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/k9NmoommCtEwWyx96 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:45:23 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 7: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4529/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:44:31 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/693/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:10 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5936/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:08 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/854/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:13 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5895/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:08 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5914/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:12 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1092/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:18 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6135/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:15 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9871/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:17 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6496/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:21 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1187/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:22 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6285/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:24 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 7: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8692/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:42:26 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1281/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:26 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11405/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:06 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5832/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:06 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3922/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:06 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/6077/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:07 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Hello Anon. E. Moose (1000171), Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3433 to look at the new patch set (#7). Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. [ASTERIXDB-2584][FUN] Support rounding digit for round() - user model changes: yes - user can pass optional 2nd argument to round() function to specify the digit to round to. - storage format changes: no - interface changes: no Details: - Added new descriptor for 2-arguments version of round(). - Converted evaluator class to named class, now used by both round() descriptors. - Added test cases for 2-arguments version and invalid cases. Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b --- A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round10_with_digit_double/round10_with_digit_double.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round11_invalid/round11_invalid.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round5_with_digit_int8/round5_with_digit_int8.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round6_with_digit_int16/round6_with_digit_int16.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round7_with_digit_int32/round7_with_digit_int32.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round8_with_digit_int64/round8_with_digit_int64.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round9_with_digit_float/round9_with_digit_float.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round10_with_digit_double/round10_with_digit_double.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round11_invalid/round11_invalid.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round5_with_digit_int8/round5_with_digit_int8.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round6_with_digit_int16/round6_with_digit_int16.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round7_with_digit_int32/round6_with_digit_int16.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round8_with_digit_int64/round8_with_digit_int64.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round9_with_digit_float/round9_with_digit_float.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java A asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NumericRoundFunctionTypeComputer.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundDescriptor.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundWithRoundDigitDescriptor.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionCollection.java 21 files changed, 685 insertions(+), 107 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/33/3433/7 -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1280/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 6 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:21:10 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 6: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/HXpF2BYzPADXrD7d6 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 6 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:20:22 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 5: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/4aHLEYnyGwvWgY82A : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:17:15 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6284/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 6 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:42 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6134/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 6 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:54 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN Support rounding digit for round() .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11403/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:10 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3921/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 6 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:37 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/853/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 6 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:46 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5831/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 6 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:35 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/6075/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:14 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9870/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 6 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:36 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN Support rounding digit for round() .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5934/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:03 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5913/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 6 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:45 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN Support rounding digit for round() .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6133/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:06 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN Support rounding digit for round() .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/691/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:04 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN Support rounding digit for round() .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/852/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:01 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5894/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 6 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:38 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1279/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:28 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5935/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 6 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:48 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1091/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 6 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:40 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 4: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/VfXcPs7mpZtxAodF8 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:23 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6495/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 6 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:35 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/692/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 6 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:51 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11404/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 6 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:52 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/6076/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 6 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:43 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1186/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3433 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b Gerrit-Change-Number: 3433 Gerrit-PatchSet: 6 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:37 + Gerrit-HasComments: No
