Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5692/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 30 Apr 2019 20:29:48 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5706/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 30 Apr 2019 20:29:46 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5915/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 30 Apr 2019 20:30:04 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9651/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 30 Apr 2019 20:29:55 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6065/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 30 Apr 2019 20:29:44 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/969/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 30 Apr 2019 20:30:16 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/634/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 30 Apr 2019 20:29:43 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5608/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 30 Apr 2019 20:30:07 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6275/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 30 Apr 2019 20:29:58 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11182/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 30 Apr 2019 20:30:14 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5671/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 30 Apr 2019 20:30:11 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/871/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 30 Apr 2019 20:30:02 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Dmitry Lychagin has uploaded this change for review. (
https://asterix-gerrit.ics.uci.edu/3369
Change subject: [NO ISSUE][COMP] Refactor physical window operator
..
[NO ISSUE][COMP] Refactor physical window operator
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Create a new physical operator (WindowStreamPOperator)
for window operators that do not require partition materialization
- Create AbstractWindowPOperator which is now a base
class for both physical window operators
- Rename WindowSimpleRuntime* to WindowStreamRuntime*
Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e
---
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/resource/OperatorResourcesComputer.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/resource/RequiredCapacityVisitor.java
M
asterixdb/asterix-app/src/test/resources/optimizerts/results/window/win_misc/win_misc_02.plan
M
asterixdb/asterix-app/src/test/resources/optimizerts/results/window/win_opt_01/win_opt_01_6.plan
M
asterixdb/asterix-app/src/test/resources/optimizerts/results/window/win_opt_01/win_opt_01_7.plan
M
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/base/PhysicalOperatorTag.java
A
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/AbstractWindowPOperator.java
M
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/WindowPOperator.java
A
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/WindowStreamPOperator.java
M
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java
R
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/win/WindowStreamPushRuntime.java
R
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/win/WindowStreamRuntimeFactory.java
13 files changed, 439 insertions(+), 309 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/69/3369/1
diff --git
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
index b26eaca..69eecfd 100644
---
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
+++
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
@@ -56,8 +56,10 @@
import
org.apache.hyracks.algebricks.core.algebra.operators.logical.LeftOuterUnnestMapOperator;
import
org.apache.hyracks.algebricks.core.algebra.operators.logical.UnnestMapOperator;
import
org.apache.hyracks.algebricks.core.algebra.operators.logical.WindowOperator;
+import
org.apache.hyracks.algebricks.core.algebra.operators.physical.AbstractWindowPOperator;
import
org.apache.hyracks.algebricks.core.algebra.operators.physical.ExternalGroupByPOperator;
import
org.apache.hyracks.algebricks.core.algebra.operators.physical.WindowPOperator;
+import
org.apache.hyracks.algebricks.core.algebra.operators.physical.WindowStreamPOperator;
import org.apache.hyracks.algebricks.core.algebra.properties.INodeDomain;
import
org.apache.hyracks.algebricks.core.algebra.visitors.ILogicalOperatorVisitor;
import
org.apache.hyracks.algebricks.rewriter.rules.SetAlgebricksPhysicalOperatorsRule;
@@ -241,19 +243,24 @@
}
@Override
-public WindowPOperator createWindowPOperator(WindowOperator winOp)
throws AlgebricksException {
-boolean partitionMaterialization = winOp.hasNestedPlans() ||
AnalysisUtil.hasFunctionWithProperty(winOp,
-
BuiltinFunctions.WindowFunctionProperty.MATERIALIZE_PARTITION);
-boolean frameStartIsMonotonic = AnalysisUtil
-
.isWindowFrameBoundaryMonotonic(winOp.getFrameStartExpressions(),
winOp.getFrameValueExpressions());
-boolean frameEndIsMonotonic =
AnalysisUtil.isWindowFrameBoundaryMonotonic(winOp.getFrameEndExpressions(),
-winOp.getFrameValueExpressions());
-boolean nestedTrivialAggregates = winOp.hasNestedPlans()
-&&
winOp.getNestedPlans().stream().allMatch(AnalysisUtil::isTrivialAggregateSubplan);
-
-return new WindowPOperator(winOp.getPartitionVarList(),
partitionMaterialization,
-winOp.getOrderColumnList(), frameStartIsMonotonic,
fra
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8470/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 30 Apr 2019 20:32:14 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 1: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 30 Apr 2019 20:34:13 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 1: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/xrEyahAHh2KoXavX7 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 30 Apr 2019 20:34:15 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1062/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 30 Apr 2019 20:37:54 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5862/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 30 Apr 2019 20:29:43 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/473/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 30 Apr 2019 20:29:43 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3705/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 30 Apr 2019 20:29:52 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4339/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 30 Apr 2019 20:33:22 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4339/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 30 Apr 2019 20:47:00 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8470/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 30 Apr 2019 21:46:15 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 1: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/8YzxGycJ8PHstQ3g7 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 30 Apr 2019 22:33:14 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 01 May 2019 17:20:20 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/875/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 01 May 2019 17:25:07 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6279/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 01 May 2019 17:25:06 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5711/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 01 May 2019 17:25:11 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5866/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 01 May 2019 17:25:09 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5612/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 01 May 2019 17:25:06 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5696/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 01 May 2019 17:25:13 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/638/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 01 May 2019 17:25:15 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6069/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 01 May 2019 17:25:08 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8474/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 01 May 2019 17:26:31 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3709/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 01 May 2019 17:25:18 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1066/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 01 May 2019 17:25:25 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5919/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 01 May 2019 17:25:24 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/477/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 01 May 2019 17:25:17 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9655/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 01 May 2019 17:25:23 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 2: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 01 May 2019 17:29:13 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 2: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/MzNQBDjvSNtkAYRb9 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 01 May 2019 17:29:12 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/973/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 01 May 2019 17:25:07 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5675/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 01 May 2019 17:25:08 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11186/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 01 May 2019 17:25:21 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5712/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 01 May 2019 18:32:52 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8474/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 01 May 2019 18:37:06 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 2: Contrib+1 Analytics Compatibility Tests Successful https://cbjenkins.page.link/4qNJNLrNyVgLsdqE9 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 01 May 2019 18:48:20 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3369 ) Change subject: [NO ISSUE][COMP] Refactor physical window operator .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3369 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e Gerrit-Change-Number: 3369 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 01 May 2019 19:27:03 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Refactor physical window operator
Dmitry Lychagin has submitted this change and it was merged. (
https://asterix-gerrit.ics.uci.edu/3369 )
Change subject: [NO ISSUE][COMP] Refactor physical window operator
..
[NO ISSUE][COMP] Refactor physical window operator
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Create a new physical operator (WindowStreamPOperator)
for window operators that do not require partition materialization
- Create AbstractWindowPOperator which is now a base
class for both physical window operators
- Rename WindowSimpleRuntime* to WindowStreamRuntime*
Change-Id: I3863fa3d298aef53d4098be9fc17b0451eb2c23e
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3369
Integration-Tests: Jenkins
Tested-by: Jenkins
Reviewed-by: Ali Alsuliman
---
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/resource/OperatorResourcesComputer.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/resource/RequiredCapacityVisitor.java
M
asterixdb/asterix-app/src/test/resources/optimizerts/results/window/win_misc/win_misc_02.plan
M
asterixdb/asterix-app/src/test/resources/optimizerts/results/window/win_opt_01/win_opt_01_6.plan
M
asterixdb/asterix-app/src/test/resources/optimizerts/results/window/win_opt_01/win_opt_01_7.plan
M
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/base/PhysicalOperatorTag.java
A
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/AbstractWindowPOperator.java
M
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/WindowPOperator.java
A
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/WindowStreamPOperator.java
M
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java
R
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/win/WindowStreamPushRuntime.java
R
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/win/WindowStreamRuntimeFactory.java
13 files changed, 439 insertions(+), 309 deletions(-)
Approvals:
Jenkins: Verified; Verified
Anon. E. Moose (1000171):
Ali Alsuliman: Looks good to me, approved
Objections:
Jenkins: Violations found
diff --git
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
index b26eaca..69eecfd 100644
---
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
+++
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
@@ -56,8 +56,10 @@
import
org.apache.hyracks.algebricks.core.algebra.operators.logical.LeftOuterUnnestMapOperator;
import
org.apache.hyracks.algebricks.core.algebra.operators.logical.UnnestMapOperator;
import
org.apache.hyracks.algebricks.core.algebra.operators.logical.WindowOperator;
+import
org.apache.hyracks.algebricks.core.algebra.operators.physical.AbstractWindowPOperator;
import
org.apache.hyracks.algebricks.core.algebra.operators.physical.ExternalGroupByPOperator;
import
org.apache.hyracks.algebricks.core.algebra.operators.physical.WindowPOperator;
+import
org.apache.hyracks.algebricks.core.algebra.operators.physical.WindowStreamPOperator;
import org.apache.hyracks.algebricks.core.algebra.properties.INodeDomain;
import
org.apache.hyracks.algebricks.core.algebra.visitors.ILogicalOperatorVisitor;
import
org.apache.hyracks.algebricks.rewriter.rules.SetAlgebricksPhysicalOperatorsRule;
@@ -241,19 +243,24 @@
}
@Override
-public WindowPOperator createWindowPOperator(WindowOperator winOp)
throws AlgebricksException {
-boolean partitionMaterialization = winOp.hasNestedPlans() ||
AnalysisUtil.hasFunctionWithProperty(winOp,
-
BuiltinFunctions.WindowFunctionProperty.MATERIALIZE_PARTITION);
-boolean frameStartIsMonotonic = AnalysisUtil
-
.isWindowFrameBoundaryMonotonic(winOp.getFrameStartExpressions(),
winOp.getFrameValueExpressions());
-boolean frameEndIsMonotonic =
AnalysisUtil.isWindowFrameBoundaryMonotonic(winOp.getFrameEndExpressions(),
-winOp.getFrameValueExpressions());
-boolean nestedTrivialAggregates = winOp.hasNestedPlans()
-&&
winOp.getNestedPlans().stream().allMatch(Analysis
