Change in asterixdb[master]: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

2019-05-29 Thread Murtadha Hubail (Code Review) 
Murtadha Hubail has submitted this change and it was merged. ( 
https://asterix-gerrit.ics.uci.edu/3413 )

Change subject: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
..

[NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Mark KeyStore pass as a hidden config to avoid
  displaying the password on APIs that use the hidden
  flag to certain config.

Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3413
Contrib: Jenkins 
Integration-Tests: Jenkins 
Tested-by: Jenkins 
Reviewed-by: Ali Alsuliman 
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java
2 files changed, 9 insertions(+), 0 deletions(-)

Approvals:
  Jenkins: Verified; ; Verified
  Anon. E. Moose (1000171):
  Ali Alsuliman: Looks good to me, approved

Objections:
  Jenkins: Violations found



diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java
index a38ee65..4f35aca 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java
@@ -211,6 +211,11 @@
 public String usageDefaultOverride(IApplicationConfig accessor, 
Function optionPrinter) {
 return defaultValueDescription;
 }
+
+@Override
+public boolean hidden() {
+return this == KEY_STORE_PASSWORD;
+}
 }

 private List appArgs = new ArrayList<>();
diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java
index dd92798..e947d7a 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java
@@ -247,6 +247,10 @@
 return defaultValueDescription;
 }

+@Override
+public boolean hidden() {
+return this == KEY_STORE_PASSWORD;
+}
 }

 public String getReplicationPublicAddress() {

--
To view, visit https://asterix-gerrit.ics.uci.edu/3413
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
Gerrit-Change-Number: 3413
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann

Change in asterixdb[master]: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

2019-05-29 Thread Ali Alsuliman (Code Review) 
Ali Alsuliman has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3413 )

Change subject: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
..


Patch Set 1: Code-Review+2


--
To view, visit https://asterix-gerrit.ics.uci.edu/3413
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
Gerrit-Change-Number: 3413
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Wed, 29 May 2019 16:35:12 +
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

2019-05-27 Thread Anon. E. Moose (Code Review) 
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3413 )

Change subject: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
..


Patch Set 1: Contrib+1

Analytics Compatibility Tests Successful
https://cbjenkins.page.link/Ar189kXb9mQU1CYTA : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3413
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
Gerrit-Change-Number: 3413
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 28 May 2019 04:04:18 +
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

2019-05-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3413 )

Change subject: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8612/ 
: SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3413
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
Gerrit-Change-Number: 3413
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 28 May 2019 03:44:37 +
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

2019-05-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3413 )

Change subject: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
..


Patch Set 1: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4458/ : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3413
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
Gerrit-Change-Number: 3413
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 28 May 2019 02:47:07 +
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

2019-05-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3413 )

Change subject: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5851/ 
(15/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3413
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
Gerrit-Change-Number: 3413
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 28 May 2019 02:30:23 +
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

2019-05-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3413 )

Change subject: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8612/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3413
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
Gerrit-Change-Number: 3413
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 28 May 2019 02:31:35 +
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

2019-05-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3413 )

Change subject: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6206/ 
(8/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3413
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
Gerrit-Change-Number: 3413
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 28 May 2019 02:30:06 +
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

2019-05-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3413 )

Change subject: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6056/ 
(3/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3413
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
Gerrit-Change-Number: 3413
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 28 May 2019 02:29:59 +
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

2019-05-27 Thread Anon. E. Moose (Code Review) 
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3413 )

Change subject: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/pEiutfc7cB4auVC1A : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3413
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
Gerrit-Change-Number: 3413
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 28 May 2019 02:34:06 +
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

2019-05-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3413 )

Change subject: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4458/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3413
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
Gerrit-Change-Number: 3413
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 28 May 2019 02:33:22 +
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

2019-05-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3413 )

Change subject: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6416/ (7/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3413
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
Gerrit-Change-Number: 3413
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 28 May 2019 02:30:03 +
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

2019-05-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3413 )

Change subject: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9792/ (4/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3413
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
Gerrit-Change-Number: 3413
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 28 May 2019 02:30:00 +
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

2019-05-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3413 )

Change subject: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1201/
 (5/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3413
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
Gerrit-Change-Number: 3413
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 28 May 2019 02:30:01 +
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

2019-05-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3413 )

Change subject: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/615/ 
(11/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3413
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
Gerrit-Change-Number: 3413
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 28 May 2019 02:30:13 +
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

2019-05-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3413 )

Change subject: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1012/ (9/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3413
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
Gerrit-Change-Number: 3413
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 28 May 2019 02:30:08 +
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

2019-05-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3413 )

Change subject: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5833/
 (13/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3413
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
Gerrit-Change-Number: 3413
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 28 May 2019 02:30:18 +
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

2019-05-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3413 )

Change subject: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11325/ (16/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3413
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
Gerrit-Change-Number: 3413
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 28 May 2019 02:30:25 +
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

2019-05-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3413 )

Change subject: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/6001/
 (10/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3413
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
Gerrit-Change-Number: 3413
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 28 May 2019 02:30:10 +
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

2019-05-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3413 )

Change subject: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5815/ 
(14/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3413
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
Gerrit-Change-Number: 3413
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 28 May 2019 02:30:21 +
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

2019-05-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3413 )

Change subject: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3845/ 
(2/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3413
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
Gerrit-Change-Number: 3413
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 28 May 2019 02:29:59 +
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

2019-05-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3413 )

Change subject: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1110/
 (6/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3413
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
Gerrit-Change-Number: 3413
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 28 May 2019 02:30:02 +
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

2019-05-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3413 )

Change subject: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5750/ 
(1/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3413
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
Gerrit-Change-Number: 3413
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 28 May 2019 02:29:59 +
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

2019-05-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3413 )

Change subject: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/774/ 
(12/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3413
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
Gerrit-Change-Number: 3413
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 28 May 2019 02:30:15 +
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

2019-05-27 Thread Murtadha Hubail (Code Review) 
Murtadha Hubail has uploaded this change for review. ( 
https://asterix-gerrit.ics.uci.edu/3413


Change subject: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
..

[NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Mark KeyStore pass as a hidden config to avoid
  displaying the password on APIs that use the hidden
  flag to certain config.

Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java
2 files changed, 9 insertions(+), 0 deletions(-)



  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/13/3413/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java
index a38ee65..4f35aca 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java
@@ -211,6 +211,11 @@
 public String usageDefaultOverride(IApplicationConfig accessor, 
Function optionPrinter) {
 return defaultValueDescription;
 }
+
+@Override
+public boolean hidden() {
+return this == KEY_STORE_PASSWORD;
+}
 }

 private List appArgs = new ArrayList<>();
diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java
index dd92798..e947d7a 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java
@@ -247,6 +247,10 @@
 return defaultValueDescription;
 }

+@Override
+public boolean hidden() {
+return this == KEY_STORE_PASSWORD;
+}
 }

 public String getReplicationPublicAddress() {

--
To view, visit https://asterix-gerrit.ics.uci.edu/3413
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
Gerrit-Change-Number: 3413
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail