Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Dmitry Lychagin has submitted this change and it was merged. (
https://asterix-gerrit.ics.uci.edu/3449 )
Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
..
[NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
- user model changes: yes
- storage format changes: no
- interface changes: no
Details:
- Support frame specification in RATIO_TO_REPORT()
window function call
Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3449
Contrib: Jenkins
Integration-Tests: Jenkins
Tested-by: Jenkins
Reviewed-by: Dmitry Lychagin
Reviewed-by: Ali Alsuliman
---
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/ratio_to_report_01/ratio_to_report_01.8.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/results/window/ratio_to_report_01/ratio_to_report_01.8.adm
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java
4 files changed, 36 insertions(+), 6 deletions(-)
Approvals:
Jenkins: Verified; ; Verified
Anon. E. Moose (1000171):
Dmitry Lychagin: Looks good to me, but someone else must approve
Ali Alsuliman: Looks good to me, approved
Objections:
Jenkins: Violations found
diff --git
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
index 1c5750c..988723f 100644
---
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
+++
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
@@ -1228,11 +1228,6 @@
createOperatorExpr(fargs.get(1), OperatorType.MINUS,
new IntegerLiteral(1), sourceLoc);
} else if (BuiltinFunctions.RATIO_TO_REPORT_IMPL.equals(fi)) {
// ratio_to_report(x) over (...) --> x / sum(x) over (...)
-winFrameMode = WindowExpression.FrameMode.RANGE;
-winFrameStartKind =
WindowExpression.FrameBoundaryKind.UNBOUNDED_PRECEDING;
-winFrameEndKind =
WindowExpression.FrameBoundaryKind.CURRENT_ROW;
-winFrameExclusionKind =
WindowExpression.FrameExclusionKind.NO_OTHERS;
-
nestedAggFunc = BuiltinFunctions.SCALAR_SQL_SUM;
postWinResultFunc = BuiltinFunctions.NUMERIC_DIVIDE;
postWinExpr = fargs.get(1);
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/ratio_to_report_01/ratio_to_report_01.8.query.sqlpp
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/ratio_to_report_01/ratio_to_report_01.8.query.sqlpp
new file mode 100644
index 000..9408641
--- /dev/null
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/ratio_to_report_01/ratio_to_report_01.8.query.sqlpp
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/*
+ * Description : Test RATIO_TO_REPORT() with frame specification
+ * Expected Res : SUCCESS
+ */
+
+FROM range(1, 2) x, range(1, 4) y
+SELECT x, y,
+ round_half_to_even(ratio_to_report(y) over (partition by x order by y rows
between 1 preceding and 1 following), 2) rr
+ORDER BY x, y
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/results/window/ratio_to_report_01/ratio_to_report_01.8.adm
b/asterixdb/asterix-app/src/test/resources/runtimets/results/window/ratio_to_report_01/ratio_to_report_01.8.adm
new file mode 100644
index 000..5ff1afc
--- /dev/null
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/results/window/ratio_to_report_01/ratio_to_report_01.8.adm
@@ -0,0 +1,8 @@
+{ "x": 1, "y": 1, "rr": 0.33 }
+{ "x": 1, "y": 2, "rr": 0.33 }
+{ "x": 1, "y": 3, "rr": 0.33 }
+{ "x": 1, "y": 4, "rr": 0.57 }
+{ "x": 2, "y": 1, "rr": 0.33 }
+{ "x": 2, "y": 2, "rr": 0.33 }
+{ "x": 2, "y": 3, "rr": 0.33 }
+{ "x": 2, "y": 4, "rr": 0.57 }
\ No newline at
Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3449 ) Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT() .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3449 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a Gerrit-Change-Number: 3449 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 18 Jun 2019 04:44:43 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3449 ) Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT() .. Patch Set 1: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/3449 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a Gerrit-Change-Number: 3449 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 18 Jun 2019 04:20:30 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3449 ) Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5941/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3449 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a Gerrit-Change-Number: 3449 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 18 Jun 2019 04:09:00 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3449 ) Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT() .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://cbjenkins.page.link/QzLgmBvA4Sb6by6F8 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3449 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a Gerrit-Change-Number: 3449 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 18 Jun 2019 01:53:59 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3449 ) Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT() .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8735/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3449 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a Gerrit-Change-Number: 3449 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 18 Jun 2019 01:04:19 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3449 ) Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT() .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4562/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3449 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a Gerrit-Change-Number: 3449 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Tue, 18 Jun 2019 00:11:45 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3449 ) Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT() .. Patch Set 1: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/avRtxWuQQFTeSDV48 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3449 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a Gerrit-Change-Number: 3449 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 17 Jun 2019 23:57:44 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3449 ) Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT() .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4562/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3449 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a Gerrit-Change-Number: 3449 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 17 Jun 2019 23:54:35 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3449 ) Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6329/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3449 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a Gerrit-Change-Number: 3449 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 17 Jun 2019 23:51:25 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3449 ) Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/895/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3449 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a Gerrit-Change-Number: 3449 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 17 Jun 2019 23:51:22 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3449 ) Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5958/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3449 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a Gerrit-Change-Number: 3449 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 17 Jun 2019 23:51:27 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3449 ) Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9915/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3449 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a Gerrit-Change-Number: 3449 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 17 Jun 2019 23:51:19 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3449 ) Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/6118/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3449 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a Gerrit-Change-Number: 3449 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 17 Jun 2019 23:51:30 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3449 ) Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3963/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3449 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a Gerrit-Change-Number: 3449 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 17 Jun 2019 23:51:23 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3449 ) Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT() .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8735/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3449 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a Gerrit-Change-Number: 3449 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 17 Jun 2019 23:53:15 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3449 ) Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1325/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3449 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a Gerrit-Change-Number: 3449 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 17 Jun 2019 23:51:10 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3449 ) Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11449/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3449 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a Gerrit-Change-Number: 3449 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 17 Jun 2019 23:51:10 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3449 ) Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6540/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3449 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a Gerrit-Change-Number: 3449 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 17 Jun 2019 23:51:14 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3449 ) Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5939/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3449 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a Gerrit-Change-Number: 3449 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 17 Jun 2019 23:51:09 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3449 ) Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1136/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3449 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a Gerrit-Change-Number: 3449 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 17 Jun 2019 23:51:17 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3449 ) Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5981/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3449 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a Gerrit-Change-Number: 3449 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 17 Jun 2019 23:51:09 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3449 ) Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1229/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3449 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a Gerrit-Change-Number: 3449 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 17 Jun 2019 23:51:15 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3449 ) Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6179/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3449 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a Gerrit-Change-Number: 3449 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 17 Jun 2019 23:51:12 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Dmitry Lychagin has uploaded this change for review. (
https://asterix-gerrit.ics.uci.edu/3449
Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
..
[NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
- user model changes: yes
- storage format changes: no
- interface changes: no
Details:
- Support frame specification in RATIO_TO_REPORT()
window function call
Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a
---
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/ratio_to_report_01/ratio_to_report_01.8.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/results/window/ratio_to_report_01/ratio_to_report_01.8.adm
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java
4 files changed, 36 insertions(+), 6 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/49/3449/1
diff --git
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
index 1c5750c..988723f 100644
---
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
+++
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
@@ -1228,11 +1228,6 @@
createOperatorExpr(fargs.get(1), OperatorType.MINUS,
new IntegerLiteral(1), sourceLoc);
} else if (BuiltinFunctions.RATIO_TO_REPORT_IMPL.equals(fi)) {
// ratio_to_report(x) over (...) --> x / sum(x) over (...)
-winFrameMode = WindowExpression.FrameMode.RANGE;
-winFrameStartKind =
WindowExpression.FrameBoundaryKind.UNBOUNDED_PRECEDING;
-winFrameEndKind =
WindowExpression.FrameBoundaryKind.CURRENT_ROW;
-winFrameExclusionKind =
WindowExpression.FrameExclusionKind.NO_OTHERS;
-
nestedAggFunc = BuiltinFunctions.SCALAR_SQL_SUM;
postWinResultFunc = BuiltinFunctions.NUMERIC_DIVIDE;
postWinExpr = fargs.get(1);
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/ratio_to_report_01/ratio_to_report_01.8.query.sqlpp
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/ratio_to_report_01/ratio_to_report_01.8.query.sqlpp
new file mode 100644
index 000..9408641
--- /dev/null
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/ratio_to_report_01/ratio_to_report_01.8.query.sqlpp
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/*
+ * Description : Test RATIO_TO_REPORT() with frame specification
+ * Expected Res : SUCCESS
+ */
+
+FROM range(1, 2) x, range(1, 4) y
+SELECT x, y,
+ round_half_to_even(ratio_to_report(y) over (partition by x order by y rows
between 1 preceding and 1 following), 2) rr
+ORDER BY x, y
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/results/window/ratio_to_report_01/ratio_to_report_01.8.adm
b/asterixdb/asterix-app/src/test/resources/runtimets/results/window/ratio_to_report_01/ratio_to_report_01.8.adm
new file mode 100644
index 000..5ff1afc
--- /dev/null
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/results/window/ratio_to_report_01/ratio_to_report_01.8.adm
@@ -0,0 +1,8 @@
+{ "x": 1, "y": 1, "rr": 0.33 }
+{ "x": 1, "y": 2, "rr": 0.33 }
+{ "x": 1, "y": 3, "rr": 0.33 }
+{ "x": 1, "y": 4, "rr": 0.57 }
+{ "x": 2, "y": 1, "rr": 0.33 }
+{ "x": 2, "y": 2, "rr": 0.33 }
+{ "x": 2, "y": 3, "rr": 0.33 }
+{ "x": 2, "y": 4, "rr": 0.57 }
\ No newline at end of file
diff --git
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java
index 7afda20..5e2257a 100644
---
Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3449 ) Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5876/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3449 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a Gerrit-Change-Number: 3449 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 17 Jun 2019 23:51:08 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3449 ) Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/735/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3449 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a Gerrit-Change-Number: 3449 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 17 Jun 2019 23:51:09 + Gerrit-HasComments: No
