Change in asterixdb[master]: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
Ali Alsuliman has submitted this change and it was merged. (
https://asterix-gerrit.ics.uci.edu/3375 )
Change subject: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash
join
..
[NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
Hash join build activity assumes that upon calling close()
the join state must have been allocated in open() and
therefore, it will directly call "close build" using the join
state. However, if the build activity throws an exception
in open(), then it could happen that the join state has
not been initialized. Calling close() on the build activity
will lead to a NPE since it will use the join state directly.
This patch checks if the join state has been initialized. If
so, it will close the build as usual.
Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3375
Contrib: Jenkins
Tested-by: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Murtadha Hubail
---
M
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
1 file changed, 9 insertions(+), 7 deletions(-)
Approvals:
Jenkins: Verified; ; Verified
Anon. E. Moose (1000171):
Murtadha Hubail: Looks good to me, approved
Objections:
Jenkins: Violations found
diff --git
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
index 403c492..81d08b2 100644
---
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
+++
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
@@ -315,13 +315,15 @@
@Override
public void close() throws HyracksDataException {
-state.hybridHJ.closeBuild();
-if (isFailed) {
-state.hybridHJ.clearBuildTempFiles();
-} else {
-ctx.setStateObject(state);
-if (LOGGER.isTraceEnabled()) {
-LOGGER.trace("OptimizedHybridHashJoin closed its
build phase");
+if (state.hybridHJ != null) {
+state.hybridHJ.closeBuild();
+if (isFailed) {
+state.hybridHJ.clearBuildTempFiles();
+} else {
+ctx.setStateObject(state);
+if (LOGGER.isTraceEnabled()) {
+LOGGER.trace("OptimizedHybridHashJoin closed
its build phase");
+}
}
}
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/3375
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb
Gerrit-Change-Number: 3375
Gerrit-PatchSet: 2
Gerrit-Owner: Ali Alsuliman
Gerrit-Reviewer: Ali Alsuliman
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Murtadha Hubail
Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3375 ) Change subject: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3375 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb Gerrit-Change-Number: 3375 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Comment-Date: Thu, 02 May 2019 19:11:07 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3375 ) Change subject: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://cbjenkins.page.link/zb6SKC8H4nMqf4ZS9 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3375 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb Gerrit-Change-Number: 3375 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 02 May 2019 18:00:30 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3375 ) Change subject: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join .. Patch Set 1: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/AzVSqJ2gtWYo4dW47 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3375 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb Gerrit-Change-Number: 3375 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 02 May 2019 06:09:55 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3375 ) Change subject: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8480/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3375 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb Gerrit-Change-Number: 3375 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 02 May 2019 04:42:26 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3375 ) Change subject: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4348/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3375 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb Gerrit-Change-Number: 3375 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 02 May 2019 03:33:58 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3375 ) Change subject: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6285/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3375 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb Gerrit-Change-Number: 3375 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 02 May 2019 03:25:20 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3375 ) Change subject: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8480/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3375 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb Gerrit-Change-Number: 3375 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 02 May 2019 03:32:37 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3375 ) Change subject: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1071/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3375 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb Gerrit-Change-Number: 3375 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 02 May 2019 03:31:38 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3375 ) Change subject: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3715/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3375 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb Gerrit-Change-Number: 3375 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 02 May 2019 03:29:13 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3375 ) Change subject: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/483/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3375 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb Gerrit-Change-Number: 3375 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 02 May 2019 03:18:15 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3375 ) Change subject: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6075/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3375 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb Gerrit-Change-Number: 3375 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 02 May 2019 03:19:22 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3375 ) Change subject: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4348/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3375 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb Gerrit-Change-Number: 3375 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 02 May 2019 03:19:48 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3375 ) Change subject: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5925/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3375 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb Gerrit-Change-Number: 3375 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 02 May 2019 03:25:41 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3375 ) Change subject: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/979/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3375 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb Gerrit-Change-Number: 3375 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 02 May 2019 03:25:13 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3375 ) Change subject: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9661/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3375 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb Gerrit-Change-Number: 3375 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 02 May 2019 03:24:26 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3375 ) Change subject: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join .. Patch Set 1: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/Va5c8aQzxXWdpyBM6 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3375 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb Gerrit-Change-Number: 3375 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 02 May 2019 03:22:31 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3375 ) Change subject: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5872/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3375 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb Gerrit-Change-Number: 3375 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 02 May 2019 03:19:20 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3375 ) Change subject: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5618/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3375 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb Gerrit-Change-Number: 3375 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 02 May 2019 03:18:12 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3375 ) Change subject: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11192/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3375 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb Gerrit-Change-Number: 3375 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 02 May 2019 03:18:13 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3375 ) Change subject: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5681/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3375 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb Gerrit-Change-Number: 3375 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 02 May 2019 03:18:13 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3375 ) Change subject: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5702/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3375 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb Gerrit-Change-Number: 3375 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 02 May 2019 03:18:13 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3375 ) Change subject: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5718/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3375 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb Gerrit-Change-Number: 3375 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 02 May 2019 03:18:12 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3375 ) Change subject: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/644/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3375 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb Gerrit-Change-Number: 3375 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 02 May 2019 03:18:17 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3375 ) Change subject: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/881/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3375 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb Gerrit-Change-Number: 3375 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 02 May 2019 03:18:12 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
Ali Alsuliman has uploaded this change for review. (
https://asterix-gerrit.ics.uci.edu/3375
Change subject: [NO ISSUE][HYR][RT] Handle calls to close() properly in hash
join
..
[NO ISSUE][HYR][RT] Handle calls to close() properly in hash join
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
Hash join build activity assumes that upon calling close()
the join state must have been allocated in open() and
therefore, it will directly call "close build" using the join
state. However, if the build activity throws an exception
in open(), then it could happen that the join state has
not been initialized. Calling close() on the build activity
will lead to a NPE since it will use the join state directly.
This patch checks if the join state has been initialized. If
so, it will close the build as usual.
Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb
---
M
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
1 file changed, 9 insertions(+), 7 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/75/3375/1
diff --git
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
index 403c492..81d08b2 100644
---
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
+++
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
@@ -315,13 +315,15 @@
@Override
public void close() throws HyracksDataException {
-state.hybridHJ.closeBuild();
-if (isFailed) {
-state.hybridHJ.clearBuildTempFiles();
-} else {
-ctx.setStateObject(state);
-if (LOGGER.isTraceEnabled()) {
-LOGGER.trace("OptimizedHybridHashJoin closed its
build phase");
+if (state.hybridHJ != null) {
+state.hybridHJ.closeBuild();
+if (isFailed) {
+state.hybridHJ.clearBuildTempFiles();
+} else {
+ctx.setStateObject(state);
+if (LOGGER.isTraceEnabled()) {
+LOGGER.trace("OptimizedHybridHashJoin closed
its build phase");
+}
}
}
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/3375
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I41fff7deed5e56818bfefb4d36b8018a9f512cbb
Gerrit-Change-Number: 3375
Gerrit-PatchSet: 1
Gerrit-Owner: Ali Alsuliman
