Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 2:

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4244/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4244/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1924/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1195/ 
(6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Michael Blow (Code Review)]

Michael Blow has submitted this change and it was merged.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


[NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored IPC connection

Regression in 860fcde

Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2067
Reviewed-by: Michael Blow 
Tested-by: Michael Blow 
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Michael Blow: Looks good to me, approved; Verified



diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
index 69137e5..4a2c2e9 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
@@ -317,6 +317,12 @@
 timer.schedule(new ProfileDumpTask(ccs), 0, 
nodeParameters.getProfileDumpPeriod());
 }
 
+// Start heartbeat generator.
+heartbeatThread = new Thread(new HeartbeatTask(ccs, 
nodeParameters.getHeartbeatPeriod()), id + "-Heartbeat");
+heartbeatThread.setPriority(Thread.MAX_PRIORITY);
+heartbeatThread.setDaemon(true);
+heartbeatThread.start();
+
 LOGGER.log(Level.INFO, "Started NodeControllerService");
 application.startupCompleted();
 }
@@ -354,12 +360,6 @@
 registrationException);
 throw registrationException;
 }
-// Start heartbeat generator.
-heartbeatThread = new Thread(new HeartbeatTask(ccs, 
nodeParameters.getHeartbeatPeriod()), id + "-Heartbeat");
-heartbeatThread.setPriority(Thread.MAX_PRIORITY);
-heartbeatThread.setDaemon(true);
-heartbeatThread.start();
-
 serviceCtx.setDistributedState(nodeParameters.getDistributedState());
 application.onRegisterNode();
 LOGGER.info("Registering with Cluster Controller complete");

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1803/ (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Michael Blow (Code Review)]

Hello Till Westmann, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2067

to look at the new patch set (#2).

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..

[NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored IPC connection

Regression in 860fcde

Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
1 file changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/67/2067/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1524/ 
(5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6740/ (7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1903/ 
(8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1861/
 (9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5244/ (2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2083/ (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1186/ 
(4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 2: Code-Review+2 Verified+1

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1923/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1195/
 (3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4243/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2082/ (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1902/ 
(9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1860/
 (8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1194/
 (5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1185/ 
(1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6739/ (7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Michael Blow (Code Review)]

Michael Blow has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2067

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..

[NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored IPC connection

Regression in 860fcde

Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
1 file changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/67/2067/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
index 69137e5..534e195 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
@@ -317,6 +317,12 @@
 timer.schedule(new ProfileDumpTask(ccs), 0, 
nodeParameters.getProfileDumpPeriod());
 }
 
+// Start heartbeat generator.
+heartbeatThread = new Thread(new HeartbeatTask(ccs, 
nodeParameters.getHeartbeatPeriod()), id + "-Heartbeat");
+heartbeatThread.setPriority(Thread.MAX_PRIORITY);
+heartbeatThread.setDaemon(true);
+heartbeatThread.start();
+
 LOGGER.log(Level.INFO, "Started NodeControllerService");
 application.startupCompleted();
 }
@@ -354,12 +360,6 @@
 registrationException);
 throw registrationException;
 }
-// Start heartbeat generator.
-heartbeatThread = new Thread(new HeartbeatTask(ccs, 
nodeParameters.getHeartbeatPeriod()), id + "-Heartbeat");
-heartbeatThread.setPriority(Thread.MAX_PRIORITY);
-heartbeatThread.setDaemon(true);
-heartbeatThread.start();
-
 serviceCtx.setDistributedState(nodeParameters.getDistributedState());
 application.onRegisterNode();
 LOGGER.info("Registering with Cluster Controller complete");

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1194/ 
(6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1802/ (4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5243/ (3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on resto...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR] Prevent duplicate heartbeat threads on restored 
IPC connection
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1523/ 
(2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2067
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13833f5c3afc5e17591e112ce0e127a19d7385c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No