Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
abdullah alamoudi has submitted this change and it was merged.
Change subject: [NO ISSUE][OTH] Fix memory component release trace call
..
[NO ISSUE][OTH] Fix memory component release trace call
- user model changes: no
- storage format changes: no
- interface changes: no
details:
- The trace for releasing memory component produces
malformed json which makes it fail to load in
chrome tracer. This change fixes it
Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2065
Integration-Tests: Jenkins
Tested-by: Jenkins
Contrib: Jenkins
Reviewed-by: Till Westmann
---
A
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ParserPerformanceTest.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
2 files changed, 98 insertions(+), 2 deletions(-)
Approvals:
Till Westmann: Looks good to me, approved
Jenkins: Verified; ; Verified
Objections:
Jenkins: Violations found
diff --git
a/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ParserPerformanceTest.java
b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ParserPerformanceTest.java
new file mode 100644
index 000..17cd4ab
--- /dev/null
+++
b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ParserPerformanceTest.java
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.asterix.external.parser.test;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.nio.CharBuffer;
+import java.nio.charset.CharsetDecoder;
+import java.nio.charset.CoderResult;
+import java.nio.charset.StandardCharsets;
+
+import org.apache.asterix.external.input.record.CharArrayRecord;
+import org.apache.asterix.external.parser.ADMDataParser;
+import org.apache.asterix.external.util.ExternalDataConstants;
+import org.apache.asterix.om.pointables.base.DefaultOpenFieldType;
+import org.apache.hyracks.data.std.util.ArrayBackedValueStorage;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+
+public class ParserPerformanceTest {
+
+public void benchmark() throws Exception {
+int seed = 2;
+int levels = 26;
+int[] rounds = getRounds(seed, levels);
+for (int round : rounds) {
+round(round);
+}
+}
+
+private int[] getRounds(int seed, int levels) {
+int[] rounds = new int[levels];
+rounds[0] = seed;
+for (int i = 1; i < rounds.length; i++) {
+seed *= 2;
+rounds[i] = seed;
+}
+return rounds;
+}
+
+public void round(int round) throws Exception {
+System.err.println("Running a parse round of size = " + round + "
records");
+ObjectMapper om = new ObjectMapper();
+byte[] json = "{\"name\":\"value\"}".getBytes(StandardCharsets.UTF_8);
+long start = System.nanoTime();
+for (int i = 0; i < round; i++) {
+om.readTree(json);
+}
+long end = System.nanoTime();
+long jacksonTime = end - start;
+CharsetDecoder decoder = StandardCharsets.UTF_8.newDecoder();
+CharBuffer chars =
CharBuffer.allocate(ExternalDataConstants.DEFAULT_BUFFER_SIZE);
+CharArrayRecord record = new CharArrayRecord();
+set(json, decoder, chars, record);
+ADMDataParser parser = new
ADMDataParser(DefaultOpenFieldType.NESTED_OPEN_RECORD_TYPE, false);
+ArrayBackedValueStorage output = new ArrayBackedValueStorage();
+start = System.nanoTime();
+for (int i = 0; i < round; i++) {
+output.reset();
+parser.parse(record, output.getDataOutput());
+}
+end = System.nanoTime();
+long admParserTime = end - start;
+System.err.println("Jackson time = " + jacksonTime);
+System.err.println("AdmParser time = " + admParserTime);
+}
+
+private static void set(final byte[] content, final CharsetDecoder
decoder, final CharBuffer chars,
+
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 4: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 4: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1928/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 4: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1928/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1866/ (10/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 4: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4242/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 4: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4242/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5242/ (5/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1522/ (2/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2081/ (4/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1184/ (9/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1859/ (10/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1901/ (6/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1801/ (8/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1193/ (7/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1193/ (3/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6738/ (1/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Ian Maxon has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 3: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 3: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4236/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 3: Contrib-1 Analytics Compatibility Tests Failed Build 2735 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 3: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1917/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 3: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1917/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4236/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2075/ (10/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1893/ (9/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1852/ (8/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1186/ (7/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1515/ (6/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 3: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5235/ (4/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1176/ (2/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6731/ (1/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1186/ (5/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
abdullah alamoudi has uploaded a new patch set (#3). Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. [NO ISSUE][OTH] Fix memory component release trace call - user model changes: no - storage format changes: no - interface changes: no details: - The trace for releasing memory component produces malformed json which makes it fail to load in chrome tracer. This change fixes it Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 --- A asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ParserPerformanceTest.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java 2 files changed, 98 insertions(+), 2 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/65/2065/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1794/ (3/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
abdullah alamoudi has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2065/2/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ParserPerformanceTest.java File asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ParserPerformanceTest.java: PS2, Line 81: Cbas > what's a cbas? Done https://asterix-gerrit.ics.uci.edu/#/c/2065/2/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java: PS2, Line 257: lsmIndex.toString() > I thought Till mentioned this should be JSON, is it? yes it is -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Michael Blow has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2065/2/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ParserPerformanceTest.java File asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ParserPerformanceTest.java: PS2, Line 81: Cbas what's a cbas? https://asterix-gerrit.ics.uci.edu/#/c/2065/2/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java: PS2, Line 257: lsmIndex.toString() I thought Till mentioned this should be JSON, is it? -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 2: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1514/ (6/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1793/ (3/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1175/ (2/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1185/ (5/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6730/ (1/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5234/ (4/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
abdullah alamoudi has uploaded a new patch set (#2). Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. [NO ISSUE][OTH] Fix memory component release trace call - user model changes: no - storage format changes: no - interface changes: no details: - The trace for releasing memory component produces malformed json which makes it fail to load in chrome tracer. This change fixes it Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 --- A asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ParserPerformanceTest.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMMemoryComponent.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java 3 files changed, 103 insertions(+), 2 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/65/2065/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1792/ (5/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
abdullah alamoudi has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2065
Change subject: [NO ISSUE][OTH] Fix memory component release trace call
..
[NO ISSUE][OTH] Fix memory component release trace call
- user model changes: no
- storage format changes: no
- interface changes: no
details:
- The trace for releasing memory component produces
malformed json which makes it fail to load in
chrome tracer. This change fixes it
Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060
---
A
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ParserPerformanceTest.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMMemoryComponent.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
3 files changed, 103 insertions(+), 2 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/65/2065/1
diff --git
a/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ParserPerformanceTest.java
b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ParserPerformanceTest.java
new file mode 100644
index 000..569f093
--- /dev/null
+++
b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ParserPerformanceTest.java
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.asterix.external.parser.test;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.nio.CharBuffer;
+import java.nio.charset.CharsetDecoder;
+import java.nio.charset.CoderResult;
+import java.nio.charset.StandardCharsets;
+
+import org.apache.asterix.external.input.record.CharArrayRecord;
+import org.apache.asterix.external.parser.ADMDataParser;
+import org.apache.asterix.external.util.ExternalDataConstants;
+import org.apache.asterix.om.pointables.base.DefaultOpenFieldType;
+import org.apache.hyracks.data.std.util.ArrayBackedValueStorage;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+
+public class ParserPerformanceTest {
+
+public void benchmark() throws Exception {
+int seed = 2;
+int levels = 26;
+int[] rounds = getRounds(seed, levels);
+for (int round : rounds) {
+round(round);
+}
+}
+
+private int[] getRounds(int seed, int levels) {
+int[] rounds = new int[levels];
+rounds[0] = seed;
+for (int i = 1; i < rounds.length; i++) {
+seed *= 2;
+rounds[i] = seed;
+}
+return rounds;
+}
+
+public void round(int round) throws Exception {
+System.err.println("Running a parse round of " + round + " size");
+ObjectMapper om = new ObjectMapper();
+byte[] json = "{\"name\":\"value\"}".getBytes(StandardCharsets.UTF_8);
+long start = System.nanoTime();
+for (int i = 0; i < round; i++) {
+om.readTree(json);
+}
+long end = System.nanoTime();
+long jacksonTime = end - start;
+CharsetDecoder decoder = StandardCharsets.UTF_8.newDecoder();
+CharBuffer chars =
CharBuffer.allocate(ExternalDataConstants.DEFAULT_BUFFER_SIZE);
+CharArrayRecord record = new CharArrayRecord();
+set(json, decoder, chars, record);
+ADMDataParser parser = new
ADMDataParser(DefaultOpenFieldType.NESTED_OPEN_RECORD_TYPE, false);
+ArrayBackedValueStorage output = new ArrayBackedValueStorage();
+start = System.nanoTime();
+for (int i = 0; i < round; i++) {
+output.reset();
+parser.parse(record, output.getDataOutput());
+}
+end = System.nanoTime();
+long cbasTime = end - start;
+System.err.println("Jackson time = " + jacksonTime);
+System.err.println("Cbas time = " + cbasTime);
+}
+
+private static void set(final byte[] content, final CharsetDecoder
decoder, final CharBuffer chars,
+final CharArrayRecord r
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1174/ (2/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1184/ (3/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6729/ (1/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Fix memory component release trace call
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Fix memory component release trace call .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5233/ (4/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb6105ffebe01b6ece78983b7b56603f0787060 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
