Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Murtadha Hubail has submitted this change and it was merged. (
https://asterix-gerrit.ics.uci.edu/3432 )
Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
..
[NO ISSUE][OTH] Simplify ResultJobRecord APIs
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Simplify ResultJobRecord APIs by allowing only a single ResultSetId
per ResultJobRecord (i.e. per job).
- Fail result partition registration when a job attempts to use
multiple ResultSetIds or inconsistent number of partitions and
log the inconsistency.
- Delete test ReplicateOperatorTest which duplicates
the test PushRuntimeTest#scanReplicateWrite.
Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3432
Contrib: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Murtadha Hubail
Tested-by: Jenkins
Reviewed-by: Till Westmann
---
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/result/ResultJobRecord.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/result/ResultDirectoryService.java
D
hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/ReplicateOperatorTest.java
3 files changed, 37 insertions(+), 155 deletions(-)
Approvals:
Jenkins: Verified; ; Verified
Anon. E. Moose (1000171):
Murtadha Hubail: Looks good to me, but someone else must approve
Till Westmann: Looks good to me, approved
Objections:
Jenkins: Violations found
diff --git
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/result/ResultJobRecord.java
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/result/ResultJobRecord.java
index b3b0706..02762ee 100644
---
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/result/ResultJobRecord.java
+++
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/result/ResultJobRecord.java
@@ -21,12 +21,12 @@
import java.io.Serializable;
import java.util.ArrayList;
import java.util.Arrays;
-import java.util.HashMap;
import java.util.List;
-import java.util.Map;
import org.apache.hyracks.api.exceptions.ErrorCode;
import org.apache.hyracks.api.exceptions.HyracksDataException;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
public class ResultJobRecord implements IResultStateRecord {
@@ -77,15 +77,13 @@
}
private static final long serialVersionUID = 1L;
-
+private static final Logger LOGGER = LogManager.getLogger();
private final long timestamp;
private long jobStartTime;
private long jobEndTime;
private Status status;
-
+private ResultSetId rsId;
private ResultSetMetaData resultSetMetaData;
-
-private Map resultSetMetadataMap = new
HashMap<>();
public ResultJobRecord() {
this.timestamp = System.nanoTime();
@@ -116,10 +114,6 @@
updateState(State.SUCCESS);
}
-public void fail(ResultSetId rsId, int partition) {
-getOrCreateDirectoryRecord(rsId, partition).fail();
-}
-
public void fail(List exceptions) {
updateState(State.FAILED);
status.setExceptions(exceptions);
@@ -139,47 +133,40 @@
StringBuilder sb = new StringBuilder();
sb.append("{ \"status\": ").append(status.toString()).append(", ");
sb.append("\"timestamp\": ").append(timestamp).append(", ");
-sb.append("\"resultsets\":
").append(Arrays.toString(resultSetMetadataMap.entrySet().toArray())).append("
}");
+sb.append("\"resultset\": ").append(resultSetMetaData).append(" }");
return sb.toString();
}
public synchronized void setResultSetMetaData(ResultSetId rsId,
IResultMetadata metadata, int nPartitions)
throws HyracksDataException {
-ResultSetMetaData rsMd = resultSetMetadataMap.get(rsId);
-if (rsMd == null) {
-final ResultSetMetaData resultSetMetaData = new
ResultSetMetaData(nPartitions, metadata);
-resultSetMetadataMap.put(rsId, resultSetMetaData);
-this.resultSetMetaData = resultSetMetaData;
-} else if (rsMd.getRecords().length != nPartitions) {
-throw
HyracksDataException.create(ErrorCode.INCONSISTENT_RESULT_METADATA,
rsId.toString());
+if (this.rsId == null) {
+this.rsId = rsId;
+this.resultSetMetaData = new ResultSetMetaData(nPartitions,
metadata);
+} else if (!this.rsId.equals(rsId) ||
resultSetMetaData.getRecords().length != nPartitions) {
+logInconsistentMetadata(rsId, nPartitions);
+throw
HyracksDataException.create(ErrorCode.INCONSISTENT_RESULT_METADATA,
this.rsId.toString());
}
-//TODO(tillw) throwing a HyracksDataException here hangs the execution
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:54:40 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Comment-Date: Mon, 10 Jun 2019 17:04:01 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: Contrib+1 Analytics Compatibility Tests Successful https://cbjenkins.page.link/5vCtGGDH15NkrLAw6 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 10 Jun 2019 17:03:24 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5903/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 10 Jun 2019 17:02:29 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8682/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 10 Jun 2019 16:40:58 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4519/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 10 Jun 2019 15:49:24 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1270/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 10 Jun 2019 15:37:40 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/B7bUMD9JdBQNcAAF8 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 10 Jun 2019 15:33:32 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4519/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 10 Jun 2019 15:32:33 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8682/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 10 Jun 2019 15:30:19 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Hello Anon. E. Moose (1000171), Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3432 to look at the new patch set (#2). Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. [NO ISSUE][OTH] Simplify ResultJobRecord APIs - user model changes: no - storage format changes: no - interface changes: no Details: - Simplify ResultJobRecord APIs by allowing only a single ResultSetId per ResultJobRecord (i.e. per job). - Fail result partition registration when a job attempts to use multiple ResultSetIds or inconsistent number of partitions and log the inconsistency. - Delete test ReplicateOperatorTest which duplicates the test PushRuntimeTest#scanReplicateWrite. Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f --- M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/result/ResultJobRecord.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/result/ResultDirectoryService.java D hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/ReplicateOperatorTest.java 3 files changed, 37 insertions(+), 155 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/32/3432/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5902/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 10 Jun 2019 15:29:33 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5884/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 10 Jun 2019 15:29:31 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5925/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 10 Jun 2019 15:29:37 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5821/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 10 Jun 2019 15:29:42 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/843/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 10 Jun 2019 15:29:39 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/682/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 10 Jun 2019 15:29:35 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11394/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 10 Jun 2019 15:29:19 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/6066/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 10 Jun 2019 15:29:29 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6125/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 10 Jun 2019 15:29:20 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3911/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 10 Jun 2019 15:29:27 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6275/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 10 Jun 2019 15:29:23 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1176/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 10 Jun 2019 15:29:21 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1081/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 10 Jun 2019 15:29:25 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6485/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 10 Jun 2019 15:29:21 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9861/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 10 Jun 2019 15:29:20 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://cbjenkins.page.link/Zok7tsa5BjEqgAAR6 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 09 Jun 2019 03:25:02 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8674/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 09 Jun 2019 03:04:42 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4512/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 09 Jun 2019 02:08:23 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 1: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/LKTsbkgpZNgvtqsb6 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 09 Jun 2019 01:55:18 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4512/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 09 Jun 2019 01:54:22 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8674/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 09 Jun 2019 01:52:39 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/835/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 09 Jun 2019 01:51:42 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6117/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 09 Jun 2019 01:51:26 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5917/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 09 Jun 2019 01:51:25 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6267/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 09 Jun 2019 01:51:38 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1073/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 09 Jun 2019 01:51:32 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1262/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 09 Jun 2019 01:51:34 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6477/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 09 Jun 2019 01:51:29 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5894/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 09 Jun 2019 01:51:41 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Murtadha Hubail has uploaded this change for review. (
https://asterix-gerrit.ics.uci.edu/3432
Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
..
[NO ISSUE][OTH] Simplify ResultJobRecord APIs
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Simplify ResultJobRecord APIs by allowing only a single ResultSetId
per ResultJobRecord (i.e. per job).
- Fail result partition registration when a job attempts to use
multiple ResultSetIds or inconsistent number of partitions and
log the inconsistency.
- Remove unused methods.
Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f
---
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/result/ResultJobRecord.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/result/ResultDirectoryService.java
2 files changed, 37 insertions(+), 39 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/32/3432/1
diff --git
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/result/ResultJobRecord.java
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/result/ResultJobRecord.java
index b3b0706..eebfd9d 100644
---
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/result/ResultJobRecord.java
+++
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/result/ResultJobRecord.java
@@ -21,12 +21,12 @@
import java.io.Serializable;
import java.util.ArrayList;
import java.util.Arrays;
-import java.util.HashMap;
import java.util.List;
-import java.util.Map;
import org.apache.hyracks.api.exceptions.ErrorCode;
import org.apache.hyracks.api.exceptions.HyracksDataException;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
public class ResultJobRecord implements IResultStateRecord {
@@ -77,15 +77,13 @@
}
private static final long serialVersionUID = 1L;
-
+private static final Logger LOGGER = LogManager.getLogger();
private final long timestamp;
private long jobStartTime;
private long jobEndTime;
private Status status;
-
+private ResultSetId rsId;
private ResultSetMetaData resultSetMetaData;
-
-private Map resultSetMetadataMap = new
HashMap<>();
public ResultJobRecord() {
this.timestamp = System.nanoTime();
@@ -116,10 +114,6 @@
updateState(State.SUCCESS);
}
-public void fail(ResultSetId rsId, int partition) {
-getOrCreateDirectoryRecord(rsId, partition).fail();
-}
-
public void fail(List exceptions) {
updateState(State.FAILED);
status.setExceptions(exceptions);
@@ -139,47 +133,40 @@
StringBuilder sb = new StringBuilder();
sb.append("{ \"status\": ").append(status.toString()).append(", ");
sb.append("\"timestamp\": ").append(timestamp).append(", ");
-sb.append("\"resultsets\":
").append(Arrays.toString(resultSetMetadataMap.entrySet().toArray())).append("
}");
+sb.append("\"resultset\": ").append(resultSetMetaData).append(" }");
return sb.toString();
}
public synchronized void setResultSetMetaData(ResultSetId rsId,
IResultMetadata metadata, int nPartitions)
throws HyracksDataException {
-ResultSetMetaData rsMd = resultSetMetadataMap.get(rsId);
-if (rsMd == null) {
-final ResultSetMetaData resultSetMetaData = new
ResultSetMetaData(nPartitions, metadata);
-resultSetMetadataMap.put(rsId, resultSetMetaData);
-this.resultSetMetaData = resultSetMetaData;
-} else if (rsMd.getRecords().length != nPartitions) {
-throw
HyracksDataException.create(ErrorCode.INCONSISTENT_RESULT_METADATA,
rsId.toString());
+if (this.rsId == null) {
+this.rsId = rsId;
+this.resultSetMetaData = new ResultSetMetaData(nPartitions,
metadata);
+} else if (!this.rsId.equals(rsId) ||
resultSetMetaData.getRecords().length != nPartitions) {
+logInconsistentMetadata(rsId, nPartitions);
+throw
HyracksDataException.create(ErrorCode.INCONSISTENT_RESULT_METADATA,
this.rsId.toString());
}
-//TODO(tillw) throwing a HyracksDataException here hangs the execution
tests
}
-public ResultSetMetaData getResultSetMetaData(ResultSetId rsId) {
-return resultSetMetadataMap.get(rsId);
-}
-
-public synchronized ResultDirectoryRecord
getOrCreateDirectoryRecord(ResultSetId rsId, int partition) {
-ResultDirectoryRecord[] records =
getResultSetMetaData(rsId).getRecords();
+public synchronized ResultDirectoryRecord getOrCreateDirectoryRecord(int
partition) {
+ResultDirectoryRecord[] records = resultSetMetaData.getRecords();
if (records[partition] == null) {
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3903/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 09 Jun 2019 01:51:27 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5813/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 09 Jun 2019 01:51:24 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11386/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 09 Jun 2019 01:51:26 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9853/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 09 Jun 2019 01:51:36 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/674/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 09 Jun 2019 01:51:24 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1168/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 09 Jun 2019 01:51:31 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/6058/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 09 Jun 2019 01:51:39 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5876/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Sun, 09 Jun 2019 01:51:25 + Gerrit-HasComments: No
