Change in asterixdb[master]: [NO ISSUE][OTH] Use Log4j2 Application Context
Murtadha Hubail has submitted this change and it was merged. Change subject: [NO ISSUE][OTH] Use Log4j2 Application Context .. [NO ISSUE][OTH] Use Log4j2 Application Context - user model changes: no - storage format changes: no - interface changes: no Details: - Instead of using Log4j2's default LoggerContext, use the application context to avoid using incorrect configuration for loggers. Change-Id: Iea86ddc7a505b8f2c816cc4887a6dc46871ae76d Reviewed-on: https://asterix-gerrit.ics.uci.edu/3116 Reviewed-by: Ali Alsuliman Tested-by: Jenkins Integration-Tests: Jenkins Contrib: Jenkins --- M hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/LoggingConfigUtil.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ali Alsuliman: Looks good to me, approved Jenkins: Verified; ; Verified Objections: Anon. E. Moose #1000171: Violations found Jenkins: Violations found diff --git a/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/LoggingConfigUtil.java b/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/LoggingConfigUtil.java index a98c241..cf274af 100644 --- a/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/LoggingConfigUtil.java +++ b/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/LoggingConfigUtil.java @@ -34,7 +34,7 @@ } public static void defaultIfMissing(String logger, Level defaultLvl) { -final Configuration loggingConfig = LoggerContext.getContext().getConfiguration(); +final Configuration loggingConfig = LoggerContext.getContext(false).getConfiguration(); final LoggerConfig loggerConfig = loggingConfig.getLoggers().get(logger); if (loggerConfig != null) { LOGGER.info("{} log level is {}", logger, loggerConfig.getLevel()); -- To view, visit https://asterix-gerrit.ics.uci.edu/3116 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea86ddc7a505b8f2c816cc4887a6dc46871ae76d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail
Change in asterixdb[master]: [NO ISSUE][OTH] Use Log4j2 Application Context
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTH] Use Log4j2 Application Context .. Patch Set 1: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/HC9myd : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3116 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea86ddc7a505b8f2c816cc4887a6dc46871ae76d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Use Log4j2 Application Context
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Use Log4j2 Application Context .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3897/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3116 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea86ddc7a505b8f2c816cc4887a6dc46871ae76d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Use Log4j2 Application Context
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Use Log4j2 Application Context .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7767/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3116 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea86ddc7a505b8f2c816cc4887a6dc46871ae76d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Use Log4j2 Application Context
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Use Log4j2 Application Context .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3897/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3116 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea86ddc7a505b8f2c816cc4887a6dc46871ae76d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Use Log4j2 Application Context
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Use Log4j2 Application Context .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5281/ (14/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3116 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea86ddc7a505b8f2c816cc4887a6dc46871ae76d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Use Log4j2 Application Context
Ali Alsuliman has posted comments on this change. Change subject: [NO ISSUE][OTH] Use Log4j2 Application Context .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3116 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea86ddc7a505b8f2c816cc4887a6dc46871ae76d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Use Log4j2 Application Context
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Use Log4j2 Application Context .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4950/ (13/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3116 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea86ddc7a505b8f2c816cc4887a6dc46871ae76d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Use Log4j2 Application Context
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTH] Use Log4j2 Application Context .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/ZuR7KL : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3116 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea86ddc7a505b8f2c816cc4887a6dc46871ae76d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Use Log4j2 Application Context
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Use Log4j2 Application Context .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7767/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3116 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea86ddc7a505b8f2c816cc4887a6dc46871ae76d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Use Log4j2 Application Context
Murtadha Hubail has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/3116 Change subject: [NO ISSUE][OTH] Use Log4j2 Application Context .. [NO ISSUE][OTH] Use Log4j2 Application Context - user model changes: no - storage format changes: no - interface changes: no Details: - Instead of using Log4j2's default LoggerContext, use the application context to avoid using incorrect configuration for loggers. Change-Id: Iea86ddc7a505b8f2c816cc4887a6dc46871ae76d --- M hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/LoggingConfigUtil.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/16/3116/1 diff --git a/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/LoggingConfigUtil.java b/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/LoggingConfigUtil.java index a98c241..cf274af 100644 --- a/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/LoggingConfigUtil.java +++ b/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/LoggingConfigUtil.java @@ -34,7 +34,7 @@ } public static void defaultIfMissing(String logger, Level defaultLvl) { -final Configuration loggingConfig = LoggerContext.getContext().getConfiguration(); +final Configuration loggingConfig = LoggerContext.getContext(false).getConfiguration(); final LoggerConfig loggerConfig = loggingConfig.getLoggers().get(logger); if (loggerConfig != null) { LOGGER.info("{} log level is {}", logger, loggerConfig.getLevel()); -- To view, visit https://asterix-gerrit.ics.uci.edu/3116 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iea86ddc7a505b8f2c816cc4887a6dc46871ae76d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail
Change in asterixdb[master]: [NO ISSUE][OTH] Use Log4j2 Application Context
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Use Log4j2 Application Context .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/347/ (8/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3116 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea86ddc7a505b8f2c816cc4887a6dc46871ae76d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Use Log4j2 Application Context
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Use Log4j2 Application Context .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8891/ (11/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3116 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea86ddc7a505b8f2c816cc4887a6dc46871ae76d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Use Log4j2 Application Context
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Use Log4j2 Application Context .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5512/ (2/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3116 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea86ddc7a505b8f2c816cc4887a6dc46871ae76d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Use Log4j2 Application Context
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Use Log4j2 Application Context .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/352/ (10/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3116 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea86ddc7a505b8f2c816cc4887a6dc46871ae76d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Use Log4j2 Application Context
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Use Log4j2 Application Context .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/108/ (7/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3116 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea86ddc7a505b8f2c816cc4887a6dc46871ae76d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Use Log4j2 Application Context
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Use Log4j2 Application Context .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4854/ (3/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3116 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea86ddc7a505b8f2c816cc4887a6dc46871ae76d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Use Log4j2 Application Context
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Use Log4j2 Application Context .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2952/ (9/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3116 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea86ddc7a505b8f2c816cc4887a6dc46871ae76d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Use Log4j2 Application Context
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Use Log4j2 Application Context .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4942/ (4/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3116 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea86ddc7a505b8f2c816cc4887a6dc46871ae76d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Use Log4j2 Application Context
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Use Log4j2 Application Context .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5165/ (12/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3116 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea86ddc7a505b8f2c816cc4887a6dc46871ae76d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Use Log4j2 Application Context
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Use Log4j2 Application Context .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10424/ (5/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3116 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea86ddc7a505b8f2c816cc4887a6dc46871ae76d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Use Log4j2 Application Context
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Use Log4j2 Application Context .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4908/ (1/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3116 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea86ddc7a505b8f2c816cc4887a6dc46871ae76d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Use Log4j2 Application Context
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Use Log4j2 Application Context .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5326/ (6/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3116 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea86ddc7a505b8f2c816cc4887a6dc46871ae76d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No