Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2792/ 
(7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3340/ (1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://goo.gl/KzKq8B : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3027/ 
(7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 2:

Analytics Compatibility Compilation Successful
https://goo.gl/87WHTN : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2767/ 
(6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/816/ 
(8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2801/
 (9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2768/ 
(2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Michael Blow (Code Review)
Michael Blow has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2415

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..

[NO ISSUE] Add Invoke.runUninterruptible

Add helper method to clear interruption and restore around invocation of an
action

Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
---
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/InvokeUtil.java
1 file changed, 33 insertions(+), 12 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/15/2415/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/InvokeUtil.java
 
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/InvokeUtil.java
index 9b356a0..bdaf479 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/InvokeUtil.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/InvokeUtil.java
@@ -39,7 +39,7 @@
  * Executes the passed interruptible, retrying if the operation is 
interrupted. Once the interruptible
  * completes, the current thread will be re-interrupted, if the original 
operation was interrupted.
  */
-public static void doUninterruptibly(Interruptible interruptible) {
+public static void doUninterruptibly(InterruptibleAction interruptible) {
 boolean interrupted = false;
 try {
 while (true) {
@@ -58,10 +58,10 @@
 }
 
 /**
- * Executes the passed interruptible, retrying if the operation is 
interrupted. Once the interruptible
+ * Executes the passed action, retrying if the operation is interrupted. 
Once the interruptible
  * completes, the current thread will be re-interrupted, if the original 
operation was interrupted.
  */
-public static void doExUninterruptibly(ThrowingInterruptible 
interruptible) throws Exception {
+public static void doExUninterruptibly(ThrowingAction interruptible) 
throws Exception {
 boolean interrupted = false;
 try {
 while (true) {
@@ -84,7 +84,7 @@
  *
  * @return true if the original operation was interrupted, otherwise false
  */
-public static boolean doUninterruptiblyGet(Interruptible interruptible) {
+public static boolean doUninterruptiblyGet(InterruptibleAction 
interruptible) {
 boolean interrupted = false;
 while (true) {
 try {
@@ -103,12 +103,12 @@
  *
  * @return true if the original operation was interrupted, otherwise false
  */
-public static boolean doExUninterruptiblyGet(ThrowingInterruptible 
interruptible) throws Exception {
+public static boolean doExUninterruptiblyGet(Callable interruptible) 
throws Exception {
 boolean interrupted = false;
 boolean success = false;
 while (true) {
 try {
-interruptible.run();
+interruptible.call();
 success = true;
 break;
 } catch (InterruptedException e) { // NOSONAR- contract states 
caller must handle
@@ -154,7 +154,7 @@
  * {@link InterruptedException}. Once the interruptible completes, the 
current thread will be re-interrupted, if
  * the original operation was interrupted.
  */
-public static void doIoUninterruptibly(ThrowingIOInterruptible 
interruptible) throws IOException {
+public static void doIoUninterruptibly(IOInterruptibleAction 
interruptible) throws IOException {
 boolean interrupted = false;
 try {
 while (true) {
@@ -175,7 +175,7 @@
 }
 
 @SuppressWarnings({ "squid:S1181", "squid:S1193" }) // catching Throwable, 
instanceof of exception
-public static void tryWithCleanups(ThrowingInterruptible action, 
ThrowingInterruptible... cleanups)
+public static void tryWithCleanups(ThrowingAction action, 
ThrowingAction... cleanups)
 throws Exception {
 Throwable savedT = null;
 boolean suppressedInterrupted = false;
@@ -184,7 +184,7 @@
 } catch (Throwable t) {
 savedT = t;
 } finally {
-for (ThrowingInterruptible cleanup : cleanups) {
+for (ThrowingAction cleanup : cleanups) {
 try {
 cleanup.run();
 } catch (Throwable t) {
@@ -212,18 +212,39 @@
 }
 }
 
+/**
+ * Runs the supplied action, after suspending any pending interruption.  
An error will be logged if
+ * the action is itself interrupted.
+ */
+public static void runUninterruptible(ThrowingAction action) throws 
Exception {
+boolean interrupted = Thread.interrupted();
+try {
+action.run();
+if (Thread.interrupted()) {
+throw new InterruptedException();
+}
+} catch (Interrup

Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Michael Blow (Code Review)
Michael Blow has uploaded a new patch set (#2).

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..

[NO ISSUE] Add Invoke.runUninterruptible

Add helper method to clear interruption and restore around invocation of an
action

Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
---
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/InvokeUtil.java
1 file changed, 33 insertions(+), 13 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/15/2415/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6759/ (3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/817/ 
(4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2793/ 
(1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6760/ (8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2802/
 (9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Murtadha Hubail (Code Review)
Murtadha Hubail has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 2: Code-Review+2 Integration-Tests+1 Verified+1

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2750/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2720/ 
(4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3026/ 
(2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 2: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2750/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Michael Blow (Code Review)
Michael Blow has submitted this change and it was merged.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


[NO ISSUE] Add Invoke.runUninterruptible

Add helper method to clear interruption and restore around invocation of an
action

Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2415
Sonar-Qube: Jenkins 
Reviewed-by: Murtadha Hubail 
Integration-Tests: Murtadha Hubail 
Tested-by: Murtadha Hubail 
Contrib: Jenkins 
---
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/InvokeUtil.java
1 file changed, 33 insertions(+), 13 deletions(-)

Approvals:
  Jenkins: No violations found; 
  Murtadha Hubail: Looks good to me, approved; Verified; Verified



diff --git 
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/InvokeUtil.java
 
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/InvokeUtil.java
index 9b356a0..ba4f82d 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/InvokeUtil.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/InvokeUtil.java
@@ -39,7 +39,7 @@
  * Executes the passed interruptible, retrying if the operation is 
interrupted. Once the interruptible
  * completes, the current thread will be re-interrupted, if the original 
operation was interrupted.
  */
-public static void doUninterruptibly(Interruptible interruptible) {
+public static void doUninterruptibly(InterruptibleAction interruptible) {
 boolean interrupted = false;
 try {
 while (true) {
@@ -58,10 +58,10 @@
 }
 
 /**
- * Executes the passed interruptible, retrying if the operation is 
interrupted. Once the interruptible
+ * Executes the passed action, retrying if the operation is interrupted. 
Once the interruptible
  * completes, the current thread will be re-interrupted, if the original 
operation was interrupted.
  */
-public static void doExUninterruptibly(ThrowingInterruptible 
interruptible) throws Exception {
+public static void doExUninterruptibly(ThrowingAction interruptible) 
throws Exception {
 boolean interrupted = false;
 try {
 while (true) {
@@ -84,7 +84,7 @@
  *
  * @return true if the original operation was interrupted, otherwise false
  */
-public static boolean doUninterruptiblyGet(Interruptible interruptible) {
+public static boolean doUninterruptiblyGet(InterruptibleAction 
interruptible) {
 boolean interrupted = false;
 while (true) {
 try {
@@ -103,12 +103,12 @@
  *
  * @return true if the original operation was interrupted, otherwise false
  */
-public static boolean doExUninterruptiblyGet(ThrowingInterruptible 
interruptible) throws Exception {
+public static boolean doExUninterruptiblyGet(Callable interruptible) 
throws Exception {
 boolean interrupted = false;
 boolean success = false;
 while (true) {
 try {
-interruptible.run();
+interruptible.call();
 success = true;
 break;
 } catch (InterruptedException e) { // NOSONAR- contract states 
caller must handle
@@ -154,7 +154,7 @@
  * {@link InterruptedException}. Once the interruptible completes, the 
current thread will be re-interrupted, if
  * the original operation was interrupted.
  */
-public static void doIoUninterruptibly(ThrowingIOInterruptible 
interruptible) throws IOException {
+public static void doIoUninterruptibly(IOInterruptibleAction 
interruptible) throws IOException {
 boolean interrupted = false;
 try {
 while (true) {
@@ -175,8 +175,7 @@
 }
 
 @SuppressWarnings({ "squid:S1181", "squid:S1193" }) // catching Throwable, 
instanceof of exception
-public static void tryWithCleanups(ThrowingInterruptible action, 
ThrowingInterruptible... cleanups)
-throws Exception {
+public static void tryWithCleanups(ThrowingAction action, 
ThrowingAction... cleanups) throws Exception {
 Throwable savedT = null;
 boolean suppressedInterrupted = false;
 try {
@@ -184,7 +183,7 @@
 } catch (Throwable t) {
 savedT = t;
 } finally {
-for (ThrowingInterruptible cleanup : cleanups) {
+for (ThrowingAction cleanup : cleanups) {
 try {
 cleanup.run();
 } catch (Throwable t) {
@@ -212,18 +211,39 @@
 }
 }
 
+/**
+ * Runs the supplied action, after suspending any pending interruption.  
An error will be logged if
+ * the action is itself interrupted.
+ */
+public static void runUninterruptible(ThrowingAction action) throws 
Exception {
+boolean

Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5723/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3543/ (10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3282/
 (11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3306/ 
(12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2721/ 
(6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3341/ (5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 2:

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5723/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8267/ (3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible

2018-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8266/ (5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2415
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No