Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 9:

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2227/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 9:

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/829/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 9:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/829/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Xikui Wang (Code Review)]

Xikui Wang has submitted this change and it was merged.

Change subject: Feed Exception Revise
..


Feed Exception Revise

1. Add compliation exception for missing Twitter4J library. Try to
expose this exception when create feed.
2. Tweaked 'invalid feed parameter exception'. Expose detailed exception
information to front end.
3. Related test cases fix.

Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1534
Reviewed-by: Michael Blow 
Tested-by: Michael Blow 
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/connect-feed/connect-feed.0.ddl.aql
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M 
asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/statement/SubscribeFeedStatement.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataException.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
8 files changed, 32 insertions(+), 23 deletions(-)

Approvals:
  Michael Blow: Looks good to me, approved; Verified



diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/connect-feed/connect-feed.0.ddl.aql
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/connect-feed/connect-feed.0.ddl.aql
index 8a13210..9237c1e 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/connect-feed/connect-feed.0.ddl.aql
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/connect-feed/connect-feed.0.ddl.aql
@@ -37,10 +37,10 @@
 create dataset Tweets3 (Tweet)
 primary key id;
 
-create feed TwitterFeed using push_twitter(
-("type-name"="Tweet"),
-("format"="twitter-status"),
-("consumer.key"=""),
-("consumer.secret"=""),
-("access.token"=""),
-("access.token.secret"=""));
+create feed TwitterFeed using socket_adapter
+(
+("sockets"="127.0.0.1:10001"),
+("address-type"="IP"),
+("type-name"="Tweet"),
+("format"="adm")
+);
\ No newline at end of file
diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml 
b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
index 29998fd..5df39db 100644
--- a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
@@ -153,15 +153,15 @@
 
   
 twitter-feed
-One or more parameters are missing from adapter 
configuration
-Unknown source feed
+Twitter4J library not found!
+Unknown source feed: TwitterFeed
   
 
 
   
 revised-tweet-parser
-One or more parameters are missing from adapter 
configuration
-Unknown source feed
+Twitter4J library not found!
+Unknown source feed: TwitterFeed
   
 
 
diff --git 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
index 8f859c7..96ac491 100644
--- 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
+++ 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
@@ -93,9 +93,9 @@
 public static final int 
OPERATORS_FEED_INTAKE_OPERATOR_DESCRIPTOR_CLASSLOADER_NOT_CONFIGURED = 3004;
 public static final int PARSER_DELIMITED_NONOPTIONAL_NULL = 3005;
 public static final int PARSER_DELIMITED_ILLEGAL_FIELD = 3006;
-public static final int 
FEED_MANAGEMENT_ACTIVE_LIFE_CYCLE_EVENT_SUBSCRIBER_ACTIVE_JOB_FAILURE = 3007;
+public static final int ADAPTER_TWITTER_TWITTER4J_LIB_NOT_FOUND = 3007;
 public static final int 
OPERATORS_FEED_INTAKE_OPERATOR_NODE_PUSHABLE_FAIL_AT_INGESTION = 3008;
-public static final int 
OPERATORS_FEED_MSG_OPERATOR_NODE_PUSHABLE_INVALID_SUBSCRIBABLE_RUNTIME = 3009;
+public static final int FEED_CREATE_FEED_DATATYPE_ERROR = 3009;
 public static final int PARSER_HIVE_NON_PRIMITIVE_LIST_NOT_SUPPORT = 3010;
 public static final int PARSER_HIVE_FIELD_TYPE = 3011;
 public static final int PARSER_HIVE_GET_COLUMNS = 3012;
diff --git 
a/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties 
b/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
index bf9c6f9..a0bfab9 100644
--- a/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
+++ 

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 9:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2227/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 9: Verified+1

carrying forward Verified+1

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 9:

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2205/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 9:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2205/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 9: Integration-Tests-1

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2191/ 
: ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 9: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 9:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2191/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 9:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/801/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/8/ (2/2)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4689/ (1/2)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Michael Blow (Code Review)]

Hello Xikui Wang, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1534

to look at the new patch set (#8).

Change subject: Feed Exception Revise
..

Feed Exception Revise

1. Add compliation exception for missing Twitter4J library. Try to
expose this exception when create feed.
2. Tweaked 'invalid feed parameter exception'. Expose detailed exception
information to front end.
3. Related test cases fix.

Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/connect-feed/connect-feed.0.ddl.aql
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M 
asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/statement/SubscribeFeedStatement.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataException.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
8 files changed, 32 insertions(+), 23 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/34/1534/8
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 6: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2178/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4667/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Xikui Wang (Code Review)]

Hello Michael Blow, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1534

to look at the new patch set (#7).

Change subject: Feed Exception Revise
..

Feed Exception Revise

1. Add compliation exception for missing Twitter4J library. Try to
expose this exception when create feed.
2. Tweaked 'invalid feed parameter exception'. Expose detailed exception
information to front end.
3. Related test cases fix.

Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/connect-feed/connect-feed.0.ddl.aql
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M 
asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/statement/SubscribeFeedStatement.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataException.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
8 files changed, 32 insertions(+), 23 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/34/1534/7
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 6: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/788/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 6:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1534/6/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java:

PS6, Line 96: O
/ADAPTOR/ADAPTER/


https://asterix-gerrit.ics.uci.edu/#/c/1534/6/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties:

PS6, Line 84:   
extra space


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 6:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/788/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 6:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2178/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4665/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 5: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2156/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 5: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/769/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 5:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/769/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2156/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4629/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Xikui Wang (Code Review)]

Xikui Wang has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 4: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/742/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2122/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 4:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/742/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4591/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 3:

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/740/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 3:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/740/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 3:

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/693/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 3:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/693/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 3: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2035/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2035/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 3: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2033/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 3: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/658/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 3:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/658/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4477/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4469/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Xikui Wang (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1534

to look at the new patch set (#2).

Change subject: Feed Exception Revise
..

Feed Exception Revise

1. Add compliation exception for missing Twitter4J library. Try to
expose this exception when create feed.
2. Removed 'invalid feed parameter exception'. Expose detailed exception
information to front end.

Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
---
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M 
asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/statement/SubscribeFeedStatement.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataException.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
6 files changed, 21 insertions(+), 12 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/34/1534/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: Feed Exception Revise

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Feed Exception Revise
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4460/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1534
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Feed Exception Revise

[Xikui Wang (Code Review)]

Xikui Wang has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1534

Change subject: Feed Exception Revise
..

Feed Exception Revise

1. Add compliation exception for missing Twitter4J library. Try to
expose this exception when create feed.
2. Removed 'invalid feed parameter exception'. Expose detailed exception
information to front end.

Change-Id: Iee65b2a5365067c9ba2aa1615ac23f0ace41b51e
---
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M 
asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/statement/SubscribeFeedStatement.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataException.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
6 files changed, 21 insertions(+), 12 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/34/1534/1

diff --git 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
index 83ff3a2..b03ed0f 100644
--- 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
+++ 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
@@ -87,9 +87,9 @@
 public static final int 
OPERATORS_FEED_INTAKE_OPERATOR_DESCRIPTOR_CLASSLOADER_NOT_CONFIGURED = 3004;
 public static final int PARSER_DELIMITED_NONOPTIONAL_NULL = 3005;
 public static final int PARSER_DELIMITED_ILLEGAL_FIELD = 3006;
-public static final int 
FEED_MANAGEMENT_ACTIVE_LIFE_CYCLE_EVENT_SUBSCRIBER_ACTIVE_JOB_FAILURE = 3007;
+public static final int ADAPTOR_TWITTER_TWITTER4J_LIB_NOT_FOUND = 3007;
 public static final int 
OPERATORS_FEED_INTAKE_OPERATOR_NODE_PUSHABLE_FAIL_AT_INGESTION = 3008;
-public static final int 
OPERATORS_FEED_MSG_OPERATOR_NODE_PUSHABLE_INVALID_SUBSCRIBABLE_RUNTIME = 3009;
+public static final int FEED_CREATE_FEED_DATATYPE_ERROR = 3009;
 public static final int PARSER_HIVE_NON_PRIMITIVE_LIST_NOT_SUPPORT = 3010;
 public static final int PARSER_HIVE_FIELD_TYPE = 3011;
 public static final int PARSER_HIVE_GET_COLUMNS = 3012;
diff --git 
a/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties 
b/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
index 3e96972..9373a0f 100644
--- a/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
+++ b/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
@@ -72,9 +72,9 @@
 3004 = Unable to create adapter as class loader not configured for library 
%1$s in dataverse %2$s
 3005 = At record: %1$s - Field %2$s is not privatean optional type so it 
cannot accept null value.
 3006 = Illegal field %1$s in closed type %2$s
-3007 = Failure in active job.
+3007 = Twitter4J library not found!
 3008 = Unable to ingest data
-3009 = Invalid subscribable runtime type %1$s
+3009 = Exception in get record type  %1$s for feed
 3010 = Doesn't support Hive data with list of non-primitive types
 3011 = Can't get hive type for field of type %1$s
 3012 = Failed to get columns of record
diff --git 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
index 1428863..88d6898 100644
--- 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
+++ 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
@@ -38,6 +38,7 @@
 import org.apache.asterix.external.util.ExternalDataUtils;
 import org.apache.hyracks.algebricks.common.exceptions.AlgebricksException;
 import org.apache.hyracks.api.exceptions.HyracksDataException;
+import twitter4j.conf.ConfigurationBuilder;
 
 public class DatasourceFactoryProvider {
 
@@ -108,6 +109,11 @@
 case ExternalDataConstants.READER_PUSH_TWITTER:
 case ExternalDataConstants.READER_PULL_TWITTER:
 case ExternalDataConstants.READER_USER_STREAM_TWITTER:
+try {
+ConfigurationBuilder cb = new ConfigurationBuilder();
+} catch (NoClassDefFoundError e) {
+throw new 
RuntimeDataException(ErrorCode.ADAPTOR_TWITTER_TWITTER4J_LIB_NOT_FOUND);
+}
 return new TwitterRecordReaderFactory();
 case ExternalDataConstants.ALIAS_SOCKET_ADAPTER:
 case