Change in asterixdb[master]: Fix ASTERIXDB-1255
Jenkins has posted comments on this change. Change subject: Fix ASTERIXDB-1255 .. Patch Set 8: BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/57/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri RamampiaroGerrit-Reviewer: Chen Li Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Fix ASTERIXDB-1255
Till Westmann has submitted this change and it was merged. Change subject: Fix ASTERIXDB-1255 .. Fix ASTERIXDB-1255 This changes enable dynamic hashtable size in SimilarityJaccardEvaluator Change-Id: I08c550d35d864df08792369d38ff81012e3976af Reviewed-on: https://asterix-gerrit.ics.uci.edu/586 Sonar-Qube: JenkinsTested-by: Jenkins Integration-Tests: Jenkins Reviewed-by: Till Westmann --- M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/SimilarityJaccardEvaluator.java 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: Till Westmann: Looks good to me, approved Jenkins: Verified; No violations found; Verified Objections: Jenkins: Violations found diff --git a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/SimilarityJaccardEvaluator.java b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/SimilarityJaccardEvaluator.java index e9928a1..ab817bd 100644 --- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/SimilarityJaccardEvaluator.java +++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/SimilarityJaccardEvaluator.java @@ -50,11 +50,11 @@ public class SimilarityJaccardEvaluator implements IScalarEvaluator { // Parameters for hash table. -protected final int TABLE_SIZE = 100; -protected final int TABLE_FRAME_SIZE = 32768; +protected static final int MIN_TABLE_SIZE = 100; +protected static final int TABLE_FRAME_SIZE = 32768; // Assuming type indicator in serde format. -protected final int TYPE_INDICATOR_SIZE = 1; +protected static final int TYPE_INDICATOR_SIZE = 1; protected final ArrayBackedValueStorage resultStorage = new ArrayBackedValueStorage(); protected final DataOutput out = resultStorage.getDataOutput(); @@ -88,6 +88,8 @@ // Ignore case for strings. Defaults to true. protected final boolean ignoreCase = true; + +protected int hashTableSize = MIN_TABLE_SIZE; public SimilarityJaccardEvaluator(IScalarEvaluatorFactory[] args, IHyracksTaskContext context) throws HyracksDataException { @@ -140,6 +142,10 @@ if (firstListIter.size() == 0 || secondListIter.size() == 0) { return false; } + +// Set the size of the table dynamically +hashTableSize = Math.max(Math.max(firstListIter.size(), secondListIter.size()), MIN_TABLE_SIZE); + // TODO: Check item types are compatible. return true; } @@ -229,7 +235,7 @@ .createBinaryHashFunction(probeItemTypeTag, ignoreCase); IBinaryComparator cmp = ListItemBinaryComparatorFactory.INSTANCE.createBinaryComparator(buildItemTypeTag, probeItemTypeTag, ignoreCase); -hashMap = new BinaryHashMap(TABLE_SIZE, TABLE_FRAME_SIZE, putHashFunc, getHashFunc, cmp); +hashMap = new BinaryHashMap(hashTableSize, TABLE_FRAME_SIZE, putHashFunc, getHashFunc, cmp); } protected boolean checkArgTypes(ATypeTag typeTag1, ATypeTag typeTag2) throws HyracksDataException { -- To view, visit https://asterix-gerrit.ics.uci.edu/586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri Ramampiaro Gerrit-Reviewer: Chen Li Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: Fix ASTERIXDB-1255
Till Westmann has posted comments on this change. Change subject: Fix ASTERIXDB-1255 .. Patch Set 8: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri RamampiaroGerrit-Reviewer: Chen Li Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Fix ASTERIXDB-1255
Jenkins has posted comments on this change. Change subject: Fix ASTERIXDB-1255 .. Patch Set 8: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1330/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri RamampiaroGerrit-Reviewer: Chen Li Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Fix ASTERIXDB-1255
Jenkins has posted comments on this change. Change subject: Fix ASTERIXDB-1255 .. Patch Set 8: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/57/ -- To view, visit https://asterix-gerrit.ics.uci.edu/586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri RamampiaroGerrit-Reviewer: Chen Li Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Fix ASTERIXDB-1255
Jenkins has posted comments on this change. Change subject: Fix ASTERIXDB-1255 .. Patch Set 8: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/54/ -- To view, visit https://asterix-gerrit.ics.uci.edu/586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri RamampiaroGerrit-Reviewer: Chen Li Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Fix ASTERIXDB-1255
Jenkins has posted comments on this change. Change subject: Fix ASTERIXDB-1255 .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3564/ -- To view, visit https://asterix-gerrit.ics.uci.edu/586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri RamampiaroGerrit-Reviewer: Chen Li Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Fix ASTERIXDB-1255
Hello Yingyi Bu, Till Westmann, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/586 to look at the new patch set (#8). Change subject: Fix ASTERIXDB-1255 .. Fix ASTERIXDB-1255 This changes enable dynamic hashtable size in SimilarityJaccardEvaluator Change-Id: I08c550d35d864df08792369d38ff81012e3976af --- M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/SimilarityJaccardEvaluator.java 1 file changed, 10 insertions(+), 4 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/86/586/8 -- To view, visit https://asterix-gerrit.ics.uci.edu/586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri RamampiaroGerrit-Reviewer: Chen Li Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: Fix ASTERIXDB-1255
Till Westmann has posted comments on this change. Change subject: Fix ASTERIXDB-1255 .. Patch Set 7: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri RamampiaroGerrit-Reviewer: Chen Li Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Fix ASTERIXDB-1255
Jenkins has posted comments on this change. Change subject: Fix ASTERIXDB-1255 .. Patch Set 7: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/38/ -- To view, visit https://asterix-gerrit.ics.uci.edu/586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri RamampiaroGerrit-Reviewer: Chen Li Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Fix ASTERIXDB-1255
Jenkins has posted comments on this change. Change subject: Fix ASTERIXDB-1255 .. Patch Set 7: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1311/ -- To view, visit https://asterix-gerrit.ics.uci.edu/586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri RamampiaroGerrit-Reviewer: Chen Li Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Fix ASTERIXDB-1255
Jenkins has posted comments on this change. Change subject: Fix ASTERIXDB-1255 .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3536/ -- To view, visit https://asterix-gerrit.ics.uci.edu/586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri RamampiaroGerrit-Reviewer: Chen Li Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Fix ASTERIXDB-1255
Hello Yingyi Bu, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/586 to look at the new patch set (#7). Change subject: Fix ASTERIXDB-1255 .. Fix ASTERIXDB-1255 This changes enable dynamic hashtable size in SimilarityJaccardEvaluator Change-Id: I08c550d35d864df08792369d38ff81012e3976af --- M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/SimilarityJaccardEvaluator.java 1 file changed, 10 insertions(+), 4 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/86/586/7 -- To view, visit https://asterix-gerrit.ics.uci.edu/586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri RamampiaroGerrit-Reviewer: Chen Li Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: Fix ASTERIXDB-1255
Michael Blow has posted comments on this change. Change subject: Fix ASTERIXDB-1255 .. Patch Set 6: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/586/6/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/SimilarityJaccardEvaluator.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/SimilarityJaccardEvaluator.java: Line 53: protected final int MIN_TABLE_SIZE = 100; > MAJOR SonarQube violation: Done -- To view, visit https://asterix-gerrit.ics.uci.edu/586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri RamampiaroGerrit-Reviewer: Chen Li Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: Yes
Change in asterixdb[master]: Fix ASTERIXDB-1255
Jenkins has posted comments on this change. Change subject: Fix ASTERIXDB-1255 .. Patch Set 6: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1291/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri RamampiaroGerrit-Reviewer: Chen Li Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Fix ASTERIXDB-1255
Jenkins has posted comments on this change. Change subject: Fix ASTERIXDB-1255 .. Patch Set 6: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/21/ -- To view, visit https://asterix-gerrit.ics.uci.edu/586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri RamampiaroGerrit-Reviewer: Chen Li Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Fix ASTERIXDB-1255
Jenkins has posted comments on this change. Change subject: Fix ASTERIXDB-1255 .. Patch Set 6: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1291/ -- To view, visit https://asterix-gerrit.ics.uci.edu/586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri RamampiaroGerrit-Reviewer: Chen Li Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Fix ASTERIXDB-1255
Hello Yingyi Bu, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/586 to look at the new patch set (#6). Change subject: Fix ASTERIXDB-1255 .. Fix ASTERIXDB-1255 This changes enable dynamic hashtable size in SimilarityJaccardEvaluator Change-Id: I08c550d35d864df08792369d38ff81012e3976af --- M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/SimilarityJaccardEvaluator.java 1 file changed, 8 insertions(+), 2 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/86/586/6 -- To view, visit https://asterix-gerrit.ics.uci.edu/586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri RamampiaroGerrit-Reviewer: Chen Li Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: Fix ASTERIXDB-1255
Jenkins has posted comments on this change. Change subject: Fix ASTERIXDB-1255 .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3512/ -- To view, visit https://asterix-gerrit.ics.uci.edu/586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri RamampiaroGerrit-Reviewer: Chen Li Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No