Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-10 Thread Xikui Wang (Code Review)
Xikui Wang has submitted this change and it was merged.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Fix ASTERIXDB-1875 UDF in SQL++

1. Fix the bug that if a function created with SQLPP, the callExpr in
   the function body is not normalzied to list input functions.
2. Fix the bug that in SQL++ Query Rewritter, the variables are not
   expanded before the inline the functions.
3. Add test case for this issue.
4. Make SQL++ visitor visits decorVariableExpression.
5. Optimizer test cases update.

Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1666
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
BAD: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Yingyi Bu 
---
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate/constant-gby-agg.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-sugar.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-159-3.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-1671.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-1806.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/exists.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/in.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/in_correlated.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/not_exists.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/query-ASTERIXDB-1572.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1580.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581-correlated.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1591.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1596.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpch/q12_shipping.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpch/q12_shipping_broadcast.plan
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/query-ASTERIXDB-1875/query-ASTERIXDB-1298.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/query-ASTERIXDB-1875/query-ASTERIXDB-1298.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/user-defined-functions/query-ASTERIXDB-1875/query-ASTERIXDB-1875.1.adm
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/SqlppQueryRewriter.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/base/AbstractSqlppSimpleExpressionVisitor.java
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
24 files changed, 245 insertions(+), 192 deletions(-)

Approvals:
  Yingyi Bu: Looks good to me, approved
  Jenkins: Verified; No violations found; No violations found; Verified



diff --git 
a/asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate/constant-gby-agg.plan
 
b/asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate/constant-gby-agg.plan
index 94bf390..d6399f7 100644
--- 
a/asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate/constant-gby-agg.plan
+++ 
b/asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate/constant-gby-agg.plan
@@ -3,13 +3,13 @@
 -- STREAM_PROJECT  |PARTITIONED|
   -- ASSIGN  |PARTITIONED|
 -- ONE_TO_ONE_EXCHANGE  |PARTITIONED|
-  -- SORT_GROUP_BY[$$26]  |PARTITIONED|
+  -- SORT_GROUP_BY[$$20]  |PARTITIONED|
   {
 -- AGGREGATE  |LOCAL|
   -- NESTED_TUPLE_SOURCE  |LOCAL|
   }
--- HASH_PARTITION_EXCHANGE [$$26]  |PARTITIONED|
-  -- SORT_GROUP_BY[$$22]  |PARTITIONED|
+-- HASH_PARTITION_EXCHANGE [$$20]  |PARTITIONED|
+  -- SORT_GROUP_BY[$$16]  |PARTITIONED|
   {
 -- AGGREGATE  |LOCAL|
   -- NESTED_TUPLE_SOURCE  |LOCAL|
diff --git 
a/asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan 
b/asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan
index fb6d5fb..1d34c95 100644
--- a/asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan
+++ b/asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan
@@ -2,20 +2,20 @@
   -- ONE_TO_ONE_EXCHANGE  |PARTITIONED|
 -- STREAM_PROJECT  |PARTITIONED|
   -- ASSIGN  |PARTITIONED|
-   

Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-10 Thread Yingyi Bu (Code Review)
Yingyi Bu has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-10 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 6: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2483/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-10 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 6: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1000/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-10 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 6:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1000/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-10 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/44/ (6/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-10 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/3515/ (5/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-10 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 6:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2483/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-10 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/305/ (4/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-10 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/121/
 (2/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-10 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4987/ (3/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-10 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/123/ 
(1/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-10 Thread Xikui Wang (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1666

to look at the new patch set (#6).

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..

Fix ASTERIXDB-1875 UDF in SQL++

1. Fix the bug that if a function created with SQLPP, the callExpr in
   the function body is not normalzied to list input functions.
2. Fix the bug that in SQL++ Query Rewritter, the variables are not
   expanded before the inline the functions.
3. Add test case for this issue.
4. Make SQL++ visitor visits decorVariableExpression.
5. Optimizer test cases update.

Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
---
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate/constant-gby-agg.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-sugar.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-159-3.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-1671.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-1806.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/exists.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/in.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/in_correlated.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/not_exists.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/query-ASTERIXDB-1572.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1580.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581-correlated.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1591.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1596.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpch/q12_shipping.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpch/q12_shipping_broadcast.plan
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/query-ASTERIXDB-1875/query-ASTERIXDB-1298.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/query-ASTERIXDB-1875/query-ASTERIXDB-1298.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/user-defined-functions/query-ASTERIXDB-1875/query-ASTERIXDB-1875.1.adm
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/SqlppQueryRewriter.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/base/AbstractSqlppSimpleExpressionVisitor.java
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
24 files changed, 245 insertions(+), 192 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/66/1666/6
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-10 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/304/ (6/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-10 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/122/ 
(6/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-09 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4981/ (6/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-09 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2474/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-09 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/111/
 (1/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-09 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/3508/ (4/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-09 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/114/ 
(2/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-09 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/37/ (6/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-09 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4976/ (5/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-09 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/295/ (3/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-08 Thread Xikui Wang (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1666

to look at the new patch set (#5).

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..

Fix ASTERIXDB-1875 UDF in SQL++

1. Fix the bug that if a function created with SQLPP, the callExpr in
   the function body is not normalzied to list input functions.
2. Fix the bug that in SQL++ Query Rewritter, the variables are not
   expanded before the inline the functions.
3. Add test case for this issue.
4. Make SQL++ visitor visits decorVariableExpression.

Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
---
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/query-ASTERIXDB-1875/query-ASTERIXDB-1298.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/query-ASTERIXDB-1875/query-ASTERIXDB-1298.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/user-defined-functions/query-ASTERIXDB-1875/query-ASTERIXDB-1875.1.adm
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/SqlppQueryRewriter.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/base/AbstractSqlppSimpleExpressionVisitor.java
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
6 files changed, 59 insertions(+), 6 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/66/1666/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-07 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 4: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2470/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-07 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/33/ (6/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-07 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/3504/ (5/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-07 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4972/ (4/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-07 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2470/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-07 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/107/
 (1/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-07 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/291/ (3/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-07 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/110/ 
(2/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-07 Thread Xikui Wang (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1666

to look at the new patch set (#4).

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..

Fix ASTERIXDB-1875 UDF in SQL++

1. Fix the bug that if a function created with SQLPP, the callExpr in
   the function body is not normalzied to list input functions.
2. Fix the bug that in SQL++ Query Rewritter, the variables are not
   expanded before the inline the functions.

Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
---
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/SqlppQueryRewriter.java
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
2 files changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/66/1666/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-07 Thread Yingyi Bu (Code Review)
Yingyi Bu has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 3:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1666/3/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/SqlppQueryRewriter.java
File 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/SqlppQueryRewriter.java:

PS3, Line 136: variableCheckAndRewrite
> Inlines WITH expressions after variableCheckAndRewrite(...) so that the var
E.g.,

WITH bar (SELECT * FROM foo)
SELECT *
FROM temp AS foo, bar;

If we do variableCheckAndRewrite after inlineWithExpressions, then, 
it will become

SELECT *
FROM temp, (SELECT * FROM temp) bar;


which is not correct regarding to the WITH semantics.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-07 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/32/ (6/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-07 Thread Yingyi Bu (Code Review)
Yingyi Bu has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 3:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1666/3/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/SqlppQueryRewriter.java
File 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/SqlppQueryRewriter.java:

PS3, Line 136: variableCheckAndRewrite
Inlines WITH expressions after variableCheckAndRewrite(...) so that the 
variable scoping for WITH expression is correct.

With expression are not supposed to see variables defined in the followed 
SELECT query.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-07 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/3503/ (5/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-07 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4971/ (4/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-07 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2469/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-07 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/290/ (3/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-07 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/109/ 
(2/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-07 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/106/
 (1/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-07 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4970/ (4/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix ASTERIXDB-1875 UDF in SQL++

2017-04-07 Thread Xikui Wang (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1666

to look at the new patch set (#3).

Change subject: Fix ASTERIXDB-1875 UDF in SQL++
..

Fix ASTERIXDB-1875 UDF in SQL++

1. Fix the bug that if a function created with SQLPP, the callExpr in
   the function body is not normalzied to list input functions.
2. Fix the bug that in SQL++ Query Rewritter, the variables are not
   expanded before the inline the functions.

Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
---
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/SqlppQueryRewriter.java
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
2 files changed, 6 insertions(+), 14 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/66/1666/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu