Change in asterixdb[master]: Remove IOMVisitor and its only (unused) implementation

[Till Westmann (Code Review)]

Till Westmann has submitted this change and it was merged.

Change subject: Remove IOMVisitor and its only (unused) implementation
..


Remove IOMVisitor and its only (unused) implementation

Change-Id: I5230479d6446db0dbd167f30320fd31d772c9898
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1699
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Yingyi Bu 
---
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ABinary.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ABitArray.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ABoolean.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ACircle.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADate.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADateTime.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADayTimeDuration.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADouble.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADuration.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AFloat.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AInt16.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AInt32.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AInt64.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AInt8.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AInterval.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ALine.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AMissing.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ANull.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AOrderedList.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/APoint.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/APoint3D.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/APolygon.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ARecord.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ARectangle.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AString.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ATime.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AUUID.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AUnorderedList.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AYearMonthDuration.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/IAObject.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ShortWithoutTypeInfo.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AUnionType.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AbstractCollectionType.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/BuiltinType.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/visitors/IOMVisitor.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/visitors/OMPrintToStringVisitor.java
37 files changed, 0 insertions(+), 673 deletions(-)

Approvals:
  Yingyi Bu: Looks good to me, approved
  Jenkins: Verified; No violations found; Verified

Objections:
  Jenkins: Violations found



diff --git 
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ABinary.java 
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ABinary.java
index db87ce0..d4b7ac7 100644
--- a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ABinary.java
+++ b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ABinary.java
@@ -19,10 +19,8 @@
 package org.apache.asterix.om.base;
 
 import com.fasterxml.jackson.databind.ObjectMapper;
-import org.apache.asterix.common.exceptions.AsterixException;
 import org.apache.asterix.om.types.BuiltinType;
 import org.apache.asterix.om.types.IAType;
-import org.apache.asterix.om.visitors.IOMVisitor;
 import com.fasterxml.jackson.databind.node.ArrayNode;
 import com.fasterxml.jackson.databind.node.ObjectNode;
 
@@ -56,11 +54,6 @@
 
 public int getLength() {
 return length;
-}
-
-@Override
-public void accept(IOMVisitor visitor) throws AsterixException {
-visitor.visitABinary(this);
 }
 
 @Override
diff --git 
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ABitArray.java 
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ABitArray.java
index a15dbad..d3dbe42 100644
--- 

Change in asterixdb[master]: Remove IOMVisitor and its only (unused) implementation

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: Remove IOMVisitor and its only (unused) implementation
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1699
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5230479d6446db0dbd167f30320fd31d772c9898
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Remove IOMVisitor and its only (unused) implementation

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Remove IOMVisitor and its only (unused) implementation
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2590/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1699
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5230479d6446db0dbd167f30320fd31d772c9898
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Remove IOMVisitor and its only (unused) implementation

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Remove IOMVisitor and its only (unused) implementation
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1051/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1699
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5230479d6446db0dbd167f30320fd31d772c9898
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Remove IOMVisitor and its only (unused) implementation

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Remove IOMVisitor and its only (unused) implementation
..


Patch Set 1: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1051/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1699
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5230479d6446db0dbd167f30320fd31d772c9898
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Remove IOMVisitor and its only (unused) implementation

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Remove IOMVisitor and its only (unused) implementation
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/405/ (6/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1699
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5230479d6446db0dbd167f30320fd31d772c9898
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Remove IOMVisitor and its only (unused) implementation

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Remove IOMVisitor and its only (unused) implementation
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2590/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1699
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5230479d6446db0dbd167f30320fd31d772c9898
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Remove IOMVisitor and its only (unused) implementation

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Remove IOMVisitor and its only (unused) implementation
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/223/ 
(2/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1699
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5230479d6446db0dbd167f30320fd31d772c9898
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Remove IOMVisitor and its only (unused) implementation

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Remove IOMVisitor and its only (unused) implementation
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/221/
 (1/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1699
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5230479d6446db0dbd167f30320fd31d772c9898
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Remove IOMVisitor and its only (unused) implementation

[Till Westmann (Code Review)]

Till Westmann has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1699

Change subject: Remove IOMVisitor and its only (unused) implementation
..

Remove IOMVisitor and its only (unused) implementation

Change-Id: I5230479d6446db0dbd167f30320fd31d772c9898
---
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ABinary.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ABitArray.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ABoolean.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ACircle.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADate.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADateTime.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADayTimeDuration.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADouble.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADuration.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AFloat.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AInt16.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AInt32.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AInt64.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AInt8.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AInterval.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ALine.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AMissing.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ANull.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AOrderedList.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/APoint.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/APoint3D.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/APolygon.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ARecord.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ARectangle.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AString.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ATime.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AUUID.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AUnorderedList.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AYearMonthDuration.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/IAObject.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ShortWithoutTypeInfo.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AUnionType.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AbstractCollectionType.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/BuiltinType.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/visitors/IOMVisitor.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/visitors/OMPrintToStringVisitor.java
37 files changed, 0 insertions(+), 673 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/99/1699/1

diff --git 
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ABinary.java 
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ABinary.java
index db87ce0..d4b7ac7 100644
--- a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ABinary.java
+++ b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ABinary.java
@@ -19,10 +19,8 @@
 package org.apache.asterix.om.base;
 
 import com.fasterxml.jackson.databind.ObjectMapper;
-import org.apache.asterix.common.exceptions.AsterixException;
 import org.apache.asterix.om.types.BuiltinType;
 import org.apache.asterix.om.types.IAType;
-import org.apache.asterix.om.visitors.IOMVisitor;
 import com.fasterxml.jackson.databind.node.ArrayNode;
 import com.fasterxml.jackson.databind.node.ObjectNode;
 
@@ -56,11 +54,6 @@
 
 public int getLength() {
 return length;
-}
-
-@Override
-public void accept(IOMVisitor visitor) throws AsterixException {
-visitor.visitABinary(this);
 }
 
 @Override
diff --git 
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ABitArray.java 
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ABitArray.java
index a15dbad..d3dbe42 100644
--- 
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ABitArray.java
+++ 
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ABitArray.java
@@ -22,10 +22,8 @@
 import com.fasterxml.jackson.databind.node.ArrayNode;
 import com.fasterxml.jackson.databind.node.ObjectNode;
 
-import 

Change in asterixdb[master]: Remove IOMVisitor and its only (unused) implementation

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Remove IOMVisitor and its only (unused) implementation
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/142/ (5/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1699
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5230479d6446db0dbd167f30320fd31d772c9898
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Remove IOMVisitor and its only (unused) implementation

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Remove IOMVisitor and its only (unused) implementation
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/3612/ (3/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1699
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5230479d6446db0dbd167f30320fd31d772c9898
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Remove IOMVisitor and its only (unused) implementation

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Remove IOMVisitor and its only (unused) implementation
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5089/ (4/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1699
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5230479d6446db0dbd167f30320fd31d772c9898
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No