Change in asterixdb[master]: Runtime ErrorCode fix in external data
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1374 to look at the new patch set (#3). Change subject: Runtime ErrorCode fix in external data .. Runtime ErrorCode fix in external data 1. Change all runtime exceptions in external data to use error code. 2. This change only covers HyracksDataExcetion. AsterixException remains unchanged. Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 --- M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/AsterixException.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/library/ILibraryManager.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/AsterixInputStream.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalFunction.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalIndexer.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalScalarFunction.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IFunctionHelper.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/ILookupRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordDataParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordWithMetadataParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordWithPKDataParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IStreamDataParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedWithMetaDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/CounterTimerTupleForwarder.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedWithMetaDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FrameFullTupleForwarder.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RateControlledTupleForwarder.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/StreamDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataset/adapter/LookupAdapter.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/api/IActiveLifecycleEventSubscriber.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/api/ISubscribableRuntime.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/DistributeFeedFrameWriter.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedExceptionHandler.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FrameDistributor.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FrameSpiller.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/ActiveLifecycleEventSubscriber.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/FeedEventsListener.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/policy/FeedPolicyEnforcer.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/AdapterExecutor.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/AdapterRuntimeManager.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/CollectionRuntime.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/IngestionRuntime.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/ExternalFileIndexAccessor.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/FileIndexTupleTranslator.java M asterixdb/asterix-exter
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Jenkins has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3472/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Jenkins has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 3: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1374 to look at the new patch set (#4). Change subject: Runtime ErrorCode fix in external data .. Runtime ErrorCode fix in external data 1. Change all runtime exceptions in external data to use error code. 2. This change only covers HyracksDataExcetion. AsterixException remains unchanged. Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 --- M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/AsterixException.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/library/ILibraryManager.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/AsterixInputStream.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalFunction.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalIndexer.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalScalarFunction.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IFunctionHelper.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/ILookupRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordDataParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordWithMetadataParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordWithPKDataParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IStreamDataParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedWithMetaDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/CounterTimerTupleForwarder.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedWithMetaDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FrameFullTupleForwarder.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RateControlledTupleForwarder.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/StreamDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataset/adapter/LookupAdapter.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/api/IActiveLifecycleEventSubscriber.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/api/ISubscribableRuntime.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/DistributeFeedFrameWriter.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedExceptionHandler.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FrameDistributor.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FrameSpiller.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/ActiveLifecycleEventSubscriber.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/FeedEventsListener.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/policy/FeedPolicyEnforcer.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/AdapterExecutor.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/AdapterRuntimeManager.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/CollectionRuntime.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/IngestionRuntime.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/ExternalFileIndexAccessor.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/e
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Jenkins has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3479/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Jenkins has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 4: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1374 to look at the new patch set (#5). Change subject: Runtime ErrorCode fix in external data .. Runtime ErrorCode fix in external data 1. Change all runtime exceptions in external data to use error code. 2. This change only covers HyracksDataExcetion. AsterixException remains unchanged. Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 --- M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/AsterixException.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/library/ILibraryManager.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/AsterixInputStream.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalFunction.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalIndexer.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalScalarFunction.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IFunctionHelper.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/ILookupRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordDataParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordWithMetadataParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordWithPKDataParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IStreamDataParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedWithMetaDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/CounterTimerTupleForwarder.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedWithMetaDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FrameFullTupleForwarder.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RateControlledTupleForwarder.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/StreamDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataset/adapter/LookupAdapter.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/api/IActiveLifecycleEventSubscriber.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/api/ISubscribableRuntime.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/DistributeFeedFrameWriter.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedExceptionHandler.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FrameDistributor.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FrameSpiller.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/ActiveLifecycleEventSubscriber.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/FeedEventsListener.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/policy/FeedPolicyEnforcer.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/AdapterExecutor.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/AdapterRuntimeManager.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/CollectionRuntime.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/IngestionRuntime.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/ExternalFileIndexAccessor.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/e
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Jenkins has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3483/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Jenkins has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 5: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Jenkins has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 5: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1271/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Jenkins has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 5: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1271/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Till Westmann has posted comments on this change.
Change subject: Runtime ErrorCode fix in external data
..
Patch Set 5:
(11 comments)
- There are a number of places (interfaces, catch clauses) where "Exception"
is replaced by a more specific checked exception. This might change the
system behavior as "Exception" also catches unchecked RuntimeExceptions.
Did you carefully consider this possibility in each of those cases?
- The same is care is needed for changes that wrap all Exceptions/Throwables
in checked exceptions.
- When modifying the throws clauses on interface method it is especially
important to consider a) the consistent use of exceptions across interface
methods and b) the impact of the change on existing implementations of the
the interface that might not be in this code base.
- Please address the SQ comments.
https://asterix-gerrit.ics.uci.edu/#/c/1374/5/asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
File asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml:
Line 6559: a quote enclosing a field needs to be placed
in the beginning of that field.
Start message with a capital a?
Line 6565: a quote enclosing a field needs to be placed
in the beginning of that field.
Start message with a capital a?
https://asterix-gerrit.ics.uci.edu/#/c/1374/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedExceptionHandler.java
File
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedExceptionHandler.java:
Line 55: } catch (HyracksDataException ex) {
Is it indeed the intention to handle only HyracksDataExceptions and no
RuntimeExceptions? The previous version of this code also handled (potentially
undeclared) RuntimeExceptions.
Line 66: } catch (HyracksDataException exception) {
Is it indeed the intention to handle only HyracksDataExceptions and no
RuntimeExceptions? The previous version of this code also handled (potentially
undeclared) RuntimeExceptions.
https://asterix-gerrit.ics.uci.edu/#/c/1374/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FrameSpiller.java
File
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FrameSpiller.java:
Line 130: } catch (IOException e) {
Is it indeed the intention to handle only IOException and no RuntimeExceptions?
The previous version of this code also handled (potentially undeclared)
RuntimeExceptions.
https://asterix-gerrit.ics.uci.edu/#/c/1374/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/ActiveLifecycleEventSubscriber.java
File
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/ActiveLifecycleEventSubscriber.java:
Line 57: throw new HyracksDataException(e1);
Will this surely end the thread?
https://asterix-gerrit.ics.uci.edu/#/c/1374/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/AdapterExecutor.java
File
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/AdapterExecutor.java:
Line 59: } catch (HyracksDataException e) {
Is it indeed the intention to handle only HyracksDataExceptions and no
RuntimeExceptions? The previous version of this code also handled (potentially
undeclared) RuntimeExceptions.
https://asterix-gerrit.ics.uci.edu/#/c/1374/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/AdapterRuntimeManager.java
File
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/AdapterRuntimeManager.java:
Line 80: } catch (ExecutionException exception) {
Is it indeed the intention to handle only ExecutionException and no
RuntimeExceptions? The previous version of this code also handled (potentially
undeclared) RuntimeExceptions.
https://asterix-gerrit.ics.uci.edu/#/c/1374/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/CollectionRuntime.java
File
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/CollectionRuntime.java:
Line 64: throw new HyracksDataException(e);
Will this surely exit the thread?
https://asterix-gerrit.ics.uci.edu/#/c/1374/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/DelimitedDataParser.java
File
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/DelimitedDataParser.java:
Line 117: private void parseRecord(DataOutput out) throws
HyracksDataException {
> MAJOR SonarQube violation:
That seems to be a good point ...
https://asterix-gerrit.ics.uci.edu/#/c/1374/5/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/c
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1374 to look at the new patch set (#6). Change subject: Runtime ErrorCode fix in external data .. Runtime ErrorCode fix in external data 1. Refactored most of the exceptions in external-data package to use ErrorCode. 2. This change only covers RuntimeDataException/HyracksDataExcetion. Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 --- M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/AsterixException.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/library/ILibraryManager.java M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IFunctionHelper.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/ILookupRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordDataParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordWithMetadataParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordWithPKDataParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IStreamDataParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedWithMetaDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/CounterTimerTupleForwarder.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedWithMetaDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FrameFullTupleForwarder.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RateControlledTupleForwarder.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/api/IActiveLifecycleEventSubscriber.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedExceptionHandler.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FrameDistributor.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/ActiveLifecycleEventSubscriber.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/FeedEventsListener.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/policy/FeedPolicyEnforcer.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/ExternalFileIndexAccessor.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/FileIndexTupleTranslator.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/HDFSDataSourceFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/CharArrayRecord.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/RecordWithMetadataAndPK.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/RecordWithPK.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketClientInputStream.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalFunction.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalFunctionProvider.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JavaFunctionHelper.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/RuntimeExternalFunctionUtil.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectUtil.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjects.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/oper
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Jenkins has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3786/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Jenkins has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 6: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/204/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Yingyi Bu has posted comments on this change.
Change subject: Runtime ErrorCode fix in external data
..
Patch Set 6:
(12 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1374/6/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
File
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java:
Line 119: public static final int
ERROR_PARSER_FACTORY_HIVE_DATA_PARSER_FACTORY_NO_SERDE = 3052;
ERROR_PARSER_FACTORY_HIVE_DATA_PARSER_FACTORY_NO_SERDE is not used? Or it
should be used but there is a typo somewhere?
https://asterix-gerrit.ics.uci.edu/#/c/1374/6/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties:
Line 54: 3002 = Tuple is too large for a frame
Can't feed handle large objects?
Line 62: 3010 = doesn't support hive data with list of non-primitive types
hive -> Hive
Line 63: 3011 = Can't get hive type for field of type %1$s
hive -> Hive
Line 65: 3013 = Can't deserialize hive records with no closed columns
hive -> Hive
Line 68: 3016 = can't parse null field
can't -> Can't
Line 69: 3017 = can't parse hive list with null values
hive -> Hive
Line 104: 3052 = no hive serde provided for hive deserialized records
hive -> Hive
Line 131: 3079 = Was not able to find a file in the files index
Let all messages start with capital letter?
https://asterix-gerrit.ics.uci.edu/#/c/1374/6/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedExceptionHandler.java
File
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedExceptionHandler.java:
Line 65: } catch (Exception exception) {
Why not print the stack trace? It's easier for debugging if the stack trace is
printed.
https://asterix-gerrit.ics.uci.edu/#/c/1374/6/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/policy/FeedPolicyEnforcer.java
File
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/policy/FeedPolicyEnforcer.java:
Line 36: public boolean
continueIngestionPostSoftwareFailure(HyracksDataException e) throws
HyracksDataException {
> MAJOR SonarQube violation:
The method is never used?
https://asterix-gerrit.ics.uci.edu/#/c/1374/6/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/HiveDataParserFactory.java
File
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/HiveDataParserFactory.java:
Line 52: throw new IllegalArgumentException("no hive serde provided
for hive deserialized records");
I'm guessing the configure method is only called at the compiler side. If
that's the case, this should be a CompilationException.
--
To view, visit https://asterix-gerrit.ics.uci.edu/1374
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Till Westmann
Gerrit-Reviewer: Yingyi Bu
Gerrit-HasComments: Yes
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Yingyi Bu has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 6: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1374/6/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorDescriptor.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorDescriptor.java: Line 125: String message = "Unable to create adapter as class loader not configured for library " + adaptorLibraryName Remove the hardcoded message. Instead, RuntimeDataException exception = new RuntimeDataException(...) LOGGER.severe(message); throw exception; Line 129: ErrorCode.ERROR_OPERATORS_FEED_INTAKE_OPERATOR_DESCRIPTOR_CLASSLOADER_NOT_CONFIGURED); The exception requires two parameters: 3004 = Unable to create adapter as class loader not configured for library %1$s in dataverse %2$s https://asterix-gerrit.ics.uci.edu/#/c/1374/6/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/DelimitedDataParserFactory.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/DelimitedDataParserFactory.java: Line 92: ErrorCode.ERROR_PARSER_FACTORY_DELIMITED_DATA_PARSER_FACTORY_QUOTE_DELIMITER_MISMATCH); The error message requires two parameters. -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: Yes
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Jenkins has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 6: BAD+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/204/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Yingyi Bu has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 6: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1374/6/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/CounterTimerTupleForwarder.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/CounterTimerTupleForwarder.java: Line 161: LOGGER.log(Level.WARNING, e.getMessage()); Why not print stack trace or log stack trace? Having a stack trace will help a lot for debugging, compared to only having an error message. https://asterix-gerrit.ics.uci.edu/#/c/1374/6/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorDescriptor.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorDescriptor.java: Line 125: String message = "Unable to create adapter as class loader not configured for library " + adaptorLibraryName > Remove the hardcoded message. RuntimeDataException exception = new RuntimeDataException(...) LOGGER.severe(exception.getMessage()); throw exception; -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: Yes
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1374 to look at the new patch set (#7). Change subject: Runtime ErrorCode fix in external data .. Runtime ErrorCode fix in external data 1. Refactored most of the exceptions in external-data package to use ErrorCode. 2. This change only covers RuntimeDataException/HyracksDataExcetion. Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 --- M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/AsterixException.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/library/ILibraryManager.java M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IFunctionHelper.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/ILookupRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordDataParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordWithMetadataParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordWithPKDataParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IStreamDataParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedWithMetaDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/CounterTimerTupleForwarder.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedWithMetaDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FrameFullTupleForwarder.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RateControlledTupleForwarder.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/api/IActiveLifecycleEventSubscriber.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedExceptionHandler.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FrameDistributor.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/ActiveLifecycleEventSubscriber.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/FeedEventsListener.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/policy/FeedPolicyEnforcer.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/ExternalFileIndexAccessor.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/FileIndexTupleTranslator.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/HDFSDataSourceFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/CharArrayRecord.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/RecordWithMetadataAndPK.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/RecordWithPK.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketClientInputStream.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalFunction.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalFunctionProvider.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JavaFunctionHelper.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/RuntimeExternalFunctionUtil.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectUtil.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjects.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/oper
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Jenkins has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3789/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Xikui Wang has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 7: The NotImplementedException and IllegalStateException are changed to HyrackDataException and thrown explicitly. Is this the right way to handle them? @Abdullah, there are some comments from Yingyi in last patch which I am not that certain. Could you help me verify? Also there is a Exception check in LocalFSInputStream... I think this patch would not affect that. Could you also verify it? -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Jenkins has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 6: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1484/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Jenkins has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 7: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/207/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Jenkins has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 7: BAD+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/207/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Jenkins has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 7: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1487/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
abdullah alamoudi has posted comments on this change.
Change subject: Runtime ErrorCode fix in external data
..
Patch Set 6:
(3 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1374/6/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties:
Line 54: 3002 = Tuple is too large for a frame
> Can't feed handle large objects?
Checked the two places where this is used. It will never be thrown because now
we expand the frame. We can change the place where they are used to:
if (!appender.append(tuple)) {
appender.write(writer, true);
appender.append(tuple);
}
Or simply leave it/replace it with illegal state exception! Not sure what the
right approach is. Throughts @Yingyi?
https://asterix-gerrit.ics.uci.edu/#/c/1374/6/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/policy/FeedPolicyEnforcer.java
File
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/policy/FeedPolicyEnforcer.java:
Line 36: public boolean
continueIngestionPostSoftwareFailure(HyracksDataException e) throws
HyracksDataException {
> The method is never used?
That is correct. It is some leftover from the early feed days. we still didn't
get to look at exception handling for feeds + policies. Let's leave it for now
and once we cleanup this part, we will either use it or remove it.
https://asterix-gerrit.ics.uci.edu/#/c/1374/6/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/HiveDataParserFactory.java
File
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/HiveDataParserFactory.java:
Line 52: throw new IllegalArgumentException("no hive serde provided
for hive deserialized records");
> I'm guessing the configure method is only called at the compiler side. If
I think it should be compilation exception too.
--
To view, visit https://asterix-gerrit.ics.uci.edu/1374
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Till Westmann
Gerrit-Reviewer: Xikui Wang
Gerrit-Reviewer: Yingyi Bu
Gerrit-Reviewer: abdullah alamoudi
Gerrit-HasComments: Yes
Change in asterixdb[master]: Runtime ErrorCode fix in external data
abdullah alamoudi has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 7: The change looks good to me and I think that it should be merged... @Yingyi? -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Jenkins has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 7: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1487/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Yingyi Bu has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 7: @Abdullah, I agree. But let's open two issues for: 1. cleanup big object handling exceptions; 2. cleanup the unused method in FeedPolicyEnforcer. -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
abdullah alamoudi has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 7: @Yingyi, Look at my inlined comments on your comments on patch set 6 :) -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
abdullah alamoudi has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 7: Yingyi, I am sorry. I was sleepy when I read your comment. I will create two issues to fix the two problems. :-) Abdullah. -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Yingyi Bu has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 7: Cool, thanks, Xikui! -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Jenkins has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 7: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1505/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Xikui Wang has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 7: @Yingyi My pleasure. :) Not sure why IT failed again... Hope this time it will go through. Thanks to everyone's help. -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Jenkins has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 7: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1505/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Yingyi Bu has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 7: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Yingyi Bu has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 7: @Xikui, can you rebase the latest master? Thx! -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Hello Yingyi Bu, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1374 to look at the new patch set (#8). Change subject: Runtime ErrorCode fix in external data .. Runtime ErrorCode fix in external data 1. Refactored most of the exceptions in external-data package to use ErrorCode. 2. This change only covers RuntimeDataException/HyracksDataExcetion. 3. Refactor errorcode names Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/CheckInsertUpsertReturningRule.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/CompilerExtensionManager.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCExtensionManager.java M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/AsterixException.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/library/ILibraryManager.java M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IFunctionHelper.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/ILookupRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordDataParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordWithMetadataParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordWithPKDataParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IStreamDataParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedWithMetaDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/CounterTimerTupleForwarder.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedWithMetaDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FrameFullTupleForwarder.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RateControlledTupleForwarder.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/api/IActiveLifecycleEventSubscriber.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedExceptionHandler.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FrameDistributor.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/ActiveLifecycleEventSubscriber.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/FeedEventsListener.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/policy/FeedPolicyEnforcer.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/ExternalFileIndexAccessor.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/FileIndexTupleTranslator.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/HDFSDataSourceFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/CharArrayRecord.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/RecordWithMetadataAndPK.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/RecordWithPK.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketClientInputStream.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalFunction.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalFunctionProvider.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JavaFunctionHelper.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/RuntimeExternalFunctionUtil.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Jenkins has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3817/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Jenkins has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 8: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/223/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Jenkins has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 8: BAD+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/223/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Runtime ErrorCode fix in external data
Yingyi Bu has posted comments on this change. Change subject: Runtime ErrorCode fix in external data .. Patch Set 8: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
