Change in asterixdb[neo]: [NO ISSUE][HYR][CONTROL] Avoid halt in event of interrupted registration

2024-05-09 Thread AsterixDB Code Review 
>From Michael Blow :

Michael Blow has submitted this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18268 )

Change subject: [NO ISSUE][HYR][CONTROL] Avoid halt in event of interrupted 
registration
..

[NO ISSUE][HYR][CONTROL] Avoid halt in event of interrupted registration

Change-Id: I3577c0aa5a8358027146f2ac342a627d813894ca
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18268
Reviewed-by: Michael Blow 
Reviewed-by: Murtadha Hubail 
Tested-by: Michael Blow 
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/CcConnection.java
1 file changed, 15 insertions(+), 0 deletions(-)

Approvals:
  Murtadha Hubail: Looks good to me, approved
  Michael Blow: Looks good to me, but someone else must approve; Verified
  Anon. E. Moose #1000171:




diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/CcConnection.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/CcConnection.java
index d1f7d5a..c99898d 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/CcConnection.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/CcConnection.java
@@ -70,6 +70,8 @@
 InvokeUtil.runWithTimeout(() -> {
 this.wait(REGISTRATION_RESPONSE_POLL_PERIOD); // NOSONAR while 
loop in timeout call
 }, () -> !registrationPending, 1, TimeUnit.MINUTES);
+} catch (InterruptedException e) {
+throw e;
 } catch (Exception e) {
 registrationException = e;
 }

--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18268
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: I3577c0aa5a8358027146f2ac342a627d813894ca
Gerrit-Change-Number: 18268
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-CC: Jenkins 
Gerrit-MessageType: merged

Change in asterixdb[neo]: [NO ISSUE][HYR][CONTROL] Avoid halt in event of interrupted registration

2024-05-08 Thread AsterixDB Code Review 
>From Murtadha Hubail :

Attention is currently required from: Ali Alsuliman, Michael Blow, Murtadha 
Hubail.
Murtadha Hubail has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18268 )

Change subject: [NO ISSUE][HYR][CONTROL] Avoid halt in event of interrupted 
registration
..


Patch Set 1: Code-Review+2


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18268
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: I3577c0aa5a8358027146f2ac342a627d813894ca
Gerrit-Change-Number: 18268
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-CC: Jenkins 
Gerrit-Attention: Ali Alsuliman 
Gerrit-Attention: Michael Blow 
Gerrit-Attention: Murtadha Hubail
Gerrit-Comment-Date: Wed, 08 May 2024 15:52:47 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in asterixdb[neo]: [NO ISSUE][HYR][CONTROL] Avoid halt in event of interrupted registration

2024-05-08 Thread AsterixDB Code Review 
>From Michael Blow :

Attention is currently required from: Ali Alsuliman, Murtadha Hubail.
Michael Blow has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18268 )

Change subject: [NO ISSUE][HYR][CONTROL] Avoid halt in event of interrupted 
registration
..


Patch Set 1: Verified+1


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18268
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: I3577c0aa5a8358027146f2ac342a627d813894ca
Gerrit-Change-Number: 18268
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail
Gerrit-CC: Jenkins 
Gerrit-Attention: Ali Alsuliman 
Gerrit-Attention: Murtadha Hubail
Gerrit-Comment-Date: Wed, 08 May 2024 13:12:24 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in asterixdb[neo]: [NO ISSUE][HYR][CONTROL] Avoid halt in event of interrupted registration

2024-05-07 Thread AsterixDB Code Review 
>From Michael Blow :

Attention is currently required from: Ali Alsuliman, Murtadha Hubail.
Michael Blow has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18268 )

Change subject: [NO ISSUE][HYR][CONTROL] Avoid halt in event of interrupted 
registration
..


Patch Set 1: Code-Review+1


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18268
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: I3577c0aa5a8358027146f2ac342a627d813894ca
Gerrit-Change-Number: 18268
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail
Gerrit-CC: Jenkins 
Gerrit-Attention: Ali Alsuliman 
Gerrit-Attention: Murtadha Hubail
Gerrit-Comment-Date: Tue, 07 May 2024 13:03:20 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in asterixdb[neo]: [NO ISSUE][HYR][CONTROL] Avoid halt in event of interrupted registration

2024-05-06 Thread AsterixDB Code Review 
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18268 )

Change subject: [NO ISSUE][HYR][CONTROL] Avoid halt in event of interrupted 
registration
..


Patch Set 1: Contrib+1

Analytics Compatibility Tests Successful
https://cbjenkins.page.link/rLVKufYBRcxePoG8A : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18268
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: I3577c0aa5a8358027146f2ac342a627d813894ca
Gerrit-Change-Number: 18268
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-CC: Jenkins 
Gerrit-Comment-Date: Tue, 07 May 2024 01:56:11 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in asterixdb[neo]: [NO ISSUE][HYR][CONTROL] Avoid halt in event of interrupted registration

2024-05-06 Thread AsterixDB Code Review 
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18268 )

Change subject: [NO ISSUE][HYR][CONTROL] Avoid halt in event of interrupted 
registration
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/RjjmvvAVuxmXWN5t6 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18268
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: I3577c0aa5a8358027146f2ac342a627d813894ca
Gerrit-Change-Number: 18268
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow 
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-CC: Jenkins 
Gerrit-Comment-Date: Tue, 07 May 2024 00:10:47 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in asterixdb[neo]: [NO ISSUE][HYR][CONTROL] Avoid halt in event of interrupted registration

2024-05-06 Thread AsterixDB Code Review 
>From Michael Blow :

Michael Blow has uploaded this change for review. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18268 )


Change subject: [NO ISSUE][HYR][CONTROL] Avoid halt in event of interrupted 
registration
..

[NO ISSUE][HYR][CONTROL] Avoid halt in event of interrupted registration

Change-Id: I3577c0aa5a8358027146f2ac342a627d813894ca
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/CcConnection.java
1 file changed, 11 insertions(+), 0 deletions(-)



  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/68/18268/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/CcConnection.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/CcConnection.java
index d1f7d5a..c99898d 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/CcConnection.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/CcConnection.java
@@ -70,6 +70,8 @@
 InvokeUtil.runWithTimeout(() -> {
 this.wait(REGISTRATION_RESPONSE_POLL_PERIOD); // NOSONAR while 
loop in timeout call
 }, () -> !registrationPending, 1, TimeUnit.MINUTES);
+} catch (InterruptedException e) {
+throw e;
 } catch (Exception e) {
 registrationException = e;
 }

--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18268
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: I3577c0aa5a8358027146f2ac342a627d813894ca
Gerrit-Change-Number: 18268
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow 
Gerrit-MessageType: newchange