Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions
Murtadha Hubail has submitted this change and it was merged. Change subject: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions .. [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions - user model changes: no - storage format changes: no - interface changes: no Details: - Fix JSON of additional expressions in the JSON plan printer of InsertDeleteUpsertOperator. Change-Id: I2d13b91b4e5e36b156f52fbb09f0ddcffe1deda3 Reviewed-on: https://asterix-gerrit.ics.uci.edu/2627 Sonar-Qube: Jenkins Tested-by: Jenkins Contrib: Jenkins Integration-Tests: Jenkins Reviewed-by: Till Westmann --- M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Anon. E. Moose #1000171: Till Westmann: Looks good to me, approved Jenkins: Verified; No violations found; ; Verified diff --git a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java index 1076eb5..8acf08b 100644 --- a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java +++ b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java @@ -544,9 +544,9 @@ addIndent(indent).append("\"from-record\": \"") .append(op.getPayloadExpression().getValue().accept(exprVisitor, indent) + "\""); if (op.getAdditionalNonFilteringExpressions() != null) { -buffer.append(",\n\"meta\": \""); +buffer.append(",\n\"meta\": {"); pprintExprList(op.getAdditionalNonFilteringExpressions(), 0); -buffer.append("\""); +buffer.append("}"); } buffer.append(",\n"); addIndent(indent).append("\"partitioned-by\": {"); -- To view, visit https://asterix-gerrit.ics.uci.edu/2627 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d13b91b4e5e36b156f52fbb09f0ddcffe1deda3 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions
Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2627 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d13b91b4e5e36b156f52fbb09f0ddcffe1deda3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6328/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2627 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d13b91b4e5e36b156f52fbb09f0ddcffe1deda3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3120/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2627 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d13b91b4e5e36b156f52fbb09f0ddcffe1deda3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/94w9h7 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2627 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d13b91b4e5e36b156f52fbb09f0ddcffe1deda3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3120/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2627 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d13b91b4e5e36b156f52fbb09f0ddcffe1deda3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/ynXTt1 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2627 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d13b91b4e5e36b156f52fbb09f0ddcffe1deda3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6328/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2627 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d13b91b4e5e36b156f52fbb09f0ddcffe1deda3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1466/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2627 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d13b91b4e5e36b156f52fbb09f0ddcffe1deda3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3459/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2627 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d13b91b4e5e36b156f52fbb09f0ddcffe1deda3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3991/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2627 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d13b91b4e5e36b156f52fbb09f0ddcffe1deda3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3418/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2627 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d13b91b4e5e36b156f52fbb09f0ddcffe1deda3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3371/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2627 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d13b91b4e5e36b156f52fbb09f0ddcffe1deda3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions
Murtadha Hubail has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/2627 Change subject: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions .. [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions - user model changes: no - storage format changes: no - interface changes: no Details: - Fix JSON of additional expressions in the JSON plan printer of InsertDeleteUpsertOperator. Change-Id: I2d13b91b4e5e36b156f52fbb09f0ddcffe1deda3 --- M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/27/2627/1 diff --git a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java index 1076eb5..8acf08b 100644 --- a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java +++ b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java @@ -544,9 +544,9 @@ addIndent(indent).append("\"from-record\": \"") .append(op.getPayloadExpression().getValue().accept(exprVisitor, indent) + "\""); if (op.getAdditionalNonFilteringExpressions() != null) { -buffer.append(",\n\"meta\": \""); +buffer.append(",\n\"meta\": {"); pprintExprList(op.getAdditionalNonFilteringExpressions(), 0); -buffer.append("\""); +buffer.append("}"); } buffer.append(",\n"); addIndent(indent).append("\"partitioned-by\": {"); -- To view, visit https://asterix-gerrit.ics.uci.edu/2627 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2d13b91b4e5e36b156f52fbb09f0ddcffe1deda3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Murtadha Hubail
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3447/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2627 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d13b91b4e5e36b156f52fbb09f0ddcffe1deda3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3910/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2627 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d13b91b4e5e36b156f52fbb09f0ddcffe1deda3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3674/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2627 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d13b91b4e5e36b156f52fbb09f0ddcffe1deda3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4175/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2627 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d13b91b4e5e36b156f52fbb09f0ddcffe1deda3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3890/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2627 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d13b91b4e5e36b156f52fbb09f0ddcffe1deda3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7398/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2627 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d13b91b4e5e36b156f52fbb09f0ddcffe1deda3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2377][OTH] Fix JSON of Additional Expressions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8922/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2627 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d13b91b4e5e36b156f52fbb09f0ddcffe1deda3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No