Change in asterixdb-bad[master]: Coordinated change to support parameterized queries

2018-06-15 Thread Steven Jacobs (Code Review)
Steven Jacobs has submitted this change and it was merged.

Change subject: Coordinated change to support parameterized queries
..


Coordinated change to support parameterized queries

Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5
---
M asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java
8 files changed, 23 insertions(+), 44 deletions(-)

Approvals:
  Steven Jacobs: Looks good to me, approved
  Till Westmann: Looks good to me, but someone else must approve
  Jenkins: Verified



diff --git 
a/asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java 
b/asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
index 69145d9..c48ec54 100644
--- a/asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
+++ b/asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
@@ -108,9 +108,8 @@
 public static boolean runDeployedJobSpecCheckPeriod(DeployedJobSpecId 
distributedId, IHyracksClientConnection hcc,
 Map jobParameters, long period, EntityId entityId, 
ITxnIdFactory txnIdFactory,
 DeployedJobSpecEventListener listener) throws Exception {
-long executionMilliseconds =
-runDeployedJobSpec(distributedId, hcc, null, jobParameters, 
entityId, txnIdFactory, null, listener,
-null);
+long executionMilliseconds = runDeployedJobSpec(distributedId, hcc, 
null, jobParameters, entityId, txnIdFactory,
+null, listener, null);
 if (executionMilliseconds > period) {
 LOGGER.log(Level.SEVERE,
 "Periodic job for " + entityId.getExtensionName() + " " + 
entityId.getDataverse() + "."
@@ -153,7 +152,6 @@
 
 }
 
-
 public static long findPeriod(String duration) {
 //TODO: Allow Repetitive Channels to use YMD durations
 String hoursMinutesSeconds = "";
@@ -189,7 +187,8 @@
 metadataProvider.setMetadataTxnContext(mdTxnCtx);
 JobSpecification jobSpec = null;
 try {
-jobSpec = ((QueryTranslator) 
statementExecutor).rewriteCompileQuery(hcc, metadataProvider, q, null);
+jobSpec = ((QueryTranslator) 
statementExecutor).rewriteCompileQuery(hcc, metadataProvider, q, null, null,
+null);
 MetadataManager.INSTANCE.commitTransaction(mdTxnCtx);
 bActiveTxn = false;
 } catch (Exception e) {
@@ -230,7 +229,7 @@
 jobSpec = compilePushChannel(badStatementExecutor, 
metadataProvider, hcc, (Query) fStatements.get(1));
 } else {
 jobSpec = 
badStatementExecutor.handleInsertUpsertStatement(metadataProvider, 
fStatements.get(1), hcc,
-null, null, null, null, true, null);
+null, null, null, null, true, null, null, null);
 }
 } else {
 //Procedures
@@ -263,7 +262,7 @@
 metadataProvider.setMetadataTxnContext(mdTxnCtx);
 JobSpecification jobSpec;
 try {
-jobSpec = statementExecutor.rewriteCompileQuery(hcc, 
metadataProvider, q, null);
+jobSpec = statementExecutor.rewriteCompileQuery(hcc, 
metadataProvider, q, null, null, null);
 MetadataManager.INSTANCE.commitTransaction(mdTxnCtx);
 } catch (Exception e) {
 ((QueryTranslator) statementExecutor).abort(e, e, mdTxnCtx);
@@ -277,14 +276,15 @@
 IStatementExecutor.Stats stats, Statement procedureStatement) 
throws Exception {
 if (procedureStatement.getKind() == Statement.Kind.INSERT) {
 return ((QueryTranslator) 
statementExecutor).handleInsertUpsertStatement(metadataProvider,
-procedureStatement, hcc, hdc, 
IStatementExecutor.ResultDelivery.ASYNC, null, stats, true, null);
+procedureStatement, hcc, hdc, 
IStatementExecutor.ResultDelivery.ASYNC, null, stats, true, null,
+null, null);
 } else if (procedureStatement.getKind() == Statement.Kind.QUERY) {
 return compileQueryJob(statementExecutor, metadataProvider, hcc, 
(Query) procedureStatement);
 } else {
 SqlppDeleteRewriteVisitor visitor = new 
SqlppDeleteRewriteVisitor();
 

Change in asterixdb-bad[master]: Coordinated change to support parameterized queries

2018-06-15 Thread Steven Jacobs (Code Review)
Steven Jacobs has posted comments on this change.

Change subject: Coordinated change to support parameterized queries
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2712
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No


Change in asterixdb-bad[master]: Coordinated change to support parameterized queries

2018-06-15 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change.

Change subject: Coordinated change to support parameterized queries
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2712
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb-bad[master]: Coordinated change to support parameterized queries

2018-06-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Coordinated change to support parameterized queries
..


Patch Set 6:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/313/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2712
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb-bad[master]: Coordinated change to support parameterized queries

2018-06-14 Thread Till Westmann (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2712

to look at the new patch set (#6).

Change subject: Coordinated change to support parameterized queries
..

Coordinated change to support parameterized queries

Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5
---
M asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java
8 files changed, 23 insertions(+), 44 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad 
refs/changes/12/2712/6
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2712
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 


Change in asterixdb-bad[master]: Coordinated change to support parameterized queries

2018-06-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Coordinated change to support parameterized queries
..


Patch Set 5:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/312/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2712
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb-bad[master]: Coordinated change to support parameterized queries

2018-06-14 Thread Till Westmann (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2712

to look at the new patch set (#5).

Change subject: Coordinated change to support parameterized queries
..

Coordinated change to support parameterized queries

Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5
---
M asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java
10 files changed, 25 insertions(+), 47 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad 
refs/changes/12/2712/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2712
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 


Change in asterixdb-bad[master]: Coordinated change to support parameterized queries

2018-06-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Coordinated change to support parameterized queries
..


Patch Set 4:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/311/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2712
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb-bad[master]: Coordinated change to support parameterized queries

2018-06-14 Thread Till Westmann (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2712

to look at the new patch set (#4).

Change subject: Coordinated change to support parameterized queries
..

Coordinated change to support parameterized queries

Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5
---
M asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java
10 files changed, 28 insertions(+), 50 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad 
refs/changes/12/2712/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2712
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 


Change in asterixdb-bad[master]: Coordinated change to support parameterized queries

2018-06-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Coordinated change to support parameterized queries
..


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/310/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2712
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb-bad[master]: Coordinated change to support parameterized queries

2018-06-14 Thread Till Westmann (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2712

to look at the new patch set (#3).

Change subject: Coordinated change to support parameterized queries
..

Coordinated change to support parameterized queries

Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5
---
M asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ProcedureDropStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java
11 files changed, 43 insertions(+), 71 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad 
refs/changes/12/2712/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2712
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 


Change in asterixdb-bad[master]: Coordinated change to support parameterized queries

2018-06-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Coordinated change to support parameterized queries
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/309/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2712
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb-bad[master]: Coordinated change to support parameterized queries

2018-06-14 Thread Till Westmann (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2712

to look at the new patch set (#2).

Change subject: Coordinated change to support parameterized queries
..

Coordinated change to support parameterized queries

Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5
---
M asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ProcedureDropStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java
11 files changed, 66 insertions(+), 79 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad 
refs/changes/12/2712/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2712
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 


Change in asterixdb-bad[master]: Coordinated change to support parameterized queries

2018-06-14 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change.

Change subject: Coordinated change to support parameterized queries
..


Patch Set 1: Code-Review-1

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2712
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb-bad[master]: Coordinated change to support parameterized queries

2018-06-14 Thread Till Westmann (Code Review)
Till Westmann has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2712

Change subject: Coordinated change to support parameterized queries
..

Coordinated change to support parameterized queries

Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5
---
M asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/BrokerDropStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateBrokerStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ProcedureDropStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java
13 files changed, 126 insertions(+), 101 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad 
refs/changes/12/2712/1

diff --git 
a/asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java 
b/asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
index 69145d9..a52efeb 100644
--- a/asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
+++ b/asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
@@ -41,6 +41,7 @@
 import org.apache.asterix.bad.metadata.DeployedJobSpecEventListener;
 import org.apache.asterix.common.dataflow.ICcApplicationContext;
 import org.apache.asterix.common.transactions.ITxnIdFactory;
+import org.apache.asterix.lang.common.base.IStatementRewriter;
 import org.apache.asterix.lang.common.base.Statement;
 import org.apache.asterix.lang.common.statement.Query;
 import org.apache.asterix.lang.common.statement.SetStatement;
@@ -48,6 +49,7 @@
 import org.apache.asterix.metadata.MetadataManager;
 import org.apache.asterix.metadata.MetadataTransactionContext;
 import org.apache.asterix.metadata.declared.MetadataProvider;
+import org.apache.asterix.om.base.IAObject;
 import org.apache.asterix.translator.IRequestParameters;
 import org.apache.asterix.translator.IStatementExecutor;
 import org.apache.hyracks.api.client.IHyracksClientConnection;
@@ -108,9 +110,8 @@
 public static boolean runDeployedJobSpecCheckPeriod(DeployedJobSpecId 
distributedId, IHyracksClientConnection hcc,
 Map jobParameters, long period, EntityId entityId, 
ITxnIdFactory txnIdFactory,
 DeployedJobSpecEventListener listener) throws Exception {
-long executionMilliseconds =
-runDeployedJobSpec(distributedId, hcc, null, jobParameters, 
entityId, txnIdFactory, null, listener,
-null);
+long executionMilliseconds = runDeployedJobSpec(distributedId, hcc, 
null, jobParameters, entityId, txnIdFactory,
+null, listener, null);
 if (executionMilliseconds > period) {
 LOGGER.log(Level.SEVERE,
 "Periodic job for " + entityId.getExtensionName() + " " + 
entityId.getDataverse() + "."
@@ -153,7 +154,6 @@
 
 }
 
-
 public static long findPeriod(String duration) {
 //TODO: Allow Repetitive Channels to use YMD durations
 String hoursMinutesSeconds = "";
@@ -183,13 +183,15 @@
 }
 
 public static JobSpecification compilePushChannel(IStatementExecutor 
statementExecutor,
-MetadataProvider metadataProvider, IHyracksClientConnection hcc, 
Query q) throws Exception {
+MetadataProvider metadataProvider, IHyracksClientConnection hcc, 
Query q, Map stmtParams,
+IStatementRewriter stmtRewriter) throws Exception {
 MetadataTransactionContext mdTxnCtx = 
MetadataManager.INSTANCE.beginTransaction();
 boolean bActiveTxn = true;
 metadataProvider.setMetadataTxnContext(mdTxnCtx);
 JobSpecification jobSpec = null;
 try {
-jobSpec = ((QueryTranslator) 
statementExecutor).rewriteCompileQuery(hcc, metadataProvider, q, null);
+jobSpec = ((QueryTranslator) 
statementExecutor).rewriteCompileQuery(hcc, metadataProvider, q, null,
+stmtParams, stmtRewriter);
 MetadataManager.INSTANCE.commitTransaction(mdTxnCtx);
 bActiveTxn = false;
 } catch (Exception e) {
@@ 

Change in asterixdb-bad[master]: Coordinated change to support parameterized queries

2018-06-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Coordinated change to support parameterized queries
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/308/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2712
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No