Change in asterixdb-bad[master]: Move channels to a result sharing framework
Jenkins has posted comments on this change. Change subject: Move channels to a result sharing framework .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/321/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2731 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbcdf264bcd21caa0d28a9ac392b36577ca60dad Gerrit-PatchSet: 1 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb-bad[master]: Move channels to a result sharing framework
Jenkins has posted comments on this change. Change subject: Move channels to a result sharing framework .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/322/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2731 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbcdf264bcd21caa0d28a9ac392b36577ca60dad Gerrit-PatchSet: 1 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb-bad[master]: Move channels to a result sharing framework
Xikui Wang has posted comments on this change.
Change subject: Move channels to a result sharing framework
..
Patch Set 1:
(18 comments)
added some comments.
https://asterix-gerrit.ics.uci.edu/#/c/2731/1/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
File
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java:
Line 181: StringBuilder builder = new StringBuilder();
One side comment. I think these constructed stmts are one per query. if not,
maybe you want to change it accordingly, as you've heard from them that
multiple stmts in one query will soon become invalid.
Line 182: builder.append("upsert into " + channelSubscriptionsDataset +
"(\n");
quick Q. This works without use dataverse?
PS1, Line 183: s
Change this a constant and give it a better name.
PS1, Line 185: param
also, is this part of certain meta data schema?
PS1, Line 185: param
Change it to a constant variable.
PS1, Line 195: param
same
PS1, Line 229: param
same
PS1, Line 249: s
same here
https://asterix-gerrit.ics.uci.edu/#/c/2731/1/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
File
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java:
PS1, Line 184: partitionFields = new ArrayList<>();
: keyIndicators = new ArrayList<>();
: keyIndicators.add(0);
: keyIndicators.add(0);
: fieldName = new ArrayList<>();
: List fieldName2 = new ArrayList<>();
: fieldName.add(BADConstants.ChannelSubscriptionId);
: fieldName2.add(BADConstants.BrokerSubscriptionId);
: partitionFields.add(fieldName);
: partitionFields.add(fieldName2);
Do you mind explain this a little bit? also, regular_name+number is very
confusing...
PS1, Line 280: a
I'm ok with constructing query strings. One minor suggestion would be to create
constant variables for variable names that are used in the query. There are
several benefits: 1) easier for future maintenance; 2) If the variable means
something, it can be shown in the names; 3) less likely to have conflicts when
adding new variables.
https://asterix-gerrit.ics.uci.edu/#/c/2731/1/asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java
File
asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java:
Line 186: //Maybe we need to add a project???
?
Line 245:
empty line
Line 343: /*This function is used to find specific operators within the
plan, either
You should be able to use the function signature to get a better template for
this.
PS1, Line 352: String param1, String param2
these two parameters seem not being used except for in recursive call... safely
to remove?
Line 352: private AbstractLogicalOperator findOp(AbstractLogicalOperator
op, int searchId, String param1, String param2) {
I think you could use LogicalOperatorTag here directly
https://asterix-gerrit.ics.uci.edu/#/c/2731/1/asterix-bad/src/test/resources/runtimets/queries/channel/room_occupants/room_occupants.4.query.sqlpp
File
asterix-bad/src/test/resources/runtimets/queries/channel/room_occupants/room_occupants.4.query.sqlpp:
PS1, Line 30: param0
correlation with the createChannel param0? (probably not...)
https://asterix-gerrit.ics.uci.edu/#/c/2731/1/asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.3.query.sqlpp
File
asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.3.query.sqlpp:
PS1, Line 21: param0
same here?
https://asterix-gerrit.ics.uci.edu/#/c/2731/1/asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.6.pollquery.sqlpp
File
asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.6.pollquery.sqlpp:
Line 19: // polltimeoutsecs=15
ws
--
To view, visit https://asterix-gerrit.ics.uci.edu/2731
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcdf264bcd21caa0d28a9ac392b36577ca60dad
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Xikui Wang
Gerrit-HasComments: Yes
Change in asterixdb-bad[master]: Move channels to a result sharing framework
Steven Jacobs has posted comments on this change.
Change subject: Move channels to a result sharing framework
..
Patch Set 1:
(18 comments)
https://asterix-gerrit.ics.uci.edu/#/c/2731/1/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
File
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java:
Line 181: StringBuilder builder = new StringBuilder();
> One side comment. I think these constructed stmts are one per query. if not
I think the BAD stuff is okay, I only use "SET as a second statement, which he
mentioned will still work"
Line 182: builder.append("upsert into " + channelSubscriptionsDataset +
"(\n");
> quick Q. This works without use dataverse?
The names passed are absolute so no "use" is needed.
PS1, Line 183: s
> Change this a constant and give it a better name.
Done
PS1, Line 185: param
> also, is this part of certain meta data schema?
The ChannelSubscriptions dataset automatically names the fields for the param
values as param0,param1,...
PS1, Line 185: param
> Change it to a constant variable.
Done
PS1, Line 195: param
> same
Done
PS1, Line 229: param
> same
Done
PS1, Line 249: s
> same here
Done
https://asterix-gerrit.ics.uci.edu/#/c/2731/1/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
File
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java:
PS1, Line 184: partitionFields = new ArrayList<>();
: keyIndicators = new ArrayList<>();
: keyIndicators.add(0);
: keyIndicators.add(0);
: fieldName = new ArrayList<>();
: List fieldName2 = new ArrayList<>();
: fieldName.add(BADConstants.ChannelSubscriptionId);
: fieldName2.add(BADConstants.BrokerSubscriptionId);
: partitionFields.add(fieldName);
: partitionFields.add(fieldName2);
> Do you mind explain this a little bit? also, regular_name+number is very co
I'll clean up the names. Essentially the partitioning fields are each a list
(for cases of nested keys). We have two fields for the primary key here, the
channelSubscriptionId and the brokerSubscriptionId. Since neither is nested
each list is of size one.
PS1, Line 280: a
> I'm ok with constructing query strings. One minor suggestion would be to cr
Done
https://asterix-gerrit.ics.uci.edu/#/c/2731/1/asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java
File
asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java:
Line 186: //Maybe we need to add a project???
> ?
Done
Line 245:
> empty line
Done
Line 343: /*This function is used to find specific operators within the
plan, either
> You should be able to use the function signature to get a better template f
Done
PS1, Line 352: String param1, String param2
> these two parameters seem not being used except for in recursive call... sa
This method went through several rewrites, so it was pretty messy. I cleaned it
up now. Take a look at the new version and see what you think.
Line 352: private AbstractLogicalOperator findOp(AbstractLogicalOperator
op, int searchId, String param1, String param2) {
> I think you could use LogicalOperatorTag here directly
Done
https://asterix-gerrit.ics.uci.edu/#/c/2731/1/asterix-bad/src/test/resources/runtimets/queries/channel/room_occupants/room_occupants.4.query.sqlpp
File
asterix-bad/src/test/resources/runtimets/queries/channel/room_occupants/room_occupants.4.query.sqlpp:
PS1, Line 30: param0
> correlation with the createChannel param0? (probably not...)
This would be the first parameter value from the subscribe statement. The
ChannelSubscriptions dataset stores the field names as param0,param1,...
https://asterix-gerrit.ics.uci.edu/#/c/2731/1/asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.3.query.sqlpp
File
asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.3.query.sqlpp:
PS1, Line 21: param0
> same here?
same
https://asterix-gerrit.ics.uci.edu/#/c/2731/1/asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.6.pollquery.sqlpp
File
asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.6.pollquery.sqlpp:
Line 19: // polltimeoutsecs=15
> ws
Done
--
To view, visit https://asterix-gerrit.ics.uci.edu/2731
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcdf264bcd21caa0d28a9ac392b36577ca60dad
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven
Change in asterixdb-bad[master]: Move channels to a result sharing framework
Jenkins has posted comments on this change. Change subject: Move channels to a result sharing framework .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/323/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2731 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbcdf264bcd21caa0d28a9ac392b36577ca60dad Gerrit-PatchSet: 2 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb-bad[master]: Move channels to a result sharing framework
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2731 to look at the new patch set (#2). Change subject: Move channels to a result sharing framework .. Move channels to a result sharing framework Change-Id: Ifbcdf264bcd21caa0d28a9ac392b36577ca60dad --- M asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataExtension.java M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataRecordTypes.java M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Channel.java M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelTupleTranslator.java M asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java M asterix-bad/src/main/resources/lang-extension/lang.txt M asterix-bad/src/test/resources/optimizerts/results/channel/channel-advanced-index-only.plan M asterix-bad/src/test/resources/optimizerts/results/channel/channel-advanced.plan M asterix-bad/src/test/resources/optimizerts/results/channel/channel-create.plan M asterix-bad/src/test/resources/optimizerts/results/channel/channel-push.plan M asterix-bad/src/test/resources/optimizerts/results/channel/channel-subscribe.plan M asterix-bad/src/test/resources/optimizerts/results/channel/channel-unsubscribe.plan M asterix-bad/src/test/resources/runtimets/queries/channel/add_index/add_index.2.update.sqlpp R asterix-bad/src/test/resources/runtimets/queries/channel/add_index/add_index.5.pollquery.sqlpp M asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_datasets/create_channel_check_datasets.3.query.sqlpp M asterix-bad/src/test/resources/runtimets/queries/channel/drop_channel_check_datasets/drop_channel_check_datasets.3.query.sqlpp M asterix-bad/src/test/resources/runtimets/queries/channel/drop_subscriptions/drop_subscriptions.1.ddl.sqlpp M asterix-bad/src/test/resources/runtimets/queries/channel/room_occupants/room_occupants.4.query.sqlpp A asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.1.ddl.sqlpp C asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.2.update.sqlpp C asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.3.query.sqlpp R asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.4.query.sqlpp C asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.5.update.sqlpp C asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.6.pollquery.sqlpp M asterix-bad/src/test/resources/runtimets/queries/channel/subscribe_channel_check_subscriptions/subscribe_channel_check_subscriptions.5.query.sqlpp M asterix-bad/src/test/resources/runtimets/results/channel/create_channel_check_datasets/create_channel_check_datasets.1.adm M asterix-bad/src/test/resources/runtimets/results/channel/create_channel_check_metadata/create_channel_check_metadata.1.adm M asterix-bad/src/test/resources/runtimets/results/channel/drop_channel_check_datasets/drop_channel_check_datasets.1.adm M asterix-bad/src/test/resources/runtimets/results/channel/drop_channel_check_metadata/drop_channel_check_metadata.1.adm M asterix-bad/src/test/resources/runtimets/results/channel/room_occupants/room_occupants.1.adm A asterix-bad/src/test/resources/runtimets/results/channel/shared_subscriptions/shared_subscriptions.3.adm A asterix-bad/src/test/resources/runtimets/results/channel/shared_subscriptions/shared_subscriptions.4.adm A asterix-bad/src/test/resources/runtimets/results/channel/shared_subscriptions/shared_subscriptions.6.adm M asterix-bad/src/test/resources/runtimets/testsuite.xml 39 files changed, 1,443 insertions(+), 821 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad refs/changes/31/2731/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2731 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifbcdf264bcd21caa0d28a9ac392b36577ca60dad Gerrit-PatchSet: 2 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Xikui Wang
Change in asterixdb-bad[master]: Move channels to a result sharing framework
Xikui Wang has posted comments on this change.
Change subject: Move channels to a result sharing framework
..
Patch Set 2:
(6 comments)
added some more comments. Congratulations to the new dad! :)
https://asterix-gerrit.ics.uci.edu/#/c/2731/2/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
File
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java:
PS2, Line 181: ng channelSubVar = "channelSub";
: String param =
Move these to the top of the class and make it public static final. Like this
one:
org.apache.hyracks.storage.am.common.datagen.DocumentStringFieldValueGenerator
Please do the same for the others.
https://asterix-gerrit.ics.uci.edu/#/c/2731/2/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
File
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java:
PS2, Line 185: keyIndicators = new ArrayList<>();
: keyIndicators.add(0);
: keyIndicators.add(0);
it seems the key indicator is not modified but only used as a parameter. If so,
replace these with Collections.singletonList(0) and put it into the parameter
lists directly.
PS2, Line 207: new ArrayList<>();
: channelSubKey.add(BADConstants.ResultId);
: partitionFields.add(ch
Replaceable with singletonList?
PS2, Line 278: nsertedRecordVar = "a";
: String channelSubscriptionRecordVar = "sub";
: String channelParamPrefix = channelSubscriptionRecordVar
+ ".param";
: String functionResultVar = "result";
: String brokerRecordVar = "b";
: String brokerSu
same as the previous one. Change it to private static final String and put it
at the top.
https://asterix-gerrit.ics.uci.edu/#/c/2731/2/asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java
File
asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java:
Line 343: //Find Specific Operators within the plan
Please restore the comments and format it like this:
/**
*
* @param partitioningExpr
* @param keySourceIndicators
* @param autogenerated
* @param filterField
*/
(You cant get this nice tempalte by type /** infront of a method and hit new
line in Intellij automatically.)
PS2, Line 374: tractLogicalOperator nestedOp = findOp((AbstractLogicalOperator)
subOp.getValue(), searchTag,
: subscriptionsName, subscriptionType);
: if (nestedOp != null) {
: return nestedOp;
: }
Minor code-style suggestion. If it's a recursive function, put the recursive
call branch at the top would be easier for others to understand the logic.
--
To view, visit https://asterix-gerrit.ics.uci.edu/2731
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcdf264bcd21caa0d28a9ac392b36577ca60dad
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Steven Jacobs
Gerrit-Reviewer: Xikui Wang
Gerrit-HasComments: Yes
Change in asterixdb-bad[master]: Move channels to a result sharing framework
Steven Jacobs has posted comments on this change.
Change subject: Move channels to a result sharing framework
..
Patch Set 2:
(6 comments)
Addressed Comments
https://asterix-gerrit.ics.uci.edu/#/c/2731/2/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
File
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java:
PS2, Line 181: ng channelSubVar = "channelSub";
: String param =
> Move these to the top of the class and make it public static final. Like th
Done
https://asterix-gerrit.ics.uci.edu/#/c/2731/2/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
File
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java:
PS2, Line 185: keyIndicators = new ArrayList<>();
: keyIndicators.add(0);
: keyIndicators.add(0);
> it seems the key indicator is not modified but only used as a parameter. If
Done
PS2, Line 207: new ArrayList<>();
: channelSubKey.add(BADConstants.ResultId);
: partitionFields.add(ch
> Replaceable with singletonList?
Done
PS2, Line 278: nsertedRecordVar = "a";
: String channelSubscriptionRecordVar = "sub";
: String channelParamPrefix = channelSubscriptionRecordVar
+ ".param";
: String functionResultVar = "result";
: String brokerRecordVar = "b";
: String brokerSu
> same as the previous one. Change it to private static final String and put
Done
https://asterix-gerrit.ics.uci.edu/#/c/2731/2/asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java
File
asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java:
Line 343: //Find Specific Operators within the plan
> Please restore the comments and format it like this:
Done
PS2, Line 374: tractLogicalOperator nestedOp = findOp((AbstractLogicalOperator)
subOp.getValue(), searchTag,
: subscriptionsName, subscriptionType);
: if (nestedOp != null) {
: return nestedOp;
: }
> Minor code-style suggestion. If it's a recursive function, put the recursiv
Done
--
To view, visit https://asterix-gerrit.ics.uci.edu/2731
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcdf264bcd21caa0d28a9ac392b36577ca60dad
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Steven Jacobs
Gerrit-Reviewer: Xikui Wang
Gerrit-HasComments: Yes
Change in asterixdb-bad[master]: Move channels to a result sharing framework
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2731 to look at the new patch set (#3). Change subject: Move channels to a result sharing framework .. Move channels to a result sharing framework Change-Id: Ifbcdf264bcd21caa0d28a9ac392b36577ca60dad --- M asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataExtension.java M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataRecordTypes.java M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Channel.java M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelTupleTranslator.java M asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java M asterix-bad/src/main/resources/lang-extension/lang.txt M asterix-bad/src/test/resources/optimizerts/results/channel/channel-advanced-index-only.plan M asterix-bad/src/test/resources/optimizerts/results/channel/channel-advanced.plan M asterix-bad/src/test/resources/optimizerts/results/channel/channel-create.plan M asterix-bad/src/test/resources/optimizerts/results/channel/channel-push.plan M asterix-bad/src/test/resources/optimizerts/results/channel/channel-subscribe.plan M asterix-bad/src/test/resources/optimizerts/results/channel/channel-unsubscribe.plan M asterix-bad/src/test/resources/runtimets/queries/channel/add_index/add_index.2.update.sqlpp R asterix-bad/src/test/resources/runtimets/queries/channel/add_index/add_index.5.pollquery.sqlpp M asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_datasets/create_channel_check_datasets.3.query.sqlpp M asterix-bad/src/test/resources/runtimets/queries/channel/drop_channel_check_datasets/drop_channel_check_datasets.3.query.sqlpp M asterix-bad/src/test/resources/runtimets/queries/channel/drop_subscriptions/drop_subscriptions.1.ddl.sqlpp M asterix-bad/src/test/resources/runtimets/queries/channel/room_occupants/room_occupants.4.query.sqlpp A asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.1.ddl.sqlpp C asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.2.update.sqlpp C asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.3.query.sqlpp R asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.4.query.sqlpp C asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.5.update.sqlpp C asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.6.pollquery.sqlpp M asterix-bad/src/test/resources/runtimets/queries/channel/subscribe_channel_check_subscriptions/subscribe_channel_check_subscriptions.5.query.sqlpp M asterix-bad/src/test/resources/runtimets/results/channel/create_channel_check_datasets/create_channel_check_datasets.1.adm M asterix-bad/src/test/resources/runtimets/results/channel/create_channel_check_metadata/create_channel_check_metadata.1.adm M asterix-bad/src/test/resources/runtimets/results/channel/drop_channel_check_datasets/drop_channel_check_datasets.1.adm M asterix-bad/src/test/resources/runtimets/results/channel/drop_channel_check_metadata/drop_channel_check_metadata.1.adm M asterix-bad/src/test/resources/runtimets/results/channel/room_occupants/room_occupants.1.adm A asterix-bad/src/test/resources/runtimets/results/channel/shared_subscriptions/shared_subscriptions.3.adm A asterix-bad/src/test/resources/runtimets/results/channel/shared_subscriptions/shared_subscriptions.4.adm A asterix-bad/src/test/resources/runtimets/results/channel/shared_subscriptions/shared_subscriptions.6.adm M asterix-bad/src/test/resources/runtimets/testsuite.xml 39 files changed, 1,454 insertions(+), 824 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad refs/changes/31/2731/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/2731 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifbcdf264bcd21caa0d28a9ac392b36577ca60dad Gerrit-PatchSet: 3 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Xikui Wang
Change in asterixdb-bad[master]: Move channels to a result sharing framework
Jenkins has posted comments on this change. Change subject: Move channels to a result sharing framework .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/327/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2731 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbcdf264bcd21caa0d28a9ac392b36577ca60dad Gerrit-PatchSet: 3 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb-bad[master]: Move channels to a result sharing framework
Xikui Wang has posted comments on this change. Change subject: Move channels to a result sharing framework .. Patch Set 3: (2 comments) two minors. let me know it's ready to push and i will +2. :) https://asterix-gerrit.ics.uci.edu/#/c/2731/3/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java File asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java: PS3, Line 348: new StringReader(builder.toString()) Just notice this. You should be able to pass String directly and to avoid using the StringReader. It's a minor issue, you can fix this in next push... https://asterix-gerrit.ics.uci.edu/#/c/2731/3/asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java File asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java: PS3, Line 343: // remove this -- To view, visit https://asterix-gerrit.ics.uci.edu/2731 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbcdf264bcd21caa0d28a9ac392b36577ca60dad Gerrit-PatchSet: 3 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: Yes
Change in asterixdb-bad[master]: Move channels to a result sharing framework
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2731 to look at the new patch set (#4). Change subject: Move channels to a result sharing framework .. Move channels to a result sharing framework Change-Id: Ifbcdf264bcd21caa0d28a9ac392b36577ca60dad --- M asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataExtension.java M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataRecordTypes.java M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Channel.java M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelTupleTranslator.java M asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java M asterix-bad/src/main/resources/lang-extension/lang.txt M asterix-bad/src/test/resources/optimizerts/results/channel/channel-advanced-index-only.plan M asterix-bad/src/test/resources/optimizerts/results/channel/channel-advanced.plan M asterix-bad/src/test/resources/optimizerts/results/channel/channel-create.plan M asterix-bad/src/test/resources/optimizerts/results/channel/channel-push.plan M asterix-bad/src/test/resources/optimizerts/results/channel/channel-subscribe.plan M asterix-bad/src/test/resources/optimizerts/results/channel/channel-unsubscribe.plan M asterix-bad/src/test/resources/runtimets/queries/channel/add_index/add_index.2.update.sqlpp R asterix-bad/src/test/resources/runtimets/queries/channel/add_index/add_index.5.pollquery.sqlpp M asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_datasets/create_channel_check_datasets.3.query.sqlpp M asterix-bad/src/test/resources/runtimets/queries/channel/drop_channel_check_datasets/drop_channel_check_datasets.3.query.sqlpp M asterix-bad/src/test/resources/runtimets/queries/channel/drop_subscriptions/drop_subscriptions.1.ddl.sqlpp M asterix-bad/src/test/resources/runtimets/queries/channel/room_occupants/room_occupants.4.query.sqlpp A asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.1.ddl.sqlpp C asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.2.update.sqlpp C asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.3.query.sqlpp R asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.4.query.sqlpp C asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.5.update.sqlpp C asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.6.pollquery.sqlpp M asterix-bad/src/test/resources/runtimets/queries/channel/subscribe_channel_check_subscriptions/subscribe_channel_check_subscriptions.5.query.sqlpp M asterix-bad/src/test/resources/runtimets/results/channel/create_channel_check_datasets/create_channel_check_datasets.1.adm M asterix-bad/src/test/resources/runtimets/results/channel/create_channel_check_metadata/create_channel_check_metadata.1.adm M asterix-bad/src/test/resources/runtimets/results/channel/drop_channel_check_datasets/drop_channel_check_datasets.1.adm M asterix-bad/src/test/resources/runtimets/results/channel/drop_channel_check_metadata/drop_channel_check_metadata.1.adm M asterix-bad/src/test/resources/runtimets/results/channel/room_occupants/room_occupants.1.adm A asterix-bad/src/test/resources/runtimets/results/channel/shared_subscriptions/shared_subscriptions.3.adm A asterix-bad/src/test/resources/runtimets/results/channel/shared_subscriptions/shared_subscriptions.4.adm A asterix-bad/src/test/resources/runtimets/results/channel/shared_subscriptions/shared_subscriptions.6.adm M asterix-bad/src/test/resources/runtimets/testsuite.xml 39 files changed, 1,453 insertions(+), 828 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad refs/changes/31/2731/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/2731 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifbcdf264bcd21caa0d28a9ac392b36577ca60dad Gerrit-PatchSet: 4 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Xikui Wang
Change in asterixdb-bad[master]: Move channels to a result sharing framework
Steven Jacobs has posted comments on this change. Change subject: Move channels to a result sharing framework .. Patch Set 3: (2 comments) Addressed comments https://asterix-gerrit.ics.uci.edu/#/c/2731/3/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java File asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java: PS3, Line 348: new StringReader(builder.toString()) > Just notice this. You should be able to pass String directly and to avoid u Done https://asterix-gerrit.ics.uci.edu/#/c/2731/3/asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java File asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java: PS3, Line 343: // > remove this Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2731 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbcdf264bcd21caa0d28a9ac392b36577ca60dad Gerrit-PatchSet: 3 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: Yes
Change in asterixdb-bad[master]: Move channels to a result sharing framework
Jenkins has posted comments on this change. Change subject: Move channels to a result sharing framework .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/328/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2731 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbcdf264bcd21caa0d28a9ac392b36577ca60dad Gerrit-PatchSet: 4 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb-bad[master]: Move channels to a result sharing framework
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2731 to look at the new patch set (#5). Change subject: Move channels to a result sharing framework .. Move channels to a result sharing framework Change-Id: Ifbcdf264bcd21caa0d28a9ac392b36577ca60dad --- M asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataExtension.java M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataRecordTypes.java M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Channel.java M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelTupleTranslator.java M asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java M asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerOperator.java M asterix-bad/src/main/resources/lang-extension/lang.txt M asterix-bad/src/test/resources/optimizerts/results/channel/channel-advanced-index-only.plan M asterix-bad/src/test/resources/optimizerts/results/channel/channel-advanced.plan M asterix-bad/src/test/resources/optimizerts/results/channel/channel-create.plan M asterix-bad/src/test/resources/optimizerts/results/channel/channel-push.plan M asterix-bad/src/test/resources/optimizerts/results/channel/channel-subscribe.plan M asterix-bad/src/test/resources/optimizerts/results/channel/channel-unsubscribe.plan M asterix-bad/src/test/resources/runtimets/queries/channel/add_index/add_index.2.update.sqlpp R asterix-bad/src/test/resources/runtimets/queries/channel/add_index/add_index.5.pollquery.sqlpp M asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_datasets/create_channel_check_datasets.3.query.sqlpp M asterix-bad/src/test/resources/runtimets/queries/channel/drop_channel_check_datasets/drop_channel_check_datasets.3.query.sqlpp M asterix-bad/src/test/resources/runtimets/queries/channel/drop_subscriptions/drop_subscriptions.1.ddl.sqlpp M asterix-bad/src/test/resources/runtimets/queries/channel/room_occupants/room_occupants.4.query.sqlpp A asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.1.ddl.sqlpp C asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.2.update.sqlpp C asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.3.query.sqlpp R asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.4.query.sqlpp C asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.5.update.sqlpp C asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.6.pollquery.sqlpp M asterix-bad/src/test/resources/runtimets/queries/channel/subscribe_channel_check_subscriptions/subscribe_channel_check_subscriptions.5.query.sqlpp M asterix-bad/src/test/resources/runtimets/results/channel/create_channel_check_datasets/create_channel_check_datasets.1.adm M asterix-bad/src/test/resources/runtimets/results/channel/create_channel_check_metadata/create_channel_check_metadata.1.adm M asterix-bad/src/test/resources/runtimets/results/channel/drop_channel_check_datasets/drop_channel_check_datasets.1.adm M asterix-bad/src/test/resources/runtimets/results/channel/drop_channel_check_metadata/drop_channel_check_metadata.1.adm M asterix-bad/src/test/resources/runtimets/results/channel/room_occupants/room_occupants.1.adm A asterix-bad/src/test/resources/runtimets/results/channel/shared_subscriptions/shared_subscriptions.3.adm A asterix-bad/src/test/resources/runtimets/results/channel/shared_subscriptions/shared_subscriptions.4.adm A asterix-bad/src/test/resources/runtimets/results/channel/shared_subscriptions/shared_subscriptions.6.adm M asterix-bad/src/test/resources/runtimets/testsuite.xml 40 files changed, 1,471 insertions(+), 860 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad refs/changes/31/2731/5 -- To view, visit https://asterix-gerrit.ics.uci.edu/2731 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifbcdf264bcd21caa0d28a9ac392b36577ca60dad Gerrit-PatchSet: 5 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Xikui Wang
Change in asterixdb-bad[master]: Move channels to a result sharing framework
Jenkins has posted comments on this change. Change subject: Move channels to a result sharing framework .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/339/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2731 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbcdf264bcd21caa0d28a9ac392b36577ca60dad Gerrit-PatchSet: 5 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb-bad[master]: Move channels to a result sharing framework
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2731 to look at the new patch set (#6). Change subject: Move channels to a result sharing framework .. Move channels to a result sharing framework Change-Id: Ifbcdf264bcd21caa0d28a9ac392b36577ca60dad --- M asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataExtension.java M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataRecordTypes.java M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Channel.java M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelTupleTranslator.java M asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java M asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerOperator.java M asterix-bad/src/main/resources/lang-extension/lang.txt M asterix-bad/src/test/resources/optimizerts/results/channel/channel-advanced-index-only.plan M asterix-bad/src/test/resources/optimizerts/results/channel/channel-advanced.plan M asterix-bad/src/test/resources/optimizerts/results/channel/channel-create.plan M asterix-bad/src/test/resources/optimizerts/results/channel/channel-push.plan M asterix-bad/src/test/resources/optimizerts/results/channel/channel-subscribe.plan M asterix-bad/src/test/resources/optimizerts/results/channel/channel-unsubscribe.plan M asterix-bad/src/test/resources/runtimets/queries/channel/add_index/add_index.2.update.sqlpp R asterix-bad/src/test/resources/runtimets/queries/channel/add_index/add_index.5.pollquery.sqlpp M asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_datasets/create_channel_check_datasets.3.query.sqlpp M asterix-bad/src/test/resources/runtimets/queries/channel/drop_channel_check_datasets/drop_channel_check_datasets.3.query.sqlpp M asterix-bad/src/test/resources/runtimets/queries/channel/drop_subscriptions/drop_subscriptions.1.ddl.sqlpp M asterix-bad/src/test/resources/runtimets/queries/channel/room_occupants/room_occupants.4.query.sqlpp A asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.1.ddl.sqlpp C asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.2.update.sqlpp C asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.3.query.sqlpp R asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.4.query.sqlpp C asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.5.update.sqlpp C asterix-bad/src/test/resources/runtimets/queries/channel/shared_subscriptions/shared_subscriptions.6.pollquery.sqlpp M asterix-bad/src/test/resources/runtimets/queries/channel/subscribe_channel_check_subscriptions/subscribe_channel_check_subscriptions.5.query.sqlpp M asterix-bad/src/test/resources/runtimets/results/channel/create_channel_check_datasets/create_channel_check_datasets.1.adm M asterix-bad/src/test/resources/runtimets/results/channel/create_channel_check_metadata/create_channel_check_metadata.1.adm M asterix-bad/src/test/resources/runtimets/results/channel/drop_channel_check_datasets/drop_channel_check_datasets.1.adm M asterix-bad/src/test/resources/runtimets/results/channel/drop_channel_check_metadata/drop_channel_check_metadata.1.adm M asterix-bad/src/test/resources/runtimets/results/channel/room_occupants/room_occupants.1.adm A asterix-bad/src/test/resources/runtimets/results/channel/shared_subscriptions/shared_subscriptions.3.adm A asterix-bad/src/test/resources/runtimets/results/channel/shared_subscriptions/shared_subscriptions.4.adm A asterix-bad/src/test/resources/runtimets/results/channel/shared_subscriptions/shared_subscriptions.6.adm M asterix-bad/src/test/resources/runtimets/testsuite.xml 40 files changed, 1,469 insertions(+), 863 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad refs/changes/31/2731/6 -- To view, visit https://asterix-gerrit.ics.uci.edu/2731 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifbcdf264bcd21caa0d28a9ac392b36577ca60dad Gerrit-PatchSet: 6 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Xikui Wang
Change in asterixdb-bad[master]: Move channels to a result sharing framework
Jenkins has posted comments on this change. Change subject: Move channels to a result sharing framework .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/340/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2731 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbcdf264bcd21caa0d28a9ac392b36577ca60dad Gerrit-PatchSet: 6 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
