Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 17:

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-integration-tests/8/ : 
FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 17:

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-integration-tests/7/ : 
FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 17:

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-integration-tests/6/ : 
FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 17: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 17:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/40/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Steven Jacobs (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1227

to look at the new patch set (#17).

Change subject: Updated to match code changes to asterix
..

Updated to match code changes to asterix

Added Procedure Langauge and Metadata
Restructured to fit with bom pom
Added ChannelJobService for execution tasks
Added string constants file
Added BAD Rewrite Rule Set

Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
---
M .gitignore
A asterix-bad/pom.xml
A asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java
R asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobInfo.java
A asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADLangExtension.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADParserFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorExtension.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorFactory.java
A asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADRuleSetFactory.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/BrokerDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateBrokerStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataExtension.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataIndexes.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataRecordTypes.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Broker.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerTupleTranslator.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Channel.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelEventsListener.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelTupleTranslator.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/DataverseBrokersSearchKey.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/DataverseChannelsSearchKey.java
A asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Procedure.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ProcedureSearchKey.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ProcedureTupleTranslator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerPOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntimeFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorDescriptor.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorNodePushable.java
R asterix-bad/src/main/resources/lang-extension/lang.txt
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADExecutionTest.java
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADOptimizerTest.java
R asterix-bad/src/test/resources/conf/asterix-build-configuration.xml
R asterix-bad/src/test/resources/conf/cluster.xml
R asterix-bad/src/test/resources/conf/hyracks-deployment.properties
R asterix-bad/src/test/resources/conf/test.properties
R asterix-bad/src/test/resources/optimizerts/queries/channel/channel-create.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-subscribe.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-unsubscribe.aql
A asterix-bad/src/test/resources/optimizerts/results/channel/channel-create.plan
A 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-subscribe.plan
A 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-unsubscribe.plan
R 

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 16:

(3 comments)

Looks good to me with the exception of the issue for the ruleset. definitely 
needs to be highlighted very clearly at least. I am pretty sure this would lead 
to many build failures in the future. I am pretty sure that is not the way to 
go but can be fine with a plan to address.
Your call at the end.

https://asterix-gerrit.ics.uci.edu/#/c/1227/16/asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADRuleSetFactory.java
File 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADRuleSetFactory.java:

Line 39: if (logicalRuleSet.size() != 14) {
I assume this will break if a new new rule has been added. Maybe you want to do 
something else.

For example, if the size changes, print a warning log and instead of using the 
specific index for the "InsertBrokerNotifierForChannelRule", we can basically 
look for the rule number 17 by name and insert the new rule after that one.

Also, this is dangerous if a rule was deleted and another was created as the 
system will not detect it.

Definitely something to consider.


https://asterix-gerrit.ics.uci.edu/#/c/1227/16/pom.xml
File pom.xml:

Line 24: pom
No!


Line 31: 
No!


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 16:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/39/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Steven Jacobs (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1227

to look at the new patch set (#16).

Change subject: Updated to match code changes to asterix
..

Updated to match code changes to asterix

Added Procedure Langauge and Metadata
Restructured to fit with bom pom
Added ChannelJobService for execution tasks
Added string constants file
Added BAD Rewrite Rule Set

Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
---
M .gitignore
A asterix-bad/pom.xml
A asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java
R asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobInfo.java
A asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADLangExtension.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADParserFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorExtension.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorFactory.java
A asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADRuleSetFactory.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/BrokerDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateBrokerStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataExtension.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataIndexes.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataRecordTypes.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Broker.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerTupleTranslator.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Channel.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelEventsListener.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelTupleTranslator.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/DataverseBrokersSearchKey.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/DataverseChannelsSearchKey.java
A asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Procedure.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ProcedureSearchKey.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ProcedureTupleTranslator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerPOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntimeFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorDescriptor.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorNodePushable.java
R asterix-bad/src/main/resources/lang-extension/lang.txt
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADExecutionTest.java
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADOptimizerTest.java
R asterix-bad/src/test/resources/conf/asterix-build-configuration.xml
R asterix-bad/src/test/resources/conf/cluster.xml
R asterix-bad/src/test/resources/conf/hyracks-deployment.properties
R asterix-bad/src/test/resources/conf/test.properties
R asterix-bad/src/test/resources/optimizerts/queries/channel/channel-create.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-subscribe.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-unsubscribe.aql
A asterix-bad/src/test/resources/optimizerts/results/channel/channel-create.plan
A 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-subscribe.plan
A 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-unsubscribe.plan
R 

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 16:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/38/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Steven Jacobs (Code Review)]

Steven Jacobs has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 15:

(19 comments)

Addressed Comments. Uploading new patchset

https://asterix-gerrit.ics.uci.edu/#/c/1227/15/.gitignore
File .gitignore:

Line 3: asteri-opt-bom/target
> Shouldn't those be covered by "target" below?
Done


Line 12: *.hprof
> Are these actually created by the build?
build is for sure. I removed the .hprof for now because I can't remember for 
sure.


https://asterix-gerrit.ics.uci.edu/#/c/1227/15//COMMIT_MSG
Commit Message:

Line 7: Updated to match code changes to asterix
> Would be nice to have a better description here.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1227/15/asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java
File asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java:

Line 41: import org.json.JSONException;
> We shouldn't use org.json anymore - the license is category X now.
Done


Line 60: e.printStackTrace();
> Could we at least log this with a log4j logger?
Done


Line 113: //TODO: Allow Repetitive Channels to use YMD durations  
> WS
Done


Line 125: 
> empty line
Done


Line 137: 
> empty line
Done


Line 163: } catch (Exception e) {
> Remove the try-catch?
Done


Line 167: throw new Exception();
> Give an error message?
Done


Line 186: System.out.println(response.toString());
> Log to a logger?
Done


Line 189: throw new Exception();
> Give an error message?
Done


Line 193: LOGGER.info("Broker connection failed to write");
> Pass the exception it?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1227/15/asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Procedure.java
File asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Procedure.java:

Line 96: 
> empty lines?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1227/15/asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorDescriptor.java
File 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorDescriptor.java:

Line 65: } catch (Exception e) {
> Can't we just throw HyracksDataException from the beginning?
The issue here is that HyracksConnection throws a generic exception. I went 
ahead and push this down into the nodepushable though.


https://asterix-gerrit.ics.uci.edu/#/c/1227/15/asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorNodePushable.java
File 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorNodePushable.java:

Line 62: 
> Huh?
This is actually the intended use of the new ActiveSourceOperatorNodePushable
Basically the start() method runs until an external source kills the running 
executor service.


https://asterix-gerrit.ics.uci.edu/#/c/1227/15/asterix-bad/src/main/resources/lang-extension/lang.txt
File asterix-bad/src/main/resources/lang-extension/lang.txt:

Line 59:  | "broker" pairId = QualifiedName() ifExists = IfExists() 
> WS
Done


https://asterix-gerrit.ics.uci.edu/#/c/1227/15/asterix-bad/src/test/resources/runtimets/queries/channel/drop_channel_check_metadata/drop_channel_check_metadata.3.query.aql
File 
asterix-bad/src/test/resources/runtimets/queries/channel/drop_channel_check_metadata/drop_channel_check_metadata.3.query.aql:

Line 3: for $result in dataset Metadata.Channel 
> WS
Done


https://asterix-gerrit.ics.uci.edu/#/c/1227/15/asterix-opt-bom/pom.xml
File asterix-opt-bom/pom.xml:

Line 20: xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
> Formatting - WS and indentation.
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 15:

(19 comments)

A first round of comments.

https://asterix-gerrit.ics.uci.edu/#/c/1227/15/.gitignore
File .gitignore:

Line 3: asteri-opt-bom/target
Shouldn't those be covered by "target" below?


Line 12: *.hprof
Are these actually created by the build?


https://asterix-gerrit.ics.uci.edu/#/c/1227/15//COMMIT_MSG
Commit Message:

Line 7: Updated to match code changes to asterix
Would be nice to have a better description here.


https://asterix-gerrit.ics.uci.edu/#/c/1227/15/asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java
File asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java:

Line 41: import org.json.JSONException;
We shouldn't use org.json anymore - the license is category X now.


Line 60: e.printStackTrace();
Could we at least log this with a log4j logger?


Line 113: //TODO: Allow Repetitive Channels to use YMD durations  
WS


Line 125: 
empty line


Line 137: 
empty line


Line 163: } catch (Exception e) {
Remove the try-catch?


Line 167: throw new Exception();
Give an error message?


Line 186: System.out.println(response.toString());
Log to a logger?


Line 189: throw new Exception();
Give an error message?


Line 193: LOGGER.info("Broker connection failed to write");
Pass the exception it?


https://asterix-gerrit.ics.uci.edu/#/c/1227/15/asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Procedure.java
File asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Procedure.java:

Line 96: 
empty lines?


https://asterix-gerrit.ics.uci.edu/#/c/1227/15/asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorDescriptor.java
File 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorDescriptor.java:

Line 65: } catch (Exception e) {
Can't we just throw HyracksDataException from the beginning?


https://asterix-gerrit.ics.uci.edu/#/c/1227/15/asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorNodePushable.java
File 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorNodePushable.java:

Line 62: 
Huh?


https://asterix-gerrit.ics.uci.edu/#/c/1227/15/asterix-bad/src/main/resources/lang-extension/lang.txt
File asterix-bad/src/main/resources/lang-extension/lang.txt:

Line 59:  | "broker" pairId = QualifiedName() ifExists = IfExists() 
WS


https://asterix-gerrit.ics.uci.edu/#/c/1227/15/asterix-bad/src/test/resources/runtimets/queries/channel/drop_channel_check_metadata/drop_channel_check_metadata.3.query.aql
File 
asterix-bad/src/test/resources/runtimets/queries/channel/drop_channel_check_metadata/drop_channel_check_metadata.3.query.aql:

Line 3: for $result in dataset Metadata.Channel 
WS


https://asterix-gerrit.ics.uci.edu/#/c/1227/15/asterix-opt-bom/pom.xml
File asterix-opt-bom/pom.xml:

Line 20: xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
Formatting - WS and indentation.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Steven Jacobs (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1227

to look at the new patch set (#15).

Change subject: Updated to match code changes to asterix
..

Updated to match code changes to asterix

Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
---
M .gitignore
A asterix-bad/pom.xml
A asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java
R asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobInfo.java
A asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADLangExtension.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADParserFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorExtension.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorFactory.java
A asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADRuleSetFactory.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/BrokerDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateBrokerStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataExtension.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataIndexes.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataRecordTypes.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Broker.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerTupleTranslator.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Channel.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelEventsListener.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelTupleTranslator.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/DataverseBrokersSearchKey.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/DataverseChannelsSearchKey.java
A asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Procedure.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ProcedureSearchKey.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ProcedureTupleTranslator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerPOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntimeFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorDescriptor.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorNodePushable.java
R asterix-bad/src/main/resources/lang-extension/lang.txt
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADExecutionTest.java
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADOptimizerTest.java
R asterix-bad/src/test/resources/conf/asterix-build-configuration.xml
R asterix-bad/src/test/resources/conf/cluster.xml
R asterix-bad/src/test/resources/conf/hyracks-deployment.properties
R asterix-bad/src/test/resources/conf/test.properties
R asterix-bad/src/test/resources/optimizerts/queries/channel/channel-create.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-subscribe.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-unsubscribe.aql
A asterix-bad/src/test/resources/optimizerts/results/channel/channel-create.plan
A 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-subscribe.plan
A 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-unsubscribe.plan
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_datasets/create_channel_check_datasets.1.ddl.aql
R 

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 15:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/37/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 14:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/36/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Steven Jacobs (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1227

to look at the new patch set (#14).

Change subject: Updated to match code changes to asterix
..

Updated to match code changes to asterix

Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
---
M .gitignore
A asterix-bad/pom.xml
A asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java
R asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobInfo.java
A asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADLangExtension.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADParserFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorExtension.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorFactory.java
A asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADRuleSetFactory.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/BrokerDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateBrokerStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataExtension.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataIndexes.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataRecordTypes.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Broker.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerTupleTranslator.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Channel.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelEventsListener.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelTupleTranslator.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/DataverseBrokersSearchKey.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/DataverseChannelsSearchKey.java
A asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Procedure.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ProcedureSearchKey.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ProcedureTupleTranslator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerPOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntimeFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorDescriptor.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorNodePushable.java
R asterix-bad/src/main/resources/lang-extension/lang.txt
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADExecutionTest.java
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADOptimizerTest.java
R asterix-bad/src/test/resources/conf/asterix-build-configuration.xml
R asterix-bad/src/test/resources/conf/cluster.xml
R asterix-bad/src/test/resources/conf/hyracks-deployment.properties
R asterix-bad/src/test/resources/conf/test.properties
R asterix-bad/src/test/resources/optimizerts/queries/channel/channel-create.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-subscribe.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-unsubscribe.aql
A asterix-bad/src/test/resources/optimizerts/results/channel/channel-create.plan
A 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-subscribe.plan
A 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-unsubscribe.plan
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_datasets/create_channel_check_datasets.1.ddl.aql
R 

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 13:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/35/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Steven Jacobs (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1227

to look at the new patch set (#13).

Change subject: Updated to match code changes to asterix
..

Updated to match code changes to asterix

Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
---
M .gitignore
A asterix-bad/pom.xml
A asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java
R asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobInfo.java
A asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADLangExtension.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADParserFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorExtension.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorFactory.java
A asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADRuleSetFactory.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/BrokerDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateBrokerStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataExtension.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataIndexes.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataRecordTypes.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Broker.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerTupleTranslator.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Channel.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelEventsListener.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelTupleTranslator.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/DataverseBrokersSearchKey.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/DataverseChannelsSearchKey.java
A asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Procedure.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ProcedureSearchKey.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ProcedureTupleTranslator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerPOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntimeFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorDescriptor.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorNodePushable.java
R asterix-bad/src/main/resources/lang-extension/lang.txt
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADExecutionTest.java
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADOptimizerTest.java
R asterix-bad/src/test/resources/conf/asterix-build-configuration.xml
R asterix-bad/src/test/resources/conf/cluster.xml
R asterix-bad/src/test/resources/conf/hyracks-deployment.properties
R asterix-bad/src/test/resources/conf/test.properties
R asterix-bad/src/test/resources/optimizerts/queries/channel/channel-create.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-subscribe.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-unsubscribe.aql
A asterix-bad/src/test/resources/optimizerts/results/channel/channel-create.plan
A 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-subscribe.plan
A 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-unsubscribe.plan
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_datasets/create_channel_check_datasets.1.ddl.aql
R 

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 12:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/34/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Steven Jacobs (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1227

to look at the new patch set (#12).

Change subject: Updated to match code changes to asterix
..

Updated to match code changes to asterix

Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
---
M .gitignore
A asterix-bad/pom.xml
R asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java
R asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobInfo.java
A asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADLangExtension.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADParserFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorExtension.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorFactory.java
A asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADRuleSetFactory.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/BrokerDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateBrokerStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataExtension.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataIndexes.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataRecordTypes.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Broker.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerTupleTranslator.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Channel.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelEventsListener.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelTupleTranslator.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/DataverseBrokersSearchKey.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/DataverseChannelsSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerPOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntimeFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorDescriptor.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorNodePushable.java
R asterix-bad/src/main/resources/lang-extension/lang.txt
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADExecutionTest.java
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADOptimizerTest.java
R asterix-bad/src/test/resources/conf/asterix-build-configuration.xml
R asterix-bad/src/test/resources/conf/cluster.xml
R asterix-bad/src/test/resources/conf/hyracks-deployment.properties
R asterix-bad/src/test/resources/conf/test.properties
R asterix-bad/src/test/resources/optimizerts/queries/channel/channel-create.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-subscribe.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-unsubscribe.aql
A asterix-bad/src/test/resources/optimizerts/results/channel/channel-create.plan
A 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-subscribe.plan
A 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-unsubscribe.plan
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_datasets/create_channel_check_datasets.1.ddl.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_datasets/create_channel_check_datasets.3.query.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_metadata/create_channel_check_metadata.1.ddl.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_metadata/create_channel_check_metadata.3.query.aql
R 

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 11:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/33/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 10:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/31/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 10:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/30/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 10:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/29/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 9:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/28/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Steven Jacobs (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1227

to look at the new patch set (#9).

Change subject: Updated to match code changes to asterix
..

Updated to match code changes to asterix

Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
---
M .gitignore
A asterix-bad/pom.xml
R asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java
R asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobInfo.java
R asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADLangExtension.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADParserFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorExtension.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorFactory.java
A asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADRuleSetFactory.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/BrokerDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateBrokerStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataExtension.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataIndexes.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataRecordTypes.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Broker.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerTupleTranslator.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Channel.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelEventsListener.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelTupleTranslator.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/DataverseBrokersSearchKey.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/DataverseChannelsSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerPOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntimeFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorDescriptor.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorNodePushable.java
R asterix-bad/src/main/resources/lang-extension/lang.txt
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADExecutionTest.java
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADOptimizerTest.java
R asterix-bad/src/test/resources/conf/asterix-build-configuration.xml
R asterix-bad/src/test/resources/conf/cluster.xml
R asterix-bad/src/test/resources/conf/hyracks-deployment.properties
R asterix-bad/src/test/resources/conf/test.properties
R asterix-bad/src/test/resources/optimizerts/queries/channel/channel-create.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-subscribe.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-unsubscribe.aql
A asterix-bad/src/test/resources/optimizerts/results/channel/channel-create.plan
A 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-subscribe.plan
A 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-unsubscribe.plan
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_datasets/create_channel_check_datasets.1.ddl.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_datasets/create_channel_check_datasets.3.query.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_metadata/create_channel_check_metadata.1.ddl.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_metadata/create_channel_check_metadata.3.query.aql
R 

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 8:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/27/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Steven Jacobs (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1227

to look at the new patch set (#8).

Change subject: Updated to match code changes to asterix
..

Updated to match code changes to asterix

Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
---
M .gitignore
A asterix-bad/pom.xml
R asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java
R asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobInfo.java
R asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADLangExtension.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADParserFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorExtension.java
A asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADRuleSetFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/BrokerDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateBrokerStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataExtension.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataIndexes.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataRecordTypes.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Broker.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerTupleTranslator.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Channel.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelEventsListener.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelTupleTranslator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerPOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntimeFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorDescriptor.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorNodePushable.java
R asterix-bad/src/main/resources/lang-extension/lang.txt
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADExecutionTest.java
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADOptimizerTest.java
R asterix-bad/src/test/resources/conf/asterix-build-configuration.xml
R asterix-bad/src/test/resources/conf/cluster.xml
R asterix-bad/src/test/resources/conf/hyracks-deployment.properties
R asterix-bad/src/test/resources/conf/test.properties
R asterix-bad/src/test/resources/optimizerts/queries/channel/channel-create.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-subscribe.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-unsubscribe.aql
R asterix-bad/src/test/resources/optimizerts/results/channel/channel-create.plan
R 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-subscribe.plan
R 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-unsubscribe.plan
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_datasets/create_channel_check_datasets.1.ddl.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_datasets/create_channel_check_datasets.3.query.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_metadata/create_channel_check_metadata.1.ddl.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_metadata/create_channel_check_metadata.3.query.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/drop_channel_check_datasets/drop_channel_check_datasets.1.ddl.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/drop_channel_check_datasets/drop_channel_check_datasets.2.ddl.aql
R 

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 7:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/26/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Steven Jacobs (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1227

to look at the new patch set (#7).

Change subject: Updated to match code changes to asterix
..

Updated to match code changes to asterix

Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
---
M .gitignore
A asterix-bad/pom.xml
R asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java
R asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobInfo.java
R asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADLangExtension.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADParserFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorExtension.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorFactory.java
A asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADRuleSetFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/BrokerDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateBrokerStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataExtension.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataIndexes.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataRecordTypes.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Broker.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerTupleTranslator.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Channel.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelEventsListener.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelTupleTranslator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerPOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntimeFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorDescriptor.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorNodePushable.java
R asterix-bad/src/main/resources/lang-extension/lang.txt
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADExecutionTest.java
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADOptimizerTest.java
R asterix-bad/src/test/resources/conf/asterix-build-configuration.xml
R asterix-bad/src/test/resources/conf/cluster.xml
R asterix-bad/src/test/resources/conf/hyracks-deployment.properties
R asterix-bad/src/test/resources/conf/test.properties
R asterix-bad/src/test/resources/optimizerts/queries/channel/channel-create.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-subscribe.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-unsubscribe.aql
R asterix-bad/src/test/resources/optimizerts/results/channel/channel-create.plan
R 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-subscribe.plan
R 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-unsubscribe.plan
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_datasets/create_channel_check_datasets.1.ddl.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_datasets/create_channel_check_datasets.3.query.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_metadata/create_channel_check_metadata.1.ddl.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_metadata/create_channel_check_metadata.3.query.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/drop_channel_check_datasets/drop_channel_check_datasets.1.ddl.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/drop_channel_check_datasets/drop_channel_check_datasets.2.ddl.aql

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 6:

It seems that we should remove the topic from this review, as the topic branch 
has been merged to master ...

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 6:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/25/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Steven Jacobs (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1227

to look at the new patch set (#6).

Change subject: Updated to match code changes to asterix
..

Updated to match code changes to asterix

Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
---
M .gitignore
A asterix-bad/pom.xml
R asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java
R asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobInfo.java
R asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADLangExtension.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADParserFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorExtension.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/BrokerDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateBrokerStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataExtension.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataIndexes.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataRecordTypes.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Broker.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerTupleTranslator.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Channel.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelEventsListener.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelTupleTranslator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerPOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntimeFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorDescriptor.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorNodePushable.java
R asterix-bad/src/main/resources/lang-extension/lang.txt
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADExecutionTest.java
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADOptimizerTest.java
R asterix-bad/src/test/resources/conf/asterix-build-configuration.xml
R asterix-bad/src/test/resources/conf/cluster.xml
R asterix-bad/src/test/resources/conf/hyracks-deployment.properties
R asterix-bad/src/test/resources/conf/test.properties
R asterix-bad/src/test/resources/optimizerts/queries/channel/channel-create.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-subscribe.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-unsubscribe.aql
R asterix-bad/src/test/resources/optimizerts/results/channel/channel-create.plan
R 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-subscribe.plan
R 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-unsubscribe.plan
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_datasets/create_channel_check_datasets.1.ddl.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_datasets/create_channel_check_datasets.3.query.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_metadata/create_channel_check_metadata.1.ddl.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_metadata/create_channel_check_metadata.3.query.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/drop_channel_check_datasets/drop_channel_check_datasets.1.ddl.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/drop_channel_check_datasets/drop_channel_check_datasets.2.ddl.aql
R 

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 5:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/24/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 4:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/23/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 4:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/22/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/20/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/19/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/18/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Steven Jacobs (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1227

to look at the new patch set (#3).

Change subject: Updated to match code changes to asterix
..

Updated to match code changes to asterix

Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
---
M .gitignore
A asterix-bad/pom.xml
R asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java
R asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobInfo.java
R asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADLangExtension.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADParserFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorExtension.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/BrokerDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateBrokerStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataExtension.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataIndexes.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataRecordTypes.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Broker.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerTupleTranslator.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Channel.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelEventsListener.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelTupleTranslator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerPOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntimeFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorDescriptor.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorNodePushable.java
R asterix-bad/src/main/resources/lang-extension/lang.txt
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADExecutionTest.java
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADOptimizerTest.java
R asterix-bad/src/test/resources/conf/asterix-build-configuration.xml
R asterix-bad/src/test/resources/conf/cluster.xml
R asterix-bad/src/test/resources/conf/hyracks-deployment.properties
R asterix-bad/src/test/resources/conf/test.properties
R asterix-bad/src/test/resources/optimizerts/queries/channel/channel-create.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-subscribe.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-unsubscribe.aql
R asterix-bad/src/test/resources/optimizerts/results/channel/channel-create.plan
R 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-subscribe.plan
R 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-unsubscribe.plan
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_datasets/create_channel_check_datasets.1.ddl.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_datasets/create_channel_check_datasets.3.query.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_metadata/create_channel_check_metadata.1.ddl.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_metadata/create_channel_check_metadata.3.query.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/drop_channel_check_datasets/drop_channel_check_datasets.1.ddl.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/drop_channel_check_datasets/drop_channel_check_datasets.2.ddl.aql
R 

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/16/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/15/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/13/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/11/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/8/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/7/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/6/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/5/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/4/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/3/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/2/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/1/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Steven Jacobs (Code Review)]

Steven Jacobs has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1227

Change subject: Updated to match code changes to asterix
..

Updated to match code changes to asterix

Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
---
M 
src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
M 
src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
M 
src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java
M src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerOperator.java
M src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerPOperator.java
5 files changed, 40 insertions(+), 20 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad 
refs/changes/27/1227/1

diff --git 
a/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
 
b/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
index 7d0cb1a..21a3ef0 100644
--- 
a/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
+++ 
b/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
@@ -29,16 +29,22 @@
 import org.apache.asterix.bad.metadata.Channel;
 import org.apache.asterix.common.exceptions.AsterixException;
 import org.apache.asterix.common.functions.FunctionSignature;
+import org.apache.asterix.lang.aql.expression.FLWOGRExpression;
+import org.apache.asterix.lang.common.base.Clause;
 import org.apache.asterix.lang.common.base.Expression;
+import org.apache.asterix.lang.common.clause.LetClause;
 import org.apache.asterix.lang.common.expression.CallExpr;
+import org.apache.asterix.lang.common.expression.FieldAccessor;
 import org.apache.asterix.lang.common.expression.FieldBinding;
 import org.apache.asterix.lang.common.expression.LiteralExpr;
 import org.apache.asterix.lang.common.expression.RecordConstructor;
+import org.apache.asterix.lang.common.expression.VariableExpr;
 import org.apache.asterix.lang.common.literal.StringLiteral;
 import org.apache.asterix.lang.common.statement.InsertStatement;
 import org.apache.asterix.lang.common.statement.Query;
 import org.apache.asterix.lang.common.statement.UpsertStatement;
 import org.apache.asterix.lang.common.struct.Identifier;
+import org.apache.asterix.lang.common.struct.VarIdentifier;
 import org.apache.asterix.lang.common.visitor.base.ILangVisitor;
 import org.apache.asterix.metadata.MetadataManager;
 import org.apache.asterix.metadata.MetadataTransactionContext;
@@ -182,18 +188,32 @@
 subscriptionTuple.setVarCounter(varCounter);
 
 if (subscriptionId == null) {
-List returnField = new ArrayList<>();
-returnField.add(BADConstants.SubscriptionId);
+
+VariableExpr subscriptionVar = new VariableExpr(new 
VarIdentifier("$sub", 1));
+VariableExpr useSubscriptionVar = new VariableExpr(new 
VarIdentifier("$sub", 1));
+VariableExpr resultVar = new VariableExpr(new 
VarIdentifier("$result", 0));
+VariableExpr useResultVar = new VariableExpr(new 
VarIdentifier("$result", 0));
+useResultVar.setIsNewVar(false);
+useSubscriptionVar.setIsNewVar(false);
+Query returnQuery = new Query(false);
+List clauseList = new ArrayList<>();
+LetClause let = new LetClause(subscriptionVar,
+new FieldAccessor(useResultVar, new 
Identifier(BADConstants.SubscriptionId)));
+clauseList.add(let);
+FLWOGRExpression body = new FLWOGRExpression(clauseList, 
useSubscriptionVar);
+returnQuery.setBody(body);
+
 metadataProvider.setResultSetId(new 
ResultSetId(resultSetIdCounter++));
 metadataProvider.setResultAsyncMode(
 resultDelivery == ResultDelivery.ASYNC || 
resultDelivery == ResultDelivery.ASYNC_DEFERRED);
 InsertStatement insert = new InsertStatement(new 
Identifier(dataverse),
-new Identifier(subscriptionsDatasetName), 
subscriptionTuple, varCounter, false, returnField);
+new Identifier(subscriptionsDatasetName), 
subscriptionTuple, varCounter, resultVar,
+returnQuery);
 ((QueryTranslator) 
statementExecutor).handleInsertUpsertStatement(metadataProvider, insert, hcc, 
hdc,
 resultDelivery, stats, false);
 } else {
 UpsertStatement upsert = new UpsertStatement(new 
Identifier(dataverse),
-new Identifier(subscriptionsDatasetName), 
subscriptionTuple, varCounter);
+new Identifier(subscriptionsDatasetName), 
subscriptionTuple, varCounter, null, null);
 ((QueryTranslator)