Change in asterixdb[master]: [NO ISSUE][RT] Ensure a cursor.close()
abdullah alamoudi has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure a cursor.close() .. Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2410/2/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/search/InvertedListMerger.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/search/InvertedListMerger.java: PS2, Line 157: invListCursor.unloadPages(); If this throws an exception, close will not be called. You can do try finally here too -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2764/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3337/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3540/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2798/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++ .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2790/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2394 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058dc0f45072a1398f6431e0c73ce680c4d8cdc7 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 3: Analytics Compatibility Compilation Successful https://goo.gl/eoxoj5 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2410 to look at the new patch set (#4). Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. [NO ISSUE][RT] Ensure an inverted list cursor.close() - user model changes: no - storage format changes: no - interface changes: no details: - Ensure to always execute an inverted list cursor.close(). Change-Id: I78c7908830be810b1d40abbd5f1978818869 --- M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/inmemory/InMemoryInvertedListCursor.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/ondisk/OnDiskInvertedIndexRangeSearchCursor.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/search/AbstractTOccurrenceSearcher.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/search/InvertedListMerger.java 4 files changed, 88 insertions(+), 50 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/10/2410/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2800/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 4: Analytics Compatibility Compilation Successful https://goo.gl/H2jq5K : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++ .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3541/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2394 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058dc0f45072a1398f6431e0c73ce680c4d8cdc7 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2791/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2792/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++ .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3304/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2394 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058dc0f45072a1398f6431e0c73ce680c4d8cdc7 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++ .. Patch Set 6: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5721/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2394 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058dc0f45072a1398f6431e0c73ce680c4d8cdc7 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3340/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/KzKq8B : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3027/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/87WHTN : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2767/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5722/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 3: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/sGtocQ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3542/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++ .. Patch Set 6: Analytics Compatibility Compilation Successful https://goo.gl/qkGVB7 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2394 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058dc0f45072a1398f6431e0c73ce680c4d8cdc7 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/816/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2766/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2801/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Change Query Plan to Use Component ID
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Change Query Plan to Use Component ID .. Patch Set 48: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3278/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2036 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bb7c8c836dffcda48861c5fd3fe25dcb7edc659 Gerrit-PatchSet: 48 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2768/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++ .. Patch Set 6: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/e9BrnR : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2394 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058dc0f45072a1398f6431e0c73ce680c4d8cdc7 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2719/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Michael Blow has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2415
Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..
[NO ISSUE] Add Invoke.runUninterruptible
Add helper method to clear interruption and restore around invocation of an
action
Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
---
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/InvokeUtil.java
1 file changed, 33 insertions(+), 12 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/15/2415/1
diff --git
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/InvokeUtil.java
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/InvokeUtil.java
index 9b356a0..bdaf479 100644
---
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/InvokeUtil.java
+++
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/InvokeUtil.java
@@ -39,7 +39,7 @@
* Executes the passed interruptible, retrying if the operation is
interrupted. Once the interruptible
* completes, the current thread will be re-interrupted, if the original
operation was interrupted.
*/
-public static void doUninterruptibly(Interruptible interruptible) {
+public static void doUninterruptibly(InterruptibleAction interruptible) {
boolean interrupted = false;
try {
while (true) {
@@ -58,10 +58,10 @@
}
/**
- * Executes the passed interruptible, retrying if the operation is
interrupted. Once the interruptible
+ * Executes the passed action, retrying if the operation is interrupted.
Once the interruptible
* completes, the current thread will be re-interrupted, if the original
operation was interrupted.
*/
-public static void doExUninterruptibly(ThrowingInterruptible
interruptible) throws Exception {
+public static void doExUninterruptibly(ThrowingAction interruptible)
throws Exception {
boolean interrupted = false;
try {
while (true) {
@@ -84,7 +84,7 @@
*
* @return true if the original operation was interrupted, otherwise false
*/
-public static boolean doUninterruptiblyGet(Interruptible interruptible) {
+public static boolean doUninterruptiblyGet(InterruptibleAction
interruptible) {
boolean interrupted = false;
while (true) {
try {
@@ -103,12 +103,12 @@
*
* @return true if the original operation was interrupted, otherwise false
*/
-public static boolean doExUninterruptiblyGet(ThrowingInterruptible
interruptible) throws Exception {
+public static boolean doExUninterruptiblyGet(Callable interruptible)
throws Exception {
boolean interrupted = false;
boolean success = false;
while (true) {
try {
-interruptible.run();
+interruptible.call();
success = true;
break;
} catch (InterruptedException e) { // NOSONAR- contract states
caller must handle
@@ -154,7 +154,7 @@
* {@link InterruptedException}. Once the interruptible completes, the
current thread will be re-interrupted, if
* the original operation was interrupted.
*/
-public static void doIoUninterruptibly(ThrowingIOInterruptible
interruptible) throws IOException {
+public static void doIoUninterruptibly(IOInterruptibleAction
interruptible) throws IOException {
boolean interrupted = false;
try {
while (true) {
@@ -175,7 +175,7 @@
}
@SuppressWarnings({ "squid:S1181", "squid:S1193" }) // catching Throwable,
instanceof of exception
-public static void tryWithCleanups(ThrowingInterruptible action,
ThrowingInterruptible... cleanups)
+public static void tryWithCleanups(ThrowingAction action,
ThrowingAction... cleanups)
throws Exception {
Throwable savedT = null;
boolean suppressedInterrupted = false;
@@ -184,7 +184,7 @@
} catch (Throwable t) {
savedT = t;
} finally {
-for (ThrowingInterruptible cleanup : cleanups) {
+for (ThrowingAction cleanup : cleanups) {
try {
cleanup.run();
} catch (Throwable t) {
@@ -212,18 +212,39 @@
}
}
+/**
+ * Runs the supplied action, after suspending any pending interruption.
An error will be logged if
+ * the action is itself interrupted.
+ */
+public static void runUninterruptible(ThrowingAction action) throws
Exception {
+boolean interrupted = Thread.interrupted();
+try {
+action.run();
+if (Thread.interrupted()) {
+throw new InterruptedException();
+}
+} catch (Interrup
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3023/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2789/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++ .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8264/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2394 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058dc0f45072a1398f6431e0c73ce680c4d8cdc7 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++ .. Patch Set 6: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2749/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2394 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058dc0f45072a1398f6431e0c73ce680c4d8cdc7 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2410 to look at the new patch set (#3). Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. [NO ISSUE][RT] Ensure an inverted list cursor.close() - user model changes: no - storage format changes: no - interface changes: no details: - Ensure to always execute an inverted list cursor.close(). Change-Id: I78c7908830be810b1d40abbd5f1978818869 --- M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/inmemory/InMemoryInvertedListCursor.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/search/AbstractTOccurrenceSearcher.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/search/InvertedListMerger.java 3 files changed, 41 insertions(+), 30 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/10/2410/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8265/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++ .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2718/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2394 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058dc0f45072a1398f6431e0c73ce680c4d8cdc7 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2188] Ensure recovery of component ids
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2188] Ensure recovery of component ids .. Patch Set 5: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5718/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2408 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c1fc2b209cfb9d3dafa216771d2b7032eb99e75 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Michael Blow has uploaded a new patch set (#2). Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. [NO ISSUE] Add Invoke.runUninterruptible Add helper method to clear interruption and restore around invocation of an action Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 --- M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/InvokeUtil.java 1 file changed, 33 insertions(+), 13 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/15/2415/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6759/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8263/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/817/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++ .. Patch Set 6: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2394 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058dc0f45072a1398f6431e0c73ce680c4d8cdc7 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2793/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6760/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2802/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++ .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3338/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2394 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058dc0f45072a1398f6431e0c73ce680c4d8cdc7 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++ .. Patch Set 6: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2749/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2394 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058dc0f45072a1398f6431e0c73ce680c4d8cdc7 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. Patch Set 2: Code-Review+2 Integration-Tests+1 Verified+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2750/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2720/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Change Query Plan to Use Component ID
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Change Query Plan to Use Component ID .. Patch Set 48: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3303/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2036 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bb7c8c836dffcda48861c5fd3fe25dcb7edc659 Gerrit-PatchSet: 48 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3339/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6758/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/815/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5720/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++ .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2799/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2394 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058dc0f45072a1398f6431e0c73ce680c4d8cdc7 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++ .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3024/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2394 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058dc0f45072a1398f6431e0c73ce680c4d8cdc7 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Change Query Plan to Use Component ID
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Change Query Plan to Use Component ID .. Patch Set 48: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5719/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2036 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bb7c8c836dffcda48861c5fd3fe25dcb7edc659 Gerrit-PatchSet: 48 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++ .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6757/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2394 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058dc0f45072a1398f6431e0c73ce680c4d8cdc7 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++ .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2765/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2394 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058dc0f45072a1398f6431e0c73ce680c4d8cdc7 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/813/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3026/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Taewoo Kim has posted comments on this change.
Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close()
..
Patch Set 4:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/2410/2/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/search/InvertedListMerger.java
File
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/search/InvertedListMerger.java:
PS2, Line 157: try {
> If this throws an exception, close will not be called.
Done
--
To view, visit https://asterix-gerrit.ics.uci.edu/2410
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Taewoo Kim
Gerrit-Reviewer: abdullah alamoudi
Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. Patch Set 2: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2750/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Michael Blow has submitted this change and it was merged.
Change subject: [NO ISSUE] Add Invoke.runUninterruptible
..
[NO ISSUE] Add Invoke.runUninterruptible
Add helper method to clear interruption and restore around invocation of an
action
Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2415
Sonar-Qube: Jenkins
Reviewed-by: Murtadha Hubail
Integration-Tests: Murtadha Hubail
Tested-by: Murtadha Hubail
Contrib: Jenkins
---
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/InvokeUtil.java
1 file changed, 33 insertions(+), 13 deletions(-)
Approvals:
Jenkins: No violations found;
Murtadha Hubail: Looks good to me, approved; Verified; Verified
diff --git
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/InvokeUtil.java
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/InvokeUtil.java
index 9b356a0..ba4f82d 100644
---
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/InvokeUtil.java
+++
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/InvokeUtil.java
@@ -39,7 +39,7 @@
* Executes the passed interruptible, retrying if the operation is
interrupted. Once the interruptible
* completes, the current thread will be re-interrupted, if the original
operation was interrupted.
*/
-public static void doUninterruptibly(Interruptible interruptible) {
+public static void doUninterruptibly(InterruptibleAction interruptible) {
boolean interrupted = false;
try {
while (true) {
@@ -58,10 +58,10 @@
}
/**
- * Executes the passed interruptible, retrying if the operation is
interrupted. Once the interruptible
+ * Executes the passed action, retrying if the operation is interrupted.
Once the interruptible
* completes, the current thread will be re-interrupted, if the original
operation was interrupted.
*/
-public static void doExUninterruptibly(ThrowingInterruptible
interruptible) throws Exception {
+public static void doExUninterruptibly(ThrowingAction interruptible)
throws Exception {
boolean interrupted = false;
try {
while (true) {
@@ -84,7 +84,7 @@
*
* @return true if the original operation was interrupted, otherwise false
*/
-public static boolean doUninterruptiblyGet(Interruptible interruptible) {
+public static boolean doUninterruptiblyGet(InterruptibleAction
interruptible) {
boolean interrupted = false;
while (true) {
try {
@@ -103,12 +103,12 @@
*
* @return true if the original operation was interrupted, otherwise false
*/
-public static boolean doExUninterruptiblyGet(ThrowingInterruptible
interruptible) throws Exception {
+public static boolean doExUninterruptiblyGet(Callable interruptible)
throws Exception {
boolean interrupted = false;
boolean success = false;
while (true) {
try {
-interruptible.run();
+interruptible.call();
success = true;
break;
} catch (InterruptedException e) { // NOSONAR- contract states
caller must handle
@@ -154,7 +154,7 @@
* {@link InterruptedException}. Once the interruptible completes, the
current thread will be re-interrupted, if
* the original operation was interrupted.
*/
-public static void doIoUninterruptibly(ThrowingIOInterruptible
interruptible) throws IOException {
+public static void doIoUninterruptibly(IOInterruptibleAction
interruptible) throws IOException {
boolean interrupted = false;
try {
while (true) {
@@ -175,8 +175,7 @@
}
@SuppressWarnings({ "squid:S1181", "squid:S1193" }) // catching Throwable,
instanceof of exception
-public static void tryWithCleanups(ThrowingInterruptible action,
ThrowingInterruptible... cleanups)
-throws Exception {
+public static void tryWithCleanups(ThrowingAction action,
ThrowingAction... cleanups) throws Exception {
Throwable savedT = null;
boolean suppressedInterrupted = false;
try {
@@ -184,7 +183,7 @@
} catch (Throwable t) {
savedT = t;
} finally {
-for (ThrowingInterruptible cleanup : cleanups) {
+for (ThrowingAction cleanup : cleanups) {
try {
cleanup.run();
} catch (Throwable t) {
@@ -212,18 +211,39 @@
}
}
+/**
+ * Runs the supplied action, after suspending any pending interruption.
An error will be logged if
+ * the action is itself interrupted.
+ */
+public static void runUninterruptible(ThrowingAction action) throws
Exception {
+boolean
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2717/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3025/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 4: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/mSK5f7 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3281/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++ .. Patch Set 6: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5721/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2394 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058dc0f45072a1398f6431e0c73ce680c4d8cdc7 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3305/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5723/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3543/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 4: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2751/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 4: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5722/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3282/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 4: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2751/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 3: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/9hnCKM : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3306/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2188] Ensure recovery of component ids
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2188] Ensure recovery of component ids .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2794/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2408 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c1fc2b209cfb9d3dafa216771d2b7032eb99e75 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6756/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2721/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++ .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3280/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2394 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058dc0f45072a1398f6431e0c73ce680c4d8cdc7 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3279/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3341/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2188] Ensure recovery of component ids
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2188] Ensure recovery of component ids .. Patch Set 5: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2752/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2408 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c1fc2b209cfb9d3dafa216771d2b7032eb99e75 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2188] Ensure recovery of component ids
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2188] Ensure recovery of component ids .. Patch Set 5: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2752/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2408 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c1fc2b209cfb9d3dafa216771d2b7032eb99e75 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
abdullah alamoudi has posted comments on this change. Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close() .. Patch Set 4: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78c7908830be810b1d40abbd5f1978818869 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Ensure an inverted list cursor.close()
Taewoo Kim has submitted this change and it was merged.
Change subject: [NO ISSUE][RT] Ensure an inverted list cursor.close()
..
[NO ISSUE][RT] Ensure an inverted list cursor.close()
- user model changes: no
- storage format changes: no
- interface changes: no
details:
- Ensure to always execute an inverted list cursor.close().
Change-Id: I78c7908830be810b1d40abbd5f1978818869
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2410
Sonar-Qube: Jenkins
Tested-by: Jenkins
Integration-Tests: Jenkins
Contrib: Jenkins
Reviewed-by: abdullah alamoudi
---
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/inmemory/InMemoryInvertedListCursor.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/ondisk/OnDiskInvertedIndexRangeSearchCursor.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/search/AbstractTOccurrenceSearcher.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/search/InvertedListMerger.java
4 files changed, 88 insertions(+), 50 deletions(-)
Approvals:
abdullah alamoudi: Looks good to me, approved
Jenkins: Verified; No violations found; ; Verified
Objections:
Anon. E. Moose #1000171: Violations found
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/inmemory/InMemoryInvertedListCursor.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/inmemory/InMemoryInvertedListCursor.java
index 085f8d5..6e8689b 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/inmemory/InMemoryInvertedListCursor.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/inmemory/InMemoryInvertedListCursor.java
@@ -172,6 +172,7 @@
btreePred.setHighKey(btreeSearchTuple, true);
try {
btreeAccessor.search(btreeCursor, btreePred);
+cursorNeedsClose = true;
} catch (Exception e) {
btreeSearchTuple.removeLastTuple();
throw HyracksDataException.create(e);
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/ondisk/OnDiskInvertedIndexRangeSearchCursor.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/ondisk/OnDiskInvertedIndexRangeSearchCursor.java
index a33b045..d9e7d34 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/ondisk/OnDiskInvertedIndexRangeSearchCursor.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/ondisk/OnDiskInvertedIndexRangeSearchCursor.java
@@ -87,8 +87,11 @@
return true;
}
// The current inverted-list-range-search cursor is exhausted.
-invListRangeSearchCursor.unloadPages();
-invListRangeSearchCursor.close();
+try {
+invListRangeSearchCursor.unloadPages();
+} finally {
+invListRangeSearchCursor.close();
+}
isInvListCursorOpen = false;
openInvListRangeSearchCursor();
return isInvListCursorOpen;
@@ -105,22 +108,34 @@
@Override
public void doDestroy() throws HyracksDataException {
-if (isInvListCursorOpen) {
-invListRangeSearchCursor.unloadPages();
-invListRangeSearchCursor.destroy();
-isInvListCursorOpen = false;
+try {
+if (isInvListCursorOpen) {
+try {
+invListRangeSearchCursor.unloadPages();
+} finally {
+isInvListCursorOpen = false;
+invListRangeSearchCursor.destroy();
+}
+}
+} finally {
+btreeCursor.destroy();
}
-btreeCursor.destroy();
}
@Override
public void doClose() throws HyracksDataException {
-if (isInvListCursorOpen) {
-invListRangeSearchCursor.unloadPages();
-invListRangeSearchCursor.close();
-isInvListCursorOpen = false;
+try {
+if (isInvListCursorOpen) {
+try {
+invListRangeSearchCursor.unloadPages();
+} finally {
+invListRangeSearchCursor.close();
+
Change in asterixdb[master]: [NO ISSUE] Add Invoke.runUninterruptible
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Add Invoke.runUninterruptible .. Patch Set 2: Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5723/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0a5dcb36bfc43168498b9a0a2a4afccedfc4f6 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
[jira] [Created] (ASTERIXDB-2294) Implement is_atomic() function
Dmitry Lychagin created ASTERIXDB-2294: -- Summary: Implement is_atomic() function Key: ASTERIXDB-2294 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2294 Project: Apache AsterixDB Issue Type: Improvement Components: FUN - Functions Reporter: Dmitry Lychagin Assignee: Dmitry Lychagin Implement is_atomic() functions which returns whether input argument is of primitive type or not. Aliases: isatomic(), isatom() -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8268/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2795/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3283/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2803/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/818/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()
Dmitry Lychagin has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2416
Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic()
..
[ASTERIXDB-2294][FUN] Implement is_atomic()
- user model changes: yes
- storage format changes: no
- interface changes: no
Details:
- Implement is_atomic() function with aliases isatomic(), isatom()
- Add testcases and documentation
Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2
---
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/isatomic/isatomic.1.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/results/types/isatomic/isatomic.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md
M
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/CommonFunctionMapUtil.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java
A
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/IsAtomicDescriptor.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionCollection.java
8 files changed, 142 insertions(+), 0 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/16/2416/1
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/isatomic/isatomic.1.query.sqlpp
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/isatomic/isatomic.1.query.sqlpp
new file mode 100644
index 000..d8b2389
--- /dev/null
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/isatomic/isatomic.1.query.sqlpp
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+{
+ "a": isatomic(true),
+ "b": isatomic(false),
+ "c": is_atomic(null),
+ "d": is_atomic(missing),
+ "e": isatom("d"),
+ "f": isatom4.0),
+ "g": isatom(5),
+ "h": isatom(["1", 2]),
+ "i": isatom({"a":1})
+};
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/results/types/isatomic/isatomic.1.adm
b/asterixdb/asterix-app/src/test/resources/runtimets/results/types/isatomic/isatomic.1.adm
new file mode 100644
index 000..b6cd2d0
--- /dev/null
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/results/types/isatomic/isatomic.1.adm
@@ -0,0 +1 @@
+{ "a": true, "b": true, "c": null, "e": true, "f": true, "g": true, "h":
false, "i": false }
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
index 909b523..541cd1b 100644
--- a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
@@ -9013,6 +9013,11 @@
+
+isatomic
+
+
+
isboolean
diff --git a/asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md
b/asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md
index a2b2555..ba3a735 100644
--- a/asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md
+++ b/asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md
@@ -53,6 +53,38 @@
The function has an alias `isarray`.
+### is_atomic (isatomic, isatom) ###
+ * Syntax:
+
+is_atomic(expr)
+
+ * Checks whether the given expression is evaluated to be a value of a
[primitive](../datamodel.html#PrimitiveTypes) type.
+ * Arguments:
+* `expr` : an expression (any type is allowed).
+ * Return Value:
+* a `boolean` on whether the argument is a primitive type or not,
+* a `missing` if the argument is a `missing` value,
+* a `null` if the argument is a `null` value.
+
+ * Example:
+
+{
+ "a": is_atomic(true),
+ "b": is_atomic(false),
+ "c": isatomic(null),
+ "d": isatomic(missing),
+ "e": isatomic("d"),
+ "f": isatom(4.0),
+ "g": isatom(5),
+ "h": isatom(["1", 2]),
+ "i": isatom({"a":1})
+};
+
+* The expected result is:
+
+{ "a"
