[GitHub] commons-compress issue #43: COMPRESS-413 : Improved build performance with t...

2017-06-30 Thread garydgregory
Github user garydgregory commented on the issue:

https://github.com/apache/commons-compress/pull/43
  
We all know that Java 7 is EOL but that is the required platform currently. 
As we have seen in Commons with other components, the IBM JDK sometimes gives 
surprising results. It is my opinion that we do loose confidence that all is 
well everywhere by omitting building on Oracle's JDK.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] commons-compress issue #43: COMPRESS-413 : Improved build performance with t...

2017-06-30 Thread sesuncedu
Github user sesuncedu commented on the issue:

https://github.com/apache/commons-compress/pull/43
  
Oracle JDK 7 has been dead for two years. Openjdk 7 has some back ports of 
security patches, but both are gone from most Linux distros. 

Openjdk and oraclejdk 8 are essentially in sync, with the only differences 
really being the oracle proprietary stuff. There's not much win testing against 
both unless the oracle commercial stuff is being used. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] commons-compress issue #43: COMPRESS-413 : Improved build performance with t...

2017-06-30 Thread coveralls
Github user coveralls commented on the issue:

https://github.com/apache/commons-compress/pull/43
  

[![Coverage 
Status](https://coveralls.io/builds/12210519/badge)](https://coveralls.io/builds/12210519)

Coverage increased (+0.3%) to 85.034% when pulling 
**ae1f61cbd73615829b2d25a9ee8f2eb734d73119 on sesuncedu:COMPRESS-413-REDUX** 
into **19e1b02f754a9b7bc969eb17bd52cc36a85c4d74 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] commons-compress issue #43: COMPRESS-413 : Improved build performance with t...

2017-06-30 Thread coveralls
Github user coveralls commented on the issue:

https://github.com/apache/commons-compress/pull/43
  

[![Coverage 
Status](https://coveralls.io/builds/12209789/badge)](https://coveralls.io/builds/12209789)

Coverage increased (+0.09%) to 84.856% when pulling 
**71eb8304944a50c30ff6b057ecdd9f6210477e4d on sesuncedu:COMPRESS-413-REDUX** 
into **19e1b02f754a9b7bc969eb17bd52cc36a85c4d74 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] commons-compress issue #43: COMPRESS-413 : Improved build performance with t...

2017-06-26 Thread bodewig
Github user bodewig commented on the issue:

https://github.com/apache/commons-compress/pull/43
  
Builds for PRs are already covered - 
https://builds.apache.org/job/Commons-Compress%20PullRequest%20Builder/ - and 
we could add support for building arbitrary branches if we wanted to using 
build pipelines. We just haven't got that many branches outside of PRs (master 
and the stalled compress-2.0 experiment). :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] commons-compress issue #43: COMPRESS-413 : Improved build performance with t...

2017-06-26 Thread sesuncedu
Github user sesuncedu commented on the issue:

https://github.com/apache/commons-compress/pull/43
  
Travis has some nice properties, especially when working with forks. It's 
very easy to enable travis for a fork, so CI can be done before a PR goes in.

 Travis can also run really quickly, but only when tuned properly, and when 
the system is not running at capacity. If the stars are aligned, you can get 
every job in a big 'ol  matrix running in parallel (each container build gets 2 
cores and max 4GB of memory), which is  nice if they're free.  The critical 
thing is to be using the container environments and not the VM, as the startup 
time is tiny.  The annoying thing about Travis is that the default environment 
is running Ubuntu 12.04, which is well past its LTS date. The trusty (14.04) 
container is *still* marked as beta, despite being on a production level update 
cycle (set group to edge for that real beta experience). The 12.04 containers 
all have to do a lot of package replacement on startup, which takes away some 
of the benefits of having a container ). I kept the home server on 12.04 until 
the end of LTS because Travis, then went  to xenial (16.04) which is the 
current LTS, and has nice things like proper zfs (hey- an apac
 he connection). 

Hudkins farms in my mental model usually seem to be more congested, but 
there are good reasons not to believe that. 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] commons-compress issue #43: COMPRESS-413 : Improved build performance with t...

2017-06-26 Thread sesuncedu
Github user sesuncedu commented on the issue:

https://github.com/apache/commons-compress/pull/43
  
I think there is also some jacoco oddness related to synthetic methods in 
certain JDKs , but mostly I blame coveralls, since I'm not sure jacoco is wrong 
:-)  
IntelliJ has a bunch of different coverage tracers, including jacoco, and 
they have a spread of class and line counts that seems to be all synthetic 
accessor related. 
Oh for statement level "ignore". 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] commons-compress issue #43: COMPRESS-413 : Improved build performance with t...

2017-06-26 Thread bodewig
Github user bodewig commented on the issue:

https://github.com/apache/commons-compress/pull/43
  
We all know coveralls is flaky at the sub-percent/sub-permille level.

The first paragraphs of 
https://github.com/apache/commons-compress/pull/39#issuecomment-310845353 are 
still true :-) The matrix build is 
https://builds.apache.org/view/Apache%20Commons/job/Commons-Compress%20JDK-Matrix%20Build/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] commons-compress issue #43: COMPRESS-413 : Improved build performance with t...

2017-06-24 Thread sesuncedu
Github user sesuncedu commented on the issue:

https://github.com/apache/commons-compress/pull/43
  
That's why there was random coveralls stuff in the PR... 
coverage/coveralls — Coverage decreased (-0.02%) to 84.742%



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] commons-compress issue #43: COMPRESS-413 : Improved build performance with t...

2017-06-24 Thread coveralls
Github user coveralls commented on the issue:

https://github.com/apache/commons-compress/pull/43
  

[![Coverage 
Status](https://:/builds/12118735/badge)](https://:/builds/12118735)

Coverage decreased (-0.02%) to 84.742% when pulling 
**2fc4afa8f6571048604616a8edb2bbd55b4776f4 on sesuncedu:COMPRESS-413-REDUX** 
into **19e1b02f754a9b7bc969eb17bd52cc36a85c4d74 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---