[GitHub] couchdb-couch pull request #209: remove compact files on failure
Github user jaydoane commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/209#discussion_r85454009 --- Diff: src/couch_db_updater.erl --- @@ -1454,3 +1450,13 @@ default_security_object(_DbName) -> "everyone" -> [] end. + +delete_compact_files(RootDir, FullFilepath) -> +lists:foreach(fun(Ext) -> +couch_file:delete(RootDir, FullFilepath ++ Ext) +end, [".compact", ".compact.data", ".compact.meta"]). + +purge_compact_files(FullFilepath) -> +lists:foreach(fun(Ext) -> +file:delete(FullFilepath ++ Ext) +end, [".compact", ".compact.data", ".compact.meta"]). --- End diff -- Since you repeat this list, any reason to not create a `define(COMPACT_SUFFIXES, [".compact", ".compact.data", ".compact.meta"]).` ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (COUCHDB-3216) Corrupted compact.meta files can lead to cyclic crashes with no recovery
[ https://issues.apache.org/jira/browse/COUCHDB-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613726#comment-15613726 ] ILYA commented on COUCHDB-3216: --- This PR https://github.com/apache/couchdb-couch/pull/209 should fix it. > Corrupted compact.meta files can lead to cyclic crashes with no recovery > > > Key: COUCHDB-3216 > URL: https://issues.apache.org/jira/browse/COUCHDB-3216 > Project: CouchDB > Issue Type: Bug >Reporter: ILYA > > In the case when compact.meta file is corrupted the compactor keeps crashing > over and over with no recovery. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (COUCHDB-3216) Corrupted compact.meta files can lead to cyclic crashes with no recovery
ILYA created COUCHDB-3216: - Summary: Corrupted compact.meta files can lead to cyclic crashes with no recovery Key: COUCHDB-3216 URL: https://issues.apache.org/jira/browse/COUCHDB-3216 Project: CouchDB Issue Type: Bug Reporter: ILYA In the case when compact.meta file is corrupted the compactor keeps crashing over and over with no recovery. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] couchdb-couch pull request #209: remove compact files on failure
GitHub user iilyak opened a pull request:
https://github.com/apache/couchdb-couch/pull/209
remove compact files on failure
In the case when `compact.meta` file is corrupted the compaction fails over
and over.
This fixes the cyclic failure aspect by use of a `.compact.crash` flag file.
The logic is:
```python
if there is an exception and `.compact.crash` exists:
remove(.compact.{meta|data})
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-couch
76900-remove-compact-files-on-failure
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/209.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #209
commit 0444072d8c10416800f05fb5c51bf67b25fda569
Author: ILYA Khlopotov
Date: 2016-10-24T20:50:32Z
Extract {delete|purge}_compact_files
commit 7e7498369e52c58f52423d58b1971bac97440765
Author: ILYA Khlopotov
Date: 2016-10-24T21:02:31Z
Use couch_db_updater:delete_compact_files/2
commit 72761387b02f73c9c5fa1960c9967fa7d918d2e9
Author: ILYA Khlopotov
Date: 2016-10-27T22:33:26Z
Use .compact.crash file to recover cyclic failures
Remove compact.{meta|data} files if compaction crashes
BugzID: 76900
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-replicator pull request #51: Format gen_server state to remove...
Github user iilyak commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-replicator/pull/51#discussion_r85435146
--- Diff: src/couch_replicator.erl ---
@@ -600,8 +562,23 @@ terminate_cleanup(State) ->
format_status(_Opt, [_PDict, State]) ->
-[{data, [{"State", state_strip_creds(State)}]}].
-
+Rep =
couch_replicator_utils:format_rep_record(State#rep_state.rep_details),
+[{data, [
+{"State", ?from_record(rep_state, State, [
+start_seq,
+committed_seq,
+current_through_seq,
+%%seqs_in_progress = [],
--- End diff --
not sure how useful seqs_in_progress
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request #208: 71267 format process state
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch/pull/208 71267 format process state Companion PR for https://github.com/apache/couchdb-couch-replicator/pull/51 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch 71267-format_process_state Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch/pull/208.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #208 commit da8cd161a7c6af74ca3d88ce42d537aa4312c7c4 Author: ILYA Khlopotov Date: 2016-10-27T21:27:08Z Add record_to_keyval and from_record macro COUCHDB-1606 commit d73697c3d953b27bf458e059eaf8ab9b12afb287 Author: ILYA Khlopotov Date: 2016-10-27T21:29:24Z Move assertEqualLists to couch_eunit.hrl for reuse COUCHDB-1606 commit 846064b7212980068296ade033e7b21aa0f75372 Author: ILYA Khlopotov Date: 2016-10-27T21:30:35Z Implement couch_db:format_db_record/1 COUCHDB-1606 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-couch-replicator pull request #51: Format gen_server state to remove...
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch-replicator/pull/51 Format gen_server state to remove plain passwords Add format_status/2 to every gen_server to prune the state before passing it to SASL logger. There are two goals for this work: - eliminate plain text passwords in the logs - reduce the size of the terms we log The size of a term is a real problem. Since what's currently happening is: 1. we have lot's of data in state (queues for example) 2. the process crashes so the term is send to group leader 3. eventually lagger receives the term 4. couch_log format the term (we have io:format fork [couch_log_trunc_io_fmt] (https://github.com/apache/couchdb-couch-log/blob/master/src/couch_log_trunc_io_fmt.erl)) Having truncate in step `#4` doesn't help much in case we have lot's of events to log. Since we bottleneck on group leader mailbox. Therefore we need to reduce the term size before we attempt to log it. COUCHDB-1606 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch-replicator 71267-format_process_state Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch-replicator/pull/51.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #51 commit 6adced02a672b065fb77432d58779b0ecf91359a Author: ILYA Khlopotov Date: 2016-10-27T21:18:58Z Format gen_server state to remove plain passwords Add format_status/2 to every gen_server to prune the state before passing it to SASL logger. There are two goals for this work: - eliminate plain text passwords in the logs - reduce the size of the terms we log COUCHDB-1606 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (COUCHDB-1606) Replicator leaves plaintext password in logs
[ https://issues.apache.org/jira/browse/COUCHDB-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613331#comment-15613331 ] ASF GitHub Bot commented on COUCHDB-1606: - GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch-replicator/pull/51 Format gen_server state to remove plain passwords Add format_status/2 to every gen_server to prune the state before passing it to SASL logger. There are two goals for this work: - eliminate plain text passwords in the logs - reduce the size of the terms we log The size of a term is a real problem. Since what's currently happening is: 1. we have lot's of data in state (queues for example) 2. the process crashes so the term is send to group leader 3. eventually lagger receives the term 4. couch_log format the term (we have io:format fork [couch_log_trunc_io_fmt] (https://github.com/apache/couchdb-couch-log/blob/master/src/couch_log_trunc_io_fmt.erl)) Having truncate in step `#4` doesn't help much in case we have lot's of events to log. Since we bottleneck on group leader mailbox. Therefore we need to reduce the term size before we attempt to log it. COUCHDB-1606 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch-replicator 71267-format_process_state Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch-replicator/pull/51.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #51 commit 6adced02a672b065fb77432d58779b0ecf91359a Author: ILYA Khlopotov Date: 2016-10-27T21:18:58Z Format gen_server state to remove plain passwords Add format_status/2 to every gen_server to prune the state before passing it to SASL logger. There are two goals for this work: - eliminate plain text passwords in the logs - reduce the size of the terms we log COUCHDB-1606 > Replicator leaves plaintext password in logs > > > Key: COUCHDB-1606 > URL: https://issues.apache.org/jira/browse/COUCHDB-1606 > Project: CouchDB > Issue Type: Bug > Components: Logging, Replication >Affects Versions: 1.2 >Reporter: Nathan Vander Wilt >Assignee: Bob Dionne > Attachments: pwd log.txt > > > While reviewing logs, I noticed that a password had been recorded in the logs > as part of a replicator error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] couchdb-fauxton pull request #794: 76046 - The Documentation Link in the Que...
GitHub user millayr opened a pull request: https://github.com/apache/couchdb-fauxton/pull/794 76046 - The Documentation Link in the Query Options Panel Points to Futon Documentation This is from Cloudant ticket https://cloudant.fogbugz.com/f/cases/76046/. The documentation link still pointed to Fauxton docs instead of Cloudant docs. The getDefaultProps() call was happening before FauxtonAPI.constants.DOC_URLS.GENERAL was tweaked for Cloudant specific values. The getDefaultProps() function is now removed and the docURL is passed as a prop to MainFieldsView. The docURL is now a required property for the React class per advice from Robert Kowalski. You can merge this pull request into a Git repository by running: $ git pull https://github.com/millayr/couchdb-fauxton 76046-query-options-documentation-link Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/794.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #794 commit ab88d189959118ae9dd90547aa0d4a4ffd8a8445 Author: Ryan Millay Date: 2016-10-25T14:12:12Z Passing docURL as prop to allow for custom Cloudant value --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb issue #442: Adds a Snap package build option with: ./configure && ma...
Github user mhall119 commented on the issue: https://github.com/apache/couchdb/pull/442 Merged by rnewson --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request #442: Adds a Snap package build option with: ./configur...
Github user mhall119 closed the pull request at: https://github.com/apache/couchdb/pull/442 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (COUCHDB-3215) Differet size for the same view
Raphael Augusto da Silva Nunes Soransso created COUCHDB-3215:
Summary: Differet size for the same view
Key: COUCHDB-3215
URL: https://issues.apache.org/jira/browse/COUCHDB-3215
Project: CouchDB
Issue Type: Bug
Components: Database Core, JavaScript View Server
Reporter: Raphael Augusto da Silva Nunes Soransso
Hi, I have created two structure for a set of data to analyse if it would make
the queries faster, one data was created using a different table, from
relational database, as the root of the documents:
Example:
One struture is like this:
{
"c_customer_sk": 65836,
"c_first_name": "Frank",
"c_last_name": "White",
"store_sales": [ {
"ss_sales_price": 20.24,
"ss_ext_sales_price": 1012,
"ss_coupon_amt": 0,
"date": [ {
"d_month_seq": 1187,
"d_year": 1998 } ],
"item": [ {
"i_item_sk": 10454,
"i_item_id": "GNIC",
"i_item_desc": "Results highlight as patterns; so right
years show. Sometimes suitable lips move with the critics. English, old mothers
ought to lift now perhaps future managers. Active, single ch",
"i_current_price": 2.88,
"i_class": "romance",
"i_category_id": 9,
"i_category": "Books" } ] },
{
"ss_sales_price": 225,
"ss_ext_sales_price": 1023,
"ss_coupon_amt": 0,...
The other organization for the same data is:
{
"i_item_sk": 10454,
"i_item_id": "GNIC",
"i_item_desc": "Results highlight as patterns; so right years show. Sometimes
suitable lips move with the critics. English, old mothers ought to lift now
perhaps future managers. Active, single ch",
"i_current_price": 2.88,
"i_class": "romance",
"i_category_id": 9,
"i_category": "Books",
"store_sales": [
{
"ss_sales_price": 20.24,
"ss_ext_sales_price": 1012,
"ss_coupon_amt": 0,
"date": [
{
"d_month_seq": 1187,
"d_year": 1998
}
],
"customer": [
{
"c_customer_sk": 65836,
"c_first_name": "Frank",
"c_last_name": "White",
}
]
},
{
"ss_sales_price": 225,
"ss_ext_sales_price": 1023,
"ss_coupon_amt": 0,...
If I create the same view for both data, their data_sizes are different, can
someone explain me why?
I have posted it on stackoverflow too:
http://stackoverflow.com/questions/38509074/different-size-for-the-same-view-on-couchdb/38521448#38521448
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] couchdb-fauxton issue #782: Encoding issues: fix for database names and refa...
Github user garrensmith commented on the issue: https://github.com/apache/couchdb-fauxton/pull/782 If I click on a shared db's database I get `base.js:243 Uncaught TypeError: Cannot read property 'server' of undefined(â¦)` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #782: Encoding issues: fix for database names and refa...
Github user garrensmith commented on the issue: https://github.com/apache/couchdb-fauxton/pull/782 If I click on the x icon in shared db's I get `components.react.jsx:213 Uncaught TypeError: Cannot read property 'get' of undefined(â¦)` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (COUCHDB-3213) Various Fauxton usability issues
[ https://issues.apache.org/jira/browse/COUCHDB-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611399#comment-15611399 ] Garren Smith commented on COUCHDB-3213: --- Thanks Nolan, this is helpful. You won't be able to update CORS via Fauxton if you are on port 5984 you need to use one of the backend ports for that. For the setup failing is there anything in the dev tools console that can give us a bit more info? > Various Fauxton usability issues > > > Key: COUCHDB-3213 > URL: https://issues.apache.org/jira/browse/COUCHDB-3213 > Project: CouchDB > Issue Type: Bug > Components: Fauxton >Reporter: Nolan Lawson > > I figured it'd be too time-consuming to list all issues I've found with > Fauxton, so I just decided to create one master issue. Please feel free to > divide into smaller issues or ignore as applicable. :) > - Can't create a new non-admin user > - Click "Configuration", click "CORS", click "Main config," nothing happens, > have to refresh > - Click "Setup," click "Configure single node," fill in admin/password, click > "Configure Node," nothing happens. > I'm using Edge 14 on Windows 10 if that helps at all. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
