[GitHub] [couchdb] wohali commented on issue #2127: Fix for CompactTest failure
wohali commented on issue #2127: Fix for CompactTest failure URL: https://github.com/apache/couchdb/pull/2127#issuecomment-525528813 @sansato it's the exact same data... we're just going to remove the data_size field at some point from the output. see: https://github.com/apache/couchdb/blob/91b299d04a4ded2e11fb65972984b24d3491d1aa/src/couch_mrview/src/couch_mrview_index.erl#L83-L89 data_size = sizes.external disk_size = sizes.file _nothing_ = sizes.active This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [couchdb] wohali commented on issue #2127: Fix for CompactTest failure
wohali commented on issue #2127: Fix for CompactTest failure URL: https://github.com/apache/couchdb/pull/2127#issuecomment-525473345 @eiri The check in `test/test_helper.exs` is not sufficient to get this test to skip on Travis (which uses `TRAVIS_BUILD_NUMBER` and won't work if you're just running `make check` on the command line, which is undoubtedly what @sarveshtamba is doing. :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services