[GitHub] couchdb-couch-replicator pull request #48: Port HTTP 429 Commits
Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch-replicator/pull/48 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-couch-replicator pull request #48: Port HTTP 429 Commits
Github user nickva commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-replicator/pull/48#discussion_r81839898
--- Diff: src/couch_replicator_httpc.erl ---
@@ -440,3 +440,12 @@ after_redirect(RedirectUrl, _Code, HttpDb, Params) ->
after_redirect(RedirectUrl, HttpDb, Params) ->
Params2 = lists:keydelete(path, 1, lists:keydelete(qs, 1, Params)),
{HttpDb#httpdb{url = RedirectUrl}, Params2}.
+
+get_max_back_off() ->
+config:get_integer("replicator", "MAX_BACKOFF_WAIT", 250 * 32768).
--- End diff --
Let's make the settings lower case. Just to confirm with most other
settings.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-replicator pull request #48: Port HTTP 429 Commits
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-replicator/pull/48#discussion_r79905411
--- Diff: src/couch_replicator_httpc.erl ---
@@ -27,6 +27,9 @@
-define(replace(L, K, V), lists:keystore(K, 1, L, {K, V})).
-define(MAX_WAIT, 5 * 60 * 1000).
+-define(MAX_BACKOFF_WAIT, 250 * 32768).
--- End diff --
Shouldn't these be configurable?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-replicator pull request #48: Port HTTP 429 Commits
GitHub user tonysun83 opened a pull request: https://github.com/apache/couchdb-couch-replicator/pull/48 Port HTTP 429 Commits These commits allow us to not crash when a server returns a HTTP 429 response during replication. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch-replicator 3010-port-429 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch-replicator/pull/48.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #48 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
