[jira] [Commented] (COUCHDB-1606) Replicator leaves plaintext password in logs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612052#comment-16612052
 ] 

ASF GitHub Bot commented on COUCHDB-1606:
-

Github user iilyak closed the pull request at:

https://github.com/apache/couchdb-couch-replicator/pull/51


> Replicator leaves plaintext password in logs
> 
>
> Key: COUCHDB-1606
> URL: https://issues.apache.org/jira/browse/COUCHDB-1606
> Project: CouchDB
>  Issue Type: Bug
>  Components: Logging, Replication
>Affects Versions: 1.2
>Reporter: Nathan Vander Wilt
>Assignee: Bob Dionne
>Priority: Major
> Attachments: pwd log.txt
>
>
> While reviewing logs, I noticed that a password had been recorded in the logs 
> as part of a replicator error.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (COUCHDB-1606) Replicator leaves plaintext password in logs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15613331#comment-15613331
 ] 

ASF GitHub Bot commented on COUCHDB-1606:
-

GitHub user iilyak opened a pull request:

https://github.com/apache/couchdb-couch-replicator/pull/51

Format gen_server state to remove plain passwords

Add format_status/2 to every gen_server to prune the state before
passing it to SASL logger. There are two goals for this work:
- eliminate plain text passwords in the logs
- reduce the size of the terms we log

The size of a term is a real problem. Since what's currently happening is:
1. we have lot's of data in state (queues for example)
2. the process crashes so the term is send to group leader
3. eventually lagger receives the term
4. couch_log format the term (we have io:format fork 
[couch_log_trunc_io_fmt]

(https://github.com/apache/couchdb-couch-log/blob/master/src/couch_log_trunc_io_fmt.erl))

Having truncate in step `#4` doesn't help much in case we have lot's of 
events to log. Since we bottleneck on group leader mailbox. Therefore we need 
to reduce the term size before we attempt to log it. 

COUCHDB-1606

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloudant/couchdb-couch-replicator 
71267-format_process_state

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb-couch-replicator/pull/51.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #51


commit 6adced02a672b065fb77432d58779b0ecf91359a
Author: ILYA Khlopotov 
Date:   2016-10-27T21:18:58Z

Format gen_server state to remove plain passwords

Add format_status/2 to every gen_server to prune the state before
passing it to SASL logger. There are two goals for this work:
- eliminate plain text passwords in the logs
- reduce the size of the terms we log

COUCHDB-1606




> Replicator leaves plaintext password in logs
> 
>
> Key: COUCHDB-1606
> URL: https://issues.apache.org/jira/browse/COUCHDB-1606
> Project: CouchDB
>  Issue Type: Bug
>  Components: Logging, Replication
>Affects Versions: 1.2
>Reporter: Nathan Vander Wilt
>Assignee: Bob Dionne
> Attachments: pwd log.txt
>
>
> While reviewing logs, I noticed that a password had been recorded in the logs 
> as part of a replicator error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)