[GitHub] beiwei30 commented on issue #1666: Does need invoke startClose() in this function
beiwei30 commented on issue #1666: Does need invoke startClose() in this function URL: https://github.com/apache/incubator-dubbo/issues/1666#issuecomment-386498181 I think it's unnecessary. You could consider `close()` will shutdown immediately. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed issue #1666: Does need invoke startClose() in this function
beiwei30 closed issue #1666: Does need invoke startClose() in this function URL: https://github.com/apache/incubator-dubbo/issues/1666 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] teclxl commented on issue #1447: NettyHelper in netty extension populated Logger "InternalLogger" in netty.
teclxl commented on issue #1447: NettyHelper in netty extension populated Logger "InternalLogger" in netty. URL: https://github.com/apache/incubator-dubbo/issues/1447#issuecomment-386497645 @beiwei30 I think your change can solve this issue. I think the reason is that FailsafeLogger changed all msg, too. I saw you have already begun to slove this issue. I don't know if it is appropriate to close the issue now. Please close this issue, if you think it is appropriate. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed issue #1731: checkMultiExtension in com.alibaba.dubbo.config.AbstractInterfaceConfig should be in setter instead of getter
beiwei30 closed issue #1731: checkMultiExtension in com.alibaba.dubbo.config.AbstractInterfaceConfig should be in setter instead of getter URL: https://github.com/apache/incubator-dubbo/issues/1731 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 opened a new pull request #1732: fix issue 1731
beiwei30 opened a new pull request #1732: fix issue 1731 URL: https://github.com/apache/incubator-dubbo/pull/1732 ## What is the purpose of the change fix issue1731: checkMultiExtension in com.alibaba.dubbo.config.AbstractInterfaceConfig should be in setter instead of getter ## Brief changelog - com.alibaba.dubbo.config.AbstractInterfaceConfig ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test). - [x] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [x] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed pull request #1732: fix issue 1731
beiwei30 closed pull request #1732: fix issue 1731
URL: https://github.com/apache/incubator-dubbo/pull/1732
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/AbstractInterfaceConfig.java
b/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/AbstractInterfaceConfig.java
index 8a7ce9b048..fd3000e706 100644
---
a/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/AbstractInterfaceConfig.java
+++
b/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/AbstractInterfaceConfig.java
@@ -410,11 +410,11 @@ public void setFilter(String filter) {
@Parameter(key = Constants.INVOKER_LISTENER_KEY, append = true)
public String getListener() {
-checkMultiExtension(InvokerListener.class, "listener", listener);
return listener;
}
public void setListener(String listener) {
+checkMultiExtension(InvokerListener.class, "listener", listener);
this.listener = listener;
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 opened a new issue #1731: checkMultiExtension in com.alibaba.dubbo.config.AbstractInterfaceConfig should be in setter instead of getter
beiwei30 opened a new issue #1731: checkMultiExtension in
com.alibaba.dubbo.config.AbstractInterfaceConfig should be in setter instead of
getter
URL: https://github.com/apache/incubator-dubbo/issues/1731
checkMultiExtension in com.alibaba.dubbo.config.AbstractInterfaceConfig
should be in setter instead of getter
```java
@Parameter(key = Constants.INVOKER_LISTENER_KEY, append = true)
public String getListener() {
checkMultiExtension(InvokerListener.class, "listener", listener);
return listener;
}
public void setListener(String listener) {
this.listener = listener;
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] qinnnyul commented on issue #1687: Enhance the test coverage part-8 : dubbo-filter module
qinnnyul commented on issue #1687: Enhance the test coverage part-8 : dubbo-filter module URL: https://github.com/apache/incubator-dubbo/issues/1687#issuecomment-386480333 good eye! I will work on it, thanks This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] htynkn commented on issue #1687: Enhance the test coverage part-8 : dubbo-filter module
htynkn commented on issue #1687: Enhance the test coverage part-8 : dubbo-filter module URL: https://github.com/apache/incubator-dubbo/issues/1687#issuecomment-386479878 PR #1715 add unit test for dubbo-filter-cache. we still need unit test for dubbo-filter-validation This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] satansk opened a new issue #1730: Do we have a plan to upgrade to Java 8?
satansk opened a new issue #1730: Do we have a plan to upgrade to Java 8? URL: https://github.com/apache/incubator-dubbo/issues/1730 The source code only compile with Java 6, since Java 8 has significant improvements, I think it's a good idea to support Java 8. :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] htynkn commented on issue #1688: Enhance the test coverage part-9 :dubbo-monitor module
htynkn commented on issue #1688: Enhance the test coverage part-9 :dubbo-monitor module URL: https://github.com/apache/incubator-dubbo/issues/1688#issuecomment-386264359 @lovepoem I would like to pick up this card This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed issue #1681: Enhance the test coverage part-3 : dubbo-common/src/main/java/com/alibaba/dubbo/common/concurrent(io|json|logger) modules
beiwei30 closed issue #1681: Enhance the test coverage part-3 : dubbo-common/src/main/java/com/alibaba/dubbo/common/concurrent(io|json|logger) modules URL: https://github.com/apache/incubator-dubbo/issues/1681 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed pull request #1721: [Dubbo-1681] add test for dubbo common module
beiwei30 closed pull request #1721: [Dubbo-1681] add test for dubbo common
module
URL: https://github.com/apache/incubator-dubbo/pull/1721
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.codecov.yml b/.codecov.yml
index d87923f145..bd786c139e 100644
--- a/.codecov.yml
+++ b/.codecov.yml
@@ -5,4 +5,5 @@ coverage:
default:
threshold: 0.1%
ignore:
- - "dubbo-demo/.*"
\ No newline at end of file
+ - "dubbo-demo/.*"
+ - "dubbo-common/src/main/java/com/alibaba/dubbo/common/json/*.java" #
internal JSON impl is deprecate, ignore test coverage for them
\ No newline at end of file
diff --git
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/concurrent/ExecutionListTest.java
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/concurrent/ExecutionListTest.java
new file mode 100644
index 00..16026e5ad8
--- /dev/null
+++
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/concurrent/ExecutionListTest.java
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.alibaba.dubbo.common.concurrent;
+
+import org.junit.Before;
+import org.junit.Test;
+
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.Executor;
+
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.doThrow;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+
+public class ExecutionListTest {
+private ExecutionList executionList;
+
+@Before
+public void setUp() throws Exception {
+this.executionList = new ExecutionList();
+}
+
+@Test(expected = NullPointerException.class)
+public void testAddNullRunnable() {
+this.executionList.add(null, mock(Executor.class));
+}
+
+@Test
+public void testAddRunnableToExecutor() {
+Executor mockedExecutor = mock(Executor.class);
+
+this.executionList.add(mock(Runnable.class), mockedExecutor);
+this.executionList.execute();
+
+verify(mockedExecutor).execute(any(Runnable.class));
+}
+
+@Test
+public void testExecuteRunnableWithDefaultExecutor() throws
InterruptedException {
+final CountDownLatch countDownLatch = new CountDownLatch(1);
+this.executionList.add(new Runnable() {
+@Override
+public void run() {
+countDownLatch.countDown();
+}
+}, null);
+
+this.executionList.execute();
+countDownLatch.await();
+}
+
+@Test
+public void testExceptionForExecutor() {
+Executor mockedExecutor = mock(Executor.class);
+doThrow(new
RuntimeException()).when(mockedExecutor).execute(any(Runnable.class));
+
+this.executionList.add(mock(Runnable.class), mockedExecutor);
+this.executionList.execute();
+}
+
+@Test
+public void testNotRunSameRunnableTwice() {
+Executor mockedExecutor = mock(Executor.class);
+
+this.executionList.add(mock(Runnable.class), mockedExecutor);
+
+this.executionList.execute();
+this.executionList.execute();
+
+verify(mockedExecutor).execute(any(Runnable.class));
+}
+
+@Test
+public void testRunImmediatelyAfterExecuted() {
+Executor mockedExecutor = mock(Executor.class);
+
+this.executionList.add(mock(Runnable.class), mockedExecutor);
+this.executionList.execute();
+this.executionList.add(mock(Runnable.class), mockedExecutor);
+
+verify(mockedExecutor, times(2)).execute(any(Runnable.class));
+}
+}
\ No newline at end of file
diff --git
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/concurrent/ListenableFutureTaskTest.java
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/concurrent/ListenableFutureTaskTest.java
new file mode 100644
index 00..cd11f8f826
--- /dev/null
+++
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/concurrent/ListenableFutureTaskTest.java
@@ -0,0 +1,100 @@
[GitHub] beiwei30 closed pull request #1715: [Dubbo-1687]Enhance test coverage for dubbo filter
beiwei30 closed pull request #1715: [Dubbo-1687]Enhance test coverage for dubbo
filter
URL: https://github.com/apache/incubator-dubbo/pull/1715
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/dubbo-filter/dubbo-filter-cache/pom.xml
b/dubbo-filter/dubbo-filter-cache/pom.xml
index bd0791f325..65164ba022 100644
--- a/dubbo-filter/dubbo-filter-cache/pom.xml
+++ b/dubbo-filter/dubbo-filter-cache/pom.xml
@@ -39,5 +39,11 @@
javax.cache
cache-api
+
+com.hazelcast
+hazelcast
+test
+${hazelcast_version}
+
\ No newline at end of file
diff --git
a/dubbo-filter/dubbo-filter-cache/src/test/java/com/alibaba/dubbo/cache/filter/CacheFilterTest.java
b/dubbo-filter/dubbo-filter-cache/src/test/java/com/alibaba/dubbo/cache/filter/CacheFilterTest.java
index a9e8d041cb..0fa6d698c0 100644
---
a/dubbo-filter/dubbo-filter-cache/src/test/java/com/alibaba/dubbo/cache/filter/CacheFilterTest.java
+++
b/dubbo-filter/dubbo-filter-cache/src/test/java/com/alibaba/dubbo/cache/filter/CacheFilterTest.java
@@ -16,45 +16,71 @@
*/
package com.alibaba.dubbo.cache.filter;
+import com.alibaba.dubbo.cache.CacheFactory;
+import com.alibaba.dubbo.cache.support.jcache.JCacheFactory;
import com.alibaba.dubbo.cache.support.lru.LruCacheFactory;
+import com.alibaba.dubbo.cache.support.threadlocal.ThreadLocalCacheFactory;
import com.alibaba.dubbo.common.URL;
import com.alibaba.dubbo.rpc.Invoker;
import com.alibaba.dubbo.rpc.RpcInvocation;
import com.alibaba.dubbo.rpc.RpcResult;
-
import org.junit.Assert;
-import org.junit.BeforeClass;
+import org.junit.Before;
import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+
+import java.util.Arrays;
+import java.util.List;
+import static org.junit.runners.Parameterized.*;
import static org.mockito.BDDMockito.given;
import static org.mockito.Mockito.mock;
+@RunWith(Parameterized.class)
public class CacheFilterTest {
-private static RpcInvocation invocation;
-static CacheFilter cacheFilter = new CacheFilter();
-static Invoker invoker = mock(Invoker.class);
-static Invoker invoker1 = mock(Invoker.class);
-static Invoker invoker2 = mock(Invoker.class);
-
-@BeforeClass
-public static void setUp() {
+private RpcInvocation invocation;
+private CacheFilter cacheFilter = new CacheFilter();
+private Invoker invoker = mock(Invoker.class);
+private Invoker invoker1 = mock(Invoker.class);
+private Invoker invoker2 = mock(Invoker.class);
+private String cacheType;
+private CacheFactory cacheFactory;
+
+public CacheFilterTest(String cacheType, CacheFactory cacheFactory) {
+this.cacheType = cacheType;
+this.cacheFactory = cacheFactory;
+}
+
+@Parameters
+public static List cacheFactories() {
+return Arrays.asList(new Object[][]{
+{"lru", new LruCacheFactory()},
+{"jcache", new JCacheFactory()},
+{"threadlocal", new ThreadLocalCacheFactory()}
+});
+}
+
+@Before
+public void setUp() throws Exception {
invocation = new RpcInvocation();
-cacheFilter.setCacheFactory(new LruCacheFactory());
+cacheFilter.setCacheFactory(this.cacheFactory);
-URL url = URL.valueOf("test://test:11/test?cache=lru");
+URL url = URL.valueOf("test://test:11/test?cache=" + this.cacheType);
-given(invoker.invoke(invocation)).willReturn(new RpcResult(new
String("value")));
+given(invoker.invoke(invocation)).willReturn(new RpcResult("value"));
given(invoker.getUrl()).willReturn(url);
-given(invoker1.invoke(invocation)).willReturn(new RpcResult(new
String("value1")));
+given(invoker1.invoke(invocation)).willReturn(new RpcResult("value1"));
given(invoker1.getUrl()).willReturn(url);
-given(invoker2.invoke(invocation)).willReturn(new RpcResult(new
String("value2")));
+given(invoker2.invoke(invocation)).willReturn(new RpcResult("value2"));
given(invoker2.getUrl()).willReturn(url);
+
}
@Test
-public void test_No_Arg_Method() {
+public void testNonArgsMethod() {
invocation.setMethodName("echo");
invocation.setParameterTypes(new Class[]{});
invocation.setArguments(new Object[]{});
@@ -66,7 +92,7 @@ public void test_No_Arg_Method() {
}
@Test
-public void test_Args_Method() {
+public void testMethodWithArgs() {
invocation.setMethodName("echo1");
invocation.setParameterTypes(new Class[]{String.class});
invocation.setArguments(new Object[]{"arg1"});
diff --git
[GitHub] LiuXuyang04 opened a new issue #1729: dubbo的consume 报InvocationTargetException: null，发现没有找到接口实例
LiuXuyang04 opened a new issue #1729: dubbo的consume 报InvocationTargetException: null，发现没有找到接口实例 URL: https://github.com/apache/incubator-dubbo/issues/1729 java.lang.reflect.InvocationTargetException: null at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_111] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_111] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_111] at java.lang.reflect.Method.invoke(Method.java:498) ~[na:1.8.0_111] at com.alibaba.dubbo.config.AbstractConfig.toString(AbstractConfig.java:473) ~[dubbo-2.5.10.jar:2.0.1] at java.lang.String.valueOf(String.java:2994) [na:1.8.0_111] at java.lang.StringBuilder.append(StringBuilder.java:131) [na:1.8.0_111] at com.alibaba.dubbo.config.spring.beans.factory.annotation.AbstractAnnotationConfigBeanBuilder.build(AbstractAnnotationConfigBeanBuilder.java:75) [dubbo-2.5.10.jar:1.1.1] at com.alibaba.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor.buildReferenceBean(ReferenceAnnotationBeanPostProcessor.java:345) [dubbo-2.5.10.jar:1.1.1] at com.alibaba.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor.access$100(ReferenceAnnotationBeanPostProcessor.java:61) [dubbo-2.5.10.jar:1.1.1] at com.alibaba.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor$ReferenceFieldElement.inject(ReferenceAnnotationBeanPostProcessor.java:323) [dubbo-2.5.10.jar:1.1.1] at org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:91) [spring-beans-5.0.5.RELEASE.jar:5.0.5.RELEASE] at com.alibaba.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor.postProcessPropertyValues(ReferenceAnnotationBeanPostProcessor.java:88) [dubbo-2.5.10.jar:1.1.1] at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1344) [spring-beans-5.0.5.RELEASE.jar:5.0.5.RELEASE] at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:578) [spring-beans-5.0.5.RELEASE.jar:5.0.5.RELEASE] at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:501) [spring-beans-5.0.5.RELEASE.jar:5.0.5.RELEASE] at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:317) [spring-beans-5.0.5.RELEASE.jar:5.0.5.RELEASE] at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:228) ~[spring-beans-5.0.5.RELEASE.jar:5.0.5.RELEASE] at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:315) [spring-beans-5.0.5.RELEASE.jar:5.0.5.RELEASE] at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:199) [spring-beans-5.0.5.RELEASE.jar:5.0.5.RELEASE] at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:760) ~[spring-beans-5.0.5.RELEASE.jar:5.0.5.RELEASE] at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:869) ~[spring-context-5.0.5.RELEASE.jar:5.0.5.RELEASE] at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:550) ~[spring-context-5.0.5.RELEASE.jar:5.0.5.RELEASE] at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:140) ~[spring-boot-2.0.1.RELEASE.jar:2.0.1.RELEASE] at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:759) ~[spring-boot-2.0.1.RELEASE.jar:2.0.1.RELEASE] at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:395) ~[spring-boot-2.0.1.RELEASE.jar:2.0.1.RELEASE] at org.springframework.boot.SpringApplication.run(SpringApplication.java:327) ~[spring-boot-2.0.1.RELEASE.jar:2.0.1.RELEASE] at org.springframework.boot.SpringApplication.run(SpringApplication.java:1255) ~[spring-boot-2.0.1.RELEASE.jar:2.0.1.RELEASE] at org.springframework.boot.SpringApplication.run(SpringApplication.java:1243) ~[spring-boot-2.0.1.RELEASE.jar:2.0.1.RELEASE] at com.lxy.controller.ClientApplication.main(ClientApplication.java:12) ~[classes/:na] Caused by: java.lang.IllegalStateException: ApplicationConfig.application == null at com.alibaba.dubbo.config.AbstractConfig.appendParameters(AbstractConfig.java:245)
[GitHub] codecov-io commented on issue #1715: [Dubbo-1687]Enhance test coverage for dubbo filter
codecov-io commented on issue #1715: [Dubbo-1687]Enhance test coverage for dubbo filter URL: https://github.com/apache/incubator-dubbo/pull/1715#issuecomment-385141526 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1715?src=pr=h1) Report > Merging [#1715](https://codecov.io/gh/apache/incubator-dubbo/pull/1715?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/6784375811518a200685e635ee51edc548629971?src=pr=desc) will **increase** coverage by `0.15%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1715?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1715 +/- ## + Coverage 36.23% 36.39% +0.15% - Complexity 3900 3924 +24 Files 629 629 Lines 3096931023 +54 Branches 5442 5460 +18 + Hits 1122311292 +69 + Misses1783217815 -17 - Partials 1914 1916 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1715?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1715/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `57.5% <0%> (-8.75%)` | `19% <0%> (-2%)` | | | [...aba/dubbo/common/compiler/support/JdkCompiler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1715/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2NvbXBpbGVyL3N1cHBvcnQvSmRrQ29tcGlsZXIuamF2YQ==) | `61.81% <0%> (ø)` | `2% <0%> (ø)` | :arrow_down: | | [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1715/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `83.33% <0%> (ø)` | `6% <0%> (ø)` | :arrow_down: | | [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1715/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==) | `54.68% <0%> (+1.56%)` | `3% <0%> (ø)` | :arrow_down: | | [...baba/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1715/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDbGllbnQuamF2YQ==) | `59.37% <0%> (+1.56%)` | `9% <0%> (+1%)` | :arrow_up: | | [...a/dubbo/remoting/transport/netty4/NettyClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1715/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9OZXR0eUNsaWVudC5qYXZh) | `53.4% <0%> (+1.74%)` | `12% <0%> (+6%)` | :arrow_up: | | [.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1715/diff?src=pr=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh) | `76.63% <0%> (+1.86%)` | `7% <0%> (ø)` | :arrow_down: | | [...a/dubbo/remoting/transport/netty4/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1715/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9OZXR0eVNlcnZlci5qYXZh) | `52.27% <0%> (+2.27%)` | `12% <0%> (+6%)` | :arrow_up: | | [.../dubbo/rpc/protocol/dubbo/DecodeableRpcResult.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1715/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9EZWNvZGVhYmxlUnBjUmVzdWx0LmphdmE=) | `59.09% <0%> (+2.27%)` | `8% <0%> (ø)` | :arrow_down: | | [...a/com/alibaba/dubbo/remoting/exchange/Request.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1715/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvZXhjaGFuZ2UvUmVxdWVzdC5qYXZh) | `85.71% <0%> (+2.38%)` | `20% <0%> (ø)` | :arrow_down: | | ... and [7
[GitHub] chickenlj closed pull request #1717: issue#1447: NettyHelper in netty extension populated Logger "InternalLogger" in netty.
chickenlj closed pull request #1717: issue#1447: NettyHelper in netty extension
populated Logger "InternalLogger" in netty.
URL: https://github.com/apache/incubator-dubbo/pull/1717
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-remoting/dubbo-remoting-netty4/src/main/java/com/alibaba/dubbo/remoting/transport/netty4/NettyClient.java
b/dubbo-remoting/dubbo-remoting-netty4/src/main/java/com/alibaba/dubbo/remoting/transport/netty4/NettyClient.java
index 73c54b7499..ea273aebfa 100644
---
a/dubbo-remoting/dubbo-remoting-netty4/src/main/java/com/alibaba/dubbo/remoting/transport/netty4/NettyClient.java
+++
b/dubbo-remoting/dubbo-remoting-netty4/src/main/java/com/alibaba/dubbo/remoting/transport/netty4/NettyClient.java
@@ -25,7 +25,6 @@
import com.alibaba.dubbo.remoting.ChannelHandler;
import com.alibaba.dubbo.remoting.RemotingException;
import com.alibaba.dubbo.remoting.transport.AbstractClient;
-import com.alibaba.dubbo.remoting.transport.netty4.logging.NettyHelper;
import io.netty.bootstrap.Bootstrap;
import io.netty.buffer.PooledByteBufAllocator;
@@ -58,7 +57,6 @@ public NettyClient(final URL url, final ChannelHandler
handler) throws RemotingE
@Override
protected void doOpen() throws Throwable {
-NettyHelper.setNettyLoggerFactory();
final NettyClientHandler nettyClientHandler = new
NettyClientHandler(getUrl(), this);
bootstrap = new Bootstrap();
bootstrap.group(nioEventLoopGroup)
diff --git
a/dubbo-remoting/dubbo-remoting-netty4/src/main/java/com/alibaba/dubbo/remoting/transport/netty4/NettyServer.java
b/dubbo-remoting/dubbo-remoting-netty4/src/main/java/com/alibaba/dubbo/remoting/transport/netty4/NettyServer.java
index 1924bd16e8..c4ffcf5dde 100644
---
a/dubbo-remoting/dubbo-remoting-netty4/src/main/java/com/alibaba/dubbo/remoting/transport/netty4/NettyServer.java
+++
b/dubbo-remoting/dubbo-remoting-netty4/src/main/java/com/alibaba/dubbo/remoting/transport/netty4/NettyServer.java
@@ -28,7 +28,6 @@
import com.alibaba.dubbo.remoting.Server;
import com.alibaba.dubbo.remoting.transport.AbstractServer;
import com.alibaba.dubbo.remoting.transport.dispatcher.ChannelHandlers;
-import com.alibaba.dubbo.remoting.transport.netty4.logging.NettyHelper;
import io.netty.bootstrap.ServerBootstrap;
import io.netty.buffer.PooledByteBufAllocator;
@@ -68,8 +67,6 @@ public NettyServer(URL url, ChannelHandler handler) throws
RemotingException {
@Override
protected void doOpen() throws Throwable {
-NettyHelper.setNettyLoggerFactory();
-
bootstrap = new ServerBootstrap();
bossGroup = new NioEventLoopGroup(1, new
DefaultThreadFactory("NettyServerBoss", true));
diff --git
a/dubbo-remoting/dubbo-remoting-netty4/src/main/java/com/alibaba/dubbo/remoting/transport/netty4/logging/NettyHelper.java
b/dubbo-remoting/dubbo-remoting-netty4/src/main/java/com/alibaba/dubbo/remoting/transport/netty4/logging/NettyHelper.java
deleted file mode 100644
index 715aa6479d..00
---
a/dubbo-remoting/dubbo-remoting-netty4/src/main/java/com/alibaba/dubbo/remoting/transport/netty4/logging/NettyHelper.java
+++ /dev/null
@@ -1,268 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package com.alibaba.dubbo.remoting.transport.netty4.logging;
-
-import com.alibaba.dubbo.common.logger.Logger;
-import com.alibaba.dubbo.common.logger.LoggerFactory;
-import io.netty.util.internal.logging.AbstractInternalLogger;
-import io.netty.util.internal.logging.InternalLogger;
-import io.netty.util.internal.logging.InternalLoggerFactory;
-
-public class NettyHelper {
-
-public static void setNettyLoggerFactory() {
-InternalLoggerFactory factory =
InternalLoggerFactory.getDefaultFactory();
-if (factory == null || !(factory instanceof DubboLoggerFactory)) {
-InternalLoggerFactory.setDefaultFactory(new DubboLoggerFactory());
-}
-}
-
-static class DubboLoggerFactory extends InternalLoggerFactory {
-
-
[GitHub] feelwing1314 opened a new issue #1728: System property dubbo.service.delay invalid
feelwing1314 opened a new issue #1728: System property dubbo.service.delay
invalid
URL: https://github.com/apache/incubator-dubbo/issues/1728
根据dubbo参数的映射关系也可以通过-Ddubbo.service.delay=5000配置，但是发现-Ddubbo.service.delay=5000不起作用；
debug下面这段代码（ServiceConfig.java）发现：
public synchronized void export() {
... ...
if (delay != null && delay > 0) {
delayExportExecutor.schedule(new Runnable() {
@Override
public void run() {
doExport();
}
}, delay, TimeUnit.MILLISECONDS);
} else {
doExport();
}
}
如果有deplay，先delay再doExport()，而解析JVM参数的逻辑（appendProperties(this);）是在doExport()方法中调用；所以导致
if (delay != null && delay >
0)判断时，还没有解析JVM参数-Ddubbo.service.delay=5000，从而导致这种配置不起作用；
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 commented on issue #1717: issue#1447: NettyHelper in netty extension populated Logger "InternalLogger" in netty.
beiwei30 commented on issue #1717: issue#1447: NettyHelper in netty extension populated Logger "InternalLogger" in netty. URL: https://github.com/apache/incubator-dubbo/pull/1717#issuecomment-386203360 I guess there's particular reason for NettyHelper introduced for netty3. Considering netty3 is not popular today, let's leave it as is. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] satansk commented on issue #1691: Enhance the test coverage part-12: dubbo-registry/dubbo-registry-multicast(dubbo-registry-redis|dubbo-registry-zookeeper)
satansk commented on issue #1691: Enhance the test coverage part-12: dubbo-registry/dubbo-registry-multicast(dubbo-registry-redis|dubbo-registry-zookeeper) URL: https://github.com/apache/incubator-dubbo/issues/1691#issuecomment-386202011 Let me try this :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] codecov-io commented on issue #1721: [Dubbo-1681] add test for dubbo common module
codecov-io commented on issue #1721: [Dubbo-1681] add test for dubbo common module URL: https://github.com/apache/incubator-dubbo/pull/1721#issuecomment-385260585 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1721?src=pr=h1) Report > Merging [#1721](https://codecov.io/gh/apache/incubator-dubbo/pull/1721?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/6784375811518a200685e635ee51edc548629971?src=pr=desc) will **increase** coverage by `1.39%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1721?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1721 +/- ## + Coverage 36.23% 37.63% +1.39% - Complexity 3900 3995 +95 Files 629 619 -10 Lines 3096929838-1131 Branches 5442 5270 -172 + Hits 1122311230 +7 + Misses1783216754-1078 + Partials 1914 1854 -60 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1721?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1721/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DaGFubmVsV3JhcHBlZEludm9rZXIuamF2YQ==) | `37.5% <0%> (-12.5%)` | `3% <0%> (ø)` | | | [...aba/dubbo/common/compiler/support/JdkCompiler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1721/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2NvbXBpbGVyL3N1cHBvcnQvSmRrQ29tcGlsZXIuamF2YQ==) | `61.81% <0%> (ø)` | `2% <0%> (ø)` | :arrow_down: | | [.../java/com/alibaba/dubbo/common/json/JSONArray.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1721/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2pzb24vSlNPTkFycmF5LmphdmE=) | | | | | [...java/com/alibaba/dubbo/common/json/J2oVisitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1721/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2pzb24vSjJvVmlzaXRvci5qYXZh) | | | | | [.../com/alibaba/dubbo/common/json/ParseException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1721/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2pzb24vUGFyc2VFeGNlcHRpb24uamF2YQ==) | | | | | [.../java/com/alibaba/dubbo/common/json/JSONToken.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1721/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2pzb24vSlNPTlRva2VuLmphdmE=) | | | | | [...java/com/alibaba/dubbo/common/json/JSONReader.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1721/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2pzb24vSlNPTlJlYWRlci5qYXZh) | | | | | [...java/com/alibaba/dubbo/common/json/JSONObject.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1721/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2pzb24vSlNPTk9iamVjdC5qYXZh) | | | | | [...main/java/com/alibaba/dubbo/common/json/Yylex.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1721/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2pzb24vWXlsZXguamF2YQ==) | | | | | [...libaba/dubbo/common/json/GenericJSONConverter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1721/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2pzb24vR2VuZXJpY0pTT05Db252ZXJ0ZXIuamF2YQ==) | | | | | ... and [29 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1721/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1721?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1721?src=pr=footer). Last update [6784375...e85e977](https://codecov.io/gh/apache/incubator-dubbo/pull/1721?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond
[GitHub] htynkn commented on issue #1727: HessianProtocolTest is unstable
htynkn commented on issue #1727: HessianProtocolTest is unstable URL: https://github.com/apache/incubator-dubbo/issues/1727#issuecomment-386199410 link to #1667 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] htynkn commented on a change in pull request #1721: [Dubbo-1681] add test for dubbo common module
htynkn commented on a change in pull request #1721: [Dubbo-1681] add test for dubbo common module URL: https://github.com/apache/incubator-dubbo/pull/1721#discussion_r185702820 ## File path: dubbo-common/src/test/java/com/alibaba/dubbo/common/io/UnsafeByteArrayOutputStreamTest.java ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package com.alibaba.dubbo.common.io; + +import org.junit.Test; +import org.mockito.Mockito; + +import java.io.IOException; +import java.io.OutputStream; +import java.nio.ByteBuffer; + +import static org.hamcrest.CoreMatchers.is; +import static org.junit.Assert.assertThat; +import static org.mockito.ArgumentMatchers.*; Review comment: @beiwei30 sorry, I thought checkstyle rule should check * import... but looks like it's only enable for source, not test folder. I already fix * imports issue. Please refer to last commit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
