[GitHub] XUZHOUWANG commented on issue #135: 刷星星哦

2018-05-13 Thread GitBox
XUZHOUWANG commented on issue #135: 刷星星哦
URL: 
https://github.com/apache/incubator-dubbo-spring-boot-project/issues/135#issuecomment-388705116
 
 
   这跟在淘宝刷单有什么区别?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[GitHub] XUZHOUWANG opened a new issue #135: 刷星星哦

2018-05-13 Thread GitBox
XUZHOUWANG opened a new issue #135: 刷星星哦
URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/135
 
 
   
![image](https://user-images.githubusercontent.com/2636711/39980298-c4165d9a-577d-11e8-9feb-7526fcaf4a54.png)
   
   please give me a star!!!
   
   haha it's normal!!!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[GitHub] beiwei30 closed pull request #1780: unit test for ServiceConfig

2018-05-13 Thread GitBox
beiwei30 closed pull request #1780: unit test for ServiceConfig
URL: https://github.com/apache/incubator-dubbo/pull/1780
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/MockRegistryFactory.java
 
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/MockRegistryFactory.java
new file mode 100644
index 00..1534d30f23
--- /dev/null
+++ 
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/MockRegistryFactory.java
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.alibaba.dubbo.config;
+
+import com.alibaba.dubbo.common.URL;
+import com.alibaba.dubbo.registry.Registry;
+import com.alibaba.dubbo.registry.RegistryFactory;
+
+public class MockRegistryFactory implements RegistryFactory {
+public static Registry registry;
+
+@Override
+public Registry getRegistry(URL url) {
+return registry;
+}
+}
diff --git 
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/MockTransporter.java
 
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/MockTransporter.java
index 749b9095ef..0651c2a1cb 100644
--- 
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/MockTransporter.java
+++ 
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/MockTransporter.java
@@ -23,15 +23,19 @@
 import com.alibaba.dubbo.remoting.RemotingException;
 import com.alibaba.dubbo.remoting.Server;
 import com.alibaba.dubbo.remoting.Transporter;
+import org.mockito.Mockito;
 
 public class MockTransporter implements Transporter {
+private Server server = Mockito.mock(Server.class);
+private Client client = Mockito.mock(Client.class);
+
 @Override
 public Server bind(URL url, ChannelHandler handler) throws 
RemotingException {
-return null;
+return server;
 }
 
 @Override
 public Client connect(URL url, ChannelHandler handler) throws 
RemotingException {
-return null;
+return client;
 }
 }
diff --git 
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/RegistryConfigTest.java
 
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/RegistryConfigTest.java
new file mode 100644
index 00..1d9bbe2038
--- /dev/null
+++ 
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/RegistryConfigTest.java
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.alibaba.dubbo.config;
+
+import com.alibaba.dubbo.common.Constants;
+import org.junit.Test;
+
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.hamcrest.Matchers.equalTo;
+import static org.hamcrest.Matchers.hasEntry;
+import static org.hamcrest.Matchers.hasKey;
+import static org.hamcrest.Matchers.not;
+import static org.junit.Assert.assertThat;
+
+public class RegistryConfigTest {
+@Test
+public void testProtocol() throws Exception {
+RegistryConfig registry = new RegistryConfig();
+registry.setProtocol("protocol");
+assertThat(registry.getProtocol(), 

[GitHub] codecov-io commented on issue #1780: unit test for ServiceConfig

2018-05-13 Thread GitBox
codecov-io commented on issue #1780: unit test for ServiceConfig
URL: https://github.com/apache/incubator-dubbo/pull/1780#issuecomment-388682077
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1780?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@50895ff`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1780/graphs/tree.svg?height=150=650=VnEIkiFQT0=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/1780?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#1780   +/-   ##
   =
 Coverage  ?   39.34%   
 Complexity? 4215   
   =
 Files ?  618   
 Lines ?29742   
 Branches  ? 5257   
   =
 Hits  ?11701   
 Misses?16178   
 Partials  ? 1863
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1780?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1780?src=pr=footer).
 Last update 
[50895ff...f88bc0b](https://codecov.io/gh/apache/incubator-dubbo/pull/1780?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[GitHub] nzomkxia opened a new pull request #1792: zk Unsubscribe issue

2018-05-13 Thread GitBox
nzomkxia opened a new pull request #1792: zk Unsubscribe issue
URL: https://github.com/apache/incubator-dubbo/pull/1792
 
 
   ## What is the purpose of the change
   
   fix zk unsubscribe issue
   
   ## Brief changelog
   
   unsubscribe zk registry
   
   ## Verifying this change
   
   X
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
   - [x] Make sure there is a 
[GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the 
change (usually before you start working on it). Trivial changes like typos do 
not require a GITHUB issue. Your pull request should address just this issue, 
without pulling in other changes - one PR resolves one issue.
   - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException 
when host config not exist #XXX`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [ ] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [ ] Write necessary unit-test to verify your logic correction, more mock a 
little better when cross module dependency exist. If the new feature or 
significant change is committed, please remember to add integration-test in 
[test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test).
   - [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile 
failsafe:integration-test` to make sure unit-test and integration-test pass.
   - [ ] If this contribution is large, please follow the [Software Donation 
Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[GitHub] beiwei30 commented on issue #134: 一定要在service里面加这些东西? 不能设置默认值吗。。。

2018-05-13 Thread GitBox
beiwei30 commented on issue #134: 一定要在service里面加这些东西? 不能设置默认值吗。。。
URL: 
https://github.com/apache/incubator-dubbo-spring-boot-project/issues/134#issuecomment-388680774
 
 
   if you don't specify, then the default value will be used.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[GitHub] ZTOGroup commented on issue #1012: Wanted: who's using dubbo

2018-05-13 Thread GitBox
ZTOGroup commented on issue #1012: Wanted: who's using dubbo
URL: 
https://github.com/apache/incubator-dubbo/issues/1012#issuecomment-388677988
 
 
   组织:中通快递
   网址:http://www.zto.com/
   地点:上海
   联系方式:xiaowe...@zto.cn
   场景:服务化


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[GitHub] ZTOGroup commented on issue #1012: Wanted: who's using dubbo

2018-05-13 Thread GitBox
ZTOGroup commented on issue #1012: Wanted: who's using dubbo
URL: 
https://github.com/apache/incubator-dubbo/issues/1012#issuecomment-388677988
 
 
   组织:中通快递
   网址:http://www.zto.com/
   地点:中国上海
   联系方式:xiaowe...@zto.cn
   场景:服务化


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[GitHub] YamDestiny commented on issue #1790: Maven cannot compile the project

2018-05-13 Thread GitBox
YamDestiny commented on issue #1790: Maven cannot compile the project
URL: 
https://github.com/apache/incubator-dubbo/issues/1790#issuecomment-388676924
 
 
   I try to delete and re-execute the command. Same error, It can't work. And I 
trying to download this `.jar` and `.pom` files from Maven Repository. It's 
also not working. But the error message has changed.
   
   ```bash
   [ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:jar (attach-javadoc) on 
project dubbo: Execution attach-javadoc of goal 
org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:jar failed: A required 
class was missing while executing 
org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:jar: 
org/apache/http/client/methods/HttpUriRequest
   ```
   
   thanks your reply.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[GitHub] piglingcn opened a new issue #134: 一定要在service里面加这些东西? 不能设置默认值吗。。。

2018-05-13 Thread GitBox
piglingcn opened a new issue #134: 一定要在service里面加这些东西? 不能设置默认值吗。。。
URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/134
 
 
   version = "1.0.0",
   application = "${dubbo.application.id}",
   protocol = "${dubbo.protocol.id}",
   registry = "${dubbo.registry.id}"


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[GitHub] codecov-io commented on issue #1380: upgrade libthrift version and add nature thrift support option

2018-05-13 Thread GitBox
codecov-io commented on issue #1380: upgrade libthrift version and add nature 
thrift support option 
URL: https://github.com/apache/incubator-dubbo/pull/1380#issuecomment-367338110
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr=h1) 
Report
   > Merging 
[#1380](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/203078981bb23517703e7bbb60925b8542bc8983?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `5.76%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/graphs/tree.svg?width=650=150=pr=VnEIkiFQT0)](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#1380  +/-   ##
   
   - Coverage 39.24%   39.24%   -0.01% 
   - Complexity 4197 4198   +1 
   
 Files   618  618  
 Lines 2974229760  +18 
 Branches   5257 5263   +6 
   
   + Hits  1167211678   +6 
   - Misses1621116223  +12 
 Partials   1859 1859
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...onfig/spring/schema/DubboBeanDefinitionParser.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL3NjaGVtYS9EdWJib0JlYW5EZWZpbml0aW9uUGFyc2VyLmphdmE=)
 | `20.81% <0%> (-0.26%)` | `18 <0> (ø)` | |
   | 
[...alibaba/dubbo/rpc/protocol/thrift/ThriftCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10aHJpZnQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvcHJvdG9jb2wvdGhyaWZ0L1RocmlmdENvZGVjLmphdmE=)
 | `2.95% <2.22%> (-0.1%)` | `5 <0> (ø)` | |
   | 
[...n/java/com/alibaba/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZy5qYXZh)
 | `39.9% <50%> (+0.09%)` | `44 <1> (+1)` | :arrow_up: |
   | 
[.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh)
 | `74.76% <0%> (-1.87%)` | `7% <0%> (ø)` | |
   | 
[...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DaGFubmVsV3JhcHBlZEludm9rZXIuamF2YQ==)
 | `50% <0%> (+12.5%)` | `3% <0%> (ø)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr=footer).
 Last update 
[2030789...996c292](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[GitHub] stardustliu closed pull request #1791: 2.6.2 release

2018-05-13 Thread GitBox
stardustliu closed pull request #1791: 2.6.2 release
URL: https://github.com/apache/incubator-dubbo/pull/1791
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[GitHub] ralf0131 commented on issue #500: 文档用到 http://code.alibabatech.com 都需要更新下

2018-05-13 Thread GitBox
ralf0131 commented on issue #500: 文档用到 http://code.alibabatech.com 都需要更新下
URL: https://github.com/apache/incubator-dubbo/issues/500#issuecomment-388625630
 
 
   @nashtsai 
   
   * Dubbo docs: https://github.com/apache/incubator-dubbo-docs
   * Dubbo website: https://github.com/apache/incubator-dubbo-website
   
   @foquanlin 
   
   http://code.alibabatech.com/schema/dubbo/dubbo.xsd the link has been fixed, 
I will be available under 2.6.2, or you can try out it 2.6.2-SNAPSHOT on the 
master branch.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[GitHub] rocky-luo opened a new issue #1789: 关于Adaptive

2018-05-13 Thread GitBox
rocky-luo opened a new issue #1789: 关于Adaptive
URL: https://github.com/apache/incubator-dubbo/issues/1789
 
 
   感觉Dubbo的Adaptive设计严重降低了代码的可读性,特别是在还包裹了很多AOP的情况下
   比如说ReferenceConfig里面的
   `invoker = refprotocol.refer(interfaceClass, urls.get(0));`
   求教这个refprotocol到底是在哪里被加强的


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[GitHub] yjx1045072812 commented on issue #1769: 我自己实现了一个Container,如何在使用com.alibaba.dubbo.container.Main启动应用的时候传递参数进来?

2018-05-13 Thread GitBox
yjx1045072812 commented on issue #1769: 
我自己实现了一个Container,如何在使用com.alibaba.dubbo.container.Main启动应用的时候传递参数进来?
URL: 
https://github.com/apache/incubator-dubbo/issues/1769#issuecomment-388609905
 
 
   我的代码是这样的:
   `public class ServiceContainer implements Container {
private static final Constants constants = new Constants();
private static final Plugins plugins = new Plugins();
private static final Interceptors interceptors = new Interceptors();
private static final AgentServiceConfig myconfig=new 
AgentServiceConfig();
private static final Logger 
logger=LoggerFactory.getLogger(ServiceContainer.class);
@Override
public void start() {
myconfig.configConstant(constants);
myconfig.configPlugin(plugins);
startPulgins();
myconfig.configInterceptor(interceptors);
myconfig.afterJFinalStart();
}
   
@Override
public void stop() {
myconfig.beforeJFinalStop();
stopPulgins();
}`
   然后使用spi 
   serviceContainer=com.my.ServiceContainer
   使用 `java -jar my.jar serviceContainer`启动容器


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[GitHub] huadong commented on issue #500: 文档用到 http://code.alibabatech.com 都需要更新下

2018-05-13 Thread GitBox
huadong commented on issue #500: 文档用到 http://code.alibabatech.com 都需要更新下
URL: https://github.com/apache/incubator-dubbo/issues/500#issuecomment-388608370
 
 
   多少年的问题了,都成为apache的孵化项目,这个还是阿里巴巴所有的域名:alibabatech.com!太丢人了!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[GitHub] yjx1045072812 commented on issue #1769: 我自己实现了一个Container,如何在使用com.alibaba.dubbo.container.Main启动应用的时候传递参数进来?

2018-05-13 Thread GitBox
yjx1045072812 commented on issue #1769: 
我自己实现了一个Container,如何在使用com.alibaba.dubbo.container.Main启动应用的时候传递参数进来?
URL: 
https://github.com/apache/incubator-dubbo/issues/1769#issuecomment-388610226
 
 
   因为我没有使用spring框架,完全使用api集成,所以想实现自己的容器


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[GitHub] yjx1045072812 commented on issue #1769: 我自己实现了一个Container,如何在使用com.alibaba.dubbo.container.Main启动应用的时候传递参数进来?

2018-05-13 Thread GitBox
yjx1045072812 commented on issue #1769: 
我自己实现了一个Container,如何在使用com.alibaba.dubbo.container.Main启动应用的时候传递参数进来?
URL: 
https://github.com/apache/incubator-dubbo/issues/1769#issuecomment-388609905
 
 
   我的代码是这样的:
   `public class ServiceContainer implements Container {
private static final Constants constants = new Constants();
private static final Plugins plugins = new Plugins();
private static final Interceptors interceptors = new Interceptors();
private static final AgentServiceConfig jfianlConfig=new 
AgentServiceConfig();
private static final Logger 
logger=LoggerFactory.getLogger(ServiceContainer.class);
@Override
public void start() {
jfianlConfig.configConstant(constants);
jfianlConfig.configPlugin(plugins);
startPulgins();
jfianlConfig.configInterceptor(interceptors);
jfianlConfig.afterJFinalStart();
}
@Override
public void stop() {
jfianlConfig.beforeJFinalStop();
stopPulgins();
}`
   然后使用spi 
   serviceContainer=com.my.ServiceContainer
   使用 `java -jar my.jar serviceContainer`启动容器


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[GitHub] yjx1045072812 commented on issue #1769: 我自己实现了一个Container,如何在使用com.alibaba.dubbo.container.Main启动应用的时候传递参数进来?

2018-05-13 Thread GitBox
yjx1045072812 commented on issue #1769: 
我自己实现了一个Container,如何在使用com.alibaba.dubbo.container.Main启动应用的时候传递参数进来?
URL: 
https://github.com/apache/incubator-dubbo/issues/1769#issuecomment-388609905
 
 
   我的代码是这样的:
   ```public class ServiceContainer implements Container {
private static final Constants constants = new Constants();
private static final Plugins plugins = new Plugins();
private static final Interceptors interceptors = new Interceptors();
private static final AgentServiceConfig jfianlConfig=new 
AgentServiceConfig();
private static final Logger 
logger=LoggerFactory.getLogger(ServiceContainer.class);
@Override
public void start() {
jfianlConfig.configConstant(constants);
jfianlConfig.configPlugin(plugins);
startPulgins();
jfianlConfig.configInterceptor(interceptors);
jfianlConfig.afterJFinalStart();
}
@Override
public void stop() {
jfianlConfig.beforeJFinalStop();
stopPulgins();
}```
   然后使用spi 
   serviceContainer=com.my.ServiceContainer
   使用 `java -jar my.jar serviceContainer`启动容器


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[GitHub] yjx1045072812 commented on issue #1769: 我自己实现了一个Container,如何在使用com.alibaba.dubbo.container.Main启动应用的时候传递参数进来?

2018-05-13 Thread GitBox
yjx1045072812 commented on issue #1769: 
我自己实现了一个Container,如何在使用com.alibaba.dubbo.container.Main启动应用的时候传递参数进来?
URL: 
https://github.com/apache/incubator-dubbo/issues/1769#issuecomment-388609905
 
 
   我的代码是这样的:
   `public class ServiceContainer implements Container {
private static final Constants constants = new Constants();
private static final Plugins plugins = new Plugins();
private static final Interceptors interceptors = new Interceptors();
private static final AgentServiceConfig jfianlConfig=new 
AgentServiceConfig();
private static final Logger 
logger=LoggerFactory.getLogger(ServiceContainer.class);
@Override
public void start() {
jfianlConfig.configConstant(constants);
jfianlConfig.configPlugin(plugins);
startPulgins();
jfianlConfig.configInterceptor(interceptors);
jfianlConfig.afterJFinalStart();
}
   
@Override
public void stop() {
jfianlConfig.beforeJFinalStop();
stopPulgins();
}`
   然后使用spi 
   serviceContainer=com.my.ServiceContainer
   使用 `java -jar my.jar serviceContainer`启动容器


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[GitHub] huadong commented on issue #500: 文档用到 http://code.alibabatech.com 都需要更新下

2018-05-13 Thread GitBox
huadong commented on issue #500: 文档用到 http://code.alibabatech.com 都需要更新下
URL: https://github.com/apache/incubator-dubbo/issues/500#issuecomment-388608370
 
 
   多少年的问题了,都成为apache的孵化项目,这个还是阿里巴巴所有的域名:alibabatech.com!太丢人了!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[GitHub] ralf0131 commented on issue #1788: 执行maven命令报错

2018-05-13 Thread GitBox
ralf0131 commented on issue #1788: 执行maven命令报错
URL: 
https://github.com/apache/incubator-dubbo/issues/1788#issuecomment-388604923
 
 
   Hi, please run `maven clean install` on the root directory first. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org