[GitHub] XUZHOUWANG commented on issue #135: 刷星星哦
XUZHOUWANG commented on issue #135: 刷星星哦 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/135#issuecomment-389050833 @mercyblitz 希望用价值的方式输出，而非利用famous来做star的堆积。假如项目okay，自然会有人star。而非先找一波人star，再来搞社区什么的。阿里还是很牛逼的。只是不欣赏这种方式。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] XUZHOUWANG commented on issue #135: 刷星星哦
XUZHOUWANG commented on issue #135: 刷星星哦 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/135#issuecomment-389050283 希望已价值的方式输出，而非利用famous来做star的堆积。假如项目okay，自然会有人star。而非先找一波人star，再来搞社区什么的。阿里还是很牛逼的。只是不欣赏这种方式。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] XUZHOUWANG commented on issue #135: 刷星星哦
XUZHOUWANG commented on issue #135: 刷星星哦 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/135#issuecomment-389050283 希望已价值的方式输出，而非利用famous来做star的堆积。假如项目okay，自然会有人star。而非先找一波人star，再来搞社区什么的。阿里还是很牛逼的。只是不欣赏这种方式。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed pull request #1797: unit test for SimpleDataStore
beiwei30 closed pull request #1797: unit test for SimpleDataStore
URL: https://github.com/apache/incubator-dubbo/pull/1797
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/store/support/SimpleDataStoreTest.java
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/store/support/SimpleDataStoreTest.java
index 42de80d517..0b81a9ad67 100644
---
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/store/support/SimpleDataStoreTest.java
+++
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/store/support/SimpleDataStoreTest.java
@@ -18,14 +18,18 @@
import org.junit.Test;
+import java.util.Map;
+
import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotEquals;
import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertTrue;
public class SimpleDataStoreTest {
-SimpleDataStore dataStore = new SimpleDataStore();
+private SimpleDataStore dataStore = new SimpleDataStore();
@Test
-public void testPut_Get() throws Exception {
+public void testPutGet() throws Exception {
assertNull(dataStore.get("xxx", "yyy"));
dataStore.put("name", "key", "1");
@@ -42,4 +46,15 @@ public void testRemove() throws Exception {
dataStore.remove("name", "key");
assertNull(dataStore.get("name", "key"));
}
+
+@Test
+public void testGetComponent() throws Exception {
+Map map = dataStore.get("component");
+assertTrue(map != null && map.isEmpty());
+dataStore.put("component", "key", "value");
+map = dataStore.get("component");
+assertTrue(map != null && map.size() == 1);
+dataStore.remove("component", "key");
+assertNotEquals(map, dataStore.get("component"));
+}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] YoungHu commented on issue #1624: [Design bug] unreasonable design for register dubbo service
YoungHu commented on issue #1624: [Design bug] unreasonable design for register dubbo service URL: https://github.com/apache/incubator-dubbo/issues/1624#issuecomment-389040288 @EdwardLee03 Yeah, our solution is to change the ZookeeperRegistry.toServicePath(URL) implementation, for our company use `group` more frequent than `version`, so our zk path like this(`interface:group`). for community version, I have two suggestion. the first, change the zk path to `interface:group:version`; the second, don't change zk path, just filter the zk item under `interface` path This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] blinkingso opened a new issue #137: providers' ip address at docker
blinkingso opened a new issue #137: providers' ip address at docker URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/137 how to use hostip instead of docker virtual ip on the registry. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] kivenhu commented on issue #818: mock 能在提供方统一 类名Mock，在消费方配置此类吗
kivenhu commented on issue #818: mock 能在提供方统一 类名Mock，在消费方配置此类吗 URL: https://github.com/apache/incubator-dubbo/issues/818#issuecomment-389026948 https://github.com/apache/incubator-dubbo/issues/1798 可以参考这个，统一抛出异常 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] codecov-io commented on issue #1797: unit test for SimpleDataStore
codecov-io commented on issue #1797: unit test for SimpleDataStore URL: https://github.com/apache/incubator-dubbo/pull/1797#issuecomment-389025831 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1797?src=pr=h1) Report > Merging [#1797](https://codecov.io/gh/apache/incubator-dubbo/pull/1797?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/04eacfeac7e4e25d3c2f0a2de12fa05708ee6b59?src=pr=desc) will **increase** coverage by `0.03%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1797?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1797 +/- ## + Coverage 39.82% 39.85% +0.03% - Complexity 4324 4327 +3 Files 626 626 Lines 3007830078 Branches 5319 5319 + Hits 1197911989 +10 + Misses1618516174 -11 - Partials 1914 1915 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1797?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1797/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `57.5% <0%> (-8.75%)` | `19% <0%> (-2%)` | | | [.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1797/diff?src=pr=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh) | `89.71% <0%> (+1.86%)` | `15% <0%> (ø)` | :arrow_down: | | [...ba/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1797/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlTZXJ2ZXIuamF2YQ==) | `71.42% <0%> (+3.57%)` | `9% <0%> (+1%)` | :arrow_up: | | [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1797/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `83.33% <0%> (+5.55%)` | `6% <0%> (+1%)` | :arrow_up: | | [...aba/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1797/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDaGFubmVsLmphdmE=) | `53.52% <0%> (+11.26%)` | `16% <0%> (+1%)` | :arrow_up: | | [...ba/dubbo/common/store/support/SimpleDataStore.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1797/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3N0b3JlL3N1cHBvcnQvU2ltcGxlRGF0YVN0b3JlLmphdmE=) | `94.44% <0%> (+16.66%)` | `8% <0%> (+2%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1797?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1797?src=pr=footer). Last update [04eacfe...2307d15](https://codecov.io/gh/apache/incubator-dubbo/pull/1797?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] mercyblitz closed pull request #133: Ensure UT pass on Java 10. #128
mercyblitz closed pull request #133: Ensure UT pass on Java 10. #128
URL: https://github.com/apache/incubator-dubbo-spring-boot-project/pull/133
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/dubbo-spring-boot-parent/pom.xml b/dubbo-spring-boot-parent/pom.xml
index 68ffc1ab..db16bc3e 100644
--- a/dubbo-spring-boot-parent/pom.xml
+++ b/dubbo-spring-boot-parent/pom.xml
@@ -26,6 +26,10 @@
3.4.9
2.12.0
1.5
+3.0.2
+3.6.0
+3.0.1
+3.0.0-M1
@@ -174,6 +178,7 @@
org.apache.maven.plugins
maven-jar-plugin
+${maven-jar.version}
true
@@ -188,15 +193,16 @@
org.apache.maven.plugins
maven-compiler-plugin
+${maven-compiler.version}
${java.version}
${java.version}
-true
org.apache.maven.plugins
maven-enforcer-plugin
+${maven-enforcer.version}
enforce-rules
@@ -223,6 +229,7 @@
org.apache.maven.plugins
maven-source-plugin
+${maven-source.version}
attach-sources
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 opened a new pull request #1797: unit test for SimpleDataStore
beiwei30 opened a new pull request #1797: unit test for SimpleDataStore URL: https://github.com/apache/incubator-dubbo/pull/1797 ## What is the purpose of the change unit test for SimpleDataStore ## Brief changelog ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test). - [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed pull request #1745: New threadLocal provides more performance.
beiwei30 closed pull request #1745: New threadLocal provides more performance.
URL: https://github.com/apache/incubator-dubbo/pull/1745
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-common/src/main/java/com/alibaba/dubbo/common/threadlocal/InternalThread.java
b/dubbo-common/src/main/java/com/alibaba/dubbo/common/threadlocal/InternalThread.java
new file mode 100644
index 00..a836561c50
--- /dev/null
+++
b/dubbo-common/src/main/java/com/alibaba/dubbo/common/threadlocal/InternalThread.java
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.alibaba.dubbo.common.threadlocal;
+
+/**
+ * InternalThread
+ */
+public class InternalThread extends Thread {
+
+private InternalThreadLocalMap threadLocalMap;
+
+public InternalThread() {
+}
+
+public InternalThread(Runnable target) {
+super(target);
+}
+
+public InternalThread(ThreadGroup group, Runnable target) {
+super(group, target);
+}
+
+public InternalThread(String name) {
+super(name);
+}
+
+public InternalThread(ThreadGroup group, String name) {
+super(group, name);
+}
+
+public InternalThread(Runnable target, String name) {
+super(target, name);
+}
+
+public InternalThread(ThreadGroup group, Runnable target, String name) {
+super(group, target, name);
+}
+
+public InternalThread(ThreadGroup group, Runnable target, String name,
long stackSize) {
+super(group, target, name, stackSize);
+}
+
+/**
+ * Returns the internal data structure that keeps the threadLocal
variables bound to this thread.
+ * Note that this method is for internal use only, and thus is subject to
change at any time.
+ */
+public final InternalThreadLocalMap threadLocalMap() {
+return threadLocalMap;
+}
+
+/**
+ * Sets the internal data structure that keeps the threadLocal variables
bound to this thread.
+ * Note that this method is for internal use only, and thus is subject to
change at any time.
+ */
+public final void setThreadLocalMap(InternalThreadLocalMap threadLocalMap)
{
+this.threadLocalMap = threadLocalMap;
+}
+}
diff --git
a/dubbo-common/src/main/java/com/alibaba/dubbo/common/threadlocal/InternalThreadLocal.java
b/dubbo-common/src/main/java/com/alibaba/dubbo/common/threadlocal/InternalThreadLocal.java
new file mode 100644
index 00..4eed57c4e8
--- /dev/null
+++
b/dubbo-common/src/main/java/com/alibaba/dubbo/common/threadlocal/InternalThreadLocal.java
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.alibaba.dubbo.common.threadlocal;
+
+import java.util.Collections;
+import java.util.IdentityHashMap;
+import java.util.Set;
+
+/**
+ * InternalThreadLocal
+ * A special variant of {@link ThreadLocal} that yields higher access
performance when accessed from a
+ * {@link InternalThread}.
+ *
+ * Internally, a {@link InternalThread} uses a constant index in an array,
instead of using hash code and hash table,
+ * to look for a variable. Although seemingly very subtle, it yields slight
performance advantage over using a hash
+ * table, and it is useful when
[GitHub] beiwei30 closed pull request #1796: unit test for com.alibaba.dubbo.common.status.support
beiwei30 closed pull request #1796: unit test for
com.alibaba.dubbo.common.status.support
URL: https://github.com/apache/incubator-dubbo/pull/1796
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-common/src/main/java/com/alibaba/dubbo/common/status/Status.java
b/dubbo-common/src/main/java/com/alibaba/dubbo/common/status/Status.java
index 940e17f570..ad598c94db 100644
--- a/dubbo-common/src/main/java/com/alibaba/dubbo/common/status/Status.java
+++ b/dubbo-common/src/main/java/com/alibaba/dubbo/common/status/Status.java
@@ -54,7 +54,7 @@ public String getDescription() {
/**
* Level
*/
-public static enum Level {
+public enum Level {
/**
* OK
*/
diff --git
a/dubbo-common/src/main/java/com/alibaba/dubbo/common/status/support/LoadStatusChecker.java
b/dubbo-common/src/main/java/com/alibaba/dubbo/common/status/support/LoadStatusChecker.java
index 018bce7807..20715c5d71 100644
---
a/dubbo-common/src/main/java/com/alibaba/dubbo/common/status/support/LoadStatusChecker.java
+++
b/dubbo-common/src/main/java/com/alibaba/dubbo/common/status/support/LoadStatusChecker.java
@@ -41,7 +41,8 @@ public Status check() {
load = -1;
}
int cpu = operatingSystemMXBean.getAvailableProcessors();
-return new Status(load < 0 ? Status.Level.UNKNOWN : (load < cpu ?
Status.Level.OK : Status.Level.WARN), (load < 0 ? "" : "load:" + load + ",") +
"cpu:" + cpu);
+return new Status(load < 0 ? Status.Level.UNKNOWN : (load < cpu ?
Status.Level.OK : Status.Level.WARN),
+(load < 0 ? "" : "load:" + load + ",") + "cpu:" + cpu);
}
}
diff --git
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/status/StatusTest.java
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/status/StatusTest.java
new file mode 100644
index 00..bc8e531483
--- /dev/null
+++ b/dubbo-common/src/test/java/com/alibaba/dubbo/common/status/StatusTest.java
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.alibaba.dubbo.common.status;
+
+import org.junit.Test;
+
+import static com.alibaba.dubbo.common.status.Status.Level.OK;
+import static org.hamcrest.Matchers.equalTo;
+import static org.hamcrest.Matchers.is;
+import static org.hamcrest.Matchers.isEmptyOrNullString;
+import static org.junit.Assert.assertThat;
+
+public class StatusTest {
+@Test
+public void testConstructor1() throws Exception {
+Status status = new Status(OK, "message", "description");
+assertThat(status.getLevel(), is(OK));
+assertThat(status.getMessage(), equalTo("message"));
+assertThat(status.getDescription(), equalTo("description"));
+}
+
+@Test
+public void testConstructor2() throws Exception {
+Status status = new Status(OK, "message");
+assertThat(status.getLevel(), is(OK));
+assertThat(status.getMessage(), equalTo("message"));
+assertThat(status.getDescription(), isEmptyOrNullString());
+}
+
+@Test
+public void testConstructor3() throws Exception {
+Status status = new Status(OK);
+assertThat(status.getLevel(), is(OK));
+assertThat(status.getMessage(), isEmptyOrNullString());
+assertThat(status.getDescription(), isEmptyOrNullString());
+}
+}
diff --git
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/status/support/LoadStatusCheckerTest.java
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/status/support/LoadStatusCheckerTest.java
new file mode 100644
index 00..121da3bb3b
--- /dev/null
+++
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/status/support/LoadStatusCheckerTest.java
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License,
[GitHub] codecov-io commented on issue #1745: New threadLocal provides more performance.
codecov-io commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-386791924 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=h1) Report > Merging [#1745](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/ddc1ea4149d3e6879be21a55981f4ccb5ad14920?src=pr=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `46.82%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1745 +/- ## - Coverage 39.67% 39.65% -0.03% - Complexity 4285 4308 +23 Files 622 626 +4 Lines 2990730077 +170 Branches 5297 5318 +21 + Hits 1186711928 +61 - Misses1613816243 +105 - Partials 1902 1906 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mmon/threadpool/support/fixed/FixedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9maXhlZC9GaXhlZFRocmVhZFBvb2wuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../threadpool/support/limited/LimitedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9saW1pdGVkL0xpbWl0ZWRUaHJlYWRQb29sLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...on/threadpool/support/cached/CachedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9jYWNoZWQvQ2FjaGVkVGhyZWFkUG9vbC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/eager/EagerThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lYWdlci9FYWdlclRocmVhZFBvb2wuamF2YQ==) | `90% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: | | [...alibaba/dubbo/common/utils/NamedThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL05hbWVkVGhyZWFkRmFjdG9yeS5qYXZh) | `64.7% <100%> (ø)` | `3 <2> (ø)` | :arrow_down: | | [...rc/main/java/com/alibaba/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvUnBjQ29udGV4dC5qYXZh) | `30.93% <100%> (ø)` | `27 <1> (ø)` | :arrow_down: | | [...common/threadlocal/NamedInternalThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL05hbWVkSW50ZXJuYWxUaHJlYWRGYWN0b3J5LmphdmE=) | `20% <20%> (ø)` | `1 <1> (?)` | | | [...ibaba/dubbo/common/threadlocal/InternalThread.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkLmphdmE=) | `26.31% <26.31%> (ø)` | `3 <3> (?)` | | | [.../dubbo/common/threadlocal/InternalThreadLocal.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWwuamF2YQ==) | `35.82% <35.82%> (ø)` | `8 <8> (?)` | | | [...bbo/common/threadlocal/InternalThreadLocalMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWxNYXAuamF2YQ==) | `63.51% <63.51%> (ø)` | `15 <15> (?)` | | | ... and [10 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute
[GitHub] codecov-io commented on issue #1745: New threadLocal provides more performance.
codecov-io commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-386791924 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=h1) Report > Merging [#1745](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/ddc1ea4149d3e6879be21a55981f4ccb5ad14920?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `46.82%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1745 +/- ## + Coverage 39.67% 39.69% +0.01% - Complexity 4285 4309 +24 Files 622 626 +4 Lines 2990730077 +170 Branches 5297 5318 +21 + Hits 1186711938 +71 - Misses1613816232 +94 - Partials 1902 1907 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../threadpool/support/limited/LimitedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9saW1pdGVkL0xpbWl0ZWRUaHJlYWRQb29sLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/eager/EagerThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lYWdlci9FYWdlclRocmVhZFBvb2wuamF2YQ==) | `90% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/fixed/FixedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9maXhlZC9GaXhlZFRocmVhZFBvb2wuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...on/threadpool/support/cached/CachedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9jYWNoZWQvQ2FjaGVkVGhyZWFkUG9vbC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...alibaba/dubbo/common/utils/NamedThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL05hbWVkVGhyZWFkRmFjdG9yeS5qYXZh) | `64.7% <100%> (ø)` | `3 <2> (ø)` | :arrow_down: | | [...rc/main/java/com/alibaba/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvUnBjQ29udGV4dC5qYXZh) | `30.93% <100%> (ø)` | `27 <1> (ø)` | :arrow_down: | | [...common/threadlocal/NamedInternalThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL05hbWVkSW50ZXJuYWxUaHJlYWRGYWN0b3J5LmphdmE=) | `20% <20%> (ø)` | `1 <1> (?)` | | | [...ibaba/dubbo/common/threadlocal/InternalThread.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkLmphdmE=) | `26.31% <26.31%> (ø)` | `3 <3> (?)` | | | [.../dubbo/common/threadlocal/InternalThreadLocal.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWwuamF2YQ==) | `35.82% <35.82%> (ø)` | `8 <8> (?)` | | | [...bbo/common/threadlocal/InternalThreadLocalMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWxNYXAuamF2YQ==) | `63.51% <63.51%> (ø)` | `15 <15> (?)` | | | ... and [10 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute
[GitHub] blinkingso commented on issue #136: how to config provider ?
blinkingso commented on issue #136: how to config provider ?
URL:
https://github.com/apache/incubator-dubbo-spring-boot-project/issues/136#issuecomment-388757758
` dubbo:
application:
name: ms-member-web
registry:
address: redis://${spring.redis.host}:${spring.redis.port}
username: root
password: ${spring.redis.password}
check: true
dynamic: true
server: true
protocol:
name: dubbo
port: 20880
consumer:
check: false
provider:
dynamic: true`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] blinkingso commented on issue #136: how to config provider ?
blinkingso commented on issue #136: how to config provider ?
URL:
https://github.com/apache/incubator-dubbo-spring-boot-project/issues/136#issuecomment-388757758
dubbo:
application:
name: ms-member-web
registry:
address: redis://${spring.redis.host}:${spring.redis.port}
username: root
password: ${spring.redis.password}
check: true
dynamic: true
server: true
protocol:
name: dubbo
port: 20880
consumer:
check: false
provider:
dynamic: true
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 opened a new pull request #1796: unit test for com.alibaba.dubbo.common.status.support
beiwei30 opened a new pull request #1796: unit test for com.alibaba.dubbo.common.status.support URL: https://github.com/apache/incubator-dubbo/pull/1796 ## What is the purpose of the change unit test for com.alibaba.dubbo.common.status.support ## Brief changelog ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test). - [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #9: Update the legacy links in docs
ralf0131 closed issue #9: Update the legacy links in docs URL: https://github.com/apache/incubator-dubbo-docs/issues/9 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #9: Update the legacy links in docs
ralf0131 commented on issue #9: Update the legacy links in docs URL: https://github.com/apache/incubator-dubbo-docs/issues/9#issuecomment-388752789 This issue has been fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed pull request #28: change invalid link address
ralf0131 closed pull request #28: change invalid link address URL: https://github.com/apache/incubator-dubbo-docs/pull/28 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/dubbo-admin-book-en/install/admin-console.md b/dubbo-admin-book-en/install/admin-console.md index 516a4f6..7f2a743 100644 --- a/dubbo-admin-book-en/install/admin-console.md +++ b/dubbo-admin-book-en/install/admin-console.md @@ -5,7 +5,7 @@ Include: route rule, dynamic configuration, service downgrade, access control, w Install: ```sh -wget http://apache.etoak.com/tomcat/tomcat-6/v6.0.35/bin/apache-tomcat-6.0.35.tar.gz +wget https://archive.apache.org/dist/tomcat/tomcat-6/v6.0.35/bin/apache-tomcat-6.0.35.tar.gz tar zxvf apache-tomcat-6.0.35.tar.gz cd apache-tomcat-6.0.35 rm -rf webapps/ROOT diff --git a/dubbo-admin-book-en/install/redis.md b/dubbo-admin-book-en/install/redis.md index ce48780..2a1f4c7 100644 --- a/dubbo-admin-book-en/install/redis.md +++ b/dubbo-admin-book-en/install/redis.md @@ -11,7 +11,7 @@ Redis configuration center cluster [^2] write multiple server in client side and Install: ```sh -wget http://redis.googlecode.com/files/redis-2.4.8.tar.gz +wget https://storage.googleapis.com/google-code-archive-downloads/v2/code.google.com/redis/redis-2.4.8.tar.gz tar xzf redis-2.4.8.tar.gz cd redis-2.4.8 make diff --git a/dubbo-admin-book/install/admin-console.md b/dubbo-admin-book/install/admin-console.md index d93f0f7..bdaf303 100644 --- a/dubbo-admin-book/install/admin-console.md +++ b/dubbo-admin-book/install/admin-console.md @@ -5,7 +5,7 @@ 安装: ```sh -wget http://apache.etoak.com/tomcat/tomcat-6/v6.0.35/bin/apache-tomcat-6.0.35.tar.gz +wget https://archive.apache.org/dist/tomcat/tomcat-6/v6.0.35/bin/apache-tomcat-6.0.35.tar.gz tar zxvf apache-tomcat-6.0.35.tar.gz cd apache-tomcat-6.0.35 rm -rf webapps/ROOT diff --git a/dubbo-admin-book/install/redis.md b/dubbo-admin-book/install/redis.md index b7b518c..fe46707 100644 --- a/dubbo-admin-book/install/redis.md +++ b/dubbo-admin-book/install/redis.md @@ -11,7 +11,7 @@ Redis 注册中心集群 [^2] 采用在客户端同时写入多个服务器， 安装: ```sh -wget http://redis.googlecode.com/files/redis-2.4.8.tar.gz +wget https://storage.googleapis.com/google-code-archive-downloads/v2/code.google.com/redis/redis-2.4.8.tar.gz tar xzf redis-2.4.8.tar.gz cd redis-2.4.8 make diff --git a/dubbo-user-book-en/benchmark-tool.md b/dubbo-user-book-en/benchmark-tool.md index e74d781..b64112e 100644 --- a/dubbo-user-book-en/benchmark-tool.md +++ b/dubbo-user-book-en/benchmark-tool.md @@ -1,6 +1,8 @@ # Beanchmark testing tool installer -Download the [benchmark installer](http://code.alibabatech.com/wiki/download/attachments/7669075/dubbo.benchmark-2.0.14.tar.gz)，and unzip it +* download： git clone https://github.com/apache/incubator-dubbo.git +* compile benchmark: cd incubator-dubbo/dubbo-test/dubbo-test-benchmark; mvn clean install +* uncompress benchmark： incubator-dubbo/dubbo-test/dubbo-test-benchmark/target/dubbo-test-benchmark-2.6.2-SNAPSHOT.tar.gz Read ReadMe.txt (the contents are as follows, in the compressed package.) diff --git a/dubbo-user-book-en/configuration/xml.md b/dubbo-user-book-en/configuration/xml.md index 99e5973..6789ffc 100644 --- a/dubbo-user-book-en/configuration/xml.md +++ b/dubbo-user-book-en/configuration/xml.md @@ -9,8 +9,8 @@ About the XML configuration items, see：[XML References](../references/xml/intr http://www.springframework.org/schema/beans; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; -xmlns:dubbo="http://code.alibabatech.com/schema/dubbo; -xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans.xsd http://code.alibabatech.com/schema/dubbo http://code.alibabatech.com/schema/dubbo/dubbo.xsd;> +xmlns:dubbo="http://dubbo.apache.org/schema/dubbo; +xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-4.3.xsd http://dubbo.apache.org/schema/dubbo http://dubbo.apache.org/schema/dubbo/dubbo.xsd;> @@ -32,9 +32,9 @@ Or: ``` xml http://www.springframework.org/schema/beans; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; -xmlns:dubbo="http://code.alibabatech.com/schema/dubbo; +xmlns:dubbo="http://dubbo.apache.org/schema/dubbo; xmlns:p="http://www.springframework.org/schema/p; -xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans.xsd http://code.alibabatech.com/schema/dubbo http://code.alibabatech.com/schema/dubbo/dubbo.xsd;> +xsi:schemaLocation="http://www.springframework.org/schema/beans
[GitHub] ralf0131 commented on issue #28: change invalid link address
ralf0131 commented on issue #28: change invalid link address URL: https://github.com/apache/incubator-dubbo-docs/pull/28#issuecomment-388752353 Thanks for the pull request, it looks good to me! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] codecov-io commented on issue #1745: New threadLocal provides more performance.
codecov-io commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-386791924 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=h1) Report > Merging [#1745](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/ddc1ea4149d3e6879be21a55981f4ccb5ad14920?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `46.82%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #1745 +/- ## === + Coverage 39.67% 39.7% +0.02% - Complexity 42854309 +24 === Files 622 626 +4 Lines 29907 30077 +170 Branches 52975318 +21 === + Hits 11867 11943 +76 - Misses16138 16225 +87 - Partials 19021909 +7 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...on/threadpool/support/cached/CachedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9jYWNoZWQvQ2FjaGVkVGhyZWFkUG9vbC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/eager/EagerThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lYWdlci9FYWdlclRocmVhZFBvb2wuamF2YQ==) | `90% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: | | [.../threadpool/support/limited/LimitedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9saW1pdGVkL0xpbWl0ZWRUaHJlYWRQb29sLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/fixed/FixedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9maXhlZC9GaXhlZFRocmVhZFBvb2wuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...alibaba/dubbo/common/utils/NamedThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL05hbWVkVGhyZWFkRmFjdG9yeS5qYXZh) | `64.7% <100%> (ø)` | `3 <2> (ø)` | :arrow_down: | | [...rc/main/java/com/alibaba/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvUnBjQ29udGV4dC5qYXZh) | `30.93% <100%> (ø)` | `27 <1> (ø)` | :arrow_down: | | [...common/threadlocal/NamedInternalThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL05hbWVkSW50ZXJuYWxUaHJlYWRGYWN0b3J5LmphdmE=) | `20% <20%> (ø)` | `1 <1> (?)` | | | [...ibaba/dubbo/common/threadlocal/InternalThread.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkLmphdmE=) | `26.31% <26.31%> (ø)` | `3 <3> (?)` | | | [.../dubbo/common/threadlocal/InternalThreadLocal.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWwuamF2YQ==) | `35.82% <35.82%> (ø)` | `8 <8> (?)` | | | [...bbo/common/threadlocal/InternalThreadLocalMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWxNYXAuamF2YQ==) | `63.51% <63.51%> (ø)` | `15 <15> (?)` | | | ... and [10 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø
[GitHub] codecov-io commented on issue #1745: New threadLocal provides more performance.
codecov-io commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-386791924 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=h1) Report > Merging [#1745](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/ddc1ea4149d3e6879be21a55981f4ccb5ad14920?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `46.82%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #1745 +/- ## === + Coverage 39.67% 39.7% +0.02% - Complexity 42854309 +24 === Files 622 626 +4 Lines 29907 30077 +170 Branches 52975318 +21 === + Hits 11867 11943 +76 - Misses16138 16225 +87 - Partials 19021909 +7 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...on/threadpool/support/cached/CachedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9jYWNoZWQvQ2FjaGVkVGhyZWFkUG9vbC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/eager/EagerThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lYWdlci9FYWdlclRocmVhZFBvb2wuamF2YQ==) | `90% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: | | [.../threadpool/support/limited/LimitedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9saW1pdGVkL0xpbWl0ZWRUaHJlYWRQb29sLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/fixed/FixedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9maXhlZC9GaXhlZFRocmVhZFBvb2wuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...rc/main/java/com/alibaba/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvUnBjQ29udGV4dC5qYXZh) | `30.93% <100%> (ø)` | `27 <1> (ø)` | :arrow_down: | | [...alibaba/dubbo/common/utils/NamedThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL05hbWVkVGhyZWFkRmFjdG9yeS5qYXZh) | `64.7% <100%> (ø)` | `3 <2> (ø)` | :arrow_down: | | [...common/threadlocal/NamedInternalThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL05hbWVkSW50ZXJuYWxUaHJlYWRGYWN0b3J5LmphdmE=) | `20% <20%> (ø)` | `1 <1> (?)` | | | [...ibaba/dubbo/common/threadlocal/InternalThread.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkLmphdmE=) | `26.31% <26.31%> (ø)` | `3 <3> (?)` | | | [.../dubbo/common/threadlocal/InternalThreadLocal.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWwuamF2YQ==) | `35.82% <35.82%> (ø)` | `8 <8> (?)` | | | [...bbo/common/threadlocal/InternalThreadLocalMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWxNYXAuamF2YQ==) | `63.51% <63.51%> (ø)` | `15 <15> (?)` | | | ... and [10 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø
[GitHub] carryxyh commented on issue #1745: New threadLocal provides more performance.
carryxyh commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-388745592 @beiwei30 done. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] codecov-io commented on issue #1745: New threadLocal provides more performance.
codecov-io commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-386791924 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=h1) Report > Merging [#1745](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/ddc1ea4149d3e6879be21a55981f4ccb5ad14920?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `46.82%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #1745 +/- ## === + Coverage 39.67% 39.7% +0.02% - Complexity 42854309 +24 === Files 622 626 +4 Lines 29907 30077 +170 Branches 52975318 +21 === + Hits 11867 11943 +76 - Misses16138 16225 +87 - Partials 19021909 +7 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...on/threadpool/support/cached/CachedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9jYWNoZWQvQ2FjaGVkVGhyZWFkUG9vbC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/eager/EagerThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lYWdlci9FYWdlclRocmVhZFBvb2wuamF2YQ==) | `90% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: | | [.../threadpool/support/limited/LimitedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9saW1pdGVkL0xpbWl0ZWRUaHJlYWRQb29sLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/fixed/FixedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9maXhlZC9GaXhlZFRocmVhZFBvb2wuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...rc/main/java/com/alibaba/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvUnBjQ29udGV4dC5qYXZh) | `30.93% <100%> (ø)` | `27 <1> (ø)` | :arrow_down: | | [...alibaba/dubbo/common/utils/NamedThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL05hbWVkVGhyZWFkRmFjdG9yeS5qYXZh) | `64.7% <100%> (ø)` | `3 <2> (ø)` | :arrow_down: | | [...common/threadlocal/NamedInternalThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL05hbWVkSW50ZXJuYWxUaHJlYWRGYWN0b3J5LmphdmE=) | `20% <20%> (ø)` | `1 <1> (?)` | | | [...ibaba/dubbo/common/threadlocal/InternalThread.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkLmphdmE=) | `26.31% <26.31%> (ø)` | `3 <3> (?)` | | | [.../dubbo/common/threadlocal/InternalThreadLocal.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWwuamF2YQ==) | `35.82% <35.82%> (ø)` | `8 <8> (?)` | | | [...bbo/common/threadlocal/InternalThreadLocalMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWxNYXAuamF2YQ==) | `63.51% <63.51%> (ø)` | `15 <15> (?)` | | | ... and [10 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø
[GitHub] blinkingso opened a new issue #136: how to config provider ?
blinkingso opened a new issue #136: how to config provider ? URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/136 how to config registry or provider with redis registry? i want to del api from redis when i stop service provider . i tried with provider:dynamic and set true. but it does no work. any help? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] 0oo closed pull request #1497: when using simpleregistry, provider throwed a exception
0oo closed pull request #1497: when using simpleregistry, provider throwed a
exception
URL: https://github.com/apache/incubator-dubbo/pull/1497
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-simple/dubbo-registry-simple/src/main/java/com/alibaba/dubbo/registry/simple/SimpleRegistryService.java
b/dubbo-simple/dubbo-registry-simple/src/main/java/com/alibaba/dubbo/registry/simple/SimpleRegistryService.java
index f75415220a..7dfdec788b 100644
---
a/dubbo-simple/dubbo-registry-simple/src/main/java/com/alibaba/dubbo/registry/simple/SimpleRegistryService.java
+++
b/dubbo-simple/dubbo-registry-simple/src/main/java/com/alibaba/dubbo/registry/simple/SimpleRegistryService.java
@@ -57,7 +57,7 @@ public boolean isAvailable() {
List urls = new ArrayList();
for (URL u : getRegistered()) {
if (UrlUtils.isMatch(url, u)) {
-urls.add(u);
+ urls.add(u.clearParameters());
}
}
return urls;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed pull request #1776: Extracting public code to the parent class
beiwei30 closed pull request #1776: Extracting public code to the parent class
URL: https://github.com/apache/incubator-dubbo/pull/1776
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/WrappedChannelHandler.java
b/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/WrappedChannelHandler.java
index fea2d6a53c..d660b52d3f 100644
---
a/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/WrappedChannelHandler.java
+++
b/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/WrappedChannelHandler.java
@@ -109,4 +109,12 @@ public URL getUrl() {
return url;
}
+public ExecutorService getExecutorService() {
+ExecutorService cexecutor = executor;
+if (cexecutor == null || cexecutor.isShutdown()) {
+cexecutor = SHARED_EXECUTOR;
+}
+return cexecutor;
+}
+
}
diff --git
a/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/all/AllChannelHandler.java
b/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/all/AllChannelHandler.java
index 9e5b331cb2..d44f0655e8 100644
---
a/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/all/AllChannelHandler.java
+++
b/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/all/AllChannelHandler.java
@@ -88,12 +88,4 @@ public void caught(Channel channel, Throwable exception)
throws RemotingExceptio
throw new ExecutionException("caught event", channel, getClass() +
" error when process caught event .", t);
}
}
-
-private ExecutorService getExecutorService() {
-ExecutorService cexecutor = executor;
-if (cexecutor == null || cexecutor.isShutdown()) {
-cexecutor = SHARED_EXECUTOR;
-}
-return cexecutor;
-}
}
diff --git
a/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/connection/ConnectionOrderedChannelHandler.java
b/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/connection/ConnectionOrderedChannelHandler.java
index 1b162d5b6e..fb432a8563 100644
---
a/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/connection/ConnectionOrderedChannelHandler.java
+++
b/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/connection/ConnectionOrderedChannelHandler.java
@@ -75,10 +75,7 @@ public void disconnected(Channel channel) throws
RemotingException {
@Override
public void received(Channel channel, Object message) throws
RemotingException {
-ExecutorService cexecutor = executor;
-if (cexecutor == null || cexecutor.isShutdown()) {
-cexecutor = SHARED_EXECUTOR;
-}
+ExecutorService cexecutor = getExecutorService();
try {
cexecutor.execute(new ChannelEventRunnable(channel, handler,
ChannelState.RECEIVED, message));
} catch (Throwable t) {
@@ -100,10 +97,7 @@ public void received(Channel channel, Object message)
throws RemotingException {
@Override
public void caught(Channel channel, Throwable exception) throws
RemotingException {
-ExecutorService cexecutor = executor;
-if (cexecutor == null || cexecutor.isShutdown()) {
-cexecutor = SHARED_EXECUTOR;
-}
+ExecutorService cexecutor = getExecutorService();
try {
cexecutor.execute(new ChannelEventRunnable(channel, handler,
ChannelState.CAUGHT, exception));
} catch (Throwable t) {
diff --git
a/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/execution/ExecutionChannelHandler.java
b/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/execution/ExecutionChannelHandler.java
index 8a19bdd5a3..d31840b688 100644
---
a/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/execution/ExecutionChannelHandler.java
+++
b/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/execution/ExecutionChannelHandler.java
@@ -27,6 +27,7 @@
import
com.alibaba.dubbo.remoting.transport.dispatcher.ChannelEventRunnable.ChannelState;
import com.alibaba.dubbo.remoting.transport.dispatcher.WrappedChannelHandler;
+import java.util.concurrent.ExecutorService;
[GitHub] codecov-io commented on issue #1795: clean up: finish unit test for config-api
codecov-io commented on issue #1795: clean up: finish unit test for config-api URL: https://github.com/apache/incubator-dubbo/pull/1795#issuecomment-388728876 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1795?src=pr=h1) Report > Merging [#1795](https://codecov.io/gh/apache/incubator-dubbo/pull/1795?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/9c4017e9ba7ba170262f388ac159bcccb11ce209?src=pr=desc) will **increase** coverage by `0.05%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1795?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1795 +/- ## + Coverage 39.28% 39.34% +0.05% - Complexity 4209 4216 +7 Files 618 618 Lines 2974229742 Branches 5257 5257 + Hits 1168411701 +17 + Misses1619016176 -14 + Partials 1868 1865 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1795?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ba/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1795/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlTZXJ2ZXIuamF2YQ==) | `67.85% <0%> (-3.58%)` | `8% <0%> (-1%)` | | | [...java/com/alibaba/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1795/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvUmVmZXJlbmNlQ29uZmlnLmphdmE=) | `48.33% <0%> (-0.37%)` | `36% <0%> (-1%)` | | | [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1795/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==) | `54.68% <0%> (+1.56%)` | `3% <0%> (ø)` | :arrow_down: | | [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1795/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `55.69% <0%> (+3.79%)` | `13% <0%> (+2%)` | :arrow_up: | | [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1795/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `83.33% <0%> (+5.55%)` | `6% <0%> (+1%)` | :arrow_up: | | [...libaba/com/caucho/hessian/util/IdentityIntMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1795/diff?src=pr=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL3V0aWwvSWRlbnRpdHlJbnRNYXAuamF2YQ==) | `30.95% <0%> (+5.95%)` | `7% <0%> (+2%)` | :arrow_up: | | [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1795/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `66.25% <0%> (+8.75%)` | `21% <0%> (+2%)` | :arrow_up: | | [...onfig/invoker/DelegateProviderMetaDataInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1795/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvaW52b2tlci9EZWxlZ2F0ZVByb3ZpZGVyTWV0YURhdGFJbnZva2VyLmphdmE=) | `100% <0%> (+18.18%)` | `7% <0%> (+2%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1795?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1795?src=pr=footer). Last update [9c4017e...f24a410](https://codecov.io/gh/apache/incubator-dubbo/pull/1795?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above
[GitHub] beiwei30 closed pull request #1795: clean up: finish unit test for config-api
beiwei30 closed pull request #1795: clean up: finish unit test for config-api
URL: https://github.com/apache/incubator-dubbo/pull/1795
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractConfigTest.java
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractConfigTest.java
index 7cd83f0b28..5366b90910 100644
---
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractConfigTest.java
+++
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractConfigTest.java
@@ -18,6 +18,7 @@
import com.alibaba.dubbo.common.Constants;
import com.alibaba.dubbo.common.utils.ConfigUtils;
+import com.alibaba.dubbo.config.api.Greeting;
import com.alibaba.dubbo.config.support.Parameter;
import junit.framework.TestCase;
import org.junit.Test;
diff --git
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractInterfaceConfigTest.java
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractInterfaceConfigTest.java
index 94578b2cfd..f34c31ffbe 100644
---
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractInterfaceConfigTest.java
+++
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractInterfaceConfigTest.java
@@ -19,6 +19,12 @@
import com.alibaba.dubbo.common.Constants;
import com.alibaba.dubbo.common.URL;
import com.alibaba.dubbo.common.utils.ConfigUtils;
+import com.alibaba.dubbo.config.api.Greeting;
+import com.alibaba.dubbo.config.mock.GreetingLocal1;
+import com.alibaba.dubbo.config.mock.GreetingLocal2;
+import com.alibaba.dubbo.config.mock.GreetingLocal3;
+import com.alibaba.dubbo.config.mock.GreetingMock1;
+import com.alibaba.dubbo.config.mock.GreetingMock2;
import com.alibaba.dubbo.monitor.MonitorService;
import com.alibaba.dubbo.registry.RegistryService;
import junit.framework.TestCase;
diff --git
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ProtocolConfigTest.java
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ProtocolConfigTest.java
index 43f3621e28..c9d904622e 100644
---
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ProtocolConfigTest.java
+++
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ProtocolConfigTest.java
@@ -18,6 +18,7 @@
package com.alibaba.dubbo.config;
import com.alibaba.dubbo.common.extension.ExtensionLoader;
+import com.alibaba.dubbo.config.mock.MockProtocol2;
import com.alibaba.dubbo.rpc.Protocol;
import org.junit.Test;
import org.mockito.Mockito;
diff --git
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ServiceConfigTest.java
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ServiceConfigTest.java
index 632cbd18ea..d0eb6bc8d0 100644
---
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ServiceConfigTest.java
+++
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ServiceConfigTest.java
@@ -20,7 +20,10 @@
import com.alibaba.dubbo.common.Constants;
import com.alibaba.dubbo.common.URL;
import com.alibaba.dubbo.config.api.DemoService;
+import com.alibaba.dubbo.config.api.Greeting;
import com.alibaba.dubbo.config.provider.impl.DemoServiceImpl;
+import com.alibaba.dubbo.config.mock.MockProtocol2;
+import com.alibaba.dubbo.config.mock.MockRegistryFactory2;
import com.alibaba.dubbo.registry.Registry;
import com.alibaba.dubbo.rpc.Exporter;
import com.alibaba.dubbo.rpc.Invoker;
@@ -55,7 +58,7 @@
@Before
public void setUp() throws Exception {
MockProtocol2.delegate = protocolDelegate;
-MockRegistryFactory.registry = registryDelegate;
+MockRegistryFactory2.registry = registryDelegate;
Mockito.when(protocolDelegate.export(Mockito.any(Invoker.class))).thenReturn(exporter);
ApplicationConfig app = new ApplicationConfig("app");
diff --git
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/Greeting.java
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/api/Greeting.java
similarity index 87%
rename from
dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/Greeting.java
rename to
dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/api/Greeting.java
index 65ab0f3b52..0ceca89d9f 100644
---
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/Greeting.java
+++
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/api/Greeting.java
@@ -6,7 +6,7 @@
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a
[GitHub] beiwei30 closed pull request #1736: [Dubbo-1687]Add unit tests for dubbo-filter-validation module
beiwei30 closed pull request #1736: [Dubbo-1687]Add unit tests for
dubbo-filter-validation module
URL: https://github.com/apache/incubator-dubbo/pull/1736
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/dubbo-filter/dubbo-filter-validation/pom.xml
b/dubbo-filter/dubbo-filter-validation/pom.xml
index 758434779d..936777d36b 100644
--- a/dubbo-filter/dubbo-filter-validation/pom.xml
+++ b/dubbo-filter/dubbo-filter-validation/pom.xml
@@ -39,5 +39,35 @@
javax.validation
validation-api
+
+org.hibernate
+hibernate-validator
+test
+${hibernate_validator_version}
+
+
+javax.el
+javax.el-api
+test
+${el_api_version}
+
+
+javax.xml.bind
+jaxb-api
+test
+${jaxb_api_version}
+
+
+com.sun.xml.bind
+jaxb-impl
+test
+${jaxb_api_version}
+
+
+com.sun.xml.bind
+jaxb-core
+test
+${jaxb_api_version}
+
\ No newline at end of file
diff --git
a/dubbo-filter/dubbo-filter-validation/src/test/java/com/alibaba/dubbo/validation/filter/ValidationFilterTest.java
b/dubbo-filter/dubbo-filter-validation/src/test/java/com/alibaba/dubbo/validation/filter/ValidationFilterTest.java
new file mode 100644
index 00..c1a0ae1ade
--- /dev/null
+++
b/dubbo-filter/dubbo-filter-validation/src/test/java/com/alibaba/dubbo/validation/filter/ValidationFilterTest.java
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.alibaba.dubbo.validation.filter;
+
+import com.alibaba.dubbo.common.URL;
+import com.alibaba.dubbo.rpc.*;
+import com.alibaba.dubbo.validation.Validation;
+import com.alibaba.dubbo.validation.Validator;
+import org.junit.Before;
+import org.junit.Test;
+
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.core.Is.is;
+import static org.mockito.BDDMockito.given;
+import static org.mockito.Mockito.mock;
+
+public class ValidationFilterTest {
+private Invoker invoker = mock(Invoker.class);
+private Validation validation = mock(Validation.class);
+private Validator validator = mock(Validator.class);
+private RpcInvocation invocation = mock(RpcInvocation.class);
+
+private ValidationFilter validationFilter;
+
+@Before
+public void setUp() throws Exception {
+this.validationFilter = new ValidationFilter();
+}
+
+@Test
+public void testItWithNotExistClass() throws Exception {
+URL url = URL.valueOf("test://test:11/test?default.validation=true");
+
+given(validation.getValidator(url)).willThrow(new
IllegalStateException("Not found class test, cause: test"));
+given(invoker.invoke(invocation)).willReturn(new RpcResult("success"));
+given(invoker.getUrl()).willReturn(url);
+given(invocation.getMethodName()).willReturn("echo1");
+given(invocation.getParameterTypes()).willReturn(new
Class[]{String.class});
+given(invocation.getArguments()).willReturn(new Object[]{"arg1"});
+
+validationFilter.setValidation(validation);
+Result result = validationFilter.invoke(invoker, invocation);
+
+assertThat(result.getException().getMessage(), is("Not found class
test, cause: test"));
+
+}
+
+@Test
+public void testItWithExistClass() throws Exception {
+URL url = URL.valueOf("test://test:11/test?default.validation=true");
+
+given(validation.getValidator(url)).willReturn(validator);
+given(invoker.invoke(invocation)).willReturn(new RpcResult("success"));
+given(invoker.getUrl()).willReturn(url);
+given(invocation.getMethodName()).willReturn("echo1");
+given(invocation.getParameterTypes()).willReturn(new
Class[]{String.class});
+
[GitHub] beiwei30 commented on a change in pull request #1738: [Dubbo-1691] Add unit tests for MulticastRegister #1691
beiwei30 commented on a change in pull request #1738: [Dubbo-1691] Add unit
tests for MulticastRegister #1691
URL: https://github.com/apache/incubator-dubbo/pull/1738#discussion_r187861452
##
File path:
dubbo-registry/dubbo-registry-multicast/src/test/java/com/alibaba/dubbo/registry/multicast/MulticastRegistryTest.java
##
@@ -27,92 +27,165 @@
import java.util.List;
import java.util.Map;
import java.util.Set;
-import java.util.concurrent.atomic.AtomicReference;
import static org.hamcrest.CoreMatchers.is;
-import static org.junit.Assert.assertThat;
-import static org.junit.Assert.assertTrue;
-import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.*;
public class MulticastRegistryTest {
-private String service = "com.alibaba.dubbo.test.injvmServie";
+private String service = "com.apache.dubbo.test.injvmServie";
Review comment:
why change this from alibaba to apache?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed issue #1688: Enhance the test coverage part-9 :dubbo-monitor module
beiwei30 closed issue #1688: Enhance the test coverage part-9 :dubbo-monitor module URL: https://github.com/apache/incubator-dubbo/issues/1688 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed pull request #1741: add test for monitor module
beiwei30 closed pull request #1741: add test for monitor module
URL: https://github.com/apache/incubator-dubbo/pull/1741
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-monitor/dubbo-monitor-api/src/test/java/com/alibaba/dubbo/monitor/support/AbstractMonitorFactoryTest.java
b/dubbo-monitor/dubbo-monitor-api/src/test/java/com/alibaba/dubbo/monitor/support/AbstractMonitorFactoryTest.java
index cc19f5ae86..64847af251 100644
---
a/dubbo-monitor/dubbo-monitor-api/src/test/java/com/alibaba/dubbo/monitor/support/AbstractMonitorFactoryTest.java
+++
b/dubbo-monitor/dubbo-monitor-api/src/test/java/com/alibaba/dubbo/monitor/support/AbstractMonitorFactoryTest.java
@@ -21,7 +21,7 @@
import com.alibaba.dubbo.monitor.Monitor;
import com.alibaba.dubbo.monitor.MonitorFactory;
-import junit.framework.Assert;
+import org.junit.Assert;
import org.junit.Test;
import java.util.List;
diff --git
a/dubbo-monitor/dubbo-monitor-api/src/test/java/com/alibaba/dubbo/monitor/support/MonitorFilterTest.java
b/dubbo-monitor/dubbo-monitor-api/src/test/java/com/alibaba/dubbo/monitor/support/MonitorFilterTest.java
index 5b8a303a48..3450eb438e 100644
---
a/dubbo-monitor/dubbo-monitor-api/src/test/java/com/alibaba/dubbo/monitor/support/MonitorFilterTest.java
+++
b/dubbo-monitor/dubbo-monitor-api/src/test/java/com/alibaba/dubbo/monitor/support/MonitorFilterTest.java
@@ -28,15 +28,21 @@
import com.alibaba.dubbo.rpc.RpcContext;
import com.alibaba.dubbo.rpc.RpcException;
import com.alibaba.dubbo.rpc.RpcInvocation;
-
-import junit.framework.Assert;
+import org.junit.Assert;
import org.junit.Test;
+import org.mockito.Mockito;
import java.io.UnsupportedEncodingException;
import java.net.URLEncoder;
import java.util.Arrays;
import java.util.List;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.BDDMockito.given;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.verify;
+
/**
* MonitorFilterTest
*/
@@ -125,6 +131,20 @@ public void testFilter() throws Exception {
Assert.assertEquals(invocation, lastInvocation);
}
+@Test
+public void testSkipMonitorIfNotHasKey() {
+MonitorFilter monitorFilter = new MonitorFilter();
+MonitorFactory mockMonitorFactory = mock(MonitorFactory.class);
+monitorFilter.setMonitorFactory(mockMonitorFactory);
+Invocation invocation = new RpcInvocation("aaa", new Class[0], new
Object[0]);
+Invoker invoker = mock(Invoker.class);
+given(invoker.getUrl()).willReturn(URL.valueOf("dubbo://" +
NetUtils.getLocalHost() + ":20880?" + Constants.APPLICATION_KEY + "=abc&" +
Constants.SIDE_KEY + "=" + Constants.CONSUMER_SIDE));
+
+monitorFilter.invoke(invoker, invocation);
+
+verify(mockMonitorFactory, never()).getMonitor(any(URL.class));
+}
+
@Test
public void testGenericFilter() throws Exception {
MonitorFilter monitorFilter = new MonitorFilter();
@@ -147,4 +167,17 @@ public void testGenericFilter() throws Exception {
Assert.assertEquals(invocation, lastInvocation);
}
+@Test
+public void testSafeFailForMonitorCollectFail() {
+MonitorFilter monitorFilter = new MonitorFilter();
+MonitorFactory mockMonitorFactory = mock(MonitorFactory.class);
+Monitor mockMonitor = mock(Monitor.class);
+Mockito.doThrow(new
RuntimeException()).when(mockMonitor).collect(any(URL.class));
+
+monitorFilter.setMonitorFactory(mockMonitorFactory);
+
given(mockMonitorFactory.getMonitor(any(URL.class))).willReturn(mockMonitor);
+Invocation invocation = new RpcInvocation("aaa", new Class[0], new
Object[0]);
+
+monitorFilter.invoke(serviceInvoker, invocation);
+}
}
diff --git
a/dubbo-monitor/dubbo-monitor-default/src/test/java/com/alibaba/dubbo/monitor/dubbo/DubboMonitorFactoryTest.java
b/dubbo-monitor/dubbo-monitor-default/src/test/java/com/alibaba/dubbo/monitor/dubbo/DubboMonitorFactoryTest.java
new file mode 100644
index 00..759a0d97eb
--- /dev/null
+++
b/dubbo-monitor/dubbo-monitor-default/src/test/java/com/alibaba/dubbo/monitor/dubbo/DubboMonitorFactoryTest.java
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by
[GitHub] beiwei30 closed issue #1254: Upgrade tomcat version to 8.5.x
beiwei30 closed issue #1254: Upgrade tomcat version to 8.5.x URL: https://github.com/apache/incubator-dubbo/issues/1254 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 opened a new pull request #1795: clean up: finish unit test for config-api
beiwei30 opened a new pull request #1795: clean up: finish unit test for config-api URL: https://github.com/apache/incubator-dubbo/pull/1795 ## What is the purpose of the change finish unit test for config-api module, remove useless classes and move class into right packages. ## Brief changelog ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test). - [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed pull request #1794: clean up work for config-api unit test
beiwei30 closed pull request #1794: clean up work for config-api unit test
URL: https://github.com/apache/incubator-dubbo/pull/1794
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractConfigTest.java
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractConfigTest.java
index 7cd83f0b28..5366b90910 100644
---
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractConfigTest.java
+++
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractConfigTest.java
@@ -18,6 +18,7 @@
import com.alibaba.dubbo.common.Constants;
import com.alibaba.dubbo.common.utils.ConfigUtils;
+import com.alibaba.dubbo.config.api.Greeting;
import com.alibaba.dubbo.config.support.Parameter;
import junit.framework.TestCase;
import org.junit.Test;
diff --git
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractInterfaceConfigTest.java
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractInterfaceConfigTest.java
index 94578b2cfd..f34c31ffbe 100644
---
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractInterfaceConfigTest.java
+++
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractInterfaceConfigTest.java
@@ -19,6 +19,12 @@
import com.alibaba.dubbo.common.Constants;
import com.alibaba.dubbo.common.URL;
import com.alibaba.dubbo.common.utils.ConfigUtils;
+import com.alibaba.dubbo.config.api.Greeting;
+import com.alibaba.dubbo.config.mock.GreetingLocal1;
+import com.alibaba.dubbo.config.mock.GreetingLocal2;
+import com.alibaba.dubbo.config.mock.GreetingLocal3;
+import com.alibaba.dubbo.config.mock.GreetingMock1;
+import com.alibaba.dubbo.config.mock.GreetingMock2;
import com.alibaba.dubbo.monitor.MonitorService;
import com.alibaba.dubbo.registry.RegistryService;
import junit.framework.TestCase;
diff --git
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ProtocolConfigTest.java
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ProtocolConfigTest.java
index 43f3621e28..c9d904622e 100644
---
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ProtocolConfigTest.java
+++
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ProtocolConfigTest.java
@@ -18,6 +18,7 @@
package com.alibaba.dubbo.config;
import com.alibaba.dubbo.common.extension.ExtensionLoader;
+import com.alibaba.dubbo.config.mock.MockProtocol2;
import com.alibaba.dubbo.rpc.Protocol;
import org.junit.Test;
import org.mockito.Mockito;
diff --git
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/RegistryConfigTest.java
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/RegistryConfigTest.java
new file mode 100644
index 00..1d9bbe2038
--- /dev/null
+++
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/RegistryConfigTest.java
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.alibaba.dubbo.config;
+
+import com.alibaba.dubbo.common.Constants;
+import org.junit.Test;
+
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.hamcrest.Matchers.equalTo;
+import static org.hamcrest.Matchers.hasEntry;
+import static org.hamcrest.Matchers.hasKey;
+import static org.hamcrest.Matchers.not;
+import static org.junit.Assert.assertThat;
+
+public class RegistryConfigTest {
+@Test
+public void testProtocol() throws Exception {
+RegistryConfig registry = new RegistryConfig();
+registry.setProtocol("protocol");
+assertThat(registry.getProtocol(), equalTo(registry.getProtocol()));
+}
+
+@Test
+public void testAddress() throws Exception {
+RegistryConfig registry = new RegistryConfig();
+
[GitHub] beiwei30 opened a new pull request #1794: clean up work for config-api unit test
beiwei30 opened a new pull request #1794: clean up work for config-api unit test URL: https://github.com/apache/incubator-dubbo/pull/1794 ## What is the purpose of the change cleanup work to finalize unit test in config-api module, including removing useless classes, move class into correct package ## Brief changelog ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test). - [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] mercyblitz closed issue #134: 一定要在service里面加这些东西? 不能设置默认值吗。。。
mercyblitz closed issue #134: 一定要在service里面加这些东西? 不能设置默认值吗。。。 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/134 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] mercyblitz commented on issue #134: 一定要在service里面加这些东西? 不能设置默认值吗。。。
mercyblitz commented on issue #134: 一定要在service里面加这些东西? 不能设置默认值吗。。。 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/134#issuecomment-388716553 @piglingcn It's optional attributes of `@Service` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] mercyblitz commented on issue #135: 刷星星哦
mercyblitz commented on issue #135: 刷星星哦 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/135#issuecomment-388716180 @XUZHOUWANG @suclogger 两位都是非常关心社区发展的小伙伴，实际上，我想请大家帮忙的原因也是提升社区的活跃度。里面并没有刷单式的利益输送，小伙伴之所以支持主要是因为大家相互帮助，我也在微信群里面答疑解惑，当然这也是交流的一部分。我希望大家共同关注在本工程的发展上，多提出建设性意见和建议，实现社区成长。不希望此等话题不断以及口舌之争，后续我将本 issue 关闭。 *如果本人之前的行为对您的生活有打扰，我在此想您道歉。* This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] mercyblitz commented on issue #135: 刷星星哦
mercyblitz commented on issue #135: 刷星星哦 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/135#issuecomment-388716180 @XUZHOUWANG @suclogger 两位都是非常关心社区发展的小伙伴，实际上，我想请大家帮忙的原因也是提升社区的活跃度。里面并没有刷单式的利益输送，小伙伴之所以支持主要是因为大家相互帮助，我也在微信群里面答疑解惑，当然这也是交流的一部分。我希望大家共同关注在本工程的发展上，多提出建设性意见和建议，实现社区成长。不希望此等话题不断以及口舌之争，后续我将本 issue 关闭。 **如果本人之前的行为对您的生活有打扰，我在此想您道歉。** This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] mercyblitz commented on issue #135: 刷星星哦
mercyblitz commented on issue #135: 刷星星哦 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/135#issuecomment-388716180 @XUZHOUWANG @suclogger 两位都是非常关心社区发展的小伙伴，实际上，我想请大家帮忙的原因也是提升社区的活跃度。里面并没有刷单式的利益输送，小伙伴之所以支持主要是因为大家相互帮助，我也在微信群里面答疑解惑，当然这也是交流的一部分。我希望大家共同关注在本工程的发展上，多提出建设性意见和建议，实现社区成长。不希望此等话题不断以及口舌之争，后续我将本 issue 关闭。 **如果本人之前的行为对您的生活有打扰，我在此向您道歉。** This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] mercyblitz closed issue #135: 刷星星哦
mercyblitz closed issue #135: 刷星星哦 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/135 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] JarVZhao opened a new issue #1793: will version 3.0 be developped here?
JarVZhao opened a new issue #1793: will version 3.0 be developped here? URL: https://github.com/apache/incubator-dubbo/issues/1793 i wonder if version 3.0 will be developped here or started in a new project This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] diecui1202 commented on issue #1347: [Dubbo-1330] Fix Support MetaspaceSize and MaxMetaspaceSize vm args in java8+
diecui1202 commented on issue #1347: [Dubbo-1330] Fix Support MetaspaceSize and
MaxMetaspaceSize vm args in java8+
URL: https://github.com/apache/incubator-dubbo/pull/1347#issuecomment-388711874
@web1992 your shell is not work on my mac os. you can use this way:
```
JAVA_VERSION=`$JAVA_HOME"/bin/java" -version 2>&1` || { echo
$JAVA_HOME"/bin/java -version failed"; exit 1; }
JAVA_VERSION_MAJOR=${JAVA_VERSION:16:1}
if [ "$JAVA_VERSION_MAJOR" -ge 8 ]; then
..
```
It works on mac and linux.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] codecov-io commented on issue #1792: zk Unsubscribe issue
codecov-io commented on issue #1792: zk Unsubscribe issue URL: https://github.com/apache/incubator-dubbo/pull/1792#issuecomment-388708105 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1792?src=pr=h1) Report > Merging [#1792](https://codecov.io/gh/apache/incubator-dubbo/pull/1792?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/203078981bb23517703e7bbb60925b8542bc8983?src=pr=desc) will **increase** coverage by `0.08%`. > The diff coverage is `33.33%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1792?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1792 +/- ## + Coverage 39.24% 39.32% +0.08% - Complexity 4197 4216 +19 Files 618 618 Lines 2974229747 +5 Branches 5257 5259 +2 + Hits 1167211699 +27 + Misses1621116185 -26 - Partials 1859 1863 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1792?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ba/dubbo/registry/zookeeper/ZookeeperRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1792/diff?src=pr=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktem9va2VlcGVyL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVnaXN0cnkvem9va2VlcGVyL1pvb2tlZXBlclJlZ2lzdHJ5LmphdmE=) | `65.98% <33.33%> (-1.62%)` | `31 <0> (+1)` | | | [...libaba/com/caucho/hessian/util/IdentityIntMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1792/diff?src=pr=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL3V0aWwvSWRlbnRpdHlJbnRNYXAuamF2YQ==) | `25% <0%> (-5.96%)` | `5% <0%> (-2%)` | | | [.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1792/diff?src=pr=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh) | `74.76% <0%> (-1.87%)` | `7% <0%> (ø)` | | | [.../alibaba/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1792/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `81.53% <0%> (+0.45%)` | `81% <0%> (+1%)` | :arrow_up: | | [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1792/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `55.69% <0%> (+3.79%)` | `13% <0%> (+2%)` | :arrow_up: | | [...n/java/com/alibaba/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1792/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZy5qYXZh) | `46.6% <0%> (+6.79%)` | `59% <0%> (+16%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1792?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1792?src=pr=footer). Last update [2030789...a5d3846](https://codecov.io/gh/apache/incubator-dubbo/pull/1792?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] chickenlj closed issue #906: JSON.json(Locale) throw StackOverflowError
chickenlj closed issue #906: JSON.json(Locale) throw StackOverflowError URL: https://github.com/apache/incubator-dubbo/issues/906 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] suclogger commented on issue #135: 刷星星哦
suclogger commented on issue #135: 刷星星哦 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/135#issuecomment-388706200 @XUZHOUWANG 推广技术，邀请大家关注和共同推动，这才是社区化的出发点和力量根源。 你完全不了解小马哥的工作和这个项目的意义就开一个无关的issue，你确定你了解这个社区？ 有幸观摩了你的博客，感觉你跟我一直以来了解到的有赞的技术氛围格格不入。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
