[GitHub] ralf0131 closed issue #220: 在使用dubbo-RMI提供服务给外部访问，同时应用依赖了common-collections，需要注意！
ralf0131 closed issue #220: 在使用dubbo-RMI提供服务给外部访问，同时应用依赖了common-collections，需要注意！ URL: https://github.com/apache/incubator-dubbo/issues/220 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #222: dubbo-admin java8
ralf0131 closed issue #222: dubbo-admin java8 URL: https://github.com/apache/incubator-dubbo/issues/222 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #222: dubbo-admin java8
ralf0131 commented on issue #222: dubbo-admin java8 URL: https://github.com/apache/incubator-dubbo/issues/222#issuecomment-389396465 The latest dubbo-admin supports Java 8, but does not support Java 9, because webx does not support Java 9. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #176: Provider 服务异常.
ralf0131 closed issue #176: Provider 服务异常. URL: https://github.com/apache/incubator-dubbo/issues/176 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #134: 支持memcached的示例能否提供一个？
ralf0131 commented on issue #134: 支持memcached的示例能否提供一个？ URL: https://github.com/apache/incubator-dubbo/issues/134#issuecomment-389395422 Please check the documentation: http://dubbo.apache.org/books/dubbo-user-book/references/protocol/memcached.html This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #135: dubbo-admin 如何配置zk集群呢？
ralf0131 closed issue #135: dubbo-admin 如何配置zk集群呢？ URL: https://github.com/apache/incubator-dubbo/issues/135 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #132: dubbo admin 用resin启动的问题
ralf0131 commented on issue #132: dubbo admin 用resin启动的问题 URL: https://github.com/apache/incubator-dubbo/issues/132#issuecomment-389395161 Please attach the full stack trace. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #135: dubbo-admin 如何配置zk集群呢？
ralf0131 commented on issue #135: dubbo-admin 如何配置zk集群呢？ URL: https://github.com/apache/incubator-dubbo/issues/135#issuecomment-389395280 It looks like it is a user configuration error. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #119: 请问提供方与消费方与注册中的问题
ralf0131 commented on issue #119: 请问提供方与消费方与注册中的问题 URL: https://github.com/apache/incubator-dubbo/issues/119#issuecomment-389394658 Yes, you can choose single registry, or you can choose multiple registries. It is up to you to decide. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] codecov-io commented on issue #1801: support generic invoke for http protocol #1768
codecov-io commented on issue #1801: support generic invoke for http protocol #1768 URL: https://github.com/apache/incubator-dubbo/pull/1801#issuecomment-389065493 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr=h1) Report > Merging [#1801](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/f78f6d4fa2e600ec212371d5afdf4124fbfd46f0?src=pr=desc) will **increase** coverage by `0.73%`. > The diff coverage is `58.82%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1801 +/- ## + Coverage 39.81% 40.54% +0.73% - Complexity 4327 4422 +95 Files 626 627 +1 Lines 3007830205 +127 Branches 5314 5343 +29 + Hits 1197512248 +273 + Misses1619016014 -176 - Partials 1913 1943 +30 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...baba/dubbo/rpc/protocol/AbstractProxyProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvcHJvdG9jb2wvQWJzdHJhY3RQcm94eVByb3RvY29sLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...om/alibaba/dubbo/rpc/filter/GenericImplFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0dlbmVyaWNJbXBsRmlsdGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../alibaba/dubbo/rpc/protocol/http/HttpProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1odHRwL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcnBjL3Byb3RvY29sL2h0dHAvSHR0cFByb3RvY29sLmphdmE=) | `64.28% <62.5%> (ø)` | `7 <2> (?)` | | | [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `83.33% <0%> (-5.56%)` | `6% <0%> (-1%)` | | | [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `51.89% <0%> (-3.8%)` | `11% <0%> (-2%)` | | | [...baba/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDbGllbnQuamF2YQ==) | `57.81% <0%> (-1.57%)` | `8% <0%> (-1%)` | | | [...aba/dubbo/common/compiler/support/JdkCompiler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2NvbXBpbGVyL3N1cHBvcnQvSmRrQ29tcGlsZXIuamF2YQ==) | `61.81% <0%> (ø)` | `2% <0%> (ø)` | :arrow_down: | | [...m/alibaba/com/caucho/hessian/io/Hessian2Input.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL2lvL0hlc3NpYW4ySW5wdXQuamF2YQ==) | `19.27% <0%> (+0.11%)` | `63% <0%> (ø)` | :arrow_down: | | [...on/src/main/java/com/alibaba/dubbo/common/URL.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL1VSTC5qYXZh) | `26.34% <0%> (+0.44%)` | `77% <0%> (+1%)` | :arrow_up: | | ... and [21 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr=footer). Last update [f78f6d4...6a5a354](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr=lastupdated). Read the [comment
[GitHub] zhaojigang commented on issue #1798: 自己改了源码，dubbo的代码里有对降级方式配置throw Exceptiond的支持。为何不对外开放呢
zhaojigang commented on issue #1798: 自己改了源码，dubbo的代码里有对降级方式配置throw Exceptiond的支持。为何不对外开放呢 URL: https://github.com/apache/incubator-dubbo/issues/1798#issuecomment-389162513 开放的呀，只是文档没写而已。我自己总结了一下：http://www.cnblogs.com/java-zhao/p/8320519.html，你可以看一下，没必要改源码 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] EdwardLee03 commented on issue #1742: Dubbo2..6.1报线程池已满错误
EdwardLee03 commented on issue #1742: Dubbo2..6.1报线程池已满错误 URL: https://github.com/apache/incubator-dubbo/issues/1742#issuecomment-386869200 @qq282485068 线程池满了，正常行为哦。看看服务提供方是否需要扩容，还是提供者处理慢引起 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] EdwardLee03 commented on issue #1742: Dubbo2..6.1报线程池已满错误
EdwardLee03 commented on issue #1742: Dubbo2..6.1报线程池已满错误 URL: https://github.com/apache/incubator-dubbo/issues/1742#issuecomment-389154679 @liangyuanpeng @lingfengsan 好尴尬，已删除评论，thx This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] EdwardLee03 commented on issue #1742: Dubbo2..6.1报线程池已满错误
EdwardLee03 commented on issue #1742: Dubbo2..6.1报线程池已满错误 URL: https://github.com/apache/incubator-dubbo/issues/1742#issuecomment-386869156 @qq282485068 服务器地址就别贴出来了（Server side(xxx.xxx.xxx.xxx,20888) ），建议改一下 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] EdwardLee03 commented on issue #1742: Dubbo2..6.1报线程池已满错误
EdwardLee03 commented on issue #1742: Dubbo2..6.1报线程池已满错误 URL: https://github.com/apache/incubator-dubbo/issues/1742#issuecomment-386869156 @qq282485068 服务器地址就别贴出来了（Server side(xxx.xxx.xxx.xxx,20888) ），建议改一下 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] wuwen5 commented on issue #118: 消费者端能支持node吗？
wuwen5 commented on issue #118: 消费者端能支持node吗？ URL: https://github.com/apache/incubator-dubbo/issues/118#issuecomment-94113064 jsonrpc https://github.com/apache/incubator-dubbo-rpc-jsonrpc node-client https://github.com/QianmiOpen/dubbo-node-client python-client https://github.com/dubbo/dubbo-client-py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed pull request #1804: issue#1682: Enhance the test coverage part-4 : dubbo-common/src/main/java/com/alibaba/dubbo/common/status(store|threadpoolutils) modules
beiwei30 closed pull request #1804: issue#1682: Enhance the test coverage
part-4 :
dubbo-common/src/main/java/com/alibaba/dubbo/common/status(store|threadpoolutils)
modules
URL: https://github.com/apache/incubator-dubbo/pull/1804
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/Assert.java
b/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/Assert.java
index 72a242f9bc..040c43d3bb 100644
--- a/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/Assert.java
+++ b/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/Assert.java
@@ -28,9 +28,9 @@ public static void notNull(Object obj, String message) {
}
}
-public static void notNull(Object obj, RuntimeException exeception) {
+public static void notNull(Object obj, RuntimeException exception) {
if (obj == null) {
-throw exeception;
+throw exception;
}
}
diff --git
a/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ClassHelper.java
b/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ClassHelper.java
index f6ac8d3bb1..ce9425639d 100644
--- a/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ClassHelper.java
+++ b/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ClassHelper.java
@@ -20,7 +20,6 @@
import java.util.Arrays;
import java.util.HashMap;
import java.util.HashSet;
-import java.util.Iterator;
import java.util.Map;
import java.util.Set;
@@ -57,12 +56,11 @@
Set primitiveTypeNames = new HashSet(16);
primitiveTypeNames.addAll(primitiveWrapperTypeMap.values());
-primitiveTypeNames.addAll(Arrays
-.asList(new Class[]{boolean[].class, byte[].class,
char[].class, double[].class,
-float[].class, int[].class, long[].class,
short[].class}));
-for (Iterator it = primitiveTypeNames.iterator();
it.hasNext(); ) {
-Class primitiveClass = (Class) it.next();
-primitiveTypeNameMap.put(primitiveClass.getName(), primitiveClass);
+primitiveTypeNames.addAll(Arrays.asList(
+boolean[].class, byte[].class, char[].class, double[].class,
float[].class, int[].class,
+long[].class, short[].class));
+for (Class primitiveTypeName : primitiveTypeNames) {
+primitiveTypeNameMap.put((primitiveTypeName).getName(),
primitiveTypeName);
}
}
@@ -193,7 +191,7 @@ public static ClassLoader getClassLoader() {
// SHOULD sit in a package, so a length check is worthwhile.
if (name != null && name.length() <= 8) {
// Could be a primitive - likely.
-result = (Class) primitiveTypeNameMap.get(name);
+result = primitiveTypeNameMap.get(name);
}
return result;
}
diff --git
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/cached/CachedThreadPoolTest.java
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/cached/CachedThreadPoolTest.java
index 63c7c93b74..083af0f263 100644
---
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/cached/CachedThreadPoolTest.java
+++
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/cached/CachedThreadPoolTest.java
@@ -66,7 +66,7 @@ public void run() {
}
});
-latch.await(5000, TimeUnit.MICROSECONDS);
+latch.await();
assertThat(latch.getCount(), is(0L));
}
diff --git
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/eager/EagerThreadPoolTest.java
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/eager/EagerThreadPoolTest.java
index a7f240896d..8d3e939601 100644
---
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/eager/EagerThreadPoolTest.java
+++
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/eager/EagerThreadPoolTest.java
@@ -67,7 +67,7 @@ public void run() {
}
});
-latch.await(5000, TimeUnit.MICROSECONDS);
+latch.await();
assertThat(latch.getCount(), is(0L));
}
diff --git
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/fixed/FixedThreadPoolTest.java
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/fixed/FixedThreadPoolTest.java
index faefe6f4d5..9d285f6511 100644
---
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/fixed/FixedThreadPoolTest.java
+++
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/fixed/FixedThreadPoolTest.java
@@ -67,7 +67,7 @@ public void run() {
[GitHub] beiwei30 opened a new pull request #1805: make unit test stable
beiwei30 opened a new pull request #1805: make unit test stable URL: https://github.com/apache/incubator-dubbo/pull/1805 ## What is the purpose of the change make thread-pool unit test stable ## Brief changelog ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test). - [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed pull request #1805: make unit test stable
beiwei30 closed pull request #1805: make unit test stable
URL: https://github.com/apache/incubator-dubbo/pull/1805
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/cached/CachedThreadPoolTest.java
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/cached/CachedThreadPoolTest.java
index 63c7c93b74..083af0f263 100644
---
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/cached/CachedThreadPoolTest.java
+++
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/cached/CachedThreadPoolTest.java
@@ -66,7 +66,7 @@ public void run() {
}
});
-latch.await(5000, TimeUnit.MICROSECONDS);
+latch.await();
assertThat(latch.getCount(), is(0L));
}
diff --git
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/eager/EagerThreadPoolTest.java
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/eager/EagerThreadPoolTest.java
index a7f240896d..8d3e939601 100644
---
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/eager/EagerThreadPoolTest.java
+++
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/eager/EagerThreadPoolTest.java
@@ -67,7 +67,7 @@ public void run() {
}
});
-latch.await(5000, TimeUnit.MICROSECONDS);
+latch.await();
assertThat(latch.getCount(), is(0L));
}
diff --git
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/fixed/FixedThreadPoolTest.java
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/fixed/FixedThreadPoolTest.java
index faefe6f4d5..9d285f6511 100644
---
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/fixed/FixedThreadPoolTest.java
+++
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/fixed/FixedThreadPoolTest.java
@@ -67,7 +67,7 @@ public void run() {
}
});
-latch.await(5000, TimeUnit.MICROSECONDS);
+latch.await();
assertThat(latch.getCount(), is(0L));
}
diff --git
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/limited/LimitedThreadPoolTest.java
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/limited/LimitedThreadPoolTest.java
index b99ce6c8cc..d58da069b4 100644
---
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/limited/LimitedThreadPoolTest.java
+++
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/limited/LimitedThreadPoolTest.java
@@ -65,7 +65,7 @@ public void run() {
}
});
-latch.await(5000, TimeUnit.MICROSECONDS);
+latch.await();
assertThat(latch.getCount(), is(0L));
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #123: linux 运行dubbo-provider-assembly 脚本启动出错
ralf0131 commented on issue #123: linux 运行dubbo-provider-assembly 脚本启动出错 URL: https://github.com/apache/incubator-dubbo/issues/123#issuecomment-389124696 Please check your machine's physical memory. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #123: linux 运行dubbo-provider-assembly 脚本启动出错
ralf0131 closed issue #123: linux 运行dubbo-provider-assembly 脚本启动出错 URL: https://github.com/apache/incubator-dubbo/issues/123 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #118: 消费者端能支持node吗？
ralf0131 commented on issue #118: 消费者端能支持node吗？ URL: https://github.com/apache/incubator-dubbo/issues/118#issuecomment-389124408 Please check this awesome project: https://github.com/dubbo/dubbo2.js This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #118: 消费者端能支持node吗？
ralf0131 closed issue #118: 消费者端能支持node吗？ URL: https://github.com/apache/incubator-dubbo/issues/118 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #72: dubbo-rpc-thrift 少了 commons-lang 的pom依赖
ralf0131 commented on issue #72: dubbo-rpc-thrift 少了 commons-lang 的pom依赖 URL: https://github.com/apache/incubator-dubbo/issues/72#issuecomment-389123724 It should be fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #72: dubbo-rpc-thrift 少了 commons-lang 的pom依赖
ralf0131 closed issue #72: dubbo-rpc-thrift 少了 commons-lang 的pom依赖 URL: https://github.com/apache/incubator-dubbo/issues/72 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #60: 有几个pom少依赖
ralf0131 commented on issue #60: 有几个pom少依赖 URL: https://github.com/apache/incubator-dubbo/issues/60#issuecomment-389123400 This is a legacy issue, which should be fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #60: 有几个pom少依赖
ralf0131 closed issue #60: 有几个pom少依赖 URL: https://github.com/apache/incubator-dubbo/issues/60 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #32: dubbo不支持json序列化
ralf0131 commented on issue #32: dubbo不支持json序列化 URL: https://github.com/apache/incubator-dubbo/issues/32#issuecomment-389122450 Dubbo now supports fastjson, please give it a try. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #32: dubbo不支持json序列化
ralf0131 closed issue #32: dubbo不支持json序列化 URL: https://github.com/apache/incubator-dubbo/issues/32 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1447: NettyHelper in netty extension populated Logger "InternalLogger" in netty.
ralf0131 commented on issue #1447: NettyHelper in netty extension populated Logger "InternalLogger" in netty. URL: https://github.com/apache/incubator-dubbo/issues/1447#issuecomment-389121798 @beiwei30 Can this issue be closed? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1492: 2.5.7 之后，dubbo增加了qos-server，然后打印日志出来的版本号是 2.0.1
ralf0131 commented on issue #1492: 2.5.7 之后，dubbo增加了qos-server，然后打印日志出来的版本号是 2.0.1 URL: https://github.com/apache/incubator-dubbo/issues/1492#issuecomment-389121211 Can you check whether it is duplicate of #1524 ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #1594: Does Dubbo currently support PHP?
ralf0131 closed issue #1594: Does Dubbo currently support PHP? URL: https://github.com/apache/incubator-dubbo/issues/1594 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #1609: incomplete: Fix hessian2 serialized short, byte is converted to int bug (#1232)
ralf0131 closed issue #1609: incomplete: Fix hessian2 serialized short, byte is converted to int bug (#1232) URL: https://github.com/apache/incubator-dubbo/issues/1609 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1624: [Design bug] unreasonable design for register dubbo service
ralf0131 commented on issue #1624: [Design bug] unreasonable design for register dubbo service URL: https://github.com/apache/incubator-dubbo/issues/1624#issuecomment-389118087 Hello, it looks like you have already fix this issue, would you mind send a pull request? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1625: typo in architecture graph
ralf0131 commented on issue #1625: typo in architecture graph URL: https://github.com/apache/incubator-dubbo/issues/1625#issuecomment-389117360 This issue has been tracked in https://github.com/apache/incubator-dubbo-docs/issues/24 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1638: [Codecov configuration] PR failing if test coverage went down
ralf0131 commented on issue #1638: [Codecov configuration] PR failing if test coverage went down URL: https://github.com/apache/incubator-dubbo/issues/1638#issuecomment-389113588 Done. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #1656: [Release] Sync 2.6.2-SNAPSHOT to master branch
ralf0131 closed issue #1656: [Release] Sync 2.6.2-SNAPSHOT to master branch URL: https://github.com/apache/incubator-dubbo/issues/1656 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1656: [Release] Sync 2.6.2-SNAPSHOT to master branch
ralf0131 commented on issue #1656: [Release] Sync 2.6.2-SNAPSHOT to master branch URL: https://github.com/apache/incubator-dubbo/issues/1656#issuecomment-389113364 Done. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1660: dubbo2.5.11 in your incubator-dubbo-spring-boot-project-0.2.0 miss
ralf0131 commented on issue #1660: dubbo2.5.11 in your incubator-dubbo-spring-boot-project-0.2.0 miss URL: https://github.com/apache/incubator-dubbo/issues/1660#issuecomment-389113198 Please try the latest version 2.6.1, if you still have the problem, please re-open this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #1660: dubbo2.5.11 in your incubator-dubbo-spring-boot-project-0.2.0 miss
ralf0131 closed issue #1660: dubbo2.5.11 in your incubator-dubbo-spring-boot-project-0.2.0 miss URL: https://github.com/apache/incubator-dubbo/issues/1660 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #1723: dubbo demo start failure
ralf0131 closed issue #1723: dubbo demo start failure URL: https://github.com/apache/incubator-dubbo/issues/1723 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1734: why dependency 'commons-lang3' is provided scope?
ralf0131 commented on issue #1734: why dependency 'commons-lang3' is provided
scope?
URL:
https://github.com/apache/incubator-dubbo/issues/1734#issuecomment-389111804
Where did you get the provided scope? In dependencies-bom/pom.xml:
```xml
org.apache.commons
commons-lang3
${commons_lang3_version}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 opened a new pull request #1804: issue#1682: Enhance the test coverage part-4 : dubbo-common/src/main/java/com/alibaba/dubbo/common/status(store|threadpoolutils) modules
beiwei30 opened a new pull request #1804: issue#1682: Enhance the test coverage part-4 : dubbo-common/src/main/java/com/alibaba/dubbo/common/status(store|threadpoolutils) modules URL: https://github.com/apache/incubator-dubbo/pull/1804 ## What is the purpose of the change issue#1682: Enhance the test coverage part-4 : dubbo-common/src/main/java/com/alibaba/dubbo/common/status(store|threadpoolutils) modules ## Brief changelog ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test). - [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1735: 采用zookeeper集群配置，把所有zookeeper都停掉以后为什么还能调用服务
ralf0131 commented on issue #1735: 采用zookeeper集群配置，把所有zookeeper都停掉以后为什么还能调用服务 URL: https://github.com/apache/incubator-dubbo/issues/1735#issuecomment-389110978 Thanks @feelwing1314 for the explanation. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1753: 升级到2.6.1版本后，是默认使用curator连接吗？
ralf0131 commented on issue #1753: 升级到2.6.1版本后，是默认使用curator连接吗？ URL: https://github.com/apache/incubator-dubbo/issues/1753#issuecomment-389110563 Are you still getting this error? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #1752: Why is the implementation-version in Dubbo 2.5.10 is 2.0.1?
ralf0131 closed issue #1752: Why is the implementation-version in Dubbo 2.5.10 is 2.0.1? URL: https://github.com/apache/incubator-dubbo/issues/1752 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1752: Why is the implementation-version in Dubbo 2.5.10 is 2.0.1?
ralf0131 commented on issue #1752: Why is the implementation-version in Dubbo 2.5.10 is 2.0.1? URL: https://github.com/apache/incubator-dubbo/issues/1752#issuecomment-389109898 duplicated to #1524 #1466 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] codecov-io commented on issue #1803: Fix bug in InternalThreadLocal and provides unit test
codecov-io commented on issue #1803: Fix bug in InternalThreadLocal and provides unit test URL: https://github.com/apache/incubator-dubbo/pull/1803#issuecomment-389107807 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1803?src=pr=h1) Report > Merging [#1803](https://codecov.io/gh/apache/incubator-dubbo/pull/1803?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/71366d6f284acdeafdf5c9dae52f21e8311c0cad?src=pr=desc) will **increase** coverage by `0.14%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1803?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1803 +/- ## + Coverage 40.01% 40.16% +0.14% - Complexity 4347 4364 +17 Files 626 626 Lines 3007830079 +1 Branches 5319 5319 + Hits 1203712082 +45 + Misses1612916077 -52 - Partials 1912 1920 +8 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1803?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../dubbo/common/threadlocal/InternalThreadLocal.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1803/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWwuamF2YQ==) | `70.58% <100%> (+34.76%)` | `16 <0> (+8)` | :arrow_up: | | [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1803/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `83.33% <0%> (-5.56%)` | `6% <0%> (-1%)` | | | [...baba/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1803/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDbGllbnQuamF2YQ==) | `59.37% <0%> (+1.56%)` | `9% <0%> (+1%)` | :arrow_up: | | [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1803/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `66.25% <0%> (+5%)` | `21% <0%> (+1%)` | :arrow_up: | | [...alibaba/dubbo/common/utils/NamedThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1803/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL05hbWVkVGhyZWFkRmFjdG9yeS5qYXZh) | `76.47% <0%> (+11.76%)` | `4% <0%> (+1%)` | :arrow_up: | | [...bbo/common/threadlocal/InternalThreadLocalMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1803/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWxNYXAuamF2YQ==) | `82.43% <0%> (+18.91%)` | `21% <0%> (+6%)` | :arrow_up: | | [...common/threadlocal/NamedInternalThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1803/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL05hbWVkSW50ZXJuYWxUaHJlYWRGYWN0b3J5LmphdmE=) | `80% <0%> (+20%)` | `3% <0%> (+1%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1803?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1803?src=pr=footer). Last update [71366d6...64bc20c](https://codecov.io/gh/apache/incubator-dubbo/pull/1803?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #27: Enable rest and serialization documentation
ralf0131 commented on issue #27: Enable rest and serialization documentation URL: https://github.com/apache/incubator-dubbo-docs/issues/27#issuecomment-389105705 Hi， I have added a `trunk/content/ip-clearance/dubbo-dubbox.xml` and update `trunk/content/ip-clearance/index.xml` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #11: dubbo.apache.org does not reflect the latest code
ralf0131 commented on issue #11: dubbo.apache.org does not reflect the latest code URL: https://github.com/apache/incubator-dubbo-website/issues/11#issuecomment-389103983 It has been fixed by manual sync via selfserve. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] carryxyh opened a new pull request #1803: Fix bug in InternalThreadLocal and provides unit test
carryxyh opened a new pull request #1803: Fix bug in InternalThreadLocal and provides unit test URL: https://github.com/apache/incubator-dubbo/pull/1803 - Fix bug in InternalThreadLocal which cause a execption in method removeAll - Provide unit test for InternalThreadLocal This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] codecov-io commented on issue #1802: Thread pool unit test
codecov-io commented on issue #1802: Thread pool unit test URL: https://github.com/apache/incubator-dubbo/pull/1802#issuecomment-389067591 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1802?src=pr=h1) Report > Merging [#1802](https://codecov.io/gh/apache/incubator-dubbo/pull/1802?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/f78f6d4fa2e600ec212371d5afdf4124fbfd46f0?src=pr=desc) will **increase** coverage by `0.18%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1802?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1802 +/- ## + Coverage 39.81% 39.99% +0.18% - Complexity 4327 4345 +18 Files 626 626 Lines 3007830078 Branches 5314 5319 +5 + Hits 1197512031 +56 + Misses1619016136 -54 + Partials 1913 1911 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1802?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1802/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `77.77% <0%> (-11.12%)` | `5% <0%> (-2%)` | | | [...aba/dubbo/common/compiler/support/JdkCompiler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1802/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2NvbXBpbGVyL3N1cHBvcnQvSmRrQ29tcGlsZXIuamF2YQ==) | `61.81% <0%> (ø)` | `2% <0%> (ø)` | :arrow_down: | | [...m/alibaba/com/caucho/hessian/io/Hessian2Input.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1802/diff?src=pr=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL2lvL0hlc3NpYW4ySW5wdXQuamF2YQ==) | `19.27% <0%> (+0.11%)` | `63% <0%> (ø)` | :arrow_down: | | [...on/src/main/java/com/alibaba/dubbo/common/URL.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1802/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL1VSTC5qYXZh) | `26.34% <0%> (+0.44%)` | `77% <0%> (+1%)` | :arrow_up: | | [.../dubbo/rpc/protocol/dubbo/DecodeableRpcResult.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1802/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9EZWNvZGVhYmxlUnBjUmVzdWx0LmphdmE=) | `59.09% <0%> (+2.27%)` | `8% <0%> (ø)` | :arrow_down: | | [...a/com/alibaba/dubbo/remoting/exchange/Request.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1802/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvZXhjaGFuZ2UvUmVxdWVzdC5qYXZh) | `85.71% <0%> (+2.38%)` | `20% <0%> (ø)` | :arrow_down: | | [...bo/rpc/protocol/dubbo/telnet/LogTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1802/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvTG9nVGVsbmV0SGFuZGxlci5qYXZh) | `71.42% <0%> (+2.85%)` | `3% <0%> (ø)` | :arrow_down: | | [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1802/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `66.25% <0%> (+8.75%)` | `21% <0%> (+2%)` | :arrow_up: | | [...mmon/threadpool/support/eager/EagerThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1802/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lYWdlci9FYWdlclRocmVhZFBvb2wuamF2YQ==) | `100% <0%> (+10%)` | `3% <0%> (+1%)` | :arrow_up: | | [...ibaba/dubbo/common/threadlocal/InternalThread.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1802/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkLmphdmE=) | `36.84% <0%> (+10.52%)` | `4% <0%> (+1%)` | :arrow_up: | | ... and [6 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1802/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1802?src=pr=continue). > **Legend** - [Click here
[GitHub] codecov-io commented on issue #1801: support generic invoke for http protocol #1768
codecov-io commented on issue #1801: support generic invoke for http protocol #1768 URL: https://github.com/apache/incubator-dubbo/pull/1801#issuecomment-389065493 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr=h1) Report > Merging [#1801](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/f78f6d4fa2e600ec212371d5afdf4124fbfd46f0?src=pr=desc) will **increase** coverage by `0.16%`. > The diff coverage is `62.5%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1801 +/- ## + Coverage 39.81% 39.97% +0.16% - Complexity 4327 4336 +9 Files 626 627 +1 Lines 3007830203 +125 Branches 5314 5343 +29 + Hits 1197512075 +100 - Misses1619016206 +16 - Partials 1913 1922 +9 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...om/alibaba/dubbo/rpc/filter/GenericImplFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0dlbmVyaWNJbXBsRmlsdGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../alibaba/dubbo/rpc/protocol/http/HttpProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1odHRwL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcnBjL3Byb3RvY29sL2h0dHAvSHR0cFByb3RvY29sLmphdmE=) | `64.8% <64.51%> (ø)` | `7 <2> (?)` | | | [...baba/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDbGllbnQuamF2YQ==) | `57.81% <0%> (-1.57%)` | `8% <0%> (-1%)` | | | [...aba/dubbo/common/compiler/support/JdkCompiler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2NvbXBpbGVyL3N1cHBvcnQvSmRrQ29tcGlsZXIuamF2YQ==) | `61.81% <0%> (ø)` | `2% <0%> (ø)` | :arrow_down: | | [...m/alibaba/com/caucho/hessian/io/Hessian2Input.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL2lvL0hlc3NpYW4ySW5wdXQuamF2YQ==) | `19.27% <0%> (+0.11%)` | `63% <0%> (ø)` | :arrow_down: | | [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==) | `54.68% <0%> (+1.56%)` | `3% <0%> (ø)` | :arrow_down: | | [.../dubbo/rpc/protocol/dubbo/DecodeableRpcResult.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9EZWNvZGVhYmxlUnBjUmVzdWx0LmphdmE=) | `59.09% <0%> (+2.27%)` | `8% <0%> (ø)` | :arrow_down: | | [...a/com/alibaba/dubbo/remoting/exchange/Request.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvZXhjaGFuZ2UvUmVxdWVzdC5qYXZh) | `85.71% <0%> (+2.38%)` | `20% <0%> (ø)` | :arrow_down: | | [...bo/rpc/protocol/dubbo/telnet/LogTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvTG9nVGVsbmV0SGFuZGxlci5qYXZh) | `71.42% <0%> (+2.85%)` | `3% <0%> (ø)` | :arrow_down: | | ... and [2 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr=footer). Last update
[GitHub] diecui1202 commented on issue #1799: 泛化调用返回结果解析不正
diecui1202 commented on issue #1799: 泛化调用返回结果解析不正 URL: https://github.com/apache/incubator-dubbo/issues/1799#issuecomment-389065577 Please use `gson.toJson()` for the result of generic invocation. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] lovepoem opened a new issue #1682: Enhance the test coverage part-4 : dubbo-common/src/main/java/com/alibaba/dubbo/common/status(store|threadpoolutils) modules
lovepoem opened a new issue #1682: Enhance the test coverage part-4 : dubbo-common/src/main/java/com/alibaba/dubbo/common/status(store|threadpoolutils) modules URL: https://github.com/apache/incubator-dubbo/issues/1682 Add unit test,modules: dubbo-common/src/main/java/com/alibaba/dubbo/common/status dubbo-common/src/main/java/com/alibaba/dubbo/common/store dubbo-common/src/main/java/com/alibaba/dubbo/common/threadpool dubbo-common/src/main/java/com/alibaba/dubbo/common/utils This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 opened a new pull request #1802: Thread pool unit test
beiwei30 opened a new pull request #1802: Thread pool unit test URL: https://github.com/apache/incubator-dubbo/pull/1802 ## What is the purpose of the change unit test for package com.alibaba.dubbo.common.threadpool ## Brief changelog ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test). - [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #11: dubbo.apache.org does not reflect the latest code
ralf0131 commented on issue #11: dubbo.apache.org does not reflect the latest code URL: https://github.com/apache/incubator-dubbo-website/issues/11#issuecomment-389056422 Filed an Infra ticket to track it: https://issues.apache.org/jira/browse/INFRA-16529 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 opened a new issue #11: dubbo.apache.org does not reflect the latest code
ralf0131 opened a new issue #11: dubbo.apache.org does not reflect the latest code URL: https://github.com/apache/incubator-dubbo-website/issues/11 When push the latest code to asf-site branch, dubbo.apache.org does not reflect the latest code. For example: We have changed the download link in [1], however, when visiting the website [2], it is not updated. [1] https://github.com/apache/incubator-dubbo-website/blob/asf-site/books/dubbo-admin-book-en/install/admin-console.html#L293 [2] http://dubbo.apache.org/books/dubbo-admin-book-en/install/admin-console.html This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed pull request #29: add DubboX doc #27
beiwei30 closed pull request #29: add DubboX doc #27
URL: https://github.com/apache/incubator-dubbo-docs/pull/29
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/dubbo-user-book/SUMMARY.md b/dubbo-user-book/SUMMARY.md
index c1eebd8..0cc3f96 100644
--- a/dubbo-user-book/SUMMARY.md
+++ b/dubbo-user-book/SUMMARY.md
@@ -57,6 +57,7 @@
* [6.42 分布式事务](./demos/distributed-transaction.md)
* [6.43 线程栈自动dump](./demos/dump.md)
* [6.44 Netty4](./demos/netty4.md)
+* [6.45 Kryo和FST序列化](./demos/serialization.md)
* [7 API 参考手册](./references/api.md)
* [8 schema 配置参考手册](./references/xml/introduction.md)
* [8.1 dubbo:service](./references/xml/dubbo-service.md)
@@ -80,6 +81,7 @@
* [9.6 thrift://](./references/protocol/thrift.md)
* [9.7 memcached://](./references/protocol/memcached.md)
* [9.8 redis://](./references/protocol/redis.md)
+* [9.9 rest://](./references/protocol/rest.md)
* [10 注册中心参考手册](./references/registry/introduction.md)
* [10.1 Multicast 注册中心](./references/registry/multicast.md)
* [10.2 Zookeeper 注册中心](./references/registry/zookeeper.md)
diff --git a/dubbo-user-book/demos/serialization.md
b/dubbo-user-book/demos/serialization.md
new file mode 100644
index 000..4722d21
--- /dev/null
+++ b/dubbo-user-book/demos/serialization.md
@@ -0,0 +1,80 @@
+# 在Dubbo中使用高效的Java序列化（Kryo和FST）
+
+
+## 启用Kryo和FST
+
+使用Kryo和FST非常简单，只需要在dubbo RPC的XML配置中添加一个属性即可：
+
+```xml
+
+```
+
+```xml
+
+```
+
+## 注册被序列化类
+
+要让Kryo和FST完全发挥出高性能，最好将那些需要被序列化的类注册到dubbo系统中，例如，我们可以实现如下回调接口：
+
+```java
+public class SerializationOptimizerImpl implements SerializationOptimizer {
+
+public Collection getSerializableClasses() {
+List classes = new LinkedList();
+classes.add(BidRequest.class);
+classes.add(BidResponse.class);
+classes.add(Device.class);
+classes.add(Geo.class);
+classes.add(Impression.class);
+classes.add(SeatBid.class);
+return classes;
+}
+}
+```
+
+然后在XML配置中添加：
+
+```xml
+
+```
+
+在注册这些类后，序列化的性能可能被大大提升，特别针对小数量的嵌套对象的时候。
+
+当然，在对一个类做序列化的时候，可能还级联引用到很多类，比如Java集合类。针对这种情况，我们已经自动将JDK中的常用类进行了注册，所以你不需要重复注册它们（当然你重复注册了也没有任何影响），包括：
+
+```
+GregorianCalendar
+InvocationHandler
+BigDecimal
+BigInteger
+Pattern
+BitSet
+URI
+UUID
+HashMap
+ArrayList
+LinkedList
+HashSet
+TreeSet
+Hashtable
+Date
+Calendar
+ConcurrentHashMap
+SimpleDateFormat
+Vector
+BitSet
+StringBuffer
+StringBuilder
+Object
+Object[]
+String[]
+byte[]
+char[]
+int[]
+float[]
+double[]
+```
+
+由于注册被序列化的类仅仅是出于性能优化的目的，所以即使你忘记注册某些类也没有关系。事实上，即使不注册任何类，Kryo和FST的性能依然普遍优于hessian和dubbo序列化。
+
diff --git a/dubbo-user-book/references/protocol/rest.md
b/dubbo-user-book/references/protocol/rest.md
new file mode 100644
index 000..c12bae5
--- /dev/null
+++ b/dubbo-user-book/references/protocol/rest.md
@@ -0,0 +1,741 @@
+# rest://
+
+基于标准的Java REST API——JAX-RS 2.0（Java API for RESTful Web Services的简写）实现的REST调用支持
+
+
+## 快速入门
+
+在dubbo中开发一个REST风格的服务会比较简单，下面以一个注册用户的简单服务为例说明。
+
+这个服务要实现的功能是提供如下URL（注：这个URL不是完全符合REST的风格，但是更简单实用）：
+
+```
+http://localhost:8080/users/register
+```
+
+而任何客户端都可以将包含用户信息的JSON字符串POST到以上URL来完成用户注册。
+
+首先，开发服务的接口：
+
+```java
+public class UserService {
+ void registerUser(User user);
+}
+```
+
+然后，开发服务的实现：
+
+```java
+@Path("users")
+public class UserServiceImpl implements UserService {
+
+@POST
+@Path("register")
+@Consumes({MediaType.APPLICATION_JSON})
+public void registerUser(User user) {
+// save the user...
+}
+}
+```
+上面的服务实现代码非常简单，但是由于REST服务是要被发布到特定HTTP
URL，供任意语言客户端甚至浏览器来访问，所以这里要额外添加了几个JAX-RS的标准annotation来做相关的配置：
+
+@Path("users")：指定访问UserService的URL相对路径是/users，即http://localhost:8080/users
+
+@Path("register")：指定访问registerUser()方法的URL相对路径是/register，再结合上一个@Path为UserService指定的路径，则调用UserService.register()的完整路径为http://localhost:8080/users/register
+
+@POST：指定访问registerUser()用HTTP POST方法
+
+@Consumes({MediaType.APPLICATION_JSON})：指定registerUser()接收JSON格式的数据。REST框架会自动将JSON数据反序列化为User对象
+
+最后，在spring配置文件中添加此服务，即完成所有服务开发工作：
+
+ ```xml
+
+
+
+
+
+
+
+
+```
+
+## REST服务提供端详解
+
+下面我们扩充“快速入门”中的UserService，进一步展示在dubbo中REST服务提供端的开发要点。
+
+### HTTP POST/GET的实现
+
+REST服务中虽然建议使用HTTP协议中四种标准方法POST、DELETE、PUT、GET来分别实现常见的“增删改查”，但实际中，我们一般情况直接用POST来实现“增改”，GET来实现“删查”即可（DELETE和PUT甚至会被一些防火墙阻挡）。
+
+前面已经简单演示了POST的实现，在此，我们为UserService添加一个获取注册用户资料的功能，来演示GET的实现。
+
+这个功能就是要实现客户端通过访问如下不同URL来获取不同ID的用户资料：
+
+```
+http://localhost:8080/users/1001
+http://localhost:8080/users/1002
+http://localhost:8080/users/1003
+```
+
+当然，也可以通过其他形式的URL来访问不同ID的用户资料，例如：
+
+```
+http://localhost:8080/users/load?id=1001
+```
+
+JAX-RS本身可以支持所有这些形式。但是上面那种在URL路径中包含查询参数的形式（http://localhost:8080/users/1001）
更符合REST的一般习惯，所以更推荐大家来使用。下面我们就为UserService添加一个getUser()方法来实现这种形式的URL访问：
+
+```java
+@GET
+@Path("{id : \\d+}")
[GitHub] nzomkxia opened a new pull request #29: add DubboX doc #27
nzomkxia opened a new pull request #29: add DubboX doc #27 URL: https://github.com/apache/incubator-dubbo-docs/pull/29 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] mahaixue opened a new issue #1800: 泛化调用-zookeeper实例化失败之后 没有重新实例化
mahaixue opened a new issue #1800: 泛化调用-zookeeper实例化失败之后 没有重新实例化 URL: https://github.com/apache/incubator-dubbo/issues/1800 泛化调用通过zookeeper调用。第一次调用的ZK不存在（实例失败），再换一个存在的ZK调用，没有重新实例导致调用不成功 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] mahaixue opened a new issue #1799: 泛化调用返回结果解析不正
mahaixue opened a new issue #1799: 泛化调用返回结果解析不正
URL: https://github.com/apache/incubator-dubbo/issues/1799
参照图1调用接口，返回格式正确，参照返回结果格式说明
通过泛化调用返回结果：[{class=org.json.JSONObject}, {class=org.json.JSONObject},
{class=org.json.JSONObject}]
由于dubbo测试现在做了个平台通过泛化调用来获取，这个BUG导致结果无法展示，求优先处理
返回结果格式：
[
{
"map": {
"lineUrl": "//bbs.wtoip.com/article/1517899684455020036.html",
"articleTitle": "20180206\u003d\u003d\u003d\u003d投票贴",
"articleCreateTime": 1517899685861,
"tagObj": "3D打印"
}
},
{
"map": {
"lineUrl": "//bbs.wtoip.com/article/1516959574329020005.html",
"articleTitle": "20180126\u003d\u003d\u003d\u003d\u003d",
"articleCreateTime": 1516959574329,
"tagObj": "影视动漫"
}
},
{
"map": {
"lineUrl": "//bbs.wtoip.com/article/1514865621766.html",
"articleTitle": "测试投票人数",
"articleCreateTime": 1514865622317,
"tagObj": "汇桔人"
}
}
]
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
