[GitHub] diecui1202 commented on issue #1860: 升级到2.6.1版本后,重复调用问题
diecui1202 commented on issue #1860: 升级到2.6.1版本后,重复调用问题 URL: https://github.com/apache/incubator-dubbo/issues/1860#issuecomment-393039237 I have checked source about 2.6.1, the default retries is ``` public static final int DEFAULT_RETRIES = 2; ``` and the real retries is ``` int len = getUrl().getMethodParameter(invocation.getMethodName(), Constants.RETRIES_KEY, Constants.DEFAULT_RETRIES) + 1; ``` It is 3. After set retries to 0 as follow: ``` ``` It doesn't retry. The result is what we want. So please check your configuration and try it again. Also, you can debug deeply. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] imlgw commented on issue #579: Failed to invoke the method xxxxx in the service xxxxx......
imlgw commented on issue #579: Failed to invoke the method x in the service x.. URL: https://github.com/apache/incubator-dubbo/issues/579#issuecomment-393016907 怎么解决？ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] lonre commented on issue #1675: Support protocol config for reference annotation
lonre commented on issue #1675: Support protocol config for reference annotation URL: https://github.com/apache/incubator-dubbo/pull/1675#issuecomment-393015837 @beiwei30 Hi, could you please check this pr? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] diecui1202 commented on issue #1860: 升级到2.6.1版本后,重复调用问题
diecui1202 commented on issue #1860: 升级到2.6.1版本后,重复调用问题 URL: https://github.com/apache/incubator-dubbo/issues/1860#issuecomment-393011910 Let me check it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] mengxiaofei007 commented on issue #1864: 生产者、消费者、注册中心不在同一个工程时，@reference调用远程接口无法识别
mengxiaofei007 commented on issue #1864: 生产者、消费者、注册中心不在同一个工程时，@reference调用远程接口无法识别 URL: https://github.com/apache/incubator-dubbo/issues/1864#issuecomment-393009285 @diecui1202 Thank you.I hava solved this problem.Thank you very much~ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] diecui1202 commented on issue #1861: the issue for setting loadbalancer.select (@SPI) completely extendable
diecui1202 commented on issue #1861: the issue for setting loadbalancer.select (@SPI) completely extendable URL: https://github.com/apache/incubator-dubbo/issues/1861#issuecomment-393009326 hi, it's a good way to send a PR for any enhancement or bugfix. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] mengxiaofei007 commented on issue #1864: 生产者、消费者、注册中心不在同一个工程时，@reference调用远程接口无法识别
mengxiaofei007 commented on issue #1864: 生产者、消费者、注册中心不在同一个工程时，@reference调用远程接口无法识别 URL: https://github.com/apache/incubator-dubbo/issues/1864#issuecomment-393009285 @diecui1202 Thank you.I hava solve this problem.Thank you very much~ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] mengxiaofei007 closed issue #1864: 生产者、消费者、注册中心不在同一个工程时，@reference调用远程接口无法识别
mengxiaofei007 closed issue #1864: 生产者、消费者、注册中心不在同一个工程时，@reference调用远程接口无法识别 URL: https://github.com/apache/incubator-dubbo/issues/1864 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] nzomkxia commented on issue #1860: 升级到2.6.1版本后,重复调用问题
nzomkxia commented on issue #1860: 升级到2.6.1版本后,重复调用问题 URL: https://github.com/apache/incubator-dubbo/issues/1860#issuecomment-393009022 can you provide a demo about this issue? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1863: 接口继承接口的实际意义是什么
ralf0131 commented on issue #1863: 接口继承接口的实际意义是什么 URL: https://github.com/apache/incubator-dubbo/issues/1863#issuecomment-393008833 This is not a issue related to Dubbo, please ask on the rocketmq community. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #1863: 接口继承接口的实际意义是什么
ralf0131 closed issue #1863: 接口继承接口的实际意义是什么 URL: https://github.com/apache/incubator-dubbo/issues/1863 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed pull request #1862: issue#1682: Enhance the test coverage part-4
beiwei30 closed pull request #1862: issue#1682: Enhance the test coverage part-4
URL: https://github.com/apache/incubator-dubbo/pull/1862
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/utils/DubboAppenderTest.java
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/utils/DubboAppenderTest.java
new file mode 100644
index 00..3abede3b91
--- /dev/null
+++
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/utils/DubboAppenderTest.java
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.alibaba.dubbo.common.utils;
+
+import com.alibaba.dubbo.common.utils.DubboAppender;
+import com.alibaba.dubbo.common.utils.Log;
+import org.apache.log4j.Category;
+import org.apache.log4j.Level;
+import org.apache.log4j.spi.LoggingEvent;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+import static org.hamcrest.Matchers.equalTo;
+import static org.hamcrest.Matchers.hasSize;
+import static org.hamcrest.Matchers.is;
+import static org.junit.Assert.assertThat;
+
+public class DubboAppenderTest {
+private LoggingEvent event;
+
+@Before
+public void setUp() throws Exception {
+Level level = Mockito.mock(Level.class);
+Category category = Mockito.mock(Category.class);
+event = Mockito.mock(LoggingEvent.class);
+Mockito.when(event.getLogger()).thenReturn(category);
+Mockito.when(event.getLevel()).thenReturn(level);
+Mockito.when(event.getThreadName()).thenReturn("thread-name");
+Mockito.when(event.getMessage()).thenReturn("message");
+}
+
+@After
+public void tearDown() throws Exception {
+DubboAppender.clear();
+DubboAppender.doStop();
+}
+
+@Test
+public void testAvailable() throws Exception {
+assertThat(DubboAppender.available, is(false));
+DubboAppender.doStart();
+assertThat(DubboAppender.available, is(true));
+DubboAppender.doStop();
+assertThat(DubboAppender.available, is(false));
+}
+
+@Test
+public void testAppend() throws Exception {
+DubboAppender appender = new DubboAppender();
+appender.append(event);
+assertThat(DubboAppender.logList, hasSize(0));
+DubboAppender.doStart();
+appender.append(event);
+assertThat(DubboAppender.logList, hasSize(1));
+Log log = DubboAppender.logList.get(0);
+assertThat(log.getLogThread(), equalTo("thread-name"));
+}
+
+@Test
+public void testClear() throws Exception {
+DubboAppender.doStart();
+DubboAppender appender = new DubboAppender();
+appender.append(event);
+assertThat(DubboAppender.logList, hasSize(1));
+DubboAppender.clear();
+assertThat(DubboAppender.logList, hasSize(0));
+}
+}
diff --git
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/utils/ExecutorUtilTest.java
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/utils/ExecutorUtilTest.java
new file mode 100644
index 00..4fc1984bf5
--- /dev/null
+++
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/utils/ExecutorUtilTest.java
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific languag
[GitHub] diecui1202 commented on issue #1864: 生产者、消费者、注册中心不在同一个工程时，@reference调用远程接口无法识别
diecui1202 commented on issue #1864: 生产者、消费者、注册中心不在同一个工程时，@reference调用远程接口无法识别 URL: https://github.com/apache/incubator-dubbo/issues/1864#issuecomment-393006702 Hi, you need to add the dependency which contains the class `Crm` to your consumer side project. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] zhaoyh001 commented on issue #148: Caused by: java.lang.ClassNotFoundException: javassist.ClassPool
zhaoyh001 commented on issue #148: Caused by: java.lang.ClassNotFoundException: javassist.ClassPool URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/148#issuecomment-393004771 All right now.Thank you This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] yythlj commented on issue #1864: 生产者、消费者、注册中心不在同一个工程时，@reference调用远程接口无法识别
yythlj commented on issue #1864: 生产者、消费者、注册中心不在同一个工程时，@reference调用远程接口无法识别 URL: https://github.com/apache/incubator-dubbo/issues/1864#issuecomment-392821340 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] mengxiaofei007 opened a new issue #1864: 生产者、消费者、注册中心不在同一个工程时，@reference调用远程接口无法识别
mengxiaofei007 opened a new issue #1864: 生产者、消费者、注册中心不在同一个工程时，@reference调用远程接口无法识别 URL: https://github.com/apache/incubator-dubbo/issues/1864   生产者可以正常发布 dubbo监控中心也可以看到生产者  就是在消费者引入远程生产者接口的时候本地不识别，编译不通过，请问这个问题该如何解决？如何让dubbo调用远程主机的接口服务呢？？能否讲解一下 翻了一下官网文档 没有发现相关解释~谢谢了~ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] zhaoyexing opened a new issue #1863: 接口继承接口的实际意义是什么
zhaoyexing opened a new issue #1863: 接口继承接口的实际意义是什么 URL: https://github.com/apache/incubator-dubbo/issues/1863    看了这段代码不是很懂，能不能解释一下呢？ 还有，如果想要顺序消费和并行消费一起的话，应该怎么写这个外层抽象类 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] codecov-io commented on issue #1862: issue#1682: Enhance the test coverage part-4
codecov-io commented on issue #1862: issue#1682: Enhance the test coverage part-4 URL: https://github.com/apache/incubator-dubbo/pull/1862#issuecomment-392757243 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1862?src=pr&el=h1) Report > Merging [#1862](https://codecov.io/gh/apache/incubator-dubbo/pull/1862?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/259c07228c9fe14285c7101e7e2d070acdbfa5ce?src=pr&el=desc) will **increase** coverage by `0.26%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1862?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#1862 +/- ## + Coverage 40.49% 40.75% +0.26% - Complexity 4419 4447 +28 Files 629 629 Lines 3014930149 Branches 5329 5329 + Hits 1220812288 +80 + Misses1601615926 -90 - Partials 1925 1935 +10 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1862?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1862/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `51.89% <0%> (-3.8%)` | `11% <0%> (-2%)` | | | [.../main/java/com/alibaba/dubbo/common/utils/Log.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1862/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL0xvZy5qYXZh) | `27.02% <0%> (+27.02%)` | `6% <0%> (+6%)` | :arrow_up: | | [...a/com/alibaba/dubbo/common/utils/ExecutorUtil.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1862/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL0V4ZWN1dG9yVXRpbC5qYXZh) | `53.44% <0%> (+53.44%)` | `9% <0%> (+9%)` | :arrow_up: | | [.../com/alibaba/dubbo/common/utils/DubboAppender.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1862/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL0R1YmJvQXBwZW5kZXIuamF2YQ==) | `100% <0%> (+55%)` | `8% <0%> (+3%)` | :arrow_up: | | [...n/java/com/alibaba/dubbo/common/utils/IOUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1862/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL0lPVXRpbHMuamF2YQ==) | `86.95% <0%> (+67.39%)` | `16% <0%> (+12%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1862?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1862?src=pr&el=footer). Last update [259c072...e482b25](https://codecov.io/gh/apache/incubator-dubbo/pull/1862?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 opened a new pull request #1862: issue#1682: Enhance the test coverage part-4
beiwei30 opened a new pull request #1862: issue#1682: Enhance the test coverage part-4 URL: https://github.com/apache/incubator-dubbo/pull/1862 ## What is the purpose of the change issue#1682: Enhance the test coverage part-4 ## Brief changelog modified: dubbo-common/src/test/java/com/alibaba/dubbo/common/utils/DubboAppenderTest.java modified: dubbo-common/src/test/java/com/alibaba/dubbo/common/utils/ExecutorUtilTest.java modified: dubbo-common/src/test/java/com/alibaba/dubbo/common/utils/HolderTest.java modified: dubbo-common/src/test/java/com/alibaba/dubbo/common/utils/IOUtilsTest.java modified: dubbo-common/src/test/java/com/alibaba/dubbo/common/utils/JVMUtilTest.java ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test). - [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] smallh0a1n1d0s commented on issue #1861: the issue for setting loadbalancer.select (@SPI) completely extendable
smallh0a1n1d0s commented on issue #1861: the issue for setting loadbalancer.select (@SPI) completely extendable URL: https://github.com/apache/incubator-dubbo/issues/1861#issuecomment-392740605 suggest that move the code in abstract or remove it before loadbalancer.select This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] smallh0a1n1d0s commented on issue #934: Extension of LoadBalance (a small suggestion for loadbalance policy when there's less than 2 providers)
smallh0a1n1d0s commented on issue #934: Extension of LoadBalance (a small suggestion for loadbalance policy when there's less than 2 providers) URL: https://github.com/apache/incubator-dubbo/issues/934#issuecomment-392732145 Assuming that the three normal services can maintain the business, notify the container platform to rebuild the service or notify the alarm platform when the payload encounters only one or no invoker alive This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] mengxiaofei007 commented on issue #145: 0.2.0自己编译会有问题，是不是没有兼容好2.6.2
mengxiaofei007 commented on issue #145: 0.2.0自己编译会有问题，是不是没有兼容好2.6.2 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/145#issuecomment-392727711 我也是 destroyAll方法被我删了 就通过了.. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] diecui1202 commented on issue #934: Extension of LoadBalance (a small suggestion for loadbalance policy when there's less than 2 providers)
diecui1202 commented on issue #934: Extension of LoadBalance (a small suggestion for loadbalance policy when there's less than 2 providers) URL: https://github.com/apache/incubator-dubbo/issues/934#issuecomment-392725800 Could you tell us the scenario that need to expand when only 1 invoker exists. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] smallh0a1n1d0s opened a new issue #1861: the issue for setting loadbalancer.select (@SPI) completely extendable
smallh0a1n1d0s opened a new issue #1861: the issue for setting loadbalancer.select (@SPI) completely extendable URL: https://github.com/apache/incubator-dubbo/issues/1861 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] smallh0a1n1d0s commented on issue #934: Extension of LoadBalance (a small suggestion for loadbalance policy when there's less than 2 providers)
smallh0a1n1d0s commented on issue #934: Extension of LoadBalance (a small suggestion for loadbalance policy when there's less than 2 providers) URL: https://github.com/apache/incubator-dubbo/issues/934#issuecomment-392722600 @diecui1202 @chickenlj Pretty Good,But the only one invoker exists ,and we also can't expand our intentions. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] codecov-io commented on issue #1859: [Dubbo-1693] Enhance the test coverage part-14
codecov-io commented on issue #1859: [Dubbo-1693] Enhance the test coverage part-14 URL: https://github.com/apache/incubator-dubbo/pull/1859#issuecomment-392721577 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1859?src=pr&el=h1) Report > Merging [#1859](https://codecov.io/gh/apache/incubator-dubbo/pull/1859?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/259c07228c9fe14285c7101e7e2d070acdbfa5ce?src=pr&el=desc) will **increase** coverage by `0.37%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1859?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#1859 +/- ## + Coverage 40.49% 40.86% +0.37% - Complexity 4419 4457 +38 Files 629 629 Lines 3014930149 Branches 5329 5329 + Hits 1220812321 +113 + Misses1601615898 -118 - Partials 1925 1930 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1859?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1859/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh) | `87.85% <0%> (-1.87%)` | `15% <0%> (ø)` | | | [...a/dubbo/remoting/transport/netty4/NettyClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1859/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9OZXR0eUNsaWVudC5qYXZh) | `64.4% <0%> (+13.55%)` | `11% <0%> (+5%)` | :arrow_up: | | [...ing/transport/netty4/NettyBackedChannelBuffer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1859/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9OZXR0eUJhY2tlZENoYW5uZWxCdWZmZXIuamF2YQ==) | `15.87% <0%> (+15.87%)` | `11% <0%> (+11%)` | :arrow_up: | | [...a/dubbo/remoting/transport/netty4/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1859/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9OZXR0eVNlcnZlci5qYXZh) | `75.4% <0%> (+26.22%)` | `10% <0%> (+4%)` | :arrow_up: | | [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1859/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9OZXR0eUNsaWVudEhhbmRsZXIuamF2YQ==) | `58.62% <0%> (+37.93%)` | `5% <0%> (+3%)` | :arrow_up: | | [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1859/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9OZXR0eVNlcnZlckhhbmRsZXIuamF2YQ==) | `72.22% <0%> (+38.88%)` | `6% <0%> (+3%)` | :arrow_up: | | [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1859/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9OZXR0eUNoYW5uZWwuamF2YQ==) | `65% <0%> (+40%)` | `22% <0%> (+12%)` | :arrow_up: | | [...o/remoting/transport/netty4/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1859/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9OZXR0eUNvZGVjQWRhcHRlci5qYXZh) | `73.52% <0%> (+41.17%)` | `3% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1859?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1859?src=pr&el=footer). Last update [259c072...a1380cc](https://codecov.io/gh/apache/incubator-dubbo/pull/1859?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request
[GitHub] LinHtao opened a new issue #1860: 升级到2.6.1版本后,重复调用问题
LinHtao opened a new issue #1860: 升级到2.6.1版本后,重复调用问题 URL: https://github.com/apache/incubator-dubbo/issues/1860 dubbo新版本的源码中,retries 默认为0,自己手动配置retries =0,也会出现接口重复调用 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] DeadLion opened a new pull request #1859: [Dubbo-1693] Enhance the test coverage part-14
DeadLion opened a new pull request #1859: [Dubbo-1693] Enhance the test coverage part-14 URL: https://github.com/apache/incubator-dubbo/pull/1859 ## add unit test [#1693](https://github.com/apache/incubator-dubbo/issues/1693) dubbo-remoting/dubbo-remoting-mina dubbo-remoting/dubbo-remoting-netty dubbo-remoting/dubbo-remoting-netty4 ## Brief changelog - add unit test for netty4 - modified some test code ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test). - [x] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [x] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] DeadLion closed pull request #1832: [Dubbo-1693] Enhance the test coverage part-14
DeadLion closed pull request #1832: [Dubbo-1693] Enhance the test coverage part-14 URL: https://github.com/apache/incubator-dubbo/pull/1832 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] kingyoungfan closed issue #31: 启动dubbo monitor报错
kingyoungfan closed issue #31: 启动dubbo monitor报错 URL: https://github.com/apache/incubator-dubbo-ops/issues/31 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] kingyoungfan commented on issue #32: monitor没有图表，没有services菜单。
kingyoungfan commented on issue #32: monitor没有图表，没有services菜单。 URL: https://github.com/apache/incubator-dubbo-ops/issues/32#issuecomment-392684531 @chickenlj This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] kingyoungfan opened a new issue #32: monitor没有图表，没有services菜单。
kingyoungfan opened a new issue #32: monitor没有图表，没有services菜单。 URL: https://github.com/apache/incubator-dubbo-ops/issues/32 @justinmclean https://user-images.githubusercontent.com/6263774/40644890-4225d87a-6357-11e8-83b8-2072d17b414c.png";> This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] diecui1202 commented on issue #150: 现在支持多协议或者多注册中心，在配置文件中配置吗
diecui1202 commented on issue #150: 现在支持多协议或者多注册中心，在配置文件中配置吗 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/150#issuecomment-392682205 Hi, please reference here for more information, Multiple protocol: http://dubbo.apache.org/books/dubbo-user-book/demos/multi-protocols.html Multiple registry: http://dubbo.apache.org/books/dubbo-user-book/demos/multi-registry.html This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] diecui1202 commented on issue #150: 现在支持多协议或者多注册中心，在配置文件中配置吗
diecui1202 commented on issue #150: 现在支持多协议或者多注册中心，在配置文件中配置吗 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/150#issuecomment-392682205 Hi, please reference here for more information, Multiple protocol: http://dubbo.apache.org/books/dubbo-user-book/demos/multi-protocols.html Multiple registry: http://dubbo.apache.org/books/dubbo-user-book/demos/multi-registry.html This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
