Re: [I] Graceful Shutdown [dubbo]
AlbumenJ closed issue #14022: Graceful Shutdown URL: https://github.com/apache/dubbo/issues/14022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] :memo: readme update [dubbo-spi-extensions]
AlbumenJ merged PR #304: URL: https://github.com/apache/dubbo-spi-extensions/pull/304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Feature] Move Mesh Rule Router to SPI Extensions [dubbo]
AlbumenJ commented on issue #13957: URL: https://github.com/apache/dubbo/issues/13957#issuecomment-2031194502 Just copy all the related code to `dubbo-spi-extensions` and then remove them in `apache/dubbo` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[I] [Bug] The triple protocol is called through http, and the return value is incorrect [dubbo]
crazyStar00 opened a new issue, #14023:
URL: https://github.com/apache/dubbo/issues/14023
### Pre-check
- [X] I am sure that all the content I provide is in English.
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/dubbo/issues?q=is%3Aissue) and found no
similar issues.
### Apache Dubbo Component
Java SDK (apache/dubbo)
### Dubbo Version
dubbo version：3.3.0-beta.1 jdk:1.8 platform：windows 10
### Steps to reproduce this issue
Start the service using the TriPojoServer class of the
dubco-samples-triple-no-IDl module and invoke the service using http
### What you expected to happen
I understand that you should return “hello star“,but return
"hello,{\"request\":\"star\"}"
### Anything else
_No response_
### Are you willing to submit a pull request to fix on your own?
- [X] Yes I am willing to submit a pull request on my own!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Feature][3.3] Enhance JsonCompatibilityUtil to support triple protocol [dubbo]
AlbumenJ commented on issue #13963:
URL: https://github.com/apache/dubbo/issues/13963#issuecomment-2031192922
> Before I start, I have some questions about this issue:
>
> * Check all the types that Dubbo can support: I guess the current
JsonCompatibilityUtil already has the functionality to check the compatibility
of classes. Is it the same usage as JsonCompatibilityUtil in RestProtocol, and
should we also use JsonCompatibilityUtil to do the same thing in TripleProtocol?
>
> ```java
> // this is the JsonCompatibilityUtil in RestProtocol
> private void checkJsonCompatibility(Class clazz, String jsonCheckLevel)
throws RpcException {
>
> if (jsonCheckLevel == null ||
JSON_CHECK_LEVEL_WARN.equals(jsonCheckLevel)) {
> //
> List unsupportedMethods =
JsonCompatibilityUtil.getUnsupportedMethods(clazz);
> } else if (JSON_CHECK_LEVEL_STRICT.equals(jsonCheckLevel)) {
> // ...
> }
> }
> ```
>
> * Generate the demo json struct: Does JsonCompatibilityUtil need to
generate corresponding sample JSON structures based on interface parameters
during the validation process?
- In TripleProtocol
- No. This is a explict feature. @oxsean Do you have any ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [dubbo]
AlbumenJ merged PR #14020: URL: https://github.com/apache/dubbo/pull/14020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Feature] Merge CommonConfigPostProcessor and ConfigPostProcessor [dubbo]
AlbumenJ commented on issue #13959: URL: https://github.com/apache/dubbo/issues/13959#issuecomment-2031187262 1. `CommonConfigPostProcessor` is in `3.3` branch 2. Because `dubbo-rpc-rest` is going to be moved to `dubbo-spi-extensions` in https://github.com/apache/dubbo/issues/13958, we can prevent the dependency loop -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[I] Graceful Shutdown [dubbo]
geekerzhou opened a new issue, #14022:
URL: https://github.com/apache/dubbo/issues/14022
### Pre-check
- [X] I am sure that all the content I provide is in English.
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/dubbo/issues?q=is%3Aissue) and found no
similar feature requirement.
### Apache Dubbo Component
Java SDK (apache/dubbo)
### Descriptions
2024-03-29 13:41:07.854 [DubboShutdownHook] INFO ,
o.a.dubbo.config.DubboShutdownHook - [DUBBO] Dubbo shutdown hooks execute now.
Dubbo Application[1.1](https://github.com/apache/dubbo-website/issues/cbs),
dubbo version: 3.2.9, current host: 10.10.1.33
2024-03-29 13:41:08.155
{"status":"UP","components":{"db":{"status":"UP","details":{"database":"PostgreSQL","validationQuery":"isValid()"}},"discoveryComposite":{"description":"Discovery
Client not
initialized","status":"UNKNOWN","components":{"discoveryClient":{"description":"Discovery
Client not
initialized","status":"UNKNOWN"}}},"diskSpace":{"status":"UP","details":{"total":250685575168,"free":15884992512,"threshold":10485760,"path":"","exists":true}},"dubbo":{"status":"UP","details":{"memory":{"source":"management.health.dubbo.status.defaults","status":{"level":"OK","message":"max:4096M,total:224M,used:188M,free:36M"}},"load":{"source":"management.health.dubbo.status.defaults","status":{"level":"OK","message":"load:2.67822265625,cpu:12"}},"registry":{"source":"management.health.dubbo.status.defaults","status":{"level":"OK","message":"10.0.2.251:8848(connected),10.0.2.251:8848(connected)"}},"spring":{"source":"management.health.dubbo.status.defaults","status":{"level":"OK","mes
sage":""}},"server":{"source":"management.health.dubbo.status.defaults","status":{"level":"OK","message":"/10.10.1.33:20880(clients:0)","nacosConfig":{"status":"UP"},"ping":{"status":"UP"},"redis":{"status":"UP","details":{"version":"6.0.9"}},"refreshScope":{"status":"UP"}}}
2024-03-29 13:41:12.098
{"status":"UP","components":{"db":{"status":"UP","details":{"database":"PostgreSQL","validationQuery":"isValid()"}},"discoveryComposite":{"description":"Discovery
Client not
initialized","status":"UNKNOWN","components":{"discoveryClient":{"description":"Discovery
Client not
initialized","status":"UNKNOWN"}}},"diskSpace":{"status":"UP","details":{"total":250685575168,"free":15878217728,"threshold":10485760,"path":"","exists":true}},"dubbo":{"status":"UNKNOWN","details":{"memory":{"source":"management.health.dubbo.status.defaults","status":{"level":"OK","message":"max:4096M,total:238M,used:155M,free:83M"}},"load":{"source":"management.health.dubbo.status.defaults","status":{"level":"OK","message":"load:2.67822265625,cpu:12"}},"registry":{"source":"management.health.dubbo.status.defaults","status":{"level":"OK","message":"10.0.2.251:8848(connected),10.0.2.251:8848(connected)"}},"spring":{"source":"management.health.dubbo.status.defaults","status":{"level":"OK"
,"message":""}},"server":{"source":"management.health.dubbo.status.defaults","status":{"level":"UNKNOWN","nacosConfig":{"status":"UP"},"ping":{"status":"UP"},"redis":{"status":"UP","details":{"version":"6.0.9"}},"refreshScope":{"status":"UP"}}}
Dubbo has been taken offline, but the actuator health check information
still shows Dubbo status as UP. It takes about 5 seconds for the server check
item to change to UNKNOWN, yet the overall healthcheck remains UP. Using Nginx
to request /actuator/health for determining whether to take the upstream
offline is not feasible anymore. Since Dubbo has been taken offline, if the
requested HTTP interface involves Dubbo-related logic, it throws an exception.
### Related issues
_No response_
### Are you willing to submit a pull request to fix on your own?
- [ ] Yes I am willing to submit a pull request on my own!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] refactor/dubbo-security grpc dependency replace [dubbo]
AlbumenJ merged PR #14004: URL: https://github.com/apache/dubbo/pull/14004 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Discussion] Under equivalent conditions, the performance of Dubbo 3 in terms of QPS (Queries Per Second) and RT (Response Time) is not as good as Dubbo 2 [dubbo]
AlbumenJ closed issue #14017: [Discussion] Under equivalent conditions, the performance of Dubbo 3 in terms of QPS (Queries Per Second) and RT (Response Time) is not as good as Dubbo 2 URL: https://github.com/apache/dubbo/issues/14017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] add native test quick start doc [dubbo-samples]
AlbumenJ merged PR #1122: URL: https://github.com/apache/dubbo-samples/pull/1122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
(dubbo-samples) branch master updated: add native test quick start (#1122)
This is an automated email from the ASF dual-hosted git repository.
albumenj pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git
The following commit(s) were added to refs/heads/master by this push:
new 305c77e36 add native test quick start (#1122)
305c77e36 is described below
commit 305c77e3681a687928f8a04e3f6fd532b21be1b6
Author: foghost
AuthorDate: Tue Apr 2 14:22:04 2024 +0800
add native test quick start (#1122)
---
test/README-NATIVE.md | 134 ++
test/README.md| 1 +
2 files changed, 135 insertions(+)
diff --git a/test/README-NATIVE.md b/test/README-NATIVE.md
new file mode 100644
index 0..3343e7a23
--- /dev/null
+++ b/test/README-NATIVE.md
@@ -0,0 +1,134 @@
+
+## Dubbo Native Integration Test Quick Start
+
+### Building Test Image
+
+```shell
+cd dubbo-samples
+./test/build-native-test-image.sh
+```
+
+For users in China, mirror acceleration can be utilized:
+
+```shell
+docker pull ghcr.m.daocloud.io/graalvm/native-image-community:17-ol7
+docker tag ghcr.m.daocloud.io/graalvm/native-image-community:17-ol7
ghcr.io/graalvm/native-image-community:17-ol7
+cd dubbo-samples
+./test/build-native-test-image.sh
+```
+
+### Running Test Cases
+
+The script `run-native-tests.sh` is used to execute a single test case, a list
of test cases, or all test cases.
+
+The script `kill-tests.sh` is used to forcefully terminate all test cases,
stop all dubbo containers, and all processes of run-native-tests.sh and
scenario.sh.
+
+Note: After interrupting the execution of run-native-tests.sh with Ctrl+C, the
kill-tests.sh script should be executed.
+
+ Running Methods
+
+* Running a Single Test Case
+
+ ``` shell
+ ./test/run-native-tests.sh
+ ```
+
+ For example, to run the dubbo-samples-native-image-registry test case:
+
+ ```shell
+ ./test/run-native-tests.sh 2-advanced/dubbo-samples-native-image-registry
+ ```
+
+* Running a Specified List of Test Cases
+
+ ```shell
+ TEST_CASE_FILE=testcases1.txt ./test/run-native-tests.sh
+ ```
+
+* Running All Test Cases
+
+ ```shell
+ ./test/run-native-tests.sh
+ ```
+
+The principle behind running all test cases with run-native-tests.sh:
+1. Search for all `native-case-configuration.yml` files.
+2. Fork multiple processes to run the test cases sequentially.
+
+### Adding Test Cases
+
+Ensure that the versions in case-versions.conf are correct:
`dubbo.version=3.3.*, spring.version=6.*, java.version= >= 17`.
+
+The test case configuration file should be named native-case-configuration.yml
and placed in the basedir of each project that requires testing.
+
+The basic usage should remain consistent with the
[quick-start](./quick-start_cn.md) guide,
+with details directly referable to the official documentation on [Support for
GraalVM Native
Image](https://cn.dubbo.apache.org/zh-cn/overview/mannual/java-sdk/advanced-features-and-usage/performance/support-graalvm/).
+
+Note:
+
+* The `native-case-configuration.yml` file should add config `timeout: 600`
because native testing requires packaging a native Image, which is
time-consuming. The default timeout may not be sufficient for the packaging
process, leading to premature timeouts.
+* Ensure that project dependencies meet the minimum version requirements. Use
the latest version of maven-compiler-plugin to prevent unnecessary issues, and
use the latest version of native-maven-plugin for better support. Refer to the
example in
2-advanced/dubbo-samples-native-image-registry/dubbo-samples-native-image-registry-provider
for version details.
+* For normal application main startup classes, the pom.xml must include a
profile named native, which will be used during the packaging and compilation
phase. Projects that require running unit tests should have a nativeTest
profile. Refer to the example in
2-advanced/dubbo-samples-native-image-registry/dubbo-samples-native-image-registry-consumer.
+* The matching rule for test classes (includes) is "*IT.java"，The default
matching rule is："**/*IT.class". In the native test scenario, this is activated
through the configuration of the test plugin.
+```xml
+
+org.apache.maven.plugins
+maven-surefire-plugin
+3.1.2
+
+
+${env.TEST_PATTERNS}
+
+
+
+```
+ Corresponding to the native-case-configuration.yml configuration is
+ ```yaml
+ dubbo-samples-native-image-registry-test:
+ type: nativeTest
+ basedir: dubbo-samples-native-image-registry-consumer
+ tests:
+ - "**/*IT.class" // Configure the matching rules of the test class,
this is also the default value
+ ```
+If the unit test runs incompletely you need to check these configurations
+
+* Examples that rely on zookeeper need to configure the zookeeper address in
the native-maven-plugin channel, otherwise the actual zookeeper address may not
be requested.
+
Re: [PR] add configcenter README [dubbo-spi-extensions]
AlbumenJ merged PR #299: URL: https://github.com/apache/dubbo-spi-extensions/pull/299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Enhance spring boot configuration metadata(port back from 3.3) [dubbo]
oxsean closed pull request #13981: Enhance spring boot configuration metadata(port back from 3.3) URL: https://github.com/apache/dubbo/pull/13981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] fix(3.2): triple AbstractServerCallListener NPE [dubbo]
AlbumenJ commented on PR #14009: URL: https://github.com/apache/dubbo/pull/14009#issuecomment-2031162836 @icodening @EarthChen PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Enhance spring boot configuration metadata(port back from 3.3) [dubbo]
AlbumenJ commented on PR #13981: URL: https://github.com/apache/dubbo/pull/13981#issuecomment-2031157550 We can enhance this feature in 3.3. In my opinion, we are no need to fix it in 3.2.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] Directly return the unFinished（注册启动成功但是consumer无法调用provider的方法） [dubbo]
CarsonYue commented on issue #9823: URL: https://github.com/apache/dubbo/issues/9823#issuecomment-2031121110 > 开了全局代理的缘故。。。 请问，具体是什么配置？如何解决的~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] Directly return the unFinished（注册启动成功但是consumer无法调用provider的方法） [dubbo]
CarsonYue commented on issue #9823: URL: https://github.com/apache/dubbo/issues/9823#issuecomment-2031105628 请问，具体是什么配置？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] feat:Remove zk3.4 support in 3.3 [dubbo]
Stellar1999 commented on PR #13970: URL: https://github.com/apache/dubbo/pull/13970#issuecomment-2031019450 After thinking and discussing, maybe removing the old ZooKeeper but not renaming `zookeeper-curator5` is a better choice to avoid new CI failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] :memo: readme update [dubbo-spi-extensions]
songxiaosheng opened a new pull request, #304: URL: https://github.com/apache/dubbo-spi-extensions/pull/304 ## What is the purpose of the change X ## Brief changelog X ## Verifying this change X Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Feature] Move Mesh Rule Router to SPI Extensions [dubbo]
heliang666s commented on issue #13957: URL: https://github.com/apache/dubbo/issues/13957#issuecomment-2029847253  hi,I don't know how to implement the interface,can you give some details or advice,thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Feature][3.3] Enhance JsonCompatibilityUtil to support triple protocol [dubbo]
hengyoush commented on issue #13963:
URL: https://github.com/apache/dubbo/issues/13963#issuecomment-2029684720
Before I start, I have some questions about this issue:
- Check all the types that Dubbo can support: I guess the current
JsonCompatibilityUtil already has the functionality to check the compatibility
of classes. Is it the same usage as JsonCompatibilityUtil in RestProtocol, and
should we also use JsonCompatibilityUtil to do the same thing in TripleProtocol?
```java
// this is the JsonCompatibilityUtil in RestProtocol
private void checkJsonCompatibility(Class clazz, String jsonCheckLevel)
throws RpcException {
if (jsonCheckLevel == null ||
JSON_CHECK_LEVEL_WARN.equals(jsonCheckLevel)) {
//
List unsupportedMethods =
JsonCompatibilityUtil.getUnsupportedMethods(clazz);
} else if (JSON_CHECK_LEVEL_STRICT.equals(jsonCheckLevel)) {
// ...
}
}
```
- Generate the demo json struct: Does JsonCompatibilityUtil need to generate
corresponding sample JSON structures based on interface parameters during the
validation process?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] client can't get attachments which is set from server [dubbo-go]
YarBor commented on issue #2641: URL: https://github.com/apache/dubbo-go/issues/2641#issuecomment-2029620433 > > Hi @Yan0613 I was working on this issue and don't think two people need to work on this. : )您好，我正在研究这个问题，并且认为不需要两个人来解决这个问题。 :) > > I have been discussing this with mentors for some time.我和导师讨论这个问题已经有一段时间了。 > > However, if you have a solution ready, please let me know. Thanks! 但是，如果您准备好解决方案，请告诉我。谢谢！ > > I see, but I think.that's no problem, I have also received this task😂明白了，不过我想，没问题，我也接到这个任务了😂 haha, But I think this appeal is reasonable and worth trying. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] client can't get attachments which is set from server [dubbo-go]
Yan0613 commented on issue #2641: URL: https://github.com/apache/dubbo-go/issues/2641#issuecomment-2029593640 > Hi @Yan0613 I was working on this issue and don't think two people need to work on this. : ) > I have been discussing this with mentors for some time. > However, if you have a solution ready, please let me know. Thanks! > I see, but I think.that's no problem, I have also received this task😂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] Bump version && fix test case failed [dubbo-spi-extensions]
aofall opened a new pull request, #303: URL: https://github.com/apache/dubbo-spi-extensions/pull/303 ## What is the purpose of the change 1. Use `revision` tags to manage versions uniformly. 2. Fix scenarios test case failed. 3. Added GitHub Actions workflow for automatic CI. 4. The `dubbo-gateway` extensions implements from `ByteAccessor`, this class since dubbo 3.2.0, but this branch(3.1.0) based on the dubbo 3.1.x, so removed this module. ## Brief changelog 1. adjust some `pom.xml` 2. Added GitHub Actions workflow 3. remove `dubbo-gateway` module ## Verifying this change X Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] docs [dubbo-js]
sonarcloud[bot] commented on PR #389: URL: https://github.com/apache/dubbo-js/pull/389#issuecomment-2029568787 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-js&pullRequest=389) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-js&pullRequest=389&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-js&pullRequest=389&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-js&pullRequest=389&resolved=false&inNewCodePeriod=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-js&pullRequest=389) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] docs [dubbo-js]
0808zhongshang opened a new pull request, #389: URL: https://github.com/apache/dubbo-js/pull/389 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Feature] Move Rest Protocol to SPI Extensions [dubbo]
wcy666103 commented on issue #13958: URL: https://github.com/apache/dubbo/issues/13958#issuecomment-2029526132 > @wcy666103 Hi, can you give me your email or other contact details, I would like to ask you some questions about this issue.thanks my DingTalk 1qn_sgsgvles4i -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Feature] Move Rest Protocol to SPI Extensions [dubbo]
wcy666103 commented on issue #13958: URL: https://github.com/apache/dubbo/issues/13958#issuecomment-2029526095 > @wcy666103 Hi, can you give me your email or other contact details, I would like to ask you some questions about this issue.thanks my DingTalk 1qn_sgsgvles4i -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Feature] Move Rest Protocol to SPI Extensions [dubbo]
chi3316 commented on issue #13958: URL: https://github.com/apache/dubbo/issues/13958#issuecomment-2029503849 @wcy666103 Hi, can you give me your email or other contact details, I would like to ask you some questions about this issue.thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Bump net.bytebuddy:byte-buddy from 1.14.12 to 1.14.13 [dubbo]
CrazyHZM merged PR #14018: URL: https://github.com/apache/dubbo/pull/14018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Bump org.apache.tomcat.embed:tomcat-embed-core from 8.5.99 to 8.5.100 [dubbo]
codecov-commenter commented on PR #14019: URL: https://github.com/apache/dubbo/pull/14019#issuecomment-2029419901 ## [Codecov](https://app.codecov.io/gh/apache/dubbo/pull/14019?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 70.44%. Comparing base [(`ec44304`)](https://app.codecov.io/gh/apache/dubbo/commit/ec443043e2da83d946943baabf7f122f9efc0dcc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`fd527f1`)](https://app.codecov.io/gh/apache/dubbo/pull/14019?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 1 commits behind head on 3.2. Additional details and impacted files ```diff @@Coverage Diff @@ ## 3.2 #14019 +/- ## == + Coverage 70.42% 70.44% +0.02% == Files1607 1607 Lines 7007570075 Branches1010010100 == + Hits4934749367 +20 + Misses 1608416070 -14 + Partials 4644 4638 -6 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo/pull/14019?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Bump org.apache.tomcat.embed:tomcat-embed-core from 8.5.99 to 8.5.100 [dubbo]
CrazyHZM merged PR #14019: URL: https://github.com/apache/dubbo/pull/14019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [dubbo]
codecov-commenter commented on PR #14020: URL: https://github.com/apache/dubbo/pull/14020#issuecomment-2029419110 ## [Codecov](https://app.codecov.io/gh/apache/dubbo/pull/14020?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 70.41%. Comparing base [(`ec44304`)](https://app.codecov.io/gh/apache/dubbo/commit/ec443043e2da83d946943baabf7f122f9efc0dcc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`e1ecad1`)](https://app.codecov.io/gh/apache/dubbo/pull/14020?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). Additional details and impacted files ```diff @@Coverage Diff @@ ## 3.2 #14020 +/- ## == - Coverage 70.42% 70.41% -0.01% == Files1607 1607 Lines 7007570075 Branches1010010100 == - Hits4934749343 -4 - Misses 1608416085 +1 - Partials 4644 4647 +3 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo/pull/14020?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Bump org.apache.tomcat.embed:tomcat-embed-core from 8.5.99 to 8.5.100 [dubbo]
sonarcloud[bot] commented on PR #14019: URL: https://github.com/apache/dubbo/pull/14019#issuecomment-2029413416 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14019) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14019&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14019&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14019&resolved=false&inNewCodePeriod=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14019) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [dubbo]
sonarcloud[bot] commented on PR #14020: URL: https://github.com/apache/dubbo/pull/14020#issuecomment-2029413390 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14020) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14020&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14020&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14020&resolved=false&inNewCodePeriod=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14020) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Bump net.bytebuddy:byte-buddy from 1.14.12 to 1.14.13 [dubbo]
codecov-commenter commented on PR #14018: URL: https://github.com/apache/dubbo/pull/14018#issuecomment-2029412759 ## [Codecov](https://app.codecov.io/gh/apache/dubbo/pull/14018?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 70.39%. Comparing base [(`ec44304`)](https://app.codecov.io/gh/apache/dubbo/commit/ec443043e2da83d946943baabf7f122f9efc0dcc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`977aabe`)](https://app.codecov.io/gh/apache/dubbo/pull/14018?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). Additional details and impacted files ```diff @@Coverage Diff @@ ## 3.2 #14018 +/- ## == - Coverage 70.42% 70.39% -0.03% == Files1607 1607 Lines 7007570075 Branches1010010100 == - Hits4934749332 -15 - Misses 1608416097 +13 - Partials 4644 4646 +2 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo/pull/14018?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Bump net.bytebuddy:byte-buddy from 1.14.12 to 1.14.13 [dubbo]
sonarcloud[bot] commented on PR #14018: URL: https://github.com/apache/dubbo/pull/14018#issuecomment-2029406792 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14018) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14018&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14018&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14018&resolved=false&inNewCodePeriod=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14018) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] dubbo 3.1.10 metadata error: No such extension org.apache.dubbo.common.serialize.Serialization by name protobuf [dubbo]
wxbty closed issue #12463: dubbo 3.1.10 metadata error: No such extension org.apache.dubbo.common.serialize.Serialization by name protobuf URL: https://github.com/apache/dubbo/issues/12463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] client can't get attachments which is set from server [dubbo-go]
YarBor commented on issue #2641: URL: https://github.com/apache/dubbo-go/issues/2641#issuecomment-2029368957 Hi @Yan0613 I was working on this issue and don't think two people need to work on this. : ) I have been discussing this with mentors for some time. However, if you have a solution ready, please let me know. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [dubbo]
dependabot[bot] opened a new pull request, #14020: URL: https://github.com/apache/dubbo/pull/14020 Bumps commons-io:commons-io from 2.15.1 to 2.16.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] Bump org.apache.tomcat.embed:tomcat-embed-core from 8.5.99 to 8.5.100 [dubbo]
dependabot[bot] opened a new pull request, #14019: URL: https://github.com/apache/dubbo/pull/14019 Bumps org.apache.tomcat.embed:tomcat-embed-core from 8.5.99 to 8.5.100. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] Bump net.bytebuddy:byte-buddy from 1.14.12 to 1.14.13 [dubbo]
dependabot[bot] opened a new pull request, #14018: URL: https://github.com/apache/dubbo/pull/14018 Bumps [net.bytebuddy:byte-buddy](https://github.com/raphw/byte-buddy) from 1.14.12 to 1.14.13. Release notes Sourced from https://github.com/raphw/byte-buddy/releases";>net.bytebuddy:byte-buddy's releases. Byte Buddy 1.14.13 Avoid resolving type variables when generic type processing is disabled. Improve error message for Byte Buddy agent external attach. Fix build for modular jars when using later version than Java 8. Commits https://github.com/raphw/byte-buddy/commit/93cee8f4b5f5be74e6026f322d622003d71c3558";>93cee8f [maven-release-plugin] prepare release byte-buddy-1.14.13 https://github.com/raphw/byte-buddy/commit/8236faebb45f08ecde6ea00bb201f1fd4a0fc419";>8236fae [release] Release new version https://github.com/raphw/byte-buddy/commit/5ce63525e4126369bf66f81c555f01feea2d5794";>5ce6352 Remove test that cannot run in context. https://github.com/raphw/byte-buddy/commit/53ce259455858e931b165851dbd82bf5942baf12";>53ce259 Legger inn type vitness. https://github.com/raphw/byte-buddy/commit/09dc1a9d65893107fc43ef2951b8b502eb946b04";>09dc1a9 Don't resolve parameterized types for RAW_TYPES mode (https://redirect.github.com/raphw/byte-buddy/issues/1604";>#1604) https://github.com/raphw/byte-buddy/commit/ddc76989a35bab0cee0bb51b8444bbf80d074445";>ddc7698 Improve error message. https://github.com/raphw/byte-buddy/commit/3b4ed21c97a960ddd8196cdd76c62810f9a6cfd2";>3b4ed21 Increment internal Byte Buddy. https://github.com/raphw/byte-buddy/commit/db916989d405341726be2981297fc257f0c669c0";>db91698 Bump org.apache.commons:commons-compress in /byte-buddy-maven-plugin (https://redirect.github.com/raphw/byte-buddy/issues/1597";>#1597) https://github.com/raphw/byte-buddy/commit/7841ebc8cd286a7240d7b1ac059be686e5e08673";>7841ebc Avoid broken modular jars when using the shade plugin where the jar tool is r... https://github.com/raphw/byte-buddy/commit/76987df2de9886e356eeacfd7b79d447d35405e6";>76987df Add main class. Additional commits viewable in https://github.com/raphw/byte-buddy/compare/byte-buddy-1.14.12...byte-buddy-1.14.13";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Feature] Move Rest Protocol to SPI Extensions [dubbo]
wcy666103 commented on issue #13958: URL: https://github.com/apache/dubbo/issues/13958#issuecomment-202900 hello,I am also interested in this issue and i wanna try to solve it .Could you please assign it to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Add corresponding tab(Form View Tab and YAML View Tab) for all routing modules under traffic control module. [dubbo-kubernetes]
jianyi-gronk commented on code in PR #246: URL: https://github.com/apache/dubbo-kubernetes/pull/246#discussion_r1546062170 ## ui-vue3/src/views/traffic/routingRule/index.vue: ## Review Comment: Are the changes to this code as expected? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] fix memory leak of tri protocol [dubbo]
sonarcloud[bot] commented on PR #13973: URL: https://github.com/apache/dubbo/pull/13973#issuecomment-2029280918 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13973) **Quality Gate passed** Issues  [1 New issue](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13973&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13973&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13973&resolved=false&inNewCodePeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13973&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13973&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13973) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
