Re: [I] triple request missed http header like scheme, host etc. [dubbo-go]

2024-04-02 Thread via GitHub


2456868764 commented on issue #2642:
URL: https://github.com/apache/dubbo-go/issues/2642#issuecomment-2033530141

   这个设置头部做法在 http2下有问题,一开始有个 method = PRI 协商协议,这个时候是不能设置头部,否则这个协商协议就挂了,对要兼容 
http2 / http1 协议不是很熟悉,对triple不是很熟悉,也尝试trick做法,写到 ctx里也是可以的,我现在也是 trick 做法只保留 
https会设置头,在 mtls filter检查没有这个这些头就认为是http协议,重新设置这些头。这个issuse 还是给社区来解决


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

2024-04-02 Thread via GitHub


sonarcloud[bot] commented on PR #13971:
URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2033505083

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13971) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13971&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13971&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13971&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [80.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13971&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13971&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13971)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[I] 请问支持服务注册发现、负载均衡等服务治理能力吗? [dubbo-js]

2024-04-02 Thread via GitHub


mrwangyin opened a new issue, #390:
URL: https://github.com/apache/dubbo-js/issues/390

   请问支持服务注册发现、负载均衡等服务治理能力吗?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Merge CommonConfigPostProcessor and ConfigPostProcessor [dubbo]

2024-04-02 Thread via GitHub


sonarcloud[bot] commented on PR #14027:
URL: https://github.com/apache/dubbo/pull/14027#issuecomment-2033294509

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14027) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14027&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14027&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14027&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14027&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14027&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14027)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[PR] Merge CommonConfigPostProcessor and ConfigPostProcessor [dubbo]

2024-04-02 Thread via GitHub


heliang666s opened a new pull request, #14027:
URL: https://github.com/apache/dubbo/pull/14027

   ## What is the purpose of the change
   Merge CommonConfigPostProcessor and ConfigPostProcessor 
   #13959 
   
   ## Brief changelog
   * delete  ConfigPostProcessor.java 
   * change related code in ReferenceConfig.java and ServiceConfig.java
   * by the way,when I compile the whole file,I find a dependency error in 
dubbo-spring-boot/dubbo-spring-boot-interceptor/pom.xml,I add it.
   ## Verifying this change
   Merge CommonConfigPostProcessor and ConfigPostProcessor 
   
   
   
   ## Checklist
   - [x] Make sure there is a 
[GitHub_issue](https://github.com/apache/dubbo/issues) field for the change 
(usually before you start working on it). Trivial changes like typos do not 
require a GitHub issue. Your pull request should address just this issue, 
without pulling in other changes - one PR resolves one issue.
   - [ ] Each commit in the pull request should have a meaningful subject line 
and body.
   - [ ] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
   - [ ] Write necessary unit-test to verify your logic correction, more mock a 
little better when cross module dependency exist. If the new feature or 
significant change is committed, please remember to add sample in [dubbo 
samples](https://github.com/apache/dubbo-samples) project.
   - [ ] Add some description to 
[dubbo-website](https://github.com/apache/dubbo-website) project if you are 
requesting to add a feature.
   - [ ] GitHub Actions works fine on your own branch.
   - [ ] If this contribution is large, please follow the [Software Donation 
Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Feat security [dubbo-go]

2024-04-02 Thread via GitHub


sonarcloud[bot] commented on PR #2643:
URL: https://github.com/apache/dubbo-go/pull/2643#issuecomment-2033046354

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2643) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [47 New 
issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2643&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2643&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2643&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.2% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2643&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2643)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Triple protocol http1 upgrade support [dubbo]

2024-04-02 Thread via GitHub


sonarcloud[bot] commented on PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2032608711

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14026) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [1 New 
issue](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14026&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14026&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14026&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14026&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14026&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14026)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [I] [Bug] The triple protocol is called through http, and the return value is incorrect [dubbo]

2024-04-02 Thread via GitHub


cnzakii commented on issue #14023:
URL: https://github.com/apache/dubbo/issues/14023#issuecomment-2032168181

   This is a misunderstanding caused by habitual thinking, perhaps because 
you're accustomed to data being passed in JSON format.
   ![2024-04-02_22 08 
27](https://github.com/apache/dubbo/assets/91261012/3c9df4d0-5108-46de-a8f8-187b832ff3a6)
   ![2024-04-02_22 09 
52](https://github.com/apache/dubbo/assets/91261012/60bc2a56-6284-4bc2-8e02-fa75d95ff196)
   
   The PojoGreeter interface definition explicitly specifies the parameter type 
as String. Therefore, the method receives a string as data. In the 
implementation class PojoGreeterImpl, the received parameter is simply 
concatenated. Hence, the response you obtained is completely correct.
   
   Below is the result obtained by calling the operation using the 
TriPojoClient from the provided sample, and the response matches yours exactly.
   
   ![2024-04-02_22 11 
06](https://github.com/apache/dubbo/assets/91261012/2c8fc004-3625-42aa-baa1-57878e130c07)
   ![2024-04-02_22 11 
45](https://github.com/apache/dubbo/assets/91261012/a2f3f9fa-2d9b-4120-9bd5-91791f0092df)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Dubbo-2.7.x版本,源码解读注释提交-----未看完 [dubbo]

2024-04-02 Thread via GitHub


MinMonk commented on PR #14025:
URL: https://github.com/apache/dubbo/pull/14025#issuecomment-2031934869

   同步最新的 2.7.x 版本的代码到当前分支


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Dubbo-2.7.x版本,源码解读注释提交-----未看完 [dubbo]

2024-04-02 Thread via GitHub


MinMonk closed pull request #14025: Dubbo-2.7.x版本,源码解读注释提交-未看完
URL: https://github.com/apache/dubbo/pull/14025


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[PR] Dubbo-2.7.x版本,源码解读注释提交-----未看完 [dubbo]

2024-04-02 Thread via GitHub


MinMonk opened a new pull request, #14025:
URL: https://github.com/apache/dubbo/pull/14025

   ## What is the purpose of the change
   
   
   
   ## Brief changelog
   
   
   ## Verifying this change
   
   
   
   
   ## Checklist
   - [x] Make sure there is a 
[GitHub_issue](https://github.com/apache/dubbo/issues) field for the change 
(usually before you start working on it). Trivial changes like typos do not 
require a GitHub issue. Your pull request should address just this issue, 
without pulling in other changes - one PR resolves one issue.
   - [ ] Each commit in the pull request should have a meaningful subject line 
and body.
   - [ ] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
   - [ ] Write necessary unit-test to verify your logic correction, more mock a 
little better when cross module dependency exist. If the new feature or 
significant change is committed, please remember to add sample in [dubbo 
samples](https://github.com/apache/dubbo-samples) project.
   - [ ] Add some description to 
[dubbo-website](https://github.com/apache/dubbo-website) project if you are 
requesting to add a feature.
   - [ ] GitHub Actions works fine on your own branch.
   - [ ] If this contribution is large, please follow the [Software Donation 
Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[I] Optimization registry extension [dubbo-rust]

2024-04-02 Thread via GitHub


onewe opened a new issue, #186:
URL: https://github.com/apache/dubbo-rust/issues/186

   - [ ] Optimization Nacos registry extension
   - [ ] Finish Zookeeper registry extension


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] For HTTP/1 unary mode, use Content-Length instead of chunk [dubbo]

2024-04-02 Thread via GitHub


sonarcloud[bot] commented on PR #13979:
URL: https://github.com/apache/dubbo/pull/13979#issuecomment-2031666705

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13979) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13979&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13979&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13979&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13979&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13979&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13979)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] For HTTP/1 unary mode, use Content-Length instead of chunk [dubbo]

2024-04-02 Thread via GitHub


sonarcloud[bot] commented on PR #13979:
URL: https://github.com/apache/dubbo/pull/13979#issuecomment-2031664927

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13979) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13979&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13979&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13979&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13979&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13979&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13979)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [I] [Task] Monitoring indicators support otel format indicator export [dubbo]

2024-04-02 Thread via GitHub


glmapper commented on issue #13902:
URL: https://github.com/apache/dubbo/issues/13902#issuecomment-2031609523

   I finished the initial coding and testing, here are my design ideas and some 
sample data, I hope to submit it to the community and then discuss it together!
   
   1. add new module dubbo-metrics/dubbo-metrics-otlp,the primary purpose is to 
introduce a dependency 
   ```xml
   
   io.micrometer
   micrometer-registry-otlp
 
   ```
   
   2. Same as the default and prometheus,  provide `OtlpMetricsReporter` and 
`OtlpMetricsReporterFactory` to support otlp protocol format data.
   3. there are no other change, but developer should be add 
dubbo.metrics.protocol=otlp to his config file.
   
   consumer site promethues protocol data:
   
   
[metrics-prometheus.json](https://github.com/apache/dubbo/files/14834969/metrics-prometheus.json)
   
   consumer site otlp protocol data:
   
[metrics-otlp.json](https://github.com/apache/dubbo/files/14834972/metrics-otlp.json)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Bump version && fix test case failed [dubbo-spi-extensions]

2024-04-02 Thread via GitHub


aofall commented on PR #303:
URL: 
https://github.com/apache/dubbo-spi-extensions/pull/303#issuecomment-2031600031

   @songxiaosheng PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] For HTTP/1 unary mode, use Content-Length instead of chunk [dubbo]

2024-04-02 Thread via GitHub


oxsean commented on PR #13979:
URL: https://github.com/apache/dubbo/pull/13979#issuecomment-2031590307

   @AlbumenJ LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[I] 有一个panic导致应用挂了 [dubbo-go]

2024-04-02 Thread via GitHub


alan2016llg opened a new issue, #2650:
URL: https://github.com/apache/dubbo-go/issues/2650

   ### Environment
   
   
   
   - Server: java-dubbo
   - Client: Dubbo-go, v3.1.1-rc
   - Protocol: dubbo
   - Registry: zk
   
   ### Issue description
   应用挂了,查询docker最后日志,有一个panic出现,日志如下
   
   
   ### Logs
   
   Click me to check logs
   
   ```
   2024-04-02 10:25:39 INFOgetty/listener.go:90session{session 
session-closed, Read Bytes: 21708, Write Bytes: 1248, Read Pkgs: 4, Write Pkgs: 
4} is closing..
   2024-04-02 10:25:39 INFOgetty/pool.go:221   after remove 
session{session session-closed, Read Bytes: 21708, Write Bytes: 1248, Read 
Pkgs: 4, Write Pkgs: 4}, left session number:0
   2024-04-02 10:25:39 WARNdubbo/dubbo_protocol.go:94  can't dial 
the server: 192.168.50.49:17624
   2024-04-02 10:25:39 WARNdubbo/dubbo_protocol.go:94  can't dial 
the server: 192.168.50.49:17624
   panic: runtime error: invalid memory address or nil pointer dereference
   [signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x166ded4]
   
   goroutine 132598 [running]:
   
dubbo.apache.org/dubbo-go/v3/metadata/service/local.(*MetadataServiceProxy).GetMetadataInfo(0xc0018c4320,
 {0xc0018f4460?, 0xc00049c0a0?})
   
/home/zmn/go/pkg/mod/dubbo.apache.org/dubbo-go/v3@v3.1.1-rc1/metadata/service/local/service_proxy.go:183
 +0x394
   
dubbo.apache.org/dubbo-go/v3/registry/servicediscovery.GetMetadataInfo({0xc001d47b90?,
 0x1e09060?}, {0x27803a0, 0xc00049c0a0}, {0xc0018f4460, 0x20})
   
/home/zmn/go/pkg/mod/dubbo.apache.org/dubbo-go/v3@v3.1.1-rc1/registry/servicediscovery/service_instances_changed_listener_impl.go:257
 +0x2a5
   
dubbo.apache.org/dubbo-go/v3/registry/servicediscovery.(*ServiceInstancesChangedListenerImpl).OnEvent(0xc001948100,
 {0x27671c0?, 0xc001211db0})
   
/home/zmn/go/pkg/mod/dubbo.apache.org/dubbo-go/v3@v3.1.1-rc1/registry/servicediscovery/service_instances_changed_listener_impl.go:125
 +0x8bf
   
dubbo.apache.org/dubbo-go/v3/registry/zookeeper.(*zookeeperServiceDiscovery).DataChange(0xc0004a39d0,
 {{0xc003e0b9c0, 0x38}, 0x0, {0xc0014ca700, 0x30b}})
   
/home/zmn/go/pkg/mod/dubbo.apache.org/dubbo-go/v3@v3.1.1-rc1/registry/zookeeper/service_discovery.go:282
 +0x303
   
dubbo.apache.org/dubbo-go/v3/remoting/zookeeper.(*ZkEventListener).listenDirEvent(0xc0024aae10,
 0x0, {0xc000484660, 0x24}, {0x27491c0, 0xc0004a39d0}, {0x0, 0x0})
   
/home/zmn/go/pkg/mod/dubbo.apache.org/dubbo-go/v3@v3.1.1-rc1/remoting/zookeeper/listener.go:406
 +0xb7a
   
dubbo.apache.org/dubbo-go/v3/remoting/zookeeper.(*ZkEventListener).ListenServiceEvent.func1({0xc000484660,
 0x24}, {0x27491c0?, 0xc0004a39d0?})
   
/home/zmn/go/pkg/mod/dubbo.apache.org/dubbo-go/v3@v3.1.1-rc1/remoting/zookeeper/listener.go:480
 +0xb1
   created by 
dubbo.apache.org/dubbo-go/v3/remoting/zookeeper.(*ZkEventListener).ListenServiceEvent
 in goroutine 132645
   
/home/zmn/go/pkg/mod/dubbo.apache.org/dubbo-go/v3@v3.1.1-rc1/remoting/zookeeper/listener.go:475
 +0x17c
   ```
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[PR] :memo: readme update [dubbo-spi-extensions]

2024-04-02 Thread via GitHub


songxiaosheng opened a new pull request, #305:
URL: https://github.com/apache/dubbo-spi-extensions/pull/305

   ## What is the purpose of the change
   
   X
   
   ## Brief changelog
   
   X
   
   ## Verifying this change
   
   X
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
   - [x] Make sure there is a 
[GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change 
(usually before
 you start working on it). Trivial changes like typos do not require a 
GITHUB issue. Your pull request should address
 just this issue, without pulling in other changes - one PR resolves one 
issue.
   - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException 
when host config not exist #XXX`. Each commit
 in the pull request should have a meaningful subject line and body.
   - [ ] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [ ] Write necessary unit-test to verify your logic correction, more mock a 
little better when cross module dependency
 exist. If the new feature or significant change is committed, please 
remember to add sample
 in [dubbo samples](https://github.com/apache/dubbo-samples) project.
   - [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile 
failsafe:integration-test` to make sure
 unit-test and integration-test pass.
   - [ ] If this contribution is large, please follow
 the [Software Donation 
Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

2024-04-02 Thread via GitHub


sonarcloud[bot] commented on PR #13971:
URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2031221667

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13971) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13971&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13971&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13971&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [80.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13971&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13971&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13971)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org