Re: [PR] [Proposal] dubbo benchmark [dubbo]
codecov-commenter commented on PR #14029: URL: https://github.com/apache/dubbo/pull/14029#issuecomment-2036248604 ## [Codecov](https://app.codecov.io/gh/apache/dubbo/pull/14029?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 70.42%. Comparing base [(`40280a2`)](https://app.codecov.io/gh/apache/dubbo/commit/40280a2c2968376e9b1e5bab89a597f01fb3de7f?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`ad4a3a4`)](https://app.codecov.io/gh/apache/dubbo/pull/14029?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > :exclamation: Current head ad4a3a4 differs from pull request most recent head 4c6ab45. Consider uploading reports for the commit 4c6ab45 to get more accurate results Additional details and impacted files ```diff @@Coverage Diff @@ ## 3.2 #14029 +/- ## == + Coverage 70.39% 70.42% +0.02% == Files1607 1607 Lines 7007570075 Branches1010010100 == + Hits4933149351 +20 + Misses 1609816077 -21 - Partials 4646 4647 +1 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo/pull/14029?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] [Proposal] dubbo benchmark [dubbo]
sonarcloud[bot] commented on PR #14029: URL: https://github.com/apache/dubbo/pull/14029#issuecomment-2036242960 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=14029) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=14029=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=14029=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=14029=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=14029) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] [Proposal] dubbo benchmark [dubbo]
icodening opened a new pull request, #14029: URL: https://github.com/apache/dubbo/pull/14029 ## What is the purpose of the change [Proposal] dubbo benchmark ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Feat security [dubbo-go]
github-advanced-security[bot] commented on code in PR #2643:
URL: https://github.com/apache/dubbo-go/pull/2643#discussion_r1550860371
##
tls/xds/xds_provider.go:
##
@@ -0,0 +1,256 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package xds
+
+import (
+ "crypto/tls"
+ "crypto/x509"
+ "fmt"
+ "sync"
+
+ "dubbo.apache.org/dubbo-go/v3/common"
+ "dubbo.apache.org/dubbo-go/v3/common/constant"
+ "dubbo.apache.org/dubbo-go/v3/common/extension"
+ "dubbo.apache.org/dubbo-go/v3/istio"
+ "dubbo.apache.org/dubbo-go/v3/istio/resources"
+ tlsprovider "dubbo.apache.org/dubbo-go/v3/tls"
+ "github.com/dubbogo/gost/log/logger"
+)
+
+var (
+ oncesync.Once
+ tlsProvider *xdsTLSProvider
+)
+
+func init() {
+ extension.SetTLSProvider(constant.TLSProviderXdsKey, newXdsTLSProvider)
+}
+
+type xdsTLSProvider struct {
+ pilotAgent istio.XdsAgent
+}
+
+func newXdsTLSProvider() tlsprovider.TLSProvider {
+ if tlsProvider == nil {
+ once.Do(func() {
+ logger.Infof("[xds tls] init pilot agent")
+ pilotAgent, err :=
istio.GetPilotAgent(istio.PilotAgentTypeServerWorkload)
+ if err != nil {
+ logger.Errorf("[xds tls] init pilot agent
err:%", err)
+ }
+ tlsProvider = {
+ pilotAgent: pilotAgent,
+ }
+ })
+ }
+ return tlsProvider
+}
+
+func (x *xdsTLSProvider) GetServerWorkLoadTLSConfig(url *common.URL)
(*tls.Config, error) {
+ cfg := {
+ GetCertificate: x.GetServerWorkloadCertificate,
+ ClientAuth: tls.VerifyClientCertIfGiven, // for test only
+ //ClientAuth: tls.RequireAndVerifyClientCert, // for
prod
+ ClientCAs: x.GetCACertPool(),
+ VerifyPeerCertificate: func(rawCerts [][]byte, verifiedChains
[][]*x509.Certificate) error {
+ err := x.VerifyPeerCertByServer(rawCerts,
verifiedChains)
+ if err != nil {
+ logger.Errorf("Could not verify client
certificate: %v", err)
+ }
+ return err
+ },
+ MinVersion: tls.VersionTLS12,
+ CipherSuites: tlsprovider.PreferredDefaultCipherSuites(),
+ NextProtos: []string{"h2", "http/1.1"},
+ }
+
+ return cfg, nil
+}
+
+func (x *xdsTLSProvider) VerifyPeerCertByServer(rawCerts [][]byte,
verifiedChains [][]*x509.Certificate) error {
+ logger.Infof("[xds tls] server verifiy peer cert")
+ if len(rawCerts) == 0 {
+ // Peer doesn't present a certificate. Just skip. Other authn
methods may be used.
+ return nil
+ }
+ var peerCert *x509.Certificate
+ intCertPool := x509.NewCertPool()
+ for id, rawCert := range rawCerts {
+ cert, err := x509.ParseCertificate(rawCert)
+ if err != nil {
+ return err
+ }
+ if id == 0 {
+ peerCert = cert
+ } else {
+ intCertPool.AddCert(cert)
+ }
+ }
+ if len(peerCert.URIs) != 1 {
+ logger.Errorf("[xds tls] peer certificate does not contain 1
URI type SAN, detected %d", len(peerCert.URIs))
+ return fmt.Errorf("peer certificate does not contain 1 URI type
SAN, detected %d", len(peerCert.URIs))
+ }
+ spiffe := peerCert.URIs[0].String()
+ _, err := resources.ParseIdentity(spiffe)
+ if err != nil {
+ logger.Errorf("[xds tls] can not ParseIdentity %s, error :%v",
spiffe, err)
+ return err
+ }
+ secretCache := x.pilotAgent.GetWorkloadCertificateProvider()
+ hostInboundListener := x.pilotAgent.GetHostInboundListener()
+ if hostInboundListener == nil {
+ return fmt.Errorf("can not get xds inbound listner info")
+ }
+
+ spiffeMatch :=
Re: [PR] Feat security [dubbo-go]
sonarcloud[bot] commented on PR #2643: URL: https://github.com/apache/dubbo-go/pull/2643#issuecomment-2036137924 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go=2643) **Quality Gate passed** Issues  [48 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go=2643=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go=2643=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go=2643=false=true)  No data about Coverage  [0.1% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go=2643=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go=2643) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] feat:remove old zookeeper [dubbo]
sonarcloud[bot] commented on PR #14028: URL: https://github.com/apache/dubbo/pull/14028#issuecomment-2035949590 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=14028) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=14028=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=14028=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=14028=false=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14028=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14028=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=14028) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] feat:remove old zookeeper [dubbo]
Stellar1999 commented on PR #14028: URL: https://github.com/apache/dubbo/pull/14028#issuecomment-2035890276 Should the first CI test fix be merged, then rerun the test case for this PR. In my own repository, it has already passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] feat:Remove zk3.4 support in 3.3 [dubbo]
Stellar1999 commented on PR #13970: URL: https://github.com/apache/dubbo/pull/13970#issuecomment-203530 new PR:refer: [#14028](https://github.com/apache/dubbo/pull/14028) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] feat:Remove zk3.4 support in 3.3 [dubbo]
Stellar1999 closed pull request #13970: feat:Remove zk3.4 support in 3.3 URL: https://github.com/apache/dubbo/pull/13970 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] feat:remove old zookeeper (#13960) [dubbo]
Stellar1999 opened a new pull request, #14028: URL: https://github.com/apache/dubbo/pull/14028 ## What is the purpose of the change refer:[#13960](https://github.com/apache/dubbo/issues/13960) ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] feat:update all old zookeeper version -> curator5 [dubbo-samples]
Stellar1999 opened a new pull request, #1124: URL: https://github.com/apache/dubbo-samples/pull/1124 refer: [#13970](https://github.com/apache/dubbo/pull/13970) This is a part of PR **feat:Remove zk3.4 support in 3.3** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] update curator version,remove old zk [dubbo-integration-cases]
Stellar1999 opened a new pull request, #20: URL: https://github.com/apache/dubbo-integration-cases/pull/20 refer: [https://github.com/apache/dubbo/pull/13970](#13970) This is a part of PR **feat:Remove zk3.4 support in 3.3** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] chore(deps-dev): bump vite from 5.0.12 to 5.0.13 in /ui-vue3 [dubbo-kubernetes]
dependabot[bot] opened a new pull request, #248: URL: https://github.com/apache/dubbo-kubernetes/pull/248 Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.0.12 to 5.0.13. Changelog Sourced from https://github.com/vitejs/vite/blob/v5.0.13/packages/vite/CHANGELOG.md;>vite's changelog. 5.0.13 (2024-03-24) fix: fs.deny with globs with directories (https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/16250;>#16250) (https://github.com/vitejs/vite/commit/d2db33f;>d2db33f), closes https://redirect.github.com/vitejs/vite/issues/16250;>#16250 Commits https://github.com/vitejs/vite/commit/80b1b07915295a32a7251df543509f8f667c5771;>80b1b07 release: v5.0.13 https://github.com/vitejs/vite/commit/d2db33f7d4b96750b35370c70dd2c35ec3b9b649;>d2db33f fix: fs.deny with globs with directories (https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/16250;>#16250) See full diff in https://github.com/vitejs/vite/commits/v5.0.13/packages/vite;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/dubbo-kubernetes/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[I] `client.WithClientCheck()` should set `check` to false instead of true. [dubbo-go]
chickenlj opened a new issue, #2652: URL: https://github.com/apache/dubbo-go/issues/2652 The default value of `check` is true, so `client.WithClientCheck()` should set `check` to false instead of true. ```go cli, err := client.NewClient( client.WithClientCheck(), } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] fix bug [dubbo-kubernetes]
sjmshsh opened a new pull request, #247: URL: https://github.com/apache/dubbo-kubernetes/pull/247 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## CheckList - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo-kubernetes/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] triple request missed http header like scheme, host etc. [dubbo-go]
2456868764 commented on issue #2642:
URL: https://github.com/apache/dubbo-go/issues/2642#issuecomment-2034811336
我现在做法：
dubbo-go/protocol/triple/triple_protocol/server.go 启动两个端口，一个http, 一个 HTTPS
代码如下 ：
```
func (s *Server) Run() error {
// todo(DMwangnima): deal with TLS
// Check if both listeners are nil
// todo http and https port can be different based on mutual tls mode
and tls config provider existed or not
httpAddr := s.addr
httpsAddr := s.getHTTPSAddress(s.addr)
httpOn := true
httpsOn := false
if s.tlsConfigProvider != nil {
httpsOn = true
}
handler := h2c.NewHandler(s.mux, {})
setHTTPHeaders := func(h http.Handler) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r
*http.Request) {
headers := make(map[string]interface{}, 0)
headers[constant.HttpHeaderXSchemeName] = "http"
headers[constant.HttpHeaderXHostName] = r.Host
headers[constant.HttpHeaderXPathName] = r.RequestURI
headers[constant.HttpHeaderXMethodName] = "POST"
ctx := context.WithValue(r.Context(),
constant.AttachmentKey, headers)
request := r.WithContext(ctx)
h.ServeHTTP(w, request)
})
}
setHTTPSHeaders := func(h http.Handler) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r
*http.Request) {
headers := make(map[string]interface{}, 0)
headers[constant.HttpHeaderXSchemeName] = "https"
headers[constant.HttpHeaderXHostName] = r.Host
headers[constant.HttpHeaderXPathName] = r.RequestURI
headers[constant.HttpHeaderXMethodName] = r.Method
certs := r.TLS.PeerCertificates
if len(certs) > 0 {
peerCert := certs[0]
if len(peerCert.URIs) > 0 {
spiffeURI := peerCert.URIs[0].String()
// Set spiffe scheme header
headers[constant.HttpHeaderXSpiffeName]
= spiffeURI
}
}
ctx := context.WithValue(r.Context(),
constant.AttachmentKey, headers)
request := r.WithContext(ctx)
h.ServeHTTP(w, request)
})
}
if s.httpLn == nil && httpOn {
httpLn, err := net.Listen("tcp", httpAddr)
if err != nil {
httpLn.Close()
return err
}
s.httpLn = httpLn
s.httpSrv = {Handler: setHTTPHeaders(handler)}
}
if s.httpsLn == nil && httpsOn {
tlsCfg, err := s.tlsConfigProvider()
if err != nil {
logger.Error("can not get tls config")
}
httpsLn, err := tls.Listen("tcp", httpsAddr, tlsCfg)
if err != nil {
httpsLn.Close()
return err
}
s.httpsLn = httpsLn
s.httpsSrv = {Handler: setHTTPSHeaders(handler)}
}
if httpsOn {
go s.httpsSrv.Serve(s.httpsLn)
}
// http should be on now
if err := s.httpSrv.Serve(s.httpLn); err != nil {
return err
}
return nil
}
```
HTTPS 可以设置自定义头， HTTP不可以，因为http 一进来就是走了 r.Method == "PRI"，这个时候不能设置自定义头。
```
func (s h2cHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
// Handle h2c with prior knowledge (RFC 7540 Section 3.4)
if r.Method == "PRI" && len(r.Header) == 0 && r.URL.Path == "*" &&
r.Proto == "HTTP/2.0" {
if http2VerboseLogs {
log.Print("h2c: attempting h2c with prior knowledge.")
}
}
```
也做了其他trick做法，我现在trick做法 HTTP不设置定义头，HTTPS设置，后续在 dubbo filter 判断再补全，
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] Update helloworld [dubbo-go-samples]
chickenlj opened a new pull request, #747: URL: https://github.com/apache/dubbo-go-samples/pull/747 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] fix Panic caused by failure to connect to the peer when obtaining remote metadata [dubbo-go]
codecov-commenter commented on PR #2651: URL: https://github.com/apache/dubbo-go/pull/2651#issuecomment-2034334676 ## [Codecov](https://app.codecov.io/gh/apache/dubbo-go/pull/2651?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `0%` with `8 lines` in your changes are missing coverage. Please review. > Project coverage is 47.38%. Comparing base [(`2f5143a`)](https://app.codecov.io/gh/apache/dubbo-go/commit/2f5143a2acf4d420d2b93555a85021295bfe86f8?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`e5e3b00`)](https://app.codecov.io/gh/apache/dubbo-go/pull/2651?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 2 commits behind head on main. > :exclamation: Current head e5e3b00 differs from pull request most recent head a0c39c2. Consider uploading reports for the commit a0c39c2 to get more accurate results | [Files](https://app.codecov.io/gh/apache/dubbo-go/pull/2651?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [...try/servicediscovery/service\_discovery\_registry.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2651?src=pr=tree=registry%2Fservicediscovery%2Fservice_discovery_registry.go_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9zZXJ2aWNlX2Rpc2NvdmVyeV9yZWdpc3RyeS5nbw==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/2651?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...ta/service/local/metadata\_service\_proxy\_factory.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2651?src=pr=tree=metadata%2Fservice%2Flocal%2Fmetadata_service_proxy_factory.go_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-bWV0YWRhdGEvc2VydmljZS9sb2NhbC9tZXRhZGF0YV9zZXJ2aWNlX3Byb3h5X2ZhY3RvcnkuZ28=) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/2651?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...scovery/service\_instances\_changed\_listener\_impl.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2651?src=pr=tree=registry%2Fservicediscovery%2Fservice_instances_changed_listener_impl.go_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9zZXJ2aWNlX2luc3RhbmNlc19jaGFuZ2VkX2xpc3RlbmVyX2ltcGwuZ28=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/2651?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## main#2651 +/- ## === Coverage 47.38% 47.38% === Files 341 341 Lines 2512225131+9 === + Hits1190411909+5 + Misses 1207412071-3 - Partials 1144 1151+7 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo-go/pull/2651?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] fix Panic caused by failure to connect to the peer when obtaining remote metadata [dubbo-go]
sonarcloud[bot] commented on PR #2651: URL: https://github.com/apache/dubbo-go/pull/2651#issuecomment-2034295030 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go=2651) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go=2651=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go=2651=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go=2651=false=true)  No data about Coverage  [2.6% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go=2651=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go=2651) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] fix Panic caused by failure to connect to the peer when obtaining remote metadata [dubbo-go]
FoghostCn opened a new pull request, #2651: URL: https://github.com/apache/dubbo-go/pull/2651 fix Panic caused by failure to connect to the peer when obtaining remote metadata -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] 请问支持服务注册发现、负载均衡等服务治理能力吗？ [dubbo-js]
jianyi-gronk commented on issue #390: URL: https://github.com/apache/dubbo-js/issues/390#issuecomment-2034208814 It is not supported yet, but it is already planned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] 有一个panic导致应用挂了 [dubbo-go]
FoghostCn commented on issue #2650: URL: https://github.com/apache/dubbo-go/issues/2650#issuecomment-2034177824 When obtaining remote metadata, the ip address (192.168.50.49:17624) cannot be connected. Can you confirm that 192.168.50.49:17624 can be connected? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] 有一个panic导致应用挂了 [dubbo-go]
chickenlj commented on issue #2650: URL: https://github.com/apache/dubbo-go/issues/2650#issuecomment-2034131446 是纯dubbo-go应用，还是dubbo-go和dubbo-java互通的场景？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] Update sentinel sample [dubbo-samples]
chickenlj opened a new pull request, #1123: URL: https://github.com/apache/dubbo-samples/pull/1123 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Task] All samples unified switch to annotation + yaml configuration [dubbo]
cnzakii commented on issue #13860: URL: https://github.com/apache/dubbo/issues/13860#issuecomment-2034025886 I would like to try it, please assign me. Clarify my task: convert all `application.properties` into `application.yaml` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Feature] Move Rest Protocol to SPI Extensions [dubbo]
wcy666103 commented on issue #13958: URL: https://github.com/apache/dubbo/issues/13958#issuecomment-2033998577 PTAL @AlbumenJ [Move Rest Protocol to SPI Extensions PR#306](https://github.com/apache/dubbo-spi-extensions/pull/306) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] The Task Of [Feature] Move Rest Protocol to SPI Extensions #13958 [dubbo-spi-extensions]
wcy666103 opened a new pull request, #306: URL: https://github.com/apache/dubbo-spi-extensions/pull/306 ## What is the purpose of the change X ## Brief changelog X ## Verifying this change X Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] The Task Of [Feature] Move Rest Protocol to SPI Extensions #13958 [dubbo-spi-extensions]
wcy666103 commented on PR #306: URL: https://github.com/apache/dubbo-spi-extensions/pull/306#issuecomment-2033992419 I have test it locally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
