Re: [PR] fix(3.2): triple AbstractServerCallListener NPE [dubbo]
icodening merged PR #14009: URL: https://github.com/apache/dubbo/pull/14009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Dependency] Exclude transitive spring dependencies from dubbo-all or dubbo-spring-boot-starter [dubbo]
heliang666s commented on issue #14032: URL: https://github.com/apache/dubbo/issues/14032#issuecomment-2041335990 @AlbumenJ You seem to be getting people wrong -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Task] All samples support builds and launches with jar or native-image [dubbo]
CrazyHZM commented on issue #13861: URL: https://github.com/apache/dubbo/issues/13861#issuecomment-2041329400 @heliang666s Please refer to https://github.com/apache/dubbo-samples/blob/master/test/README-NATIVE.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] If --add-opens=java.base/java.net=ALL-UNNAMED added to native-maven-plugin's buildArgs, Exception will be found in Dubbo ExtensionLoader [dubbo]
CrazyHZM closed issue #13802: If --add-opens=java.base/java.net=ALL-UNNAMED added to native-maven-plugin's buildArgs, Exception will be found in Dubbo ExtensionLoader URL: https://github.com/apache/dubbo/issues/13802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Dependency] Exclude transitive spring dependencies from dubbo-all or dubbo-spring-boot-starter [dubbo]
AlbumenJ commented on issue #14032: URL: https://github.com/apache/dubbo/issues/14032#issuecomment-2041328451 > hello,I think I can do it,please assign me,thanks~ done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] Chore: Update the comment content in pom.xml to be consistent [dubbo]
AlbumenJ commented on issue #13686: URL: https://github.com/apache/dubbo/issues/13686#issuecomment-2041328376 > hello,I am interested in it,please assign me. done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Task] All samples support builds and launches with jar or native-image [dubbo]
AlbumenJ commented on issue #13861: URL: https://github.com/apache/dubbo/issues/13861#issuecomment-2041328296 @CrazyHZM PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]
chickenlj commented on code in PR #13971:
URL: https://github.com/apache/dubbo/pull/13971#discussion_r1542428296
##
dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/report/support/AbstractMetadataReportFactory.java:
##
@@ -89,6 +91,12 @@ public MetadataReport getMetadataReport(URL url) {
}
protected String toMetadataReportKey(URL url) {
+String namespace = url.getParameter(NAMESPACE_KEY);
+if (!StringUtils.isEmpty(namespace)) {
+return URL.valueOf(url.toServiceString())
+.addParameter(NAMESPACE_KEY, namespace)
+.toString();
+}
Review Comment:
Can you describe the difference between the new url and the old url?
##
dubbo-common/src/main/java/org/apache/dubbo/config/RegistryConfig.java:
##
@@ -220,12 +219,6 @@ public RegistryConfig(ApplicationModel applicationModel,
String address, String
setProtocol(protocol);
}
-@Override
-@Parameter(key = REGISTRY_CLUSTER_KEY)
-public String getId() {
-return super.getId();
-}
-
Review Comment:
Please keep this method and only remove `@Parameter(key =
REGISTRY_CLUSTER_KEY)`.
##
dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/report/support/AbstractMetadataReportFactory.java:
##
@@ -89,6 +91,12 @@ public MetadataReport getMetadataReport(URL url) {
}
protected String toMetadataReportKey(URL url) {
+String namespace = url.getParameter(NAMESPACE_KEY);
+if (!StringUtils.isEmpty(namespace)) {
+return URL.valueOf(url.toServiceString())
+.addParameter(NAMESPACE_KEY, namespace)
+.toString();
+}
Review Comment:
How about making it a public util method to make calling it in other places
easier? like here
https://github.com/apache/dubbo/pull/13971/files#diff-17a0f234d88728ebc6f37959d84276704ca16846cd10cd0743616a8689949eabR33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
(dubbo-samples) branch master updated: Update dubbo-samples-callback springboot3 and JDK17 (#1125)
This is an automated email from the ASF dual-hosted git repository.
albumenj pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git
The following commit(s) were added to refs/heads/master by this push:
new 6ddb0a743 Update dubbo-samples-callback springboot3 and JDK17 (#1125)
6ddb0a743 is described below
commit 6ddb0a7431ef7be6d31831f2395a8134d6fbc3e9
Author: SSSugarman <61129238+sssugar...@users.noreply.github.com>
AuthorDate: Sun Apr 7 14:06:04 2024 +0800
Update dubbo-samples-callback springboot3 and JDK17 (#1125)
Co-authored-by: hujiajia
---
.../dubbo-samples-callback/case-versions.conf | 6 ++--
.../dubbo-samples-callback-consumer/pom.xml| 5 +--
.../dubbo-samples-callback-provider/pom.xml| 5 +--
2-advanced/dubbo-samples-callback/pom.xml | 39 +++---
4 files changed, 13 insertions(+), 42 deletions(-)
diff --git a/2-advanced/dubbo-samples-callback/case-versions.conf
b/2-advanced/dubbo-samples-callback/case-versions.conf
index 0a8a7738f..82aeb4560 100644
--- a/2-advanced/dubbo-samples-callback/case-versions.conf
+++ b/2-advanced/dubbo-samples-callback/case-versions.conf
@@ -20,6 +20,6 @@
# Supported component versions of the test case
# Spring app
-dubbo.version=2.7*, 3.*
-spring-boot.version=2.*
-java.version= [>= 8]
+dubbo.version=3.3.*
+spring.version=6.*
+java.version= [>= 17]
diff --git
a/2-advanced/dubbo-samples-callback/dubbo-samples-callback-consumer/pom.xml
b/2-advanced/dubbo-samples-callback/dubbo-samples-callback-consumer/pom.xml
index 3e8879f49..1f660ae46 100644
--- a/2-advanced/dubbo-samples-callback/dubbo-samples-callback-consumer/pom.xml
+++ b/2-advanced/dubbo-samples-callback/dubbo-samples-callback-consumer/pom.xml
@@ -35,11 +35,12 @@
org.apache.dubbo
dubbo-spring-boot-starter
+3.3.0-beta.1
org.apache.dubbo
-dubbo-dependencies-zookeeper-curator5
-pom
+
dubbo-zookeeper-curator5-spring-boot-starter
+3.2.3
diff --git
a/2-advanced/dubbo-samples-callback/dubbo-samples-callback-provider/pom.xml
b/2-advanced/dubbo-samples-callback/dubbo-samples-callback-provider/pom.xml
index a408d2f3b..3587c63b3 100644
--- a/2-advanced/dubbo-samples-callback/dubbo-samples-callback-provider/pom.xml
+++ b/2-advanced/dubbo-samples-callback/dubbo-samples-callback-provider/pom.xml
@@ -36,11 +36,12 @@
org.apache.dubbo
dubbo-spring-boot-starter
+3.3.0-beta.1
org.apache.dubbo
-dubbo-dependencies-zookeeper-curator5
-pom
+
dubbo-zookeeper-curator5-spring-boot-starter
+3.2.3
diff --git a/2-advanced/dubbo-samples-callback/pom.xml
b/2-advanced/dubbo-samples-callback/pom.xml
index db8473b10..957c3380d 100644
--- a/2-advanced/dubbo-samples-callback/pom.xml
+++ b/2-advanced/dubbo-samples-callback/pom.xml
@@ -35,12 +35,12 @@
Dubbo Samples Callback
-1.8
-1.8
+17
+17
UTF-8
-3.2.6
-2.7.8
+3.3.0-beta.1
+3.2.3
4.13.1
@@ -72,37 +72,6 @@
-
-org.apache.dubbo
-dubbo-bom
-${dubbo.version}
-pom
-import
-
-
-org.apache.dubbo
-dubbo-dependencies-zookeeper-curator5
-${dubbo.version}
-pom
-
-
-logback-classic
-ch.qos.logback
-
-
-logback-core
-ch.qos.logback
-
-
-log4j
-log4j
-
-
-slf4j-log4j12
-org.slf4j
-
-
-
junit
junit
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Update dubbo-samples-callback springboot3 and JDK17 [dubbo-samples]
AlbumenJ merged PR #1125: URL: https://github.com/apache/dubbo-samples/pull/1125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] feat:update all old zookeeper version -> curator5 [dubbo-samples]
AlbumenJ merged PR #1124: URL: https://github.com/apache/dubbo-samples/pull/1124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] update curator version,remove old zk [dubbo-integration-cases]
AlbumenJ merged PR #20: URL: https://github.com/apache/dubbo-integration-cases/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
(dubbo-samples) branch master updated: feat:update all old zookeeper version -> curator5 (#1124)
This is an automated email from the ASF dual-hosted git repository.
albumenj pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git
The following commit(s) were added to refs/heads/master by this push:
new 9c40d1824 feat:update all old zookeeper version -> curator5 (#1124)
9c40d1824 is described below
commit 9c40d18244d8586f046134479c6563d79e1abee0
Author: stellar <137587347+stellar1...@users.noreply.github.com>
AuthorDate: Sun Apr 7 14:02:59 2024 +0800
feat:update all old zookeeper version -> curator5 (#1124)
---
.../dubbo-samples-migration-case-application-consumer/pom.xml | 6 +++---
.../java/org/apache/dubbo/samples/basic/spi/CompatibleRegistry.java | 4 ++--
4-governance/dubbo-samples-zipkin/pom.xml | 6 +++---
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git
a/2-advanced/dubbo-samples-migration/dubbo-samples-migration-case-application/dubbo-samples-migration-case-application-consumer/pom.xml
b/2-advanced/dubbo-samples-migration/dubbo-samples-migration-case-application/dubbo-samples-migration-case-application-consumer/pom.xml
index 46beb3fdc..d77b374bb 100644
---
a/2-advanced/dubbo-samples-migration/dubbo-samples-migration-case-application/dubbo-samples-migration-case-application-consumer/pom.xml
+++
b/2-advanced/dubbo-samples-migration/dubbo-samples-migration-case-application/dubbo-samples-migration-case-application-consumer/pom.xml
@@ -30,7 +30,7 @@
1.8
UTF-8
-2.7.13
+3.2.6
2.20.0
4.13.1
@@ -55,7 +55,7 @@
org.apache.dubbo
-dubbo-dependencies-zookeeper
+dubbo-dependencies-zookeeper-curator5
${dubbo.consumer.version}
pom
@@ -100,7 +100,7 @@
org.apache.dubbo
-dubbo-dependencies-zookeeper
+dubbo-dependencies-zookeeper-curator5
pom
diff --git
a/2-advanced/dubbo-samples-spi-compatible/src/main/java/org/apache/dubbo/samples/basic/spi/CompatibleRegistry.java
b/2-advanced/dubbo-samples-spi-compatible/src/main/java/org/apache/dubbo/samples/basic/spi/CompatibleRegistry.java
index dab9af66e..2530cdc68 100644
---
a/2-advanced/dubbo-samples-spi-compatible/src/main/java/org/apache/dubbo/samples/basic/spi/CompatibleRegistry.java
+++
b/2-advanced/dubbo-samples-spi-compatible/src/main/java/org/apache/dubbo/samples/basic/spi/CompatibleRegistry.java
@@ -18,7 +18,7 @@ package org.apache.dubbo.samples.basic.spi;
import org.apache.dubbo.registry.zookeeper.ZookeeperRegistryFactory;
import org.apache.dubbo.remoting.zookeeper.ZookeeperTransporter;
-import org.apache.dubbo.remoting.zookeeper.curator.CuratorZookeeperTransporter;
+import
org.apache.dubbo.remoting.zookeeper.curator5.Curator5ZookeeperTransporter;
import com.alibaba.dubbo.common.URL;
import com.alibaba.dubbo.registry.NotifyListener;
@@ -34,7 +34,7 @@ public class CompatibleRegistry implements Registry {
public CompatibleRegistry(URL url) {
this.url = url;
-ZookeeperTransporter transporter = new CuratorZookeeperTransporter();
+ZookeeperTransporter transporter = new Curator5ZookeeperTransporter();
ZookeeperRegistryFactory registryFactory = new
ZookeeperRegistryFactory();
registryFactory.setZookeeperTransporter(transporter);
delegate =
registryFactory.createRegistry(url.setProtocol("zookeeper"));
diff --git a/4-governance/dubbo-samples-zipkin/pom.xml
b/4-governance/dubbo-samples-zipkin/pom.xml
index d556e4b06..d1018eda6 100644
--- a/4-governance/dubbo-samples-zipkin/pom.xml
+++ b/4-governance/dubbo-samples-zipkin/pom.xml
@@ -32,7 +32,7 @@
1.8
UTF-8
-2.7.13
+3.2.6
4.3.30.RELEASE
2.20.0
4.13.1
@@ -70,7 +70,7 @@
org.apache.dubbo
-dubbo-dependencies-zookeeper
+dubbo-dependencies-zookeeper-curator5
${dubbo.version}
pom
@@ -131,7 +131,7 @@
org.apache.dubbo
-dubbo-dependencies-zookeeper
+dubbo-dependencies-zookeeper-curator5
pom
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] The Task Of [Feature] Move Rest Protocol to SPI Extensions #13958 [dubbo-spi-extensions]
AlbumenJ commented on PR #306: URL: https://github.com/apache/dubbo-spi-extensions/pull/306#issuecomment-2041326679  Still failed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Merge CommonConfigPostProcessor and ConfigPostProcessor [dubbo]
AlbumenJ commented on code in PR #14027:
URL: https://github.com/apache/dubbo/pull/14027#discussion_r1554822437
##
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ConfigPostProcessor.java:
##
@@ -1,33 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.dubbo.config;
-
-import org.apache.dubbo.common.extension.ExtensionScope;
-import org.apache.dubbo.common.extension.SPI;
-
-/**
- * 2019/12/30
- * it will be instead of CommonConfigPostProcessor
- */
-@Deprecated
-@SPI(scope = ExtensionScope.MODULE)
-public interface ConfigPostProcessor extends CommonConfigPostProcessor {
Review Comment:
So, update the `REST protocol` would be better
##
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ConfigPostProcessor.java:
##
@@ -1,33 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.dubbo.config;
-
-import org.apache.dubbo.common.extension.ExtensionScope;
-import org.apache.dubbo.common.extension.SPI;
-
-/**
- * 2019/12/30
- * it will be instead of CommonConfigPostProcessor
- */
-@Deprecated
-@SPI(scope = ExtensionScope.MODULE)
-public interface ConfigPostProcessor extends CommonConfigPostProcessor {
Review Comment:
I would prefer to remove the `CommonConfigPostProcessor`.
`ConfigPostProcessor` exists since 2.7.x version.
`CommonConfigPostProcessor` is newly introduced in 3.3.x.
##
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ConfigPostProcessor.java:
##
@@ -1,33 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.dubbo.config;
-
-import org.apache.dubbo.common.extension.ExtensionScope;
-import org.apache.dubbo.common.extension.SPI;
-
-/**
- * 2019/12/30
- * it will be instead of CommonConfigPostProcessor
- */
-@Deprecated
-@SPI(scope = ExtensionScope.MODULE)
-public interface ConfigPostProcessor extends CommonConfigPostProcessor {
Review Comment:
There is only one usage of `CommonConfigPostProcessor` which is about `REST
protocol`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Triple protocol http1 upgrade support [dubbo]
AlbumenJ commented on code in PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#discussion_r1554821301
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/h12/HttpServerAfterUpgradeHandler.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.rpc.protocol.tri.h12;
+
+import io.netty.channel.ChannelHandler.Sharable;
+import io.netty.channel.ChannelHandlerContext;
+import io.netty.channel.ChannelInboundHandlerAdapter;
+import io.netty.handler.codec.http.HttpServerUpgradeHandler;
+import io.netty.handler.codec.http2.DefaultHttp2DataFrame;
+import io.netty.handler.codec.http2.DefaultHttp2Headers;
+import io.netty.handler.codec.http2.DefaultHttp2HeadersFrame;
+import io.netty.handler.codec.http2.Http2CodecUtil;
+import io.netty.handler.codec.http2.Http2FrameCodec;
+import io.netty.handler.codec.http2.Http2FrameStream;
+import io.netty.handler.codec.http2.Http2Headers;
+import io.netty.handler.codec.http2.InboundHttpToHttp2Adapter;
+
+import static io.netty.handler.codec.http.HttpResponseStatus.OK;
+
+/**
+ * If an upgrade occurred, the program need send a simple response via HTTP/2
on stream 1 (the stream specifically reserved
+ * for cleartext HTTP upgrade). However, {@link Http2FrameCodec} send
'upgradeRequest' to upgraded channel handlers by
+ * {@link InboundHttpToHttp2Adapter} (As it noted that this may behave
strangely). So we need to distinguish the 'upgradeRequest'
+ * and send the response.
+ *
+ * @author mailto:warlkl...@gmail.com";>Walklown
Review Comment:
Please remove this tag. Git history will remember you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Triple protocol http1 upgrade support [dubbo]
AlbumenJ commented on PR #14026: URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2041324640 @oxsean PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] For HTTP/1 unary mode, use Content-Length instead of chunk [dubbo]
AlbumenJ merged PR #13979: URL: https://github.com/apache/dubbo/pull/13979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] fix(3.2): triple AbstractServerCallListener NPE [dubbo]
sonarcloud[bot] commented on PR #14009: URL: https://github.com/apache/dubbo/pull/14009#issuecomment-2041308186 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14009) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14009&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14009&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14009&resolved=false&inNewCodePeriod=true)  [77.8% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14009&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14009&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14009) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Feat security [dubbo-go]
sonarcloud[bot] commented on PR #2643: URL: https://github.com/apache/dubbo-go/pull/2643#issuecomment-2041303678 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2643) **Quality Gate failed** Failed conditions  [C Security Rating on New Code](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2643) (required ≥ A) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2643) ##  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] fix(3.2): triple AbstractServerCallListener NPE [dubbo]
caoyanan666 commented on code in PR #14009:
URL: https://github.com/apache/dubbo/pull/14009#discussion_r1554809991
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/call/AbstractServerCallListener.java:
##
@@ -68,6 +68,10 @@ public void invoke() {
responseObserver.onError(t);
return;
}
+if (r.hasException()) {
+doOnResponseHasException(r.getException());
+return;
+}
Review Comment:
OK，我改一下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] 应用启动后加载元数据一直提示上游不可用 [dubbo]
vhypnus commented on issue #12602: URL: https://github.com/apache/dubbo/issues/12602#issuecomment-2041297919 兄弟，你是如何解决的，原因是什么，我们也遇到了这个问题 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] fix(3.2): triple AbstractServerCallListener NPE [dubbo]
icodening commented on code in PR #14009:
URL: https://github.com/apache/dubbo/pull/14009#discussion_r1554808989
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/call/AbstractServerCallListener.java:
##
@@ -68,6 +68,10 @@ public void invoke() {
responseObserver.onError(t);
return;
}
+if (r.hasException()) {
+doOnResponseHasException(r.getException());
+return;
+}
Review Comment:
嗯嗯，那这样看来使用`r.hasException()`替换掉原来的`response.hasException()`应该会更好，因为r才是最终真实的结果
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Feat security [dubbo-go]
sonarcloud[bot] commented on PR #2643: URL: https://github.com/apache/dubbo-go/pull/2643#issuecomment-2041293744 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2643) **Quality Gate failed** Failed conditions  [C Security Rating on New Code](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2643) (required ≥ A) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2643) ##  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] update imports.go [dubbo-go]
codecov-commenter commented on PR #2655: URL: https://github.com/apache/dubbo-go/pull/2655#issuecomment-2041287857 ## [Codecov](https://app.codecov.io/gh/apache/dubbo-go/pull/2655?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 47.44%. Comparing base [(`55a0639`)](https://app.codecov.io/gh/apache/dubbo-go/commit/55a06394edb544cb0a54b8b697da3ae34b4f014c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`40dd4e9`)](https://app.codecov.io/gh/apache/dubbo-go/pull/2655?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: Current head 40dd4e9 differs from pull request most recent head f744e6d. Consider uploading reports for the commit f744e6d to get more accurate results Additional details and impacted files ```diff @@Coverage Diff @@ ## main#2655 +/- ## == + Coverage 47.37% 47.44% +0.07% == Files 341 341 Lines 2512525125 == + Hits1190211920 +18 + Misses 1207812059 -19 - Partials 1145 1146 +1 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo-go/pull/2655?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] fix(3.2): triple AbstractServerCallListener NPE [dubbo]
caoyanan666 commented on code in PR #14009:
URL: https://github.com/apache/dubbo/pull/14009#discussion_r1554800953
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/call/AbstractServerCallListener.java:
##
@@ -68,6 +68,10 @@ public void invoke() {
responseObserver.onError(t);
return;
}
+if (r.hasException()) {
+doOnResponseHasException(r.getException());
+return;
+}
Review Comment:
因为直接invoke的response是同步执行的结果，whenCompleteWithContext里面回调的response是异步的AppResponse，只要provider的实现用了异步，在实际的异步结果里面有异常，就会是外面Invoker的response没异常，whenCompleteWithContext回调的appResponse有异常
Because the response of direct invoke is the result of synchronous
execution, the response of the callback in whenCompleteWithContext is an
asynchronous AppResponse. As long as the provider implementation uses
asynchronous, if there is an exception in the actual asynchronous result, it
will be because the response of the external Invoker is not abnormal, and the
callback of whenCompleteWithContext is appResponse has exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] update imports.go [dubbo-go]
sonarcloud[bot] commented on PR #2655: URL: https://github.com/apache/dubbo-go/pull/2655#issuecomment-2041285218 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2655) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2655&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2655&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2655&resolved=false&inNewCodePeriod=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2655) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] update imports.go [dubbo-go]
sonarcloud[bot] commented on PR #2655: URL: https://github.com/apache/dubbo-go/pull/2655#issuecomment-2041284707 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2655) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2655&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2655&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2655&resolved=false&inNewCodePeriod=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2655) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] update imports.go [dubbo-go]
chickenlj opened a new pull request, #2655: URL: https://github.com/apache/dubbo-go/pull/2655 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] 关于服务提供者返回调用结果给消费者报错链接被拒绝 [dubbo]
48038411 commented on issue #13759: URL: https://github.com/apache/dubbo/issues/13759#issuecomment-2041281819 > 你是如何解决的？ 机器不互通，我的部署环境是两台内网机器，使用Docker分别部署在两台机器上，一开始设定部署的时候网络模式为host，与主机共享网络空间，而内网环境下所有端口是全部开放的，这样是一直稳定的，后面我在性能调优的时候去掉了host网络模式，然后docker容器没有放开20880端口，就导致返回调用结果失败了，实际是要放开20880等相关的端口的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Use ExecutorService instead of event loop for Netty connection [dubbo]
EarthChen merged PR #13904: URL: https://github.com/apache/dubbo/pull/13904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] 关于服务提供者返回调用结果给消费者报错链接被拒绝 [dubbo]
vhypnus commented on issue #13759: URL: https://github.com/apache/dubbo/issues/13759#issuecomment-2041281075 你是如何解决的？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Feat security [dubbo-go]
sonarcloud[bot] commented on PR #2643: URL: https://github.com/apache/dubbo-go/pull/2643#issuecomment-2041281018 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2643) **Quality Gate failed** Failed conditions  [C Security Rating on New Code](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2643) (required ≥ A) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2643) ##  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Feat security [dubbo-go]
sonarcloud[bot] commented on PR #2643: URL: https://github.com/apache/dubbo-go/pull/2643#issuecomment-2041280268 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2643) **Quality Gate failed** Failed conditions  [C Security Rating on New Code](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2643) (required ≥ A) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2643) ##  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Feat security [dubbo-go]
sonarcloud[bot] commented on PR #2643: URL: https://github.com/apache/dubbo-go/pull/2643#issuecomment-2041269000 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2643) **Quality Gate failed** Failed conditions  [C Security Rating on New Code](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2643) (required ≥ A) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2643) ##  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] 有一个panic导致应用挂了 [dubbo-go]
alan2016llg commented on issue #2650: URL: https://github.com/apache/dubbo-go/issues/2650#issuecomment-2041262920 现在无法确认当时是不是真的连不上了，可能当时网络有问题导致 @FoghostCn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] 有一个panic导致应用挂了 [dubbo-go]
alan2016llg commented on issue #2650: URL: https://github.com/apache/dubbo-go/issues/2650#issuecomment-2041258124 通过泛化调用，dubbo-go调用java的dubbo服务。 @chickenlj -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] fix(3.2): triple AbstractServerCallListener NPE [dubbo]
icodening commented on code in PR #14009:
URL: https://github.com/apache/dubbo/pull/14009#discussion_r1554631553
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/call/AbstractServerCallListener.java:
##
@@ -68,6 +68,10 @@ public void invoke() {
responseObserver.onError(t);
return;
}
+if (r.hasException()) {
+doOnResponseHasException(r.getException());
+return;
+}
Review Comment:
in this case, why `response.hasException` is false？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]
DMwangnima commented on PR #2654: URL: https://github.com/apache/dubbo-go/pull/2654#issuecomment-2041118835 Should we create a unique branch to track this working process. cc @chickenlj -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]
DMwangnima commented on code in PR #2654:
URL: https://github.com/apache/dubbo-go/pull/2654#discussion_r1554627219
##
cmd/protoc-gen-go-hessian2/generate/generate.go:
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package generate
+
+import (
+ "fmt"
+)
+
+import (
+ "google.golang.org/protobuf/compiler/protogen"
+ "google.golang.org/protobuf/reflect/protoreflect"
+ "google.golang.org/protobuf/types/descriptorpb"
+)
+
+func GenHessian2(gen *protogen.Plugin, file *protogen.File) {
+ filename := file.GeneratedFilenamePrefix + ".hessian2.go"
+ g := gen.NewGeneratedFile(filename, file.GoImportPath)
+
+ g.P("package ", file.GoPackageName)
+ g.P()
+
+ g.P("import hessian \"github.com/apache/dubbo-go-hessian2\"")
+ g.P()
+
+ for _, message := range file.Messages {
+ genMessage(g, message)
+ }
+ genRegisterInitFunc(g, file)
+}
+
+func genMessage(g *protogen.GeneratedFile, m *protogen.Message) {
+ if m.Desc.IsMapEntry() {
+ return
+ }
+ g.AnnotateSymbol(m.GoIdent.String(), protogen.Annotation{
+ Location: m.Location,
+ Semantic: descriptorpb.GeneratedCodeInfo_Annotation_SET.Enum(),
+ })
+
+ g.P("type ", m.GoIdent, " struct {")
+
+ genMessageFields(g, m)
+ g.P("}")
+ g.P()
+
+ genMessageRelatedMethods(g, m)
+}
+
+func genMessageFields(g *protogen.GeneratedFile, m *protogen.Message) {
+ for _, field := range m.Fields {
+ genMessageField(g, m, field)
+ }
+}
+
+func genMessageField(g *protogen.GeneratedFile, m *protogen.Message, field
*protogen.Field) {
+ goType, pointer := fieldGoType(g, field)
+ if pointer {
+ goType = "*" + goType
+ }
+
+ name := field.GoName
+ g.AnnotateSymbol(m.GoIdent.GoName+"."+name, protogen.Annotation{
+ Location: field.Location,
+ Semantic: descriptorpb.GeneratedCodeInfo_Annotation_SET.Enum(),
+ })
+ g.P(name, " ", goType)
+}
+
+func genMessageRelatedMethods(g *protogen.GeneratedFile, m *protogen.Message) {
+ g.P("func ", "(x *", m.GoIdent.GoName, ")", "JavaClassName() string {")
+ // TODO(Yuukirn): get class name by extend field
+ g.P(" return ", "\"org.test.service.", m.GoIdent.GoName, "\"")
+ g.P("}")
+
+ g.P()
+
+ g.P("func ", "(x *", m.GoIdent.GoName, ")", "String() string {")
Review Comment:
For now, we do not need this ```String()``` method since dubbo-go-hessian2
just make use of reflection to serialize.
In the future, we could generate serialization details to make it fast.
(hessian2 FastCodec)
##
cmd/protoc-gen-go-hessian2/generate/generate.go:
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package generate
+
+import (
+ "fmt"
+)
+
+import (
+ "google.golang.org/protobuf/compiler/protogen"
+ "google.golang.org/protobuf/reflect/protoreflect"
+ "google.golang.org/protobuf/types/descriptorpb"
+)
+
+func GenHessian2(gen *protogen.Plugin, file *protogen.File) {
+ filename := file.GeneratedFilenamePrefix + ".hessian2.go"
+ g := gen.NewGeneratedFile(filename, file.GoImportPath)
+
+ g.P("package ", file.GoPackageName)
+ g.P()
+
+ g.P("import hessian \"github.com/apache/dubbo-go-hessian2\"")
+ g.
Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]
codecov-commenter commented on PR #2654: URL: https://github.com/apache/dubbo-go/pull/2654#issuecomment-2041117492 ## [Codecov](https://app.codecov.io/gh/apache/dubbo-go/pull/2654?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 47.39%. Comparing base [(`2f5143a`)](https://app.codecov.io/gh/apache/dubbo-go/commit/2f5143a2acf4d420d2b93555a85021295bfe86f8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`b22996a`)](https://app.codecov.io/gh/apache/dubbo-go/pull/2654?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 2 commits behind head on main. > :exclamation: Current head b22996a differs from pull request most recent head d8ab177. Consider uploading reports for the commit d8ab177 to get more accurate results Additional details and impacted files ```diff @@ Coverage Diff @@ ## main#2654 +/- ## === Coverage 47.38% 47.39% === Files 341 341 Lines 2512225125+3 === + Hits1190411907+3 + Misses 1207412072-2 - Partials 1144 1146+2 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo-go/pull/2654?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] fix: that protoc-gen-go-triple cannot generate normally when a proto file has multiple services. [dubbo-go]
sonarcloud[bot] commented on PR #2647: URL: https://github.com/apache/dubbo-go/pull/2647#issuecomment-2041116981 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2647) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2647&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2647&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2647&resolved=false&inNewCodePeriod=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2647) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] fix memory leak of tri protocol [dubbo]
codecov-commenter commented on PR #13973: URL: https://github.com/apache/dubbo/pull/13973#issuecomment-2041116441 ## [Codecov](https://app.codecov.io/gh/apache/dubbo/pull/13973?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 38.57%. Comparing base [(`a12975a`)](https://app.codecov.io/gh/apache/dubbo/commit/a12975aa93d42a18d308422fddb23b3dc1e8fd9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`e88b48e`)](https://app.codecov.io/gh/apache/dubbo/pull/13973?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). Additional details and impacted files ```diff @@Coverage Diff @@ ## 3.3 #13973 +/- ## == + Coverage 38.55% 38.57% +0.02% == Files1895 1896 +1 Lines 7927279297 +25 Branches1152811530 +2 == + Hits3056030589 +29 + Misses 4443944433 -6 - Partials 4273 4275 +2 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo/pull/13973?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] fix memory leak of tri protocol [dubbo]
sonarcloud[bot] commented on PR #13973: URL: https://github.com/apache/dubbo/pull/13973#issuecomment-2041115608 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13973) **Quality Gate passed** Issues  [1 New issue](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13973&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13973&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13973&resolved=false&inNewCodePeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13973&metric=new_coverage&view=list)  [2.2% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13973&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13973) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]
sonarcloud[bot] commented on PR #2654: URL: https://github.com/apache/dubbo-go/pull/2654#issuecomment-2041113460 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654) **Quality Gate passed** Issues  [2 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2654&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2654&resolved=false&inNewCodePeriod=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] [WIP] Support idl for hessian2 [dubbo-go]
Yuukirn opened a new pull request, #2654: URL: https://github.com/apache/dubbo-go/pull/2654 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] `client.WithClientCheck()` should set `check` to false instead of true. [dubbo-go]
FoghostCn commented on issue #2652: URL: https://github.com/apache/dubbo-go/issues/2652#issuecomment-2041005128 should named `client.WithClientNoCheck()` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] Java interoperability issue, `go-client` call `java-server` failed when calling MetadataService during service discovery. [dubbo-go]
FoghostCn commented on issue #2653: URL: https://github.com/apache/dubbo-go/issues/2653#issuecomment-2041004883 demo is 404, it looks like your java server use triple protocol for metadata service, but now we only support dubbo protocol -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
