Re: [I] 请更新1.0.4到mvn 仓库。 [dubbo-spi-extensions]
imgoby commented on issue #194: URL: https://github.com/apache/dubbo-spi-extensions/issues/194#issuecomment-2046576545 thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] chore: Use ReentrantLock for loading Extension Classes [dubbo]
He-Pin commented on PR #14056: URL: https://github.com/apache/dubbo/pull/14056#issuecomment-2046570318 Cool, thanks for the update, can't wait the next LTS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Feat security [dubbo-go]
AlexStocks commented on code in PR #2643: URL: https://github.com/apache/dubbo-go/pull/2643#discussion_r1558865145 ## README.md: ## @@ -12,6 +12,12 @@ Apache Dubbo-go, a Dubbo implementation written in Golang, is born to bridge the gap between Java/Dubbo and Go/X. Please visit our [Dubbo official website](https://dubbo.apache.org/zh/docs3-v2/golang-sdk/) for the quick start and documentation. +## 设计并实现一套零信任安全机制 Review Comment: 怎么还放上中文了？用 gpt 翻一下也成哦 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Feat security [dubbo-go]
AlexStocks commented on code in PR #2643: URL: https://github.com/apache/dubbo-go/pull/2643#discussion_r1558864664 ## istio/engine/rbac_test.go: ## @@ -0,0 +1,84 @@ +package engine + +import ( Review Comment: import 写的拉胯了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] chore: Use ReentrantLock for loading Extension Classes [dubbo]
AlbumenJ commented on PR #14056: URL: https://github.com/apache/dubbo/pull/14056#issuecomment-2046566218 Seems that JDK 23 EA has resolve the pining. https://mail.openjdk.org/pipermail/loom-dev/2024-February/006433.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Feature metrics support otlp [dubbo]
AlbumenJ commented on PR #14050: URL: https://github.com/apache/dubbo/pull/14050#issuecomment-2046561806 Please merge into 3.3 branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] [Feature] Move Mesh Rule Router to SPI Extensions [dubbo]
heliang666s opened a new pull request, #14058: URL: https://github.com/apache/dubbo/pull/14058 ## What is the purpose of the change [Feature] Move Mesh Rule Router to SPI Extensions #13957 ## Brief changelog * copy all the related classes to org.apache.dubbo.rpc.cluster.configurator.parser.model ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Bug] actual protocal 【tri】，but dubbo://xxxxxxxxx:50051/org.apache.dubbo.metadata.MetadataService request ues 【dubbo】protocal，and then timeout，we do not know why？ [dubbo]
vhypnus closed issue #14054: [Bug] actual protocal 【tri】，but dubbo://x:50051/org.apache.dubbo.metadata.MetadataService request ues 【dubbo】protocal，and then timeout，we do not know why？ URL: https://github.com/apache/dubbo/issues/14054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Bug] actual protocal 【tri】，but dubbo://xxxxxxxxx:50051/org.apache.dubbo.metadata.MetadataService request ues 【dubbo】protocal，and then timeout，we do not know why？ [dubbo]
vhypnus commented on issue #14054: URL: https://github.com/apache/dubbo/issues/14054#issuecomment-2046501797 already fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Sync BitList for all the operations [dubbo]
sonarcloud[bot] commented on PR #14057: URL: https://github.com/apache/dubbo/pull/14057#issuecomment-2046499469 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=14057) **Quality Gate passed** Issues  [3 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=14057=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=14057=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=14057=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14057=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=14057) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Feature] Move Mesh Rule Router to SPI Extensions [dubbo]
AlbumenJ commented on issue #13957: URL: https://github.com/apache/dubbo/issues/13957#issuecomment-2046475598 > @AlbumenJ I remove dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/router/mesh ,but other code depend on the file.How I can solve it?add dependency in pom.xml?  How about copy all the related classes to `org.apache.dubbo.rpc.cluster.configurator.parser.model` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Feature/竞赛/跨集群 [dubbo-kubernetes]
chickenlj merged PR #254: URL: https://github.com/apache/dubbo-kubernetes/pull/254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] 精简代码, 删除冗余部分 [dubbo-kubernetes]
chickenlj merged PR #256: URL: https://github.com/apache/dubbo-kubernetes/pull/256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] Update scenarioTimeout to 600 [dubbo-integration-cases]
AlbumenJ opened a new pull request, #21: URL: https://github.com/apache/dubbo-integration-cases/pull/21 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Update scenarioTimeout to 600 [dubbo-integration-cases]
AlbumenJ merged PR #21: URL: https://github.com/apache/dubbo-integration-cases/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
(dubbo-samples) branch master updated: Update scenarioTimeout to 600 (#1129)
This is an automated email from the ASF dual-hosted git repository. albumenj pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git The following commit(s) were added to refs/heads/master by this push: new f82f23f3f Update scenarioTimeout to 600 (#1129) f82f23f3f is described below commit f82f23f3fbb4a47eaeba8b7eecfef85318adf6db Author: Albumen Kevin AuthorDate: Wed Apr 10 11:13:37 2024 +0800 Update scenarioTimeout to 600 (#1129) --- 2-advanced/dubbo-samples-seata/case-configuration.yml | 2 +- .../dubbo-servicediscovery-migration/case-configuration.yml | 2 +- .../dubbo-samples-configcenter-apollo/case-configuration.yml| 2 +- .../dubbo-samples-nacos-conditionrouter/case-configuration.yml | 2 +- .../dubbo-samples-nacos-configcenter/case-configuration.yml | 2 +- .../dubbo-samples-nacos-override/case-configuration.yml | 2 +- .../dubbo-samples-nacos-registry/case-configuration.yml | 2 +- .../dubbo-samples-nacos-tagrouter/case-configuration.yml| 2 +- .../main/java/org/apache/dubbo/scenario/builder/ConfigurationImpl.java | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/2-advanced/dubbo-samples-seata/case-configuration.yml b/2-advanced/dubbo-samples-seata/case-configuration.yml index 7a18160a5..cebeae6a2 100644 --- a/2-advanced/dubbo-samples-seata/case-configuration.yml +++ b/2-advanced/dubbo-samples-seata/case-configuration.yml @@ -14,7 +14,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -timeout: 300 +timeout: 600 # global system props for all service systemProps: diff --git a/2-advanced/dubbo-samples-service-discovery/dubbo-servicediscovery-migration/case-configuration.yml b/2-advanced/dubbo-samples-service-discovery/dubbo-servicediscovery-migration/case-configuration.yml index a5c3ab13d..771badc0a 100644 --- a/2-advanced/dubbo-samples-service-discovery/dubbo-servicediscovery-migration/case-configuration.yml +++ b/2-advanced/dubbo-samples-service-discovery/dubbo-servicediscovery-migration/case-configuration.yml @@ -14,7 +14,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -timeout: 240 +timeout: 600 services: zookeeper: diff --git a/3-extensions/configcenter/dubbo-samples-configcenter-apollo/case-configuration.yml b/3-extensions/configcenter/dubbo-samples-configcenter-apollo/case-configuration.yml index 4a47be43f..ad1e1ccb2 100644 --- a/3-extensions/configcenter/dubbo-samples-configcenter-apollo/case-configuration.yml +++ b/3-extensions/configcenter/dubbo-samples-configcenter-apollo/case-configuration.yml @@ -14,7 +14,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -timeout: 300 +timeout: 600 services: dubbo-samples-configcenter-apollo: diff --git a/3-extensions/registry/dubbo-samples-nacos/dubbo-samples-nacos-conditionrouter/case-configuration.yml b/3-extensions/registry/dubbo-samples-nacos/dubbo-samples-nacos-conditionrouter/case-configuration.yml index fa3465c85..b48c734db 100644 --- a/3-extensions/registry/dubbo-samples-nacos/dubbo-samples-nacos-conditionrouter/case-configuration.yml +++ b/3-extensions/registry/dubbo-samples-nacos/dubbo-samples-nacos-conditionrouter/case-configuration.yml @@ -14,7 +14,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -timeout: 300 +timeout: 600 services: nacos: diff --git a/3-extensions/registry/dubbo-samples-nacos/dubbo-samples-nacos-configcenter/case-configuration.yml b/3-extensions/registry/dubbo-samples-nacos/dubbo-samples-nacos-configcenter/case-configuration.yml index 67bc3ba67..649bc7d2d 100644 --- a/3-extensions/registry/dubbo-samples-nacos/dubbo-samples-nacos-configcenter/case-configuration.yml +++ b/3-extensions/registry/dubbo-samples-nacos/dubbo-samples-nacos-configcenter/case-configuration.yml @@ -14,7 +14,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -timeout: 300 +timeout: 600 services: nacos: diff --git a/3-extensions/registry/dubbo-samples-nacos/dubbo-samples-nacos-override/case-configuration.yml b/3-extensions/registry/dubbo-samples-nacos/dubbo-samples-nacos-override/case-configuration.yml index 4c4201c9d..42a028a33 100644 --- a/3-extensions/registry/dubbo-samples-nacos/dubbo-samples-nacos-override/case-configuration.yml +++ b/3-extensions/registry/dubbo-samples-nacos/dubbo-samples-nacos-override/case-configuration.yml @@ -14,7 +14,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -timeout: 300 +timeout: 600 services: nacos: diff --git
Re: [PR] Update scenarioTimeout to 600 [dubbo-samples]
AlbumenJ merged PR #1129: URL: https://github.com/apache/dubbo-samples/pull/1129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] Update scenarioTimeout to 600 [dubbo-samples]
AlbumenJ opened a new pull request, #1129: URL: https://github.com/apache/dubbo-samples/pull/1129 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] fix: Server return with Attachment (#2641) [dubbo-go]
sonarcloud[bot] commented on PR #2648: URL: https://github.com/apache/dubbo-go/pull/2648#issuecomment-2046447978 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go=2648) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go=2648=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go=2648=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go=2648=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go=2648) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Sync BitList for all the operations [dubbo]
sonarcloud[bot] commented on PR #14057: URL: https://github.com/apache/dubbo/pull/14057#issuecomment-2046437125 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=14057) **Quality Gate passed** Issues  [3 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=14057=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=14057=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=14057=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14057=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=14057) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] fix: dubbo-registry-dns resource leak [dubbo-spi-extensions]
aofall opened a new pull request, #308: URL: https://github.com/apache/dubbo-spi-extensions/pull/308 ## What is the purpose of the change fix #180 1. fix netty resource leak in [issue comment description](https://github.com/apache/dubbo-spi-extensions/issues/180#issuecomment-1340658857) 2. add try catch for `getInstance()` ## Brief changelog 1. fix netty resource leak 2. add try catch for `getInstance()` ## Verifying this change X Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Feat security [dubbo-go]
sonarcloud[bot] commented on PR #2643: URL: https://github.com/apache/dubbo-go/pull/2643#issuecomment-2046313538 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go=2643) **Quality Gate failed** Failed conditions  [C Security Rating on New Code](https://sonarcloud.io/dashboard?id=apache_dubbo-go=2643) (required ≥ A) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go=2643) ##  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Bump com.alibaba.nacos:nacos-client from 2.3.1 to 2.3.2 [dubbo]
AlbumenJ merged PR #14042: URL: https://github.com/apache/dubbo/pull/14042 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Bug] The triple protocol is called through http, and the return value is incorrect [dubbo]
crazyStar00 commented on issue #14023: URL: https://github.com/apache/dubbo/issues/14023#issuecomment-2046270157 > This is a peculiar issue. If you've configured the Triple protocol, you should be using it for communication instead of using another protocol like HTTP. http call also uses the triple protocol ；dubbo version : 3.3.0-beta.2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] Sync BitList for all the operations [dubbo]
AlbumenJ opened a new pull request, #14057: URL: https://github.com/apache/dubbo/pull/14057 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Task] All samples are entirely switched to SpringBoot3 [dubbo]
chi3316 commented on issue #13862: URL: https://github.com/apache/dubbo/issues/13862#issuecomment-2046248472 2-advanced/dubbo-samples-springcloud -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Task #13958 Move Rest Protocol to SPI Extensions [dubbo]
songxiaosheng commented on PR #14055: URL: https://github.com/apache/dubbo/pull/14055#issuecomment-2046204985  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] chore: Use ReentrantLock for loading Extension Classes [dubbo]
sonarcloud[bot] commented on PR #14056: URL: https://github.com/apache/dubbo/pull/14056#issuecomment-2045742269 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=14056) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=14056=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=14056=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=14056=false=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14056=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14056=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=14056) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] chore: Use ReentrantLock for loading Extension Classes [dubbo]
He-Pin opened a new pull request, #14056: URL: https://github.com/apache/dubbo/pull/14056 ## What is the purpose of the change ```java Thread[#537,ForkJoinPool-1-worker-1,5,CarrierThreads] java.base/java.lang.VirtualThread$VThreadContinuation.onPinned(VirtualThread.java:183) java.base/jdk.internal.vm.Continuation.onPinned0(Continuation.java:393) java.base/java.lang.VirtualThread.park(VirtualThread.java:582) java.base/java.lang.System$2.parkVirtualThread(System.java:2643) java.base/jdk.internal.misc.VirtualThreads.park(VirtualThreads.java:54) java.base/java.util.concurrent.locks.LockSupport.park(LockSupport.java:219) java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:754) java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1099) java.base/java.util.concurrent.CountDownLatch.await(CountDownLatch.java:230) org.apache.dubbo.common.utils.ClassLoaderResourceLoader.loadResources(ClassLoaderResourceLoader.java:58) org.apache.dubbo.common.extension.ExtensionLoader.loadDirectoryInternal(ExtensionLoader.java:1051) org.apache.dubbo.common.extension.ExtensionLoader.loadDirectory(ExtensionLoader.java:974) org.apache.dubbo.common.extension.ExtensionLoader.loadExtensionClasses(ExtensionLoader.java:962) org.apache.dubbo.common.extension.ExtensionLoader.getExtensionClasses(ExtensionLoader.java:939) <== monitors:1 org.apache.dubbo.common.extension.ExtensionLoader.getSupportedExtensions(ExtensionLoader.java:601) org.apache.dubbo.common.extension.ExtensionLoader.getSupportedExtensionInstances(ExtensionLoader.java:608) com.taobao.hsf.threadpool.ThreadCleanUpUtil.(ThreadCleanUpUtil.java:15) com.taobao.hsf.message.HSFServerHandler.beforeThreadExecuteCleanUp(HSFServerHandler.java:279) com.taobao.hsf.message.HSFServerHandler.access$000(HSFServerHandler.java:42) com.taobao.hsf.message.HSFServerHandler$RequestHandler.run(HSFServerHandler.java:122) com.taobao.wireless.amp.log.util.LogAwareEagleAsyncRunnable.run(LogAwareEagleAsyncRunnable.java:33) java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) java.base/java.lang.VirtualThread.run(VirtualThread.java:309) ``` ## Brief changelog Make use of `ReentrantLock` to load extension classes. ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Bug] The triple protocol is called through http, and the return value is incorrect [dubbo]
cnzakii commented on issue #14023: URL: https://github.com/apache/dubbo/issues/14023#issuecomment-2045453467 This is a peculiar issue. If you've configured the Triple protocol, you should be using it for communication instead of using another protocol like HTTP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Add corresponding tab(Form View Tab and YAML View Tab) for all routing modules under traffic control module. [dubbo-kubernetes]
chickenlj merged PR #246: URL: https://github.com/apache/dubbo-kubernetes/pull/246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] improve service pages [dubbo-kubernetes]
chickenlj merged PR #258: URL: https://github.com/apache/dubbo-kubernetes/pull/258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Feature metrics support otlp [dubbo]
glmapper commented on PR #14050: URL: https://github.com/apache/dubbo/pull/14050#issuecomment-2045339953 > Can we add a case to the dubbo sample repository Okay -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] dubbo-serialization-kryo:1.0.0中依赖的dubbo-common-extensions为SNAPSHOT版本 [dubbo-spi-extensions]
aofall commented on issue #173: URL: https://github.com/apache/dubbo-spi-extensions/issues/173#issuecomment-2045271573 dubbo-spi-extensions has been released the version of 3.2.0, compatible with Dubbo 3.2.x You can find the extension in maven central repository what you need and try it. ``` org.apache.dubbo.extensions dubbo-serialization-kryo 3.2.0 ``` https://central.sonatype.com/artifact/org.apache.dubbo.extensions/dubbo-serialization-kryo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] 请更新1.0.4到mvn 仓库。 [dubbo-spi-extensions]
aofall commented on issue #194: URL: https://github.com/apache/dubbo-spi-extensions/issues/194#issuecomment-2045268611 dubbo-spi-extensions has been released the version of 3.2.0, compatible with Dubbo 3.2.x You can find the extension in maven central repository what you need and try it. ``` org.apache.dubbo.extensions dubbo-registry-consul 3.2.0 ``` https://central.sonatype.com/artifact/org.apache.dubbo.extensions/dubbo-registry-consul -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] dubbo 3.0 etcd注册中心合并 [dubbo-spi-extensions]
aofall commented on issue #120: URL: https://github.com/apache/dubbo-spi-extensions/issues/120#issuecomment-2045236814 dubbo-spi-extensions has been released the version of 3.2.0, compatible with Dubbo 3.2.x You can find the extension in maven central repository what you need and try it. ``` org.apache.dubbo.extensions dubbo-registry-etcd3 3.2.0 ``` https://central.sonatype.com/artifact/org.apache.dubbo.extensions/dubbo-registry-etcd3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] dubbo-spi-extensions 1.0.3 版本 maven jar包拉取不来，1.0.1 的可以， 1.0.3 已经发布很久了 [dubbo-spi-extensions]
aofall commented on issue #206: URL: https://github.com/apache/dubbo-spi-extensions/issues/206#issuecomment-2045232119 dubbo-spi-extensions has been released the version of 3.2.0, compatible with Dubbo 3.2.x You can find the extension in maven central repository what you need and try it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] feat:remove old zookeeper [dubbo]
Stellar1999 commented on code in PR #14028:
URL: https://github.com/apache/dubbo/pull/14028#discussion_r1557608452
##
dubbo-remoting/dubbo-remoting-zookeeper-api/src/main/java/org/apache/dubbo/remoting/zookeeper/ZookeeperTransporter.java:
##
@@ -27,16 +27,14 @@ public interface ZookeeperTransporter {
String CURATOR_5 = "curator5";
-String CURATOR = "curator";
-
ZookeeperClient connect(URL url);
void destroy();
static ZookeeperTransporter getExtension(ApplicationModel
applicationModel) {
ExtensionLoader extensionLoader =
applicationModel.getExtensionLoader(ZookeeperTransporter.class);
-return isHighVersionCurator() ?
extensionLoader.getExtension(CURATOR_5) : extensionLoader.getExtension(CURATOR);
+return extensionLoader.getExtension(CURATOR_5);
Review Comment:
Please take another look. Thanks for your guidance. @CrazyHZM
If it's alright, I will fix the sample test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] feat:remove old zookeeper [dubbo]
sonarcloud[bot] commented on PR #14028: URL: https://github.com/apache/dubbo/pull/14028#issuecomment-2045139768 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=14028) **Quality Gate passed** Issues  [36 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=14028=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=14028=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=14028=false=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14028=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14028=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=14028) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Feature metrics support otlp [dubbo]
songxiaosheng commented on PR #14050: URL: https://github.com/apache/dubbo/pull/14050#issuecomment-2045092257 Can we add a case to the dubbo sample repository -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Task #13958 Move Rest Protocol to SPI Extensions [dubbo]
songxiaosheng commented on PR #14055: URL: https://github.com/apache/dubbo/pull/14055#issuecomment-2045089946 please fix ci problem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] Task #13958 Move Rest Protocol to SPI Extensions [dubbo]
wcy666103 opened a new pull request, #14055: URL: https://github.com/apache/dubbo/pull/14055 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[I] [Bug] actual protocal 【tri】，but dubbo://xxxxxxxxx:50051/org.apache.dubbo.metadata.MetadataService request ues 【dubbo】protocal，and then timeout，we do not know why？ [dubbo]
vhypnus opened a new issue, #14054: URL: https://github.com/apache/dubbo/issues/14054 ### Pre-check - [X] I am sure that all the content I provide is in English. ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dubbo/issues?q=is%3Aissue) and found no similar issues. ### Apache Dubbo Component Java SDK (apache/dubbo) ### Dubbo Version 3.2.5 ### Steps to reproduce this issue 以下是配置信息 nacos: config: server-addr: x namespace: xxx-f1459f0956d0 data-ids: xx,xx group: xxx type: yaml auto-refresh: true bootstrap: enable: true log: enable: true username: password: x dubbo: registries: idRegistry: address: nacos://1xx:8848,10.148.0.9:8848?username=xxx=x register-mode: instance group: -x parameters.namespace: x protocol: name: tri port: -1 consumer: check: false retries: 0 timeout: 3 metrics: protocol: prometheus enable-jvm: true enable-metadata: true enable-registry: true enable-rpc: true enable-threadpool: true aggregation: enabled: true prometheus: exporter: enabled: true 以下是异常信息 2024-03-27 16:19:35.745 ERROR 2515 --- [Dubbo-framework-metadata-retry-thread-1] o.a.d.r.client.metadata.MetadataUtils : [DUBBO] Failed to get app metadata for revision d53353ed39151ea19ab50bff2f9dc0b5 for type local from instance 10.184.0.42:50051, dubbo version: 3.2.5, current host: 10.184.0.48, error code: 1-39. This may be caused by , go to https://dubbo.apache.org/faq/1/39 to find instructions. org.apache.dubbo.rpc.RpcException: Invoke remote method timeout. method: getMetadataInfo, provider: dubbo://x:50051/org.apache.dubbo.metadata.MetadataService?getAndListenInstanceMetadata.1.callback=true=pay-api-trade=false=0=consumer=5000=1.0.0, cause: Timeout after 5000ms waiting for result. at org.apache.dubbo.rpc.protocol.AbstractInvoker.waitForResultIfSync(AbstractInvoker.java:304) ~[dubbo-3.2.5.jar!/:3.2.5] at org.apache.dubbo.rpc.protocol.AbstractInvoker.invoke(AbstractInvoker.java:190) ~[dubbo-3.2.5.jar!/:3.2.5] at org.apache.dubbo.rpc.proxy.InvocationUtil.invoke(InvocationUtil.java:61) ~[dubbo-3.2.5.jar!/:3.2.5] at org.apache.dubbo.rpc.proxy.InvokerInvocationHandler.invoke(InvokerInvocationHandler.java:75) ~[dubbo-3.2.5.jar!/:3.2.5] at org.apache.dubbo.metadata.MetadataServiceDubboProxy31.getMetadataInfo(MetadataServiceDubboProxy31.java) ~[dubbo-3.2.5.jar!/:3.2.5] at org.apache.dubbo.registry.client.metadata.MetadataUtils.getRemoteMetadata(MetadataUtils.java:173) ~[dubbo-3.2.5.jar!/:3.2.5] at org.apache.dubbo.registry.client.AbstractServiceDiscovery.lambda$getRemoteMetadata$2(AbstractServiceDiscovery.java:229) [dubbo-3.2.5.jar!/:3.2.5] at org.apache.dubbo.metrics.event.MetricsEventBus.post(MetricsEventBus.java:90) ~[dubbo-3.2.5.jar!/:3.2.5] at org.apache.dubbo.registry.client.AbstractServiceDiscovery.getRemoteMetadata(AbstractServiceDiscovery.java:228) [dubbo-3.2.5.jar!/:3.2.5] at org.apache.dubbo.registry.client.event.listener.ServiceInstancesChangedListener.lambda$doOnEvent$2(ServiceInstancesChangedListener.java:162) ~[dubbo-3.2.5.jar!/:3.2.5] at java.util.Optional.orElseGet(Optional.java:267) ~[na:1.8.0_181] at org.apache.dubbo.registry.client.event.listener.ServiceInstancesChangedListener.doOnEvent(ServiceInstancesChangedListener.java:162) ~[dubbo-3.2.5.jar!/:3.2.5] at org.apache.dubbo.registry.client.event.listener.ServiceInstancesChangedListener.onEvent(ServiceInstancesChangedListener.java:116) ~[dubbo-3.2.5.jar!/:3.2.5] at org.apache.dubbo.registry.client.event.listener.ServiceInstancesChangedListener$AddressRefreshRetryTask.run(ServiceInstancesChangedListener.java:489) ~[dubbo-3.2.5.jar!/:3.2.5] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[na:1.8.0_181] at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[na:1.8.0_181] at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) ~[na:1.8.0_181] at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) ~[na:1.8.0_181] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[na:1.8.0_181] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[na:1.8.0_181] at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_181] Caused by: java.util.concurrent.TimeoutException: Timeout after 5000ms
Re: [PR] feat:remove old zookeeper [dubbo]
sonarcloud[bot] commented on PR #14028: URL: https://github.com/apache/dubbo/pull/14028#issuecomment-2044651247 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=14028) **Quality Gate passed** Issues  [36 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=14028=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=14028=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=14028=false=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14028=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14028=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=14028) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] feat:remove old zookeeper [dubbo]
sonarcloud[bot] commented on PR #14028: URL: https://github.com/apache/dubbo/pull/14028#issuecomment-2044631876 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=14028) **Quality Gate passed** Issues  [36 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=14028=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=14028=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=14028=false=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14028=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14028=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=14028) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] feat:remove old zookeeper [dubbo]
sonarcloud[bot] commented on PR #14028: URL: https://github.com/apache/dubbo/pull/14028#issuecomment-2044492900 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=14028) **Quality Gate passed** Issues  [34 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=14028=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=14028=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=14028=false=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14028=new_coverage=list)  [2.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14028=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=14028) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Feature][3.3] Triple rest path match support case insensitive [dubbo]
oxsean commented on issue #13967: URL: https://github.com/apache/dubbo/issues/13967#issuecomment-2044411290 @qyi71 Sorry, I'm already working on it. The url match of triple rest is case-sensitive by default and needs to support case-insensitive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] Is it correct to continue to maintain the connection pool when a connection encounters an error? [dubbo-getty]
No-SilverBullet commented on issue #116: URL: https://github.com/apache/dubbo-getty/issues/116#issuecomment-2044399937 > > > Getty 中 session 代表一个网络连接，client 其实是一个网络连接池，维护一定数量的连接 session，这个数量当然是用户设定的。Getty client 初始版本【2018 年以前的版本】中，每个 client 单独启动一个 goroutine 轮询检测其连接池中 session 数量，如果没有达到用户设定的连接数量就向 server 发起新连接。 > > > 当 client 与 server 连接断开时，server 可能是被下线了，可能是意外退出，也有可能是假死。如果上层用户判定对端 server 确实不存在【如收到注册中心发来的 server 下线通知】后，调用 client.Close () 接口把连接池关闭掉。如果上层用户没有调用这个接口把连接池关闭掉，client 就认为对端地址还有效，就会不断尝试发起重连，维护连接池。 > > > 综上，从一个旧 session 关闭到创建一个新 session，getty client 初始版本的重连处理流程是： > > > 1 旧 session 关闭网络接收 goroutine； > > > 2 旧 session 网络发送 goroutine 探测到 网络接收 goroutine 退出后终止网络发送，进行资源回收后设定当前 session 无效； > > > 3 client 的轮询 goroutine 检测到无效 session 后把它从 session 连接池删除； > > > 4 client 的轮询 goroutine 检测到有效 session 数目少于 getty 上层使用者设定的数目 且 getty 上层使用者没有通过 client.Close () 接口关闭连接池时，就调用连接接口发起新连接。 > > > 上面这种通过定时轮询方式不断查验 client 中 session pool 中每个 session 有效性的方式，可称之为主动连接。主动连接的缺点显然是每个 client 都需要单独启用一个 goroutine。当然，其进一步优化手段之一是可以启动一个全局的 goroutine，定时轮询检测所有 client 的 session pool，不必每个 client 单独启动一个 goroutine。但是个人从 2016 年开始一直在思考一个问题：能否换一种 session pool 维护方式，去掉定时轮询机制，完全不使用任何的 goroutine 维护每个 client 的 session pool？ > > > 2018 年 5 月个人在一次午饭后遛弯时，把 getty client 的重连逻辑又重新梳理了一遍，突然想到了另一种方法，在步骤 2 中完全可以对 网络发送 goroutine 进行 “废物利用”，在这个 goroutine 标记当前 session 无效的逻辑步骤之后再加上一个逻辑： > > > 1 如果当前 session 的维护者是一个 client【因为 session 的使用者也可能是 server】； > > > 2 且如果其当前 session pool 的 session 数量少于上层使用者设定的 session number； > > > 3 且如果上层使用者还没有通过 client.Close () 设定当前 session pool 无效【即当前 session pool 有效，或者说是对端 server 有效】 > > > 4 满足上面三个条件，网络发送 goroutine 执行连接重连即可； > > > 5 新网络连接 session 建立成功且被加入 client 的 session pool 后，网络发送 goroutine 使命完成直接退出。 > > > 我把这种重连方式称之为 lazy reconnect，网络发送 goroutine 在其生命周期的最后阶段应该被称之为 网络重连 goroutine。通过 lazy reconnect 这种方式，上述重连步骤 3 和 步骤 4 的逻辑被合入了步骤 2，client 当然也就没必要再启动一个额外的 goroutine 通过定时轮询的方式维护其 session pool 了。 > > >  > > > lazy reconnect 整体流程图如上。如果对相关代码流程感兴趣，请移步 "参考 13" 给出的链接，很容易自行分析出来。 > > > 以上内容来自 [Go 语言网络库 getty 的那些事](https://mp.weixin.qq.com/s/z22k-E2ybjAMNtxzj5Aikw) 第三章。 > > > 你先理解下，如果觉得机制不合理，我们可以在这个 issue 里面继续聊。 > > > > > > 你好，感谢回复。在一个 session 失效之前去触发重连的逻辑，这种设计没有任何问题，可以节约 goroutine。但是，如果连接存在问题，会持续的去重连，我的理解是这种行为是不合理的，会给客户端以及服务端都造成压力。这里对于无效 session 的区分是不是可以更细一点呢，当连接出现问题的时候就不再去重连。 > > 当然可以，你能否构思下，哪些 error 可以让我们明确不再执行 reConnect? 上面回复中我表达的连接出现“错误“不太准确，这里对于传输层来说，很难去区分上层应用的错误。我想表达的是，当服务端主动断开连接这种情况（服务端发起FIN），是不是就代表着客户端不要再去重连维护这个连接池了呢 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] 请问支持服务注册发现、负载均衡等服务治理能力吗？ [dubbo-js]
mrwangyin closed issue #390: 请问支持服务注册发现、负载均衡等服务治理能力吗？ URL: https://github.com/apache/dubbo-js/issues/390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] feat:remove old zookeeper [dubbo]
sonarcloud[bot] commented on PR #14028: URL: https://github.com/apache/dubbo/pull/14028#issuecomment-2044380532 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=14028) **Quality Gate passed** Issues  [17 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=14028=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=14028=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=14028=false=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14028=new_coverage=list)  [3.8% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14028=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=14028) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Feature metrics support otlp [dubbo]
sonarcloud[bot] commented on PR #14050: URL: https://github.com/apache/dubbo/pull/14050#issuecomment-2044373542 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=14050) **Quality Gate passed** Issues  [5 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=14050=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=14050=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=14050=false=true)  [47.7% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14050=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14050=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=14050) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] Is it correct to continue to maintain the connection pool when a connection encounters an error? [dubbo-getty]
AlexStocks commented on issue #116: URL: https://github.com/apache/dubbo-getty/issues/116#issuecomment-2044340111 > > Getty 中 session 代表一个网络连接，client 其实是一个网络连接池，维护一定数量的连接 session，这个数量当然是用户设定的。Getty client 初始版本【2018 年以前的版本】中，每个 client 单独启动一个 goroutine 轮询检测其连接池中 session 数量，如果没有达到用户设定的连接数量就向 server 发起新连接。 > > 当 client 与 server 连接断开时，server 可能是被下线了，可能是意外退出，也有可能是假死。如果上层用户判定对端 server 确实不存在【如收到注册中心发来的 server 下线通知】后，调用 client.Close () 接口把连接池关闭掉。如果上层用户没有调用这个接口把连接池关闭掉，client 就认为对端地址还有效，就会不断尝试发起重连，维护连接池。 > > 综上，从一个旧 session 关闭到创建一个新 session，getty client 初始版本的重连处理流程是： > > 1 旧 session 关闭网络接收 goroutine； > > 2 旧 session 网络发送 goroutine 探测到 网络接收 goroutine 退出后终止网络发送，进行资源回收后设定当前 session 无效； > > 3 client 的轮询 goroutine 检测到无效 session 后把它从 session 连接池删除； > > 4 client 的轮询 goroutine 检测到有效 session 数目少于 getty 上层使用者设定的数目 且 getty 上层使用者没有通过 client.Close () 接口关闭连接池时，就调用连接接口发起新连接。 > > 上面这种通过定时轮询方式不断查验 client 中 session pool 中每个 session 有效性的方式，可称之为主动连接。主动连接的缺点显然是每个 client 都需要单独启用一个 goroutine。当然，其进一步优化手段之一是可以启动一个全局的 goroutine，定时轮询检测所有 client 的 session pool，不必每个 client 单独启动一个 goroutine。但是个人从 2016 年开始一直在思考一个问题：能否换一种 session pool 维护方式，去掉定时轮询机制，完全不使用任何的 goroutine 维护每个 client 的 session pool？ > > 2018 年 5 月个人在一次午饭后遛弯时，把 getty client 的重连逻辑又重新梳理了一遍，突然想到了另一种方法，在步骤 2 中完全可以对 网络发送 goroutine 进行 “废物利用”，在这个 goroutine 标记当前 session 无效的逻辑步骤之后再加上一个逻辑： > > 1 如果当前 session 的维护者是一个 client【因为 session 的使用者也可能是 server】； > > 2 且如果其当前 session pool 的 session 数量少于上层使用者设定的 session number； > > 3 且如果上层使用者还没有通过 client.Close () 设定当前 session pool 无效【即当前 session pool 有效，或者说是对端 server 有效】 > > 4 满足上面三个条件，网络发送 goroutine 执行连接重连即可； > > 5 新网络连接 session 建立成功且被加入 client 的 session pool 后，网络发送 goroutine 使命完成直接退出。 > > 我把这种重连方式称之为 lazy reconnect，网络发送 goroutine 在其生命周期的最后阶段应该被称之为 网络重连 goroutine。通过 lazy reconnect 这种方式，上述重连步骤 3 和 步骤 4 的逻辑被合入了步骤 2，client 当然也就没必要再启动一个额外的 goroutine 通过定时轮询的方式维护其 session pool 了。 > >  > > lazy reconnect 整体流程图如上。如果对相关代码流程感兴趣，请移步 "参考 13" 给出的链接，很容易自行分析出来。 > > 以上内容来自 [Go 语言网络库 getty 的那些事](https://mp.weixin.qq.com/s/z22k-E2ybjAMNtxzj5Aikw) 第三章。 > > 你先理解下，如果觉得机制不合理，我们可以在这个 issue 里面继续聊。 > > 你好，感谢回复。在一个 session 失效之前去触发重连的逻辑，这种设计没有任何问题，可以节约 goroutine。但是，如果连接存在问题，会持续的去重连，我的理解是这种行为是不合理的，会给客户端以及服务端都造成压力。这里对于无效 session 的区分是不是可以更细一点呢，当连接出现问题的时候就不再去重连。 当然可以，你能否构思下，哪些 error 可以让我们明确不再执行 reConnect? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] Is it correct to continue to maintain the connection pool when a connection encounters an error? [dubbo-getty]
No-SilverBullet commented on issue #116: URL: https://github.com/apache/dubbo-getty/issues/116#issuecomment-2044282547 > Getty 中 session 代表一个网络连接，client 其实是一个网络连接池，维护一定数量的连接 session，这个数量当然是用户设定的。Getty client 初始版本【2018 年以前的版本】中，每个 client 单独启动一个 goroutine 轮询检测其连接池中 session 数量，如果没有达到用户设定的连接数量就向 server 发起新连接。 > > 当 client 与 server 连接断开时，server 可能是被下线了，可能是意外退出，也有可能是假死。如果上层用户判定对端 server 确实不存在【如收到注册中心发来的 server 下线通知】后，调用 client.Close() 接口把连接池关闭掉。如果上层用户没有调用这个接口把连接池关闭掉，client 就认为对端地址还有效，就会不断尝试发起重连，维护连接池。 > > 综上，从一个旧 session 关闭到创建一个新 session，getty client 初始版本的重连处理流程是： > > 1 旧 session 关闭网络接收 goroutine； > > 2 旧 session 网络发送 goroutine 探测到 网络接收 goroutine 退出后终止网络发送，进行资源回收后设定当前 session 无效； > > 3 client 的轮询 goroutine 检测到无效 session 后把它从 session 连接池删除； > > 4 client 的轮询 goroutine 检测到有效 session 数目少于 getty 上层使用者设定的数目 且 getty 上层使用者没有通过 client.Close() 接口关闭连接池时，就调用连接接口发起新连接。 > > 上面这种通过定时轮询方式不断查验 client 中 session pool 中每个 session 有效性的方式，可称之为主动连接。主动连接的缺点显然是每个 client 都需要单独启用一个 goroutine。当然，其进一步优化手段之一是可以启动一个全局的 goroutine，定时轮询检测所有 client 的 session pool，不必每个 client 单独启动一个 goroutine。但是个人从 2016 年开始一直在思考一个问题：能否换一种 session pool 维护方式，去掉定时轮询机制，完全不使用任何的 goroutine 维护每个 client 的 session pool？ > > 2018 年 5 月个人在一次午饭后遛弯时，把 getty client 的重连逻辑又重新梳理了一遍，突然想到了另一种方法，在步骤 2 中完全可以对 网络发送 goroutine 进行 “废物利用”，在这个 goroutine 标记当前 session 无效的逻辑步骤之后再加上一个逻辑： > > 1 如果当前 session 的维护者是一个 client【因为 session 的使用者也可能是 server】； > > 2 且如果其当前 session pool 的 session 数量少于上层使用者设定的 session number； > > 3 且如果上层使用者还没有通过 client.Close() 设定当前 session pool 无效【即当前 session pool 有效，或者说是对端 server 有效】 > > 4 满足上面三个条件，网络发送 goroutine 执行连接重连即可； > > 5 新网络连接 session 建立成功且被加入 client 的 session pool 后，网络发送 goroutine 使命完成直接退出。 > > 我把这种重连方式称之为 lazy reconnect，网络发送 goroutine 在其生命周期的最后阶段应该被称之为 网络重连 goroutine。通过 lazy reconnect这种方式，上述重连步骤 3 和 步骤 4 的逻辑被合入了步骤 2，client 当然也就没必要再启动一个额外的 goroutine 通过定时轮询的方式维护其 session pool 了。 > >  > > lazy reconnect 整体流程图如上。如果对相关代码流程感兴趣，请移步 "参考 13" 给出的链接，很容易自行分析出来。 > > 以上内容来自 [Go 语言网络库 getty 的那些事](https://mp.weixin.qq.com/s/z22k-E2ybjAMNtxzj5Aikw) 第三章。 > > 你先理解下，如果觉得机制不合理，我们可以在这个 issue 里面继续聊。 你好，感谢回复。在一个session失效之前去触发重连的逻辑，这种设计没有任何问题，可以节约goroutine。但是，如果连接存在问题，会持续的去重连，我的理解是这种行为是不合理的，会给客户端以及服务端都造成压力。这里对于无效session的区分是不是可以更细一点呢，当连接出现问题的时候就不再去重连。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] Is it correct to continue to maintain the connection pool when a connection encounters an error? [dubbo-getty]
AlexStocks commented on issue #116: URL: https://github.com/apache/dubbo-getty/issues/116#issuecomment-2044274633 Getty's session in the initial version (prior to 2018) represents a network connection, and the client is actually a network connection pool that maintains a certain number of session connections, which is determined by the user. In the initial version of Getty client, each client starts a separate goroutine to periodically check the session pool's connection count. If the count does not reach the user-defined connection quantity, a new connection request is made to the server. When the client's connection to the server is disconnected, it could be due to the server being offline, unexpectedly terminated, or stuck. If the upper-layer user confirms that the server does not exist (e.g., receiving a server offline notification from the registry), they can call the client.Close() interface to close the connection pool. If the upper-layer user does not call this interface to close the connection pool, the client assumes that the remote address is still valid and continues to attempt reconnection to maintain the connection pool. In summary, the process of closing an old session and creating a new session in the initial version of Getty client's reconnection handling is as follows: The network receiving goroutine of the old session is closed. The network sending goroutine of the old session detects the exit of the network receiving goroutine, terminates the network sending, performs resource cleanup, and marks the current session as invalid. The client's polling goroutine detects the invalid session and removes it from the session connection pool. The client's polling goroutine detects that the number of valid sessions is less than the user-defined quantity and the connection pool has not been closed through the client.Close() interface, and then initiates a new connection. The above approach, which continuously checks the validity of each session in the session pool through periodic polling, is called active reconnection. The disadvantage of active reconnection is that each client needs to start a separate goroutine. One possible optimization is to start a global goroutine that periodically polls all client's session pools, instead of starting a goroutine for each client. However, since 2016, the author has been contemplating an alternative session pool maintenance method that eliminates the need for periodic polling and does not use any goroutine to maintain each client's session pool. In May 2018, the author came up with another method during a walk after lunch. In step 2, the network sending goroutine can be "reused" by adding an additional logic after marking the current session as invalid: If the current session is maintained by a client (as the session user could also be a server). If the current session pool of the client has fewer sessions than the user-defined session number. If the upper-layer user has not set the current session pool as invalid through client.Close() (meaning the current session pool is valid or, in other words, the remote server is valid). If the above three conditions are met, the network sending goroutine initiates a reconnection. After successfully establishing a new network connection session and adding it to the client's session pool, the network sending goroutine completes its mission and exits. This reconnection method is referred to as "lazy reconnect," and the network sending goroutine in its final phase can be called the "network reconnection goroutine." With lazy reconnect, the logic of step 3 and step 4 is merged into step 2, eliminating the need for the client to start an additional goroutine for periodic polling to maintain its session pool.  The overall flowchart of lazy reconnect is as described above. If you are interested in the related code flow, please refer to the link provided in "Reference 13," where you can easily analyze it yourself. The above content is from Chapter 3 of "Getty: The Story of Go Network Library." Please take some time to understand it, and if you find any flaws in the mechanism, we can continue discussing them in this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] BeanNotOfRequiredTypeException when using spring bean injection [dubbo]
huogithub commented on issue #12637: URL: https://github.com/apache/dubbo/issues/12637#issuecomment-2044274537 对比了下2.7.X与3.X org.apache.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor#registerReferenceBean 实现 同一JVM针对一个接口既是服务提供者又是消费者处理不一样 2.7.X向spring只注册了服务提供者实例，消费者只注册了别名； 3.X向spring注册了服务提供者实例，也注册了消费者实例，这样在这个容器Reference，Resource，autowired 注解混用存在很多问题； 能否参照2.7.X，只注册一个实例，消费者注册别名  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] Is it correct to continue to maintain the connection pool when a connection encounters an error? [dubbo-getty]
AlexStocks commented on issue #116: URL: https://github.com/apache/dubbo-getty/issues/116#issuecomment-2044269591 Getty 中 session 代表一个网络连接，client 其实是一个网络连接池，维护一定数量的连接 session，这个数量当然是用户设定的。Getty client 初始版本【2018 年以前的版本】中，每个 client 单独启动一个 goroutine 轮询检测其连接池中 session 数量，如果没有达到用户设定的连接数量就向 server 发起新连接。 当 client 与 server 连接断开时，server 可能是被下线了，可能是意外退出，也有可能是假死。如果上层用户判定对端 server 确实不存在【如收到注册中心发来的 server 下线通知】后，调用 client.Close() 接口把连接池关闭掉。如果上层用户没有调用这个接口把连接池关闭掉，client 就认为对端地址还有效，就会不断尝试发起重连，维护连接池。 综上，从一个旧 session 关闭到创建一个新 session，getty client 初始版本的重连处理流程是： 1 旧 session 关闭网络接收 goroutine； 2 旧 session 网络发送 goroutine 探测到 网络接收 goroutine 退出后终止网络发送，进行资源回收后设定当前 session 无效； 3 client 的轮询 goroutine 检测到无效 session 后把它从 session 连接池删除； 4 client 的轮询 goroutine 检测到有效 session 数目少于 getty 上层使用者设定的数目 且 getty 上层使用者没有通过 client.Close() 接口关闭连接池时，就调用连接接口发起新连接。 上面这种通过定时轮询方式不断查验 client 中 session pool 中每个 session 有效性的方式，可称之为主动连接。主动连接的缺点显然是每个 client 都需要单独启用一个 goroutine。当然，其进一步优化手段之一是可以启动一个全局的 goroutine，定时轮询检测所有 client 的 session pool，不必每个 client 单独启动一个 goroutine。但是个人从 2016 年开始一直在思考一个问题：能否换一种 session pool 维护方式，去掉定时轮询机制，完全不使用任何的 goroutine 维护每个 client 的 session pool？ 2018 年 5 月个人在一次午饭后遛弯时，把 getty client 的重连逻辑又重新梳理了一遍，突然想到了另一种方法，在步骤 2 中完全可以对 网络发送 goroutine 进行 “废物利用”，在这个 goroutine 标记当前 session 无效的逻辑步骤之后再加上一个逻辑： 1 如果当前 session 的维护者是一个 client【因为 session 的使用者也可能是 server】； 2 且如果其当前 session pool 的 session 数量少于上层使用者设定的 session number； 3 且如果上层使用者还没有通过 client.Close() 设定当前 session pool 无效【即当前 session pool 有效，或者说是对端 server 有效】 4 满足上面三个条件，网络发送 goroutine 执行连接重连即可； 5 新网络连接 session 建立成功且被加入 client 的 session pool 后，网络发送 goroutine 使命完成直接退出。 我把这种重连方式称之为 lazy reconnect，网络发送 goroutine 在其生命周期的最后阶段应该被称之为 网络重连 goroutine。通过 lazy reconnect这种方式，上述重连步骤 3 和 步骤 4 的逻辑被合入了步骤 2，client 当然也就没必要再启动一个额外的 goroutine 通过定时轮询的方式维护其 session pool 了。  lazy reconnect 整体流程图如上。如果对相关代码流程感兴趣，请移步 "参考 13" 给出的链接，很容易自行分析出来。 from [Go 语言网络库 getty 的那些事](https://mp.weixin.qq.com/s/z22k-E2ybjAMNtxzj5Aikw) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] feat: Validator supports automatic switch [dubbo]
sonarcloud[bot] commented on PR #13923: URL: https://github.com/apache/dubbo/pull/13923#issuecomment-2044260658 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=13923) **Quality Gate passed** Issues  [4 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=13923=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=13923=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=13923=false=true)  [59.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=13923=new_coverage=list)  [43.9% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=13923=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=13923) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] Is it correct to continue to maintain the connection pool when a connection encounters an error? [dubbo-getty]
No-SilverBullet commented on issue #116: URL: https://github.com/apache/dubbo-getty/issues/116#issuecomment-2044258436 similar with this open issue https://github.com/apache/dubbo-getty/issues/105,i think should just close the client or distinguish errors encountered in handlePackage() in a more granular manner to choose whether to reconnect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[I] Is it correct to continue to maintain the connection pool when a connection encounters an error? [dubbo-getty]
No-SilverBullet opened a new issue, #116: URL: https://github.com/apache/dubbo-getty/issues/116 **What happened**: When the dubbo provider reports a connection error, such as exceeding the upper limit of provider accepts, reConnect() will cause the client to continuously reconnect, causing the client's CPU and memory to continue to increase. Here is the call chain : https://github.com/apache/dubbo-getty/assets/112961281/b80bd923-659f-4cf1-8d0c-58cc531dfada;> https://github.com/apache/dubbo-getty/assets/112961281/4360e92a-63c7-4b41-afe7-e3df136e1152;> https://github.com/apache/dubbo-getty/assets/112961281/63945990-943c-4aad-8dbe-0dad1fdfac9f;> **What you expected to happen**: I think that when there is a problem with the TCP connection, the practice of maintaining the connection pool should be temporarily stopped **How to reproduce it (as minimally and precisely as possible)**: In dubbo settings, set the getty-session-param's connection-number less than the provider's accepts will cause this problem. **Anything else we need to know?**: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Bug] The triple protocol is called through http, and the return value is incorrect [dubbo]
crazyStar00 commented on issue #14023: URL: https://github.com/apache/dubbo/issues/14023#issuecomment-2044234114 > This is a misunderstanding caused by habitual thinking, perhaps because you're accustomed to data being passed in JSON format.   > > The PojoGreeter interface definition explicitly specifies the parameter type as String. Therefore, the method receives a string as data. In the implementation class PojoGreeterImpl, the received parameter is simply concatenated. Hence, the response you obtained is completely correct. > > Below is the result obtained by calling the operation using the TriPojoClient from the provided sample, and the response matches yours exactly. > >   How should a single string parameter be passed in an http request? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] feat: Validator supports automatic switch [dubbo]
aofall closed pull request #13923: feat: Validator supports automatic switch URL: https://github.com/apache/dubbo/pull/13923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
