[I] [Bug] The actual number of connections established is twice what I configured [dubbo]
lpcy opened a new issue, #14129: URL: https://github.com/apache/dubbo/issues/14129 ### Pre-check - [X] I am sure that all the content I provide is in English. ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dubbo/issues?q=is%3Aissue) and found no similar issues. ### Apache Dubbo Component Java SDK (apache/dubbo) ### Dubbo Version Dubbo Java 3.2.5, JDK 1.8, Linux ### Steps to reproduce this issue ### provider config(spring xml) ```xml ``` ### consumer config(spring xml) ```xml ``` ### What you expected to happen After upgrading from Dubbo2 to Dubbo3.2.5, with the same configuration, the actual number of connections is twice normal, meaning that a consumer sends 14 connections to a provider. ### Anything else _No response_ ### Are you willing to submit a pull request to fix on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Triple protocol http1 upgrade support [dubbo]
walklown commented on PR #14026: URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2076455166 > Test `org.apache.dubbo.demo.provider.ApiProvider` with curl: > > ``` > curl.exe -v --http2 -k -H "Content-Type: application/json" -d '"asd"' http://127.0.0.1:50051/org.apache.dubbo.demo.GreeterService/sayHelloAsync > ``` > > but upgrade failed, could you please take a look?  Because you specified a http scheme (and not https), and asked curl to use HTTP/2, then curl will attempt to perform a HTTP/1.1 upgrade to HTTP/2, as can be seen from the logs. Typical HTTP/1.1 upgrades are performed using GET, not POST, notably the HTTP/1.1 upgrade to WebSocket. The server does not seem to be prepared to accept a POST with a body as an attempt to upgrade and replies with 413 because it does not expect a body. If you try a GET without body it will likely succeed. Alternatively, if you know that port 8889 accepts prior-knowledge clear-text HTTP/2 (that is, you can send directly HTTP/2 bytes to that port without having to perform a HTTP/1.1 upgrade), you can try: `curl -v --http2-prior-knowledge -X POST -k -H "content-type:application/json" -d '["myFirstParameter"]' http://127.0.0.1:50052/org.apache.dubbo.springboot.demo.DemoService/sayHello`  `$ curl -v --http2-prior-knowledge -X POST -k -H "content-type:application/json" -d '["myFirstParameter"]' http://127.0.0.1:50052/org.apache.dubbo.springboot.demo.DemoService/sayHello Note: Unnecessary use of -X or --request, POST is already inferred. * Trying 127.0.0.1:50052... * Connected to 127.0.0.1 (127.0.0.1) port 50052 * [HTTP/2] [1] OPENED stream for http://127.0.0.1:50052/org.apache.dubbo.springboot.demo.DemoService/sayHello * [HTTP/2] [1] [:method: POST] * [HTTP/2] [1] [:scheme: http] * [HTTP/2] [1] [:authority: 127.0.0.1:50052] * [HTTP/2] [1] [:path: /org.apache.dubbo.springboot.demo.DemoService/sayHello] * [HTTP/2] [1] [user-agent: curl/8.5.0] * [HTTP/2] [1] [accept: */*] * [HTTP/2] [1] [content-type: application/json] * [HTTP/2] [1] [content-length: 20] > POST /org.apache.dubbo.springboot.demo.DemoService/sayHello HTTP/2 > Host: 127.0.0.1:50052 > User-Agent: curl/8.5.0 > Accept: */* > content-type:application/json > Content-Length: 20 > < HTTP/2 200 < te: trailers < content-type: application/json < * Connection #0 to host 127.0.0.1 left intact "Hello myFirstParameter"` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] feat: add commit lint and husky [dubbo-js]
sonarcloud[bot] commented on PR #392: URL: https://github.com/apache/dubbo-js/pull/392#issuecomment-2076439246 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-js&pullRequest=392) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-js&pullRequest=392&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-js&pullRequest=392&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-js&pullRequest=392&resolved=false&inNewCodePeriod=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-js&pullRequest=392&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-js&pullRequest=392) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] support custom dubbo invoke retry times [dubbo-go-pixiu]
AlexStocks commented on code in PR #625:
URL: https://github.com/apache/dubbo-go-pixiu/pull/625#discussion_r1578876208
##
pkg/client/dubbo/config.go:
##
@@ -33,6 +33,8 @@ type DubboProxyConfig struct {
AutoResolve bool `yaml:"auto_resolve" json:"auto_resolve,omitempty"`
// Protoset path to load protoset files
Protoset []string `yaml:"protoset" json:"protoset,omitempty"`
- // Load
+ // Load load balance
Review Comment:
"Load load balance" 这嘛意思？去掉 load
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[I] [Bug] Dubbo Service was called failed in afterPropertiesSet while application built in native-image [dubbo]
imgoby opened a new issue, #14128:
URL: https://github.com/apache/dubbo/issues/14128
### Pre-check
- [X] I am sure that all the content I provide is in English.
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/dubbo/issues?q=is%3Aissue) and found no
similar issues.
### Apache Dubbo Component
Java SDK (apache/dubbo)
### Dubbo Version
3.3.0-beta.2
### Steps to reproduce this issue
Step 1:
```
@Configuration
@Slf4j
public class InterceptConfig implements InitializingBean {
@DubboReference
private DubboXyzService dubboXyzService ;
@Override
public void afterPropertiesSet() throws Exception {
dubboXyzService .load();
}
}
```
Step 2:
built with native-image
Step3:
Start up application
Step 4:
Exception:
Caused by: java.lang.NullPointerException: null
at
org.apache.dubbo.config.spring.reference.ReferenceBeanManager.initReferenceBean(ReferenceBeanManager.java:197)
at
org.apache.dubbo.config.spring.ReferenceBean.getCallProxy(ReferenceBean.java:440)
at
org.apache.dubbo.config.spring.ReferenceBean.access$100(ReferenceBean.java:110)
at
org.apache.dubbo.config.spring.ReferenceBean$DubboReferenceLazyInitTargetSource.getTarget(ReferenceBean.java:467)
at
org.apache.dubbo.config.spring.util.LazyTargetInvocationHandler.invoke(LazyTargetInvocationHandler.java:50)
at jdk.proxy4/jdk.proxy4.$Proxy86.loadSinkGroupList(Unknown Source)
at com.xxx.DubboXyzService .load(SinkGroupManager.java:52)
at com.xxx.InterceptConfig.afterPropertiesSet(InterceptConfig.java:47)
### What you expected to happen
NullPointerException was found.
### Anything else
Maybe :
This is dubbo source in package: org.apache.dubbo.config.spring.reference
class name: ReferenceBeanManager
I can find the ReferenceConfig is null while debuging.
### Are you willing to submit a pull request to fix on your own?
- [X] Yes I am willing to submit a pull request on my own!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Rft: Optimize the relation of metadata and headers [dubbo-rust]
yang20150702 commented on PR #193: URL: https://github.com/apache/dubbo-rust/pull/193#issuecomment-2075438701 #194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Triple protocol http1 upgrade support [dubbo]
oxsean commented on code in PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#discussion_r1578163707
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java:
##
@@ -143,13 +148,63 @@ public void configServerProtocolHandler(URL url,
ChannelOperator operator) {
}
private void configurerHttp1Handlers(URL url, List
handlers) {
-handlers.add(new ChannelHandlerPretender(new HttpServerCodec()));
+final HttpServerCodec sourceCodec = new HttpServerCodec();
+handlers.add(new ChannelHandlerPretender(sourceCodec));
+// Triple protocol http1 upgrade support
+handlers.add(new ChannelHandlerPretender(new
HttpServerUpgradeHandler(sourceCodec, protocol -> {
+if
(!AsciiString.contentEquals(Http2CodecUtil.HTTP_UPGRADE_PROTOCOL_NAME,
protocol)) {
+// Not upgrade request
+return null;
+}
+return buildHttp2ServerUpgradeCodec(url);
+})));
+// If the upgrade was successful, remove the message from the output
list
+// so that it's not propagated to the next handler. This request will
+// be propagated as a user event instead.
handlers.add(new ChannelHandlerPretender(new
HttpObjectAggregator(Integer.MAX_VALUE)));
handlers.add(new ChannelHandlerPretender(new NettyHttp1Codec()));
handlers.add(new ChannelHandlerPretender(new
NettyHttp1ConnectionHandler(
url, frameworkModel,
DefaultHttp11ServerTransportListenerFactory.INSTANCE)));
}
+private Http2ServerUpgradeCodec buildHttp2ServerUpgradeCodec(URL url) {
+Configuration config =
ConfigurationUtils.getGlobalConfiguration(url.getOrDefaultApplicationModel());
+final Http2FrameCodec codec = TripleHttp2FrameCodecBuilder.forServer()
Review Comment:
Recommended to extract the initialization of Http2FrameCodec into a common
method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Triple protocol http1 upgrade support [dubbo]
oxsean commented on PR #14026: URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2075349461 Please look into whether Application-Layer Protocol Negotiation is supported in addition to h2c: https://matthewparrilla.com/post/negotiation-http2-alpn-tls-handshake/ https://imququ.com/post/protocol-negotiation-in-http2.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Triple protocol http1 upgrade support [dubbo]
oxsean commented on PR #14026: URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2075309346 Test `org.apache.dubbo.demo.provider.ApiProvider` with curl: ``` curl.exe -v --http2 -k -H "Content-Type: application/json" -d '"asd"' http://127.0.0.1:50051/org.apache.dubbo.demo.GreeterService/sayHelloAsync ``` but upgrade failed, could you please take a look?  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] support custom dubbo invoke retries times [dubbo-go-pixiu]
sonarcloud[bot] commented on PR #625: URL: https://github.com/apache/dubbo-go-pixiu/pull/625#issuecomment-2075188850 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=625) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=625&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=625&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=625&resolved=false&inNewCodePeriod=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=625) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] support custom dubbo invoke retries times [dubbo-go-pixiu]
mark4z opened a new pull request, #625: URL: https://github.com/apache/dubbo-go-pixiu/pull/625 **What this PR does**: Now we can specify loadbalance strategy on dubbo proxy like this: - name: dgp.filter.http.dubboproxy config: dubboProxyConfig: auto_resolve: true retries: 3 registries: "zookeeper": protocol: "zookeeper" **Which issue(s) this PR fixes**: Fixes # **Special notes for your reviewer**: **Does this PR introduce a user-facing change?**: ```release-note ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]
oxsean commented on code in PR #14073:
URL: https://github.com/apache/dubbo/pull/14073#discussion_r1578018213
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/mapping/DefaultRequestMappingRegistry.java:
##
@@ -61,8 +61,7 @@ public DefaultRequestMappingRegistry(FrameworkModel
frameworkModel) {
public void register(Invoker invoker) {
Object service = invoker.getUrl().getServiceModel().getProxyObject();
new MethodWalker().walk(service.getClass(), (classes, consumer) -> {
-for (int i = 0, size = resolvers.size(); i < size; i++) {
-RequestMappingResolver resolver = resolvers.get(i);
+for (RequestMappingResolver resolver : resolvers) {
Review Comment:
The enhanced index loop can avoid creating iterator object. Although it's a
minor optimization, I think it's unnecessary to switch to an iterator loop.
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/filter/CorsHeaderFilterAdapter.java:
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.rpc.protocol.tri.rest.filter;
+
+import org.apache.dubbo.common.constants.CommonConstants;
+import org.apache.dubbo.common.extension.Activate;
+import org.apache.dubbo.remoting.http12.HttpRequest;
+import org.apache.dubbo.remoting.http12.HttpResponse;
+import org.apache.dubbo.remoting.http12.HttpResult;
+import org.apache.dubbo.remoting.http12.HttpStatus;
+import org.apache.dubbo.remoting.http12.exception.HttpResultPayloadException;
+import org.apache.dubbo.rpc.Invoker;
+import org.apache.dubbo.rpc.RpcException;
+import org.apache.dubbo.rpc.RpcInvocation;
+import org.apache.dubbo.rpc.model.FrameworkModel;
+import org.apache.dubbo.rpc.protocol.tri.rest.RestConstants;
+import org.apache.dubbo.rpc.protocol.tri.rest.cors.CorsProcessor;
+import org.apache.dubbo.rpc.protocol.tri.rest.mapping.RequestMapping;
+
+@Activate(group = CommonConstants.PROVIDER, order = 1000)
+public class CorsHeaderFilterAdapter extends RestHeaderFilterAdapter {
Review Comment:
Move into package 'org.apache.dubbo.rpc.protocol.tri.rest.cors' and rename
to CorsHeaderFilter
##
dubbo-rpc/dubbo-rpc-triple/src/main/resources/META-INF/dubbo/internal/org.apache.dubbo.rpc.HeaderFilter:
##
@@ -0,0 +1 @@
+rest-cors-extension=org.apache.dubbo.rpc.protocol.tri.rest.filter.CorsHeaderFilterAdapter
Review Comment:
rest-cors=...
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/cors/CorsUtils.java:
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.rpc.protocol.tri.rest.cors;
+
+import org.apache.dubbo.common.config.Configuration;
+import org.apache.dubbo.common.config.ConfigurationUtils;
+import org.apache.dubbo.common.lang.Nullable;
+import org.apache.dubbo.rpc.model.ApplicationModel;
+import org.apache.dubbo.rpc.protocol.tri.rest.RestConstants;
+
+import java.util.Arrays;
+import java.util.List;
+import java.util.stream.Collectors;
+
+public class CorsUtils {
+private static CorsMeta globalCorsMeta;
+public static final String HTTP = "http";
+public static final String HTTPS = "https";
+public static final String WS = "ws";
+public static final String WSS = "wss";
+
+private CorsUtils() {}
+
+public static int getPort(String scheme, int port) {
+
Re: [PR] Fix netty memory leak [dubbo]
oxsean commented on code in PR #14127:
URL: https://github.com/apache/dubbo/pull/14127#discussion_r1577996697
##
dubbo-remoting/dubbo-remoting-http12/src/main/java/org/apache/dubbo/remoting/http12/HttpOutputMessage.java:
##
@@ -29,6 +29,11 @@ public interface HttpOutputMessage {
public OutputStream getBody() {
return INPUT_STREAM;
}
+
+@Override
+public void close() throws Exception {
+INPUT_STREAM.close();
Review Comment:
Unnecessary
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/h12/http1/DefaultHttp11ServerTransportListener.java:
##
@@ -82,6 +83,15 @@ protected HttpMessageListener buildHttpMessageListener() {
return new DefaultHttpMessageListener(listeningDecoder);
}
+@Override
+protected void doOnData(HttpInputMessage message) {
Review Comment:
Is http2 also need it? so I think add it into Ondata is more reasonable:
```Java
public void onData(MESSAGE message) {
executor.execute(() -> {
try {
doOnData(message);
} catch (Throwable t) {
logError(t);
onError(t);
} finally {
try {
message.close();
} catch (Exception e) {
onError(e);
}
}
});
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Feature] Move Mesh Rule Router to SPI Extensions [dubbo]
walkinggo commented on issue #13957: URL: https://github.com/apache/dubbo/issues/13957#issuecomment-2075071687 Is this issue completed? Is there any progress? I am very interested in this and want to join. @heliang666s -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] AbstractCacheManager destroy fix #13615 [dubbo]
sonarcloud[bot] commented on PR #14091: URL: https://github.com/apache/dubbo/pull/14091#issuecomment-2074851587 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14091) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14091&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14091&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14091&resolved=false&inNewCodePeriod=true)  [25.9% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14091&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14091&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14091) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] 用nacos作为注册中心，consumer报no provider [dubbo]
Guo-Chenxu commented on issue #11286: URL: https://github.com/apache/dubbo/issues/11286#issuecomment-2074836594 所以这个问题是在2.7.23版本中解决了, 我今天用相同的版本也遇到了相同的问题 > Try [2.7.23](https://github.com/apache/dubbo/releases/tag/dubbo-2.7.23) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] AbstractCacheManager destroy fix #13615 [dubbo]
sonarcloud[bot] commented on PR #14091: URL: https://github.com/apache/dubbo/pull/14091#issuecomment-2074832536 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14091) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14091&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14091&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14091&resolved=false&inNewCodePeriod=true)  [25.9% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14091&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14091&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14091) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Feat security [dubbo-go]
2456868764 commented on code in PR #2643:
URL: https://github.com/apache/dubbo-go/pull/2643#discussion_r1577730386
##
tls/xds/xds_provider.go:
##
@@ -0,0 +1,256 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package xds
+
+import (
+ "crypto/tls"
+ "crypto/x509"
+ "fmt"
+ "sync"
+
+ "dubbo.apache.org/dubbo-go/v3/common"
+ "dubbo.apache.org/dubbo-go/v3/common/constant"
+ "dubbo.apache.org/dubbo-go/v3/common/extension"
+ "dubbo.apache.org/dubbo-go/v3/istio"
+ "dubbo.apache.org/dubbo-go/v3/istio/resources"
+ tlsprovider "dubbo.apache.org/dubbo-go/v3/tls"
+ "github.com/dubbogo/gost/log/logger"
+)
+
+var (
+ oncesync.Once
+ tlsProvider *xdsTLSProvider
+)
+
+func init() {
+ extension.SetTLSProvider(constant.TLSProviderXdsKey, newXdsTLSProvider)
+}
+
+type xdsTLSProvider struct {
+ pilotAgent istio.XdsAgent
+}
+
+func newXdsTLSProvider() tlsprovider.TLSProvider {
+ if tlsProvider == nil {
+ once.Do(func() {
+ logger.Infof("[xds tls] init pilot agent")
+ pilotAgent, err :=
istio.GetPilotAgent(istio.PilotAgentTypeServerWorkload)
+ if err != nil {
+ logger.Errorf("[xds tls] init pilot agent
err:%", err)
+ }
+ tlsProvider = &xdsTLSProvider{
+ pilotAgent: pilotAgent,
+ }
+ })
+ }
+ return tlsProvider
+}
+
+func (x *xdsTLSProvider) GetServerWorkLoadTLSConfig(url *common.URL)
(*tls.Config, error) {
+ cfg := &tls.Config{
+ GetCertificate: x.GetServerWorkloadCertificate,
+ ClientAuth: tls.VerifyClientCertIfGiven, // for test only
+ //ClientAuth: tls.RequireAndVerifyClientCert, // for
prod
+ ClientCAs: x.GetCACertPool(),
+ VerifyPeerCertificate: func(rawCerts [][]byte, verifiedChains
[][]*x509.Certificate) error {
+ err := x.VerifyPeerCertByServer(rawCerts,
verifiedChains)
+ if err != nil {
+ logger.Errorf("Could not verify client
certificate: %v", err)
+ }
+ return err
+ },
+ MinVersion: tls.VersionTLS12,
+ CipherSuites: tlsprovider.PreferredDefaultCipherSuites(),
+ NextProtos: []string{"h2", "http/1.1"},
+ }
+
+ return cfg, nil
+}
+
+func (x *xdsTLSProvider) VerifyPeerCertByServer(rawCerts [][]byte,
verifiedChains [][]*x509.Certificate) error {
+ logger.Infof("[xds tls] server verifiy peer cert")
+ if len(rawCerts) == 0 {
+ // Peer doesn't present a certificate. Just skip. Other authn
methods may be used.
+ return nil
+ }
+ var peerCert *x509.Certificate
+ intCertPool := x509.NewCertPool()
+ for id, rawCert := range rawCerts {
+ cert, err := x509.ParseCertificate(rawCert)
+ if err != nil {
+ return err
+ }
+ if id == 0 {
+ peerCert = cert
+ } else {
+ intCertPool.AddCert(cert)
+ }
+ }
+ if len(peerCert.URIs) != 1 {
+ logger.Errorf("[xds tls] peer certificate does not contain 1
URI type SAN, detected %d", len(peerCert.URIs))
+ return fmt.Errorf("peer certificate does not contain 1 URI type
SAN, detected %d", len(peerCert.URIs))
+ }
+ spiffe := peerCert.URIs[0].String()
+ _, err := resources.ParseIdentity(spiffe)
+ if err != nil {
+ logger.Errorf("[xds tls] can not ParseIdentity %s, error :%v",
spiffe, err)
+ return err
+ }
+ secretCache := x.pilotAgent.GetWorkloadCertificateProvider()
+ hostInboundListener := x.pilotAgent.GetHostInboundListener()
+ if hostInboundListener == nil {
+ return fmt.Errorf("can not get xds inbound listner info")
+ }
+
+ spiffeMatch := hostInboundListe
Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]
Rawven commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2074714911 @oxsean I have modified all the parts you mentioned PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2074698851 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14073) **Quality Gate passed** Issues  [6 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14073&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14073&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14073&resolved=false&inNewCodePeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14073&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14073&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14073) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Feat security [dubbo-go]
sonarcloud[bot] commented on PR #2643: URL: https://github.com/apache/dubbo-go/pull/2643#issuecomment-2074619239 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2643) **Quality Gate passed** Issues  [88 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2643&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2643&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2643&resolved=false&inNewCodePeriod=true)  No data about Coverage  [0.6% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2643&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2643) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2074612166 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14073) **Quality Gate passed** Issues  [7 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14073&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14073&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14073&resolved=false&inNewCodePeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14073&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14073&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14073) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2074593267 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14073) **Quality Gate passed** Issues  [7 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14073&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14073&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14073&resolved=false&inNewCodePeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14073&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14073&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14073) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix netty memory leak [dubbo]
sonarcloud[bot] commented on PR #14127: URL: https://github.com/apache/dubbo/pull/14127#issuecomment-2074480062 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14127) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14127&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14127&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14127&resolved=false&inNewCodePeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14127&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14127&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14127) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix netty memory leak [dubbo]
sonarcloud[bot] commented on PR #14127: URL: https://github.com/apache/dubbo/pull/14127#issuecomment-2074424326 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14127) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14127&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14127&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14127&resolved=false&inNewCodePeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14127&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14127&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14127) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Feat security [dubbo-go]
sonarcloud[bot] commented on PR #2643: URL: https://github.com/apache/dubbo-go/pull/2643#issuecomment-2074427301 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2643) **Quality Gate passed** Issues  [88 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2643&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2643&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2643&resolved=false&inNewCodePeriod=true)  No data about Coverage  [0.6% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2643&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2643) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix netty memory leak [dubbo]
sonarcloud[bot] commented on PR #14127: URL: https://github.com/apache/dubbo/pull/14127#issuecomment-2074379860 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14127) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14127&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14127&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14127&resolved=false&inNewCodePeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14127&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14127&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14127) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] Fix netty memory leak [dubbo]
finefuture opened a new pull request, #14127: URL: https://github.com/apache/dubbo/pull/14127 ## What is the purpose of the change There is a Netty memory leak in the onData and onNext methods in http1. ByteBuf needs to be released after processing the http1 request and encoding failure.   ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] AbstractCacheManager destroy Framework's executorService when shutdown [dubbo]
Chenjp commented on issue #13615: URL: https://github.com/apache/dubbo/issues/13615#issuecomment-2074261140 @AlbumenJ Please help to review PR #14091 and share your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
