Re: [PR] Add tests for triple upgrade http2 [dubbo-integration-cases]

2024-05-06 Thread via GitHub


walklown commented on PR #22:
URL: 
https://github.com/apache/dubbo-integration-cases/pull/22#issuecomment-2097580297

   And bind [RP14026](https://github.com/apache/dubbo/pull/14026). Please 
install RP related code and set revision to 3.3.0-SNAPSHOT.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] delete_rpc_rest [dubbo]

2024-05-06 Thread via GitHub


wcy666103 commented on code in PR #14084:
URL: https://github.com/apache/dubbo/pull/14084#discussion_r1591882043


##
dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/bootstrap/DubboBootstrapTest.java:
##
@@ -1,406 +0,0 @@
-/*

Review Comment:
   They are either using the rest protocol or using the rest protocol-specific 
userservice definition



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] catch the warning and ignore when childUrl is not json. [dubbo]

2024-05-06 Thread via GitHub


walkinggo commented on PR #14157:
URL: https://github.com/apache/dubbo/pull/14157#issuecomment-2097484359

   so i close it and try to create a new one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] catch the warning and ignore when childUrl is not json. [dubbo]

2024-05-06 Thread via GitHub


walkinggo commented on PR #14157:
URL: https://github.com/apache/dubbo/pull/14157#issuecomment-2097483966

   this pr didn't obey the code format.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] catch the warning and ignore when childUrl is not json. [dubbo]

2024-05-06 Thread via GitHub


walkinggo closed pull request #14157: catch the warning and ignore when 
childUrl is not json.
URL: https://github.com/apache/dubbo/pull/14157


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Fix netty memory leak [dubbo]

2024-05-06 Thread via GitHub


sonarcloud[bot] commented on PR #14127:
URL: https://github.com/apache/dubbo/pull/14127#issuecomment-2097379931

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14127) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [2 New 
issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14127&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14127&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14127&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14127&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14127&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14127)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

2024-05-06 Thread via GitHub


sonarcloud[bot] commented on PR #13971:
URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2097378464

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13971) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [1 New 
issue](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13971&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13971&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13971&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [81.5% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13971&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13971&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13971)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] delete_rpc_rest [dubbo]

2024-05-06 Thread via GitHub


finefuture commented on code in PR #14084:
URL: https://github.com/apache/dubbo/pull/14084#discussion_r1591765587


##
dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/bootstrap/DubboBootstrapTest.java:
##
@@ -1,406 +0,0 @@
-/*

Review Comment:
   Why were these unit tests removed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] delete_rpc_rest [dubbo]

2024-05-06 Thread via GitHub


finefuture commented on PR #14084:
URL: https://github.com/apache/dubbo/pull/14084#issuecomment-2097371642

   Please resolve the conflicts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [I] [Bug] nacos tests timeout and dubbo-samples-test-13787 caseSpecificVersion led to the failure of the integration tests [dubbo]

2024-05-06 Thread via GitHub


FoghostCn commented on issue #14158:
URL: https://github.com/apache/dubbo/issues/14158#issuecomment-2097254669

   The case-versions.conf configuration file describes the dubbo version that 
is expected to run. It will not run when your version does not match.
   
   so if you use dubbo.version=3.2.13-SNAPSHOT it should not run,please check 
you env DUBBO_VERSION


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] fix(3.2): ReactorDubbo3TripleStub.mustache add schema registry [dubbo]

2024-05-06 Thread via GitHub


caoyanan666 commented on PR #14035:
URL: https://github.com/apache/dubbo/pull/14035#issuecomment-2097228030

   @AlbumenJ PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] feat:remove old zookeeper [dubbo]

2024-05-06 Thread via GitHub


sonarcloud[bot] commented on PR #14028:
URL: https://github.com/apache/dubbo/pull/14028#issuecomment-2097221626

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14028) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [28 New 
issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14028&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14028&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14028&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14028&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14028&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14028)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[I] [Bug] nacos tests timeout and dubbo-samples-test-13787 caseSpecificVersion led to the failure of the integration tests [dubbo]

2024-05-06 Thread via GitHub


jkoChen opened a new issue, #14158:
URL: https://github.com/apache/dubbo/issues/14158

   ### Pre-check
   
   - [X] I am sure that all the content I provide is in English.
   
   
   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/dubbo/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Apache Dubbo Component
   
   Java Integration Cases (apache/dubbo-integration-cases)
   
   ### Dubbo Version
   
   dubbo.version=3.2.13-SNAPSHOT spring.version=5.3.30 java.version=8 
   
   ### Steps to reproduce this issue
   
   The "integration-test" step of Dubbo's GitHub workflow cannot be executed 
successfully.
   https://github.com/apache/dubbo/assets/37362859/6297aee5-44c3-4528-85d8-fe9d2e916fc6";>
   
   ### What you expected to happen
   
   https://github.com/apache/dubbo/assets/37362859/6297aee5-44c3-4528-85d8-fe9d2e916fc6";>
   The five tests have consistently failed and have not been successful. Among 
them, the tests related to Nacos could not be conducted because I was unable to 
build the Docker image locally for testing.
   The reason for the failure of the test dubbo-samples-test-13787 is that it 
uses a specific version number of Dubbo, which leads to the test not utilizing 
the version of Dubbo that was built during the CI (Continuous Integration) 
process, resulting in the failure.
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit a pull request to fix on your own?
   
   - [ ] Yes I am willing to submit a pull request on my own!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[PR] catch the warning and ignore when childUrl is not json. [dubbo]

2024-05-06 Thread via GitHub


walkinggo opened a new pull request, #14157:
URL: https://github.com/apache/dubbo/pull/14157

   ## What is the purpose of the change
   catch the exception when the url can't be 
deserialization.[issue12941](https://github.com/apache/dubbo/issues/12941)
   
   
   ## Brief changelog
   add the json check when ANY_VALUE.equals(url.getServiceInterface()) at 
ZookeeperRegistry#doSubscribe.
   
   ## Verifying this change
   the child will work normal if the child is json.
   
   
   
   ## Checklist
   - [x] Make sure there is a 
[GitHub_issue](https://github.com/apache/dubbo/issues) field for the change 
(usually before you start working on it). Trivial changes like typos do not 
require a GitHub issue. Your pull request should address just this issue, 
without pulling in other changes - one PR resolves one issue.
   - [x] Each commit in the pull request should have a meaningful subject line 
and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
   - [x] Write necessary unit-test to verify your logic correction, more mock a 
little better when cross module dependency exist. If the new feature or 
significant change is committed, please remember to add sample in [dubbo 
samples](https://github.com/apache/dubbo-samples) project.
   - [x] Add some description to 
[dubbo-website](https://github.com/apache/dubbo-website) project if you are 
requesting to add a feature.
   - [x] GitHub Actions works fine on your own branch.
   - [x] If this contribution is large, please follow the [Software Donation 
Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] optimise: create http client by connection pool [dubbo]

2024-05-06 Thread via GitHub


suncairong163 commented on PR #14079:
URL: https://github.com/apache/dubbo/pull/14079#issuecomment-2096038700

   > > > * For [OkHttpClient should use connection pool 
#13596](https://github.com/apache/dubbo/issues/13596)
   > > 
   > > 
   > > You can dowload the task error log,and query "error" keyword to find 
error reason clearly and run all task successfully .
   > 
   > CI failure is not a problem with my code, Can re-execute the ci and see?
   You can submit with a blank code  to re-execute.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] fix the signature error when using reflection to access the org.springframework.core.annotation.AnnotatedElementUtils#getMergedAnnotation method [dubbo]

2024-05-06 Thread via GitHub


sonarcloud[bot] commented on PR #14156:
URL: https://github.com/apache/dubbo/pull/14156#issuecomment-2096007979

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14156) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [1 New 
issue](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14156&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14156&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14156&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [100.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14156&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14156&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14156)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[PR] fix the signature error when using reflection to access the org.springframework.core.annotation.AnnotatedElementUtils#getMergedAnnotation method [dubbo]

2024-05-06 Thread via GitHub


jkoChen opened a new pull request, #14156:
URL: https://github.com/apache/dubbo/pull/14156

   Fixes https://github.com/apache/dubbo/issues/14104.
   
   ## The Problem
   The method 
`org.apache.dubbo.config.spring.util.AnnotationUtils#tryGetMergedAnnotation` 
utilizes reflection to access 
`org.springframework.core.annotation.AnnotatedElementUtils#getMergedAnnotation`.
 However, there is a signature mismatch in the method's input parameters, which 
leads to an inability to retrieve the correct method. Consequently, this 
results in the failure to obtain the mergedAnnotation.
   
   ## What is the purpose of the change
   It is recommended to fix this issue, as it will cause the passing of the 
`DubboReference` annotation to become ineffective.
   
   
   ## Brief changelog
   fix the signature error when using reflection to access the 
org.springframework.core.annotation.AnnotatedElementUtils#getMergedAnnotation 
method
   
   ## Verifying this change
   After the patch, it is possible to correctly obtain the 
`org.springframework.core.annotation.AnnotatedElementUtils#getMergedAnnotation` 
method.
   
   
   
   ## Checklist
   - [x] Make sure there is a 
[GitHub_issue](https://github.com/apache/dubbo/issues) field for the change 
(usually before you start working on it). Trivial changes like typos do not 
require a GitHub issue. Your pull request should address just this issue, 
without pulling in other changes - one PR resolves one issue.
   - [x] Each commit in the pull request should have a meaningful subject line 
and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] GitHub Actions works fine on your own branch.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] fix the signature error when using reflection to access the org.springframework.core.annotation.AnnotatedElementUtils#getMergedAnnotation method [dubbo]

2024-05-06 Thread via GitHub


jkoChen closed pull request #14152: fix the signature error when using 
reflection to access the 
org.springframework.core.annotation.AnnotatedElementUtils#getMergedAnnotation 
method
URL: https://github.com/apache/dubbo/pull/14152


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] test: test case [dubbo]

2024-05-06 Thread via GitHub


jkoChen closed pull request #14155: test: test case
URL: https://github.com/apache/dubbo/pull/14155


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] test: test case [dubbo]

2024-05-06 Thread via GitHub


sonarcloud[bot] commented on PR #14155:
URL: https://github.com/apache/dubbo/pull/14155#issuecomment-2095695217

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14155) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14155&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14155&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14155&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14155&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14155)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] test: test case [dubbo]

2024-05-06 Thread via GitHub


sonarcloud[bot] commented on PR #14155:
URL: https://github.com/apache/dubbo/pull/14155#issuecomment-2095692676

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14155) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14155&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14155&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14155&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14155&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14155)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[PR] test: test case [dubbo]

2024-05-06 Thread via GitHub


jkoChen opened a new pull request, #14155:
URL: https://github.com/apache/dubbo/pull/14155

   ## What is the purpose of the change
   
   
   
   ## Brief changelog
   
   
   ## Verifying this change
   
   
   
   
   ## Checklist
   - [x] Make sure there is a 
[GitHub_issue](https://github.com/apache/dubbo/issues) field for the change 
(usually before you start working on it). Trivial changes like typos do not 
require a GitHub issue. Your pull request should address just this issue, 
without pulling in other changes - one PR resolves one issue.
   - [ ] Each commit in the pull request should have a meaningful subject line 
and body.
   - [ ] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
   - [ ] Write necessary unit-test to verify your logic correction, more mock a 
little better when cross module dependency exist. If the new feature or 
significant change is committed, please remember to add sample in [dubbo 
samples](https://github.com/apache/dubbo-samples) project.
   - [ ] Add some description to 
[dubbo-website](https://github.com/apache/dubbo-website) project if you are 
requesting to add a feature.
   - [ ] GitHub Actions works fine on your own branch.
   - [ ] If this contribution is large, please follow the [Software Donation 
Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [I] [Bug] ContextHolderAuthenticationResolverFilter序列化异常 [dubbo]

2024-05-06 Thread via GitHub


FoghostCn commented on issue #14145:
URL: https://github.com/apache/dubbo/issues/14145#issuecomment-2095574793

   plz provide a demo project to reproduce 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [I] [Feature] maven中央仓库还没有3.2.12版本的dubbo [dubbo]

2024-05-06 Thread via GitHub


FoghostCn commented on issue #14107:
URL: https://github.com/apache/dubbo/issues/14107#issuecomment-2095567477

   https://central.sonatype.com/artifact/org.apache.dubbo/dubbo/3.2.12


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [I] [Feature] maven中央仓库还没有3.2.12版本的dubbo [dubbo]

2024-05-06 Thread via GitHub


FoghostCn closed issue #14107: [Feature] maven中央仓库还没有3.2.12版本的dubbo
URL: https://github.com/apache/dubbo/issues/14107


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] optimise: create http client by connection pool [dubbo]

2024-05-06 Thread via GitHub


yuluo-yx commented on PR #14079:
URL: https://github.com/apache/dubbo/pull/14079#issuecomment-2095534006

   > > * For [OkHttpClient should use connection pool 
#13596](https://github.com/apache/dubbo/issues/13596)
   > 
   > You can dowload the task error log,and query "error" keyword to find error 
reason clearly and run all task successfully .
   
   CI failure is not a problem with my code, Can re-execute the ci and see?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] optimise: create http client by connection pool [dubbo]

2024-05-06 Thread via GitHub


suncairong163 commented on PR #14079:
URL: https://github.com/apache/dubbo/pull/14079#issuecomment-2095485095

   > * For [OkHttpClient should use connection pool 
#13596](https://github.com/apache/dubbo/issues/13596)
   
   You can dowload the task error log,and query "error" keyword to find error 
reason clearly and  run all task successfully .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] test: add yaml loadAs test [dubbo]

2024-05-06 Thread via GitHub


sonarcloud[bot] commented on PR #14080:
URL: https://github.com/apache/dubbo/pull/14080#issuecomment-2095421684

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14080) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [2 New 
issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14080&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14080&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14080&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14080&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14080)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] test: add yaml loadAs test [dubbo]

2024-05-06 Thread via GitHub


sonarcloud[bot] commented on PR #14080:
URL: https://github.com/apache/dubbo/pull/14080#issuecomment-2095389260

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14080) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [2 New 
issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14080&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14080&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14080&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14080&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14080)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Bump org.apache.maven.plugin-tools:maven-plugin-annotations from 3.12.0 to 3.13.0 [dubbo]

2024-05-06 Thread via GitHub


sonarcloud[bot] commented on PR #14154:
URL: https://github.com/apache/dubbo/pull/14154#issuecomment-2095384293

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14154) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14154&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14154&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14154&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Duplication  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14154)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Bump jackson_version from 2.17.0 to 2.17.1 [dubbo]

2024-05-06 Thread via GitHub


sonarcloud[bot] commented on PR #14153:
URL: https://github.com/apache/dubbo/pull/14153#issuecomment-2095383847

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14153) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14153&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14153&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14153&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Duplication  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14153)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] optimise: create http client by connection pool [dubbo]

2024-05-06 Thread via GitHub


sonarcloud[bot] commented on PR #14079:
URL: https://github.com/apache/dubbo/pull/14079#issuecomment-2095382932

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14079) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14079&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14079&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14079&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [66.7% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14079&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14079&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14079)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] 3.3 dev xds security [dubbo]

2024-05-06 Thread via GitHub


Tomoko-hjf closed pull request #14150: 3.3 dev xds security
URL: https://github.com/apache/dubbo/pull/14150


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [I] [Bug] rmi protocol doesnot work for threads ,iothreads etc.. [dubbo]

2024-05-06 Thread via GitHub


AlbumenJ closed issue #14089: [Bug] rmi protocol doesnot work for threads 
,iothreads  etc.. 
URL: https://github.com/apache/dubbo/issues/14089


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Bump com.alibaba.fastjson2:fastjson2 from 2.0.48 to 2.0.49 [dubbo]

2024-05-06 Thread via GitHub


AlbumenJ merged PR #14087:
URL: https://github.com/apache/dubbo/pull/14087


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Update .ignore to exclude log files. [dubbo]

2024-05-06 Thread via GitHub


AlbumenJ commented on PR #14064:
URL: https://github.com/apache/dubbo/pull/14064#issuecomment-2095334251

   > @AlbumenJ would you please merge this PR to (apache:3.3)?
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] feat:remove old zookeeper [dubbo]

2024-05-06 Thread via GitHub


AlbumenJ commented on PR #14028:
URL: https://github.com/apache/dubbo/pull/14028#issuecomment-2095327569

   
![image](https://github.com/apache/dubbo/assets/9292748/5bef8e3d-43c6-4406-9e2c-4169bf0afacd)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] test: add yaml loadAs test [dubbo]

2024-05-06 Thread via GitHub


yuluo-yx commented on PR #14080:
URL: https://github.com/apache/dubbo/pull/14080#issuecomment-2095325131

   > The background of this feature is that snakeyaml supports including class 
names within the content. Therefore, it's intended to test and verify that 
classes configured on the whitelist can be deserialized, whereas others should 
be rejected. e.g.,
   > 
   > ```yaml
   > "1": !!demo.User
   >   name: Alice
   >   age: 28
   > "2": !!demo.User
   >   name: Bob
   >   age: 34
   > ```
   > 
   > Refs: 
https://github.com/apache/dubbo/blob/3.3/dubbo-remoting/dubbo-remoting-http12/src/main/java/org/apache/dubbo/remoting/http12/message/codec/YamlCodec.java#L40
 
https://github.com/apache/dubbo/blob/3.3/dubbo-common/src/main/java/org/apache/dubbo/common/utils/DefaultSerializeClassChecker.java#L33
 
https://dubbo.apache.org/zh-cn/overview/mannual/java-sdk/advanced-features-and-usage/security/class-check/
   
   got it, I will refactor it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[PR] Bump org.apache.maven.plugin-tools:maven-plugin-annotations from 3.12.0 to 3.13.0 [dubbo]

2024-05-06 Thread via GitHub


dependabot[bot] opened a new pull request, #14154:
URL: https://github.com/apache/dubbo/pull/14154

   Bumps 
[org.apache.maven.plugin-tools:maven-plugin-annotations](https://github.com/apache/maven-plugin-tools)
 from 3.12.0 to 3.13.0.
   
   Commits
   
   https://github.com/apache/maven-plugin-tools/commit/7a9ba2adccd253185ee35fe9db0a2462a26d860a";>7a9ba2a
 [maven-release-plugin] prepare release maven-plugin-tools-3.13.0
   https://github.com/apache/maven-plugin-tools/commit/789315b6958250c0e2e9291bb407a25fdd5112e3";>789315b
 [MPLUGIN-521] Nested types not properly extracted cause exception while 
gener...
   https://github.com/apache/maven-plugin-tools/commit/1fa18050144db3cf767a5ba8f5f48dbb451d1aa6";>1fa1805
 [MPLUGIN-519][MPLUGIN-520] Parent POM 42, prerequisite of 3.6.3, get rid of 
m...
   https://github.com/apache/maven-plugin-tools/commit/e746d9cc35cb03c03c61101d2b11f8247e6dcc82";>e746d9c
 [MPLUGIN-517] GoalRenderer renderParameterDetails() renders in wrong order
   https://github.com/apache/maven-plugin-tools/commit/af234c66cc1282e5c86262a20ba1b80b1c38b25e";>af234c6
 [MPLUGIN-516] Bump asmVersion from 9.6 to 9.7
   https://github.com/apache/maven-plugin-tools/commit/9fc1aaaed7f36460b8706339a04656901b7babec";>9fc1aaa
 [maven-release-plugin] prepare for next development iteration
   See full diff in https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.12.0...maven-plugin-tools-3.13.0";>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.maven.plugin-tools:maven-plugin-annotations&package-manager=maven&previous-version=3.12.0&new-version=3.13.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot show  ignore conditions` will show all of 
the ignore conditions of the specified dependency
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Bump org.apache.maven.plugins:maven-plugin-plugin from 3.10.2 to 3.12.0 [dubbo]

2024-05-06 Thread via GitHub


dependabot[bot] commented on PR #14045:
URL: https://github.com/apache/dubbo/pull/14045#issuecomment-2095320138

   A newer version of org.apache.maven.plugins:maven-plugin-plugin exists, but 
since this PR has been edited by someone other than Dependabot I haven't 
updated it. You'll get a PR for the updated version as normal once this PR is 
merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[PR] Bump jackson_version from 2.17.0 to 2.17.1 [dubbo]

2024-05-06 Thread via GitHub


dependabot[bot] opened a new pull request, #14153:
URL: https://github.com/apache/dubbo/pull/14153

   Bumps `jackson_version` from 2.17.0 to 2.17.1.
   Updates `com.fasterxml.jackson.core:jackson-core` from 2.17.0 to 2.17.1
   
   Commits
   
   https://github.com/FasterXML/jackson-core/commit/cba40f1c035dd72406d990c014c4b7477c4e621d";>cba40f1
 [maven-release-plugin] prepare release jackson-core-2.17.1
   https://github.com/FasterXML/jackson-core/commit/d33c4b5369f8451796829ec0411d4dcb12d93a08";>d33c4b5
 Prepare for 2.17.1 release
   https://github.com/FasterXML/jackson-core/commit/2a4a6dc908284d94c55b5b62ba114d0e25434cea";>2a4a6dc
 Fix https://redirect.github.com/FasterXML/jackson-core/issues/1256";>#1256:
 revert https://redirect.github.com/FasterXML/jackson-core/issues/1117";>#1117,
 default recycler pool again threadLocalPool() (for...
   https://github.com/FasterXML/jackson-core/commit/7e57e5b294899c100c6d220701323577e5601c71";>7e57e5b
 Update branch designation for CI
   https://github.com/FasterXML/jackson-core/commit/4b8d3990f1877d5a2468df36b9477614fec43d76";>4b8d399
 Part of https://redirect.github.com/FasterXML/jackson-core/issues/1260";>#1260:
 write a manually run concurrency test to tease out problem wit...
   https://github.com/FasterXML/jackson-core/commit/33c4260af3aadb7bd3c8adfc92f971ae4bc62066";>33c4260
 Fixes https://redirect.github.com/FasterXML/jackson-core/issues/1262";>#1262:
 Add diagnostic method pooledCount() in RecyclerPool (https://redirect.github.com/FasterXML/jackson-core/issues/1263";>#1263)
   https://github.com/FasterXML/jackson-core/commit/c73bde244d91b5948401bc083e8a888cc5433d16";>c73bde2
 Fix NumberInput.looksLikeValidNumber() implementation (https://redirect.github.com/FasterXML/jackson-core/issues/1241";>#1241)
   https://github.com/FasterXML/jackson-core/commit/1c656aecd20d70d04072179dcbbf83ac5525b807";>1c656ae
 ...
   https://github.com/FasterXML/jackson-core/commit/11e3bd7c0a47c3ba3332822f799287387166f343";>11e3bd7
 update(tests): migrate remaining JUnit 4 code in core to JUnit 5 (https://redirect.github.com/FasterXML/jackson-core/issues/1248";>#1248)
   https://github.com/FasterXML/jackson-core/commit/fff79ea51b1ab062721f3aad7e12ccfa354c7130";>fff79ea
 update(tests): migrate JUnit 4 code to JUnit 5 in core.base64 to core.sym (https://redirect.github.com/FasterXML/jackson-core/issues/1";>#1...
   Additional commits viewable in https://github.com/FasterXML/jackson-core/compare/jackson-core-2.17.0...jackson-core-2.17.1";>compare
 view
   
   
   
   
   Updates `com.fasterxml.jackson.core:jackson-databind` from 2.17.0 to 2.17.1
   
   Commits
   
   See full diff in https://github.com/FasterXML/jackson/commits";>compare view
   
   
   
   
   Updates `com.fasterxml.jackson.datatype:jackson-datatype-jsr310` from 2.17.0 
to 2.17.1
   
   Updates `com.fasterxml.jackson.core:jackson-annotations` from 2.17.0 to 
2.17.1
   
   Commits
   
   See full diff in https://github.com/FasterXML/jackson/commits";>compare view
   
   
   
   
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot show  ignore conditions` will show all of 
the ignore conditions of the specified dependency
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---